@quenty/actionmanager 13.33.1 → 13.34.0

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [13.34.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/actionmanager@13.33.1...@quenty/actionmanager@13.34.0) (2026-07-14)
+
+### Bug Fixes
+
+- **actionmanager:** cast enabledmixin application for strict EnabledMixin ([9c257d3](https://github.com/Quenty/NevermoreEngine/commit/9c257d3229574baacc636de89ede4e2dc0ae2d84))
+
+### Features
+
+- **actionmanager:** convert package to --!strict ([969be92](https://github.com/Quenty/NevermoreEngine/commit/969be92474791bab5c6c2515ff14557cdd0e3f9a))
+
 ## [13.33.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/actionmanager@13.33.0...@quenty/actionmanager@13.33.1) (2026-05-30)
 
 **Note:** Version bump only for package @quenty/actionmanager

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/actionmanager",
-  "version": "13.33.1",
+  "version": "13.34.0",
   "description": "Holds single toggleable actions (like a tool system)",
   "keywords": [
     "Roblox",
@@ -28,7 +28,7 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/enabledmixin": "11.26.1",
+    "@quenty/enabledmixin": "11.27.0",
     "@quenty/loader": "10.11.0",
     "@quenty/maid": "3.9.0",
     "@quenty/signal": "7.13.1",
@@ -37,5 +37,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "598b2b62b36bdcbdbbd56f7db10c399831cc6eba"
+  "gitHead": "13f0162f4971a77378e55e9b7236aea94f0dd3a8"
 }

package/src/Client/ActionManager.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	Holds single toggleable actions (like a tool system).
 
@@ -13,6 +13,7 @@ local require = require(script.Parent.loader).load(script)
 
 local ContextActionService = game:GetService("ContextActionService")
 
+local BaseAction = require("BaseAction")
 local Maid = require("Maid")
 local Signal = require("Signal")
 local ValueObject = require("ValueObject")
@@ -21,14 +22,24 @@ local ActionManager = {}
 ActionManager.__index = ActionManager
 ActionManager.ClassName = "ActionManager"
 
-function ActionManager.new()
-	local self = setmetatable({}, ActionManager)
+export type ActionManager = typeof(setmetatable(
+	{} :: {
+		_maid: Maid.Maid,
+		_actions: { [string]: BaseAction.BaseAction },
+		ActiveAction: ValueObject.ValueObject<BaseAction.BaseAction?>,
+		ActionAdded: Signal.Signal<BaseAction.BaseAction>,
+	},
+	{} :: typeof({ __index = ActionManager })
+))
+
+function ActionManager.new(): ActionManager
+	local self: ActionManager = setmetatable({} :: any, ActionManager)
 
 	self._maid = Maid.new()
 	self._actions = {}
 
-	self.ActiveAction = self._maid:Add(ValueObject.new())
-	self.ActionAdded = self._maid:Add(Signal.new()) -- :Fire(action)
+	self.ActiveAction = self._maid:Add(ValueObject.new() :: ValueObject.ValueObject<BaseAction.BaseAction?>)
+	self.ActionAdded = self._maid:Add(Signal.new() :: any) -- :Fire(action)
 
 	-- Stop actions while tool is in play
 	self._maid.ToolEquipped = ContextActionService.LocalToolEquipped:Connect(function(_)
@@ -42,7 +53,7 @@ function ActionManager.new()
 				value:Deactivate()
 			end)
 			maid:GiveTask(value.Deactivated:Connect(function()
-				if self.ActiveAction == value then
+				if self.ActiveAction.Value == value then
 					self.ActiveAction.Value = nil
 				end
 			end))
@@ -64,11 +75,11 @@ function ActionManager.new()
 	return self
 end
 
-function ActionManager:StopCurrentAction()
+function ActionManager.StopCurrentAction(self: ActionManager): ()
 	self.ActiveAction.Value = nil
 end
 
-function ActionManager:ActivateAction(name, ...)
+function ActionManager.ActivateAction(self: ActionManager, name: string, ...): ()
 	local action = self:GetAction(name)
 	if action then
 		action:Activate(...)
@@ -77,26 +88,25 @@ function ActionManager:ActivateAction(name, ...)
 	end
 end
 
-function ActionManager:GetAction(name)
+function ActionManager.GetAction(self: ActionManager, name: string): BaseAction.BaseAction?
 	return self._actions[name]
 end
 
-function ActionManager:GetActions()
-	local list = {}
+function ActionManager.GetActions(self: ActionManager): { BaseAction.BaseAction }
+	local list: { BaseAction.BaseAction } = {}
 
 	for _, action in self._actions do
-		table.insert(list, action)
+		table.insert(list, action :: any)
 	end
 
 	return list
 end
 
-function ActionManager:AddAction(action)
+function ActionManager.AddAction(self: ActionManager, action: BaseAction.BaseAction): ActionManager
 	local name = action:GetName()
 
 	if self._actions[name] then
 		error(string.format("[ActionManager] - action with name '%s' already exists", tostring(name)))
-		return
 	end
 
 	self._actions[name] = action
@@ -116,7 +126,7 @@ function ActionManager:AddAction(action)
 	return self
 end
 
-function ActionManager:Destroy()
+function ActionManager.Destroy(self: ActionManager): ()
 	self._maid:Destroy()
 end
 

package/src/Client/BaseAction.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	BaseAction state for [ActionManager].
 
@@ -15,6 +15,7 @@ local ContextActionService = game:GetService("ContextActionService")
 
 local EnabledMixin = require("EnabledMixin")
 local Maid = require("Maid")
+local Observable = require("Observable")
 local Signal = require("Signal")
 local ValueObject = require("ValueObject")
 
@@ -22,20 +23,51 @@ local BaseAction = {}
 BaseAction.__index = BaseAction
 BaseAction.ClassName = "BaseAction"
 
-EnabledMixin:Add(BaseAction)
-
-function BaseAction.new(actionData)
+(EnabledMixin :: any):Add(BaseAction)
+
+export type ActionData = {
+	Name: string,
+	Shortcuts: { any }?,
+	[any]: any,
+}
+
+export type BaseAction = typeof(setmetatable(
+	{} :: {
+		_maid: Maid.Maid,
+		_name: string,
+		_contextActionKey: string,
+		_activateData: { any }?,
+		_actionData: ActionData,
+		Activated: Signal.Signal<...any>,
+		Deactivated: Signal.Signal<()>,
+		IsActivatedValue: ValueObject.ValueObject<boolean>,
+
+		-- EnabledMixin surface (methods injected at runtime via EnabledMixin:Add)
+		_enabledMaidReference: Maid.Maid,
+		_enabledState: ValueObject.ValueObject<boolean>,
+		EnabledChanged: Signal.Signal<(boolean, boolean?)>,
+		InitEnabledMixin: (self: any, maid: Maid.Maid?) -> (),
+		IsEnabled: (self: any) -> boolean,
+		Enable: (self: any, doNotAnimate: boolean?) -> (),
+		Disable: (self: any, doNotAnimate: boolean?) -> (),
+		SetEnabled: (self: any, isEnabled: boolean, doNotAnimate: boolean?) -> (),
+		ObserveIsEnabled: (self: any) -> Observable.Observable<boolean>,
+	},
+	{} :: typeof({ __index = BaseAction })
+))
+
+function BaseAction.new(actionData: ActionData): BaseAction
 	assert(type(actionData) == "table", "Bad actionData")
 
-	local self = setmetatable({}, BaseAction)
+	local self: BaseAction = setmetatable({} :: any, BaseAction)
 
 	self._maid = Maid.new()
 	self._name = actionData.Name or error("No name")
 	self._contextActionKey = string.format("%s_ContextAction", tostring(self._name))
 	self._activateData = nil -- Data to be fired with the Activated event
 
-	self.Activated = self._maid:Add(Signal.new()) -- :Fire(actionMaid, ... (activateData))
-	self.Deactivated = self._maid:Add(Signal.new()) -- :Fire()
+	self.Activated = self._maid:Add(Signal.new() :: Signal.Signal<...any>) -- :Fire(actionMaid, ... (activateData))
+	self.Deactivated = self._maid:Add(Signal.new() :: Signal.Signal<()>) -- :Fire()
 
 	self.IsActivatedValue = self._maid:Add(ValueObject.new(false, "boolean"))
 
@@ -55,7 +87,7 @@ function BaseAction.new(actionData)
 	return self
 end
 
-function BaseAction:_handleEnabledChanged(isEnabled)
+function BaseAction._handleEnabledChanged(self: BaseAction, isEnabled: boolean): ()
 	if not isEnabled then
 		self:Deactivate()
 	end
@@ -63,11 +95,11 @@ function BaseAction:_handleEnabledChanged(isEnabled)
 	self:_updateShortcuts()
 end
 
-function BaseAction:_handleIsActiveValueChanged()
+function BaseAction._handleIsActiveValueChanged(self: BaseAction): ()
 	if self.IsActivatedValue.Value then
 		local actionMaid = Maid.new()
 		self._maid._actionMaid = actionMaid
-		self.Activated:Fire(actionMaid, unpack(self._activateData))
+		self.Activated:Fire(actionMaid, unpack(self._activateData or {}))
 		self._activateData = nil
 	else
 		self._maid._actionMaid = nil
@@ -75,11 +107,11 @@ function BaseAction:_handleIsActiveValueChanged()
 	end
 end
 
-function BaseAction:GetName()
+function BaseAction.GetName(self: BaseAction): string
 	return self._name
 end
 
-function BaseAction:_withActionData(actionData)
+function BaseAction._withActionData(self: BaseAction, actionData: ActionData): BaseAction
 	self._actionData = actionData or error("No actionData")
 
 	self:_updateShortcuts()
@@ -87,7 +119,7 @@ function BaseAction:_withActionData(actionData)
 	return self
 end
 
-function BaseAction:_updateShortcuts()
+function BaseAction._updateShortcuts(self: BaseAction): ()
 	if not self._actionData then
 		return
 	end
@@ -108,11 +140,11 @@ function BaseAction:_updateShortcuts()
 	end
 end
 
-function BaseAction:GetData()
+function BaseAction.GetData(self: BaseAction): ActionData
 	return self._actionData
 end
 
-function BaseAction:ToggleActivate(...)
+function BaseAction.ToggleActivate(self: BaseAction, ...): ()
 	self._activateData = { ... }
 
 	if self:IsEnabled() then
@@ -123,15 +155,15 @@ function BaseAction:ToggleActivate(...)
 	end
 end
 
-function BaseAction:IsActive()
+function BaseAction.IsActive(self: BaseAction): boolean
 	return self.IsActivatedValue.Value
 end
 
-function BaseAction:Deactivate()
+function BaseAction.Deactivate(self: BaseAction): ()
 	self.IsActivatedValue.Value = false
 end
 
-function BaseAction:Activate(...)
+function BaseAction.Activate(self: BaseAction, ...): ()
 	self._activateData = { ... }
 
 	if self:IsEnabled() then
@@ -141,10 +173,10 @@ function BaseAction:Activate(...)
 	end
 end
 
-function BaseAction:Destroy()
+function BaseAction.Destroy(self: BaseAction): ()
 	self._maid:DoCleaning()
 
-	setmetatable(self, nil)
+	setmetatable(self :: any, nil)
 end
 
 return BaseAction