@quark.clip/quark 1.3.1 → 1.3.3

package/README.md

@@ -40,6 +40,20 @@ The operating system clipboard is fundamentally broken and stuck in the past:
 
 No `.exe` files. No `.dmg` files. Just pure, cross-platform JavaScript.
 
+### One-Click Install (macOS / Linux)
+
+```bash
+curl -fsSL https://raw.githubusercontent.com/sir-ad/quark/main/install.sh | sh
+```
+
+### One-Click Install (Windows PowerShell)
+
+```powershell
+iex (irm https://raw.githubusercontent.com/sir-ad/quark/main/install.ps1)
+```
+
+### Manual install
+
 ```bash
 # Run instantly without installing (Temporary Session)
 npx -y @quark.clip/quark start

package/cli/bin/quark.js

@@ -2,16 +2,22 @@
 const { spawn } = require('child_process');
 const path = require('path');
 const fs = require('fs');
+const os = require('os');
 const { installService, uninstallService } = require('../src/installer');
 
 const command = process.argv[2] || 'help';
 const daemonPath = path.join(__dirname, '../src/daemon.js');
 const mcpPath = path.join(__dirname, '../src/mcp.js');
-const pidFile = path.join(__dirname, '../quark.pid');
-const logFile = path.join(__dirname, '../quark.log');
+
+// Bug fix: write state files to ~/.quark/ instead of inside the package dir (which
+// can be read-only when installed globally via npm).
+const quarkDir = path.join(os.homedir(), '.quark');
+fs.mkdirSync(quarkDir, { recursive: true });
+const pidFile = path.join(quarkDir, 'quark.pid');
+const logFile = path.join(quarkDir, 'quark.log');
 
 switch (command) {
-  case 'run':
+  case 'run': {
     console.log(`
       o-------o
       | \\   / |
@@ -23,8 +29,9 @@ switch (command) {
     console.log('💡 Press Ctrl+C to stop. Logs will appear below:');
     require(daemonPath);
     break;
+  }
 
-  case 'logs':
+  case 'logs': {
     if (fs.existsSync(logFile)) {
       console.log('📜 Tailing Quark logs... (Press Ctrl+C to exit)');
       const tail = spawn('tail', ['-f', logFile], { stdio: 'inherit' });
@@ -33,8 +40,9 @@ switch (command) {
       console.log('⚠️ No log file found at ' + logFile);
     }
     break;
+  }
 
-  case 'start':
+  case 'start': {
     console.log(`
       o-------o
       | \\   / |
@@ -49,7 +57,9 @@ switch (command) {
     }
     const out = fs.openSync(logFile, 'a');
     const err = fs.openSync(logFile, 'a');
-    const child = spawn('node', [daemonPath], {
+    // Bug fix: use process.execPath so the correct node binary is used even
+    // inside nvm / fnm / volta managed environments.
+    const child = spawn(process.execPath, [daemonPath], {
       detached: true,
       stdio: ['ignore', out, err]
     });
@@ -58,8 +68,9 @@ switch (command) {
     console.log('✨ Quark is now orbiting your clipboard in the background.');
     console.log('💡 Tip: Run `quark install` to make it start automatically on boot.');
     break;
+  }
 
-  case 'stop':
+  case 'stop': {
     if (fs.existsSync(pidFile)) {
       const pid = fs.readFileSync(pidFile, 'utf8');
       try {
@@ -73,6 +84,7 @@ switch (command) {
       console.log('Quark is not running via manual start.');
     }
     break;
+  }
 
   case 'install':
     installService();
@@ -82,34 +94,33 @@ switch (command) {
     uninstallService();
     break;
 
-  case 'status':
+  case 'status': {
     const isRunning = fs.existsSync(pidFile);
     console.log(`\n🌌 Quark Status`);
     console.log(`----------------`);
     console.log(`Manual Session: ${isRunning ? '🟢 Running' : '🔴 Stopped'}`);
 
     // Check OS Service Status
-    const os = require('os');
     const platform = os.platform();
     let serviceRunning = false;
     try {
       if (platform === 'darwin') {
         const plistPath = path.join(os.homedir(), 'Library', 'LaunchAgents', 'com.quark.daemon.plist');
         if (fs.existsSync(plistPath)) {
-          const out = require('child_process').execSync('launchctl list | grep com.quark.daemon', { encoding: 'utf8' });
-          serviceRunning = out.includes('com.quark.daemon');
+          const svcOut = require('child_process').execSync('launchctl list | grep com.quark.daemon', { encoding: 'utf8' });
+          serviceRunning = svcOut.includes('com.quark.daemon');
         }
       } else if (platform === 'linux') {
         const servicePath = path.join(os.homedir(), '.config', 'systemd', 'user', 'quark.service');
         if (fs.existsSync(servicePath)) {
-          const out = require('child_process').execSync('systemctl --user is-active quark.service', { encoding: 'utf8' });
-          serviceRunning = out.trim() === 'active';
+          const svcOut = require('child_process').execSync('systemctl --user is-active quark.service', { encoding: 'utf8' });
+          serviceRunning = svcOut.trim() === 'active';
         }
       } else if (platform === 'win32') {
         const vbsPath = path.join(process.env.APPDATA, 'Microsoft', 'Windows', 'Start Menu', 'Programs', 'Startup', 'quark.vbs');
         if (fs.existsSync(vbsPath)) {
-          const out = require('child_process').execSync('wmic process where "CommandLine like \'%daemon.js%\'" get ProcessId', { encoding: 'utf8' });
-          serviceRunning = out.includes('ProcessId') && out.trim().split('\n').length > 1;
+          const svcOut = require('child_process').execSync('wmic process where "CommandLine like \'%daemon.js%\'" get ProcessId', { encoding: 'utf8' });
+          serviceRunning = svcOut.includes('ProcessId') && svcOut.trim().split('\n').length > 1;
         }
       }
     } catch (e) {
@@ -122,6 +133,7 @@ switch (command) {
       console.log(`\n💡 Tip: Run 'quark install' to configure auto-start on boot.`);
     }
     break;
+  }
 
   case 'mcp':
     // Starts the MCP Stdio server (used by LLMs like Claude Desktop)

package/cli/src/clipboard.js

@@ -9,17 +9,20 @@ function read() {
     if (platform === 'darwin') {
       text = execSync('pbpaste', { encoding: 'utf8' }).toString();
       try {
-        const jxa = `
-          ObjC.import("AppKit");
-          var pb = $.NSPasteboard.generalPasteboard;
-          var html = pb.stringForType("public.html");
-          if (html) { html.js; } else { ""; }
-        `;
-        const raw = execSync(`osascript -l JavaScript -e '${jxa.replace(/\n/g, ' ')}' 2>/dev/null`, { encoding: 'utf8' });
+        const jxaRead = `
+ObjC.import("AppKit");
+var pb = $.NSPasteboard.generalPasteboard;
+var html = pb.stringForType("public.html");
+var res = (html && html.js) ? html.js : "";
+res;
+        `.trim();
+        const raw = execSync('osascript -l JavaScript -', { input: jxaRead, encoding: 'utf8' });
         if (raw && raw.trim() !== '') {
-          html = raw;
+          html = raw.trim();
         }
-      } catch (e) { }
+      } catch (e) {
+        // Fallback to plain text if HTML read fails
+      }
     } else if (platform === 'linux') {
       text = execSync('xclip -selection clipboard -o', { encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] }).toString();
       try {
@@ -48,19 +51,25 @@ function writeHtml(html, plainText) {
   try {
     const platform = os.platform();
     if (platform === 'darwin') {
-      // Use JXA to write both public.html and public.utf8-plain-text to NSPasteboard
-      // This ensures Electron apps (Teams, Slack) can read the HTML correctly
-      const escapedHtml = html.replace(/\\/g, '\\\\').replace(/'/g, "\\'").replace(/\n/g, '\\n');
-      const escapedText = plainText.replace(/\\/g, '\\\\').replace(/'/g, "\\'").replace(/\n/g, '\\n');
-      const jxa = `
-        ObjC.import("AppKit");
-        var pb = $.NSPasteboard.generalPasteboard;
-        pb.clearContents;
-        pb.setStringForType($('${escapedHtml}'), $('public.html'));
-        pb.setStringForType($('${escapedText}'), $('public.utf8-plain-text'));
-        "ok";
-      `;
-      execSync(`osascript -l JavaScript -e '${jxa.replace(/\n/g, ' ')}' 2>/dev/null`);
+      // CRITICAL: We must NOT pass HTML as inline shell arg — angle brackets crash the shell.
+      // Instead, we use stdin piping and environment variables to pass the data safely.
+      const jxaScript = `
+ObjC.import("AppKit");
+var env = $.NSProcessInfo.processInfo.environment.js;
+var htmlStr = env["QUARK_HTML"] || "";
+var textStr = env["QUARK_TEXT"] || "";
+
+var pb = $.NSPasteboard.generalPasteboard;
+pb.clearContents;
+pb.setStringForType($(htmlStr), $("public.html"));
+pb.setStringForType($(textStr), $("public.utf8-plain-text"));
+"ok";
+      `.trim();
+      execSync('osascript -l JavaScript -', {
+        input: jxaScript,
+        env: { ...process.env, QUARK_HTML: html, QUARK_TEXT: plainText },
+        stdio: ['pipe', 'ignore', 'ignore']
+      });
     } else if (platform === 'linux') {
       execSync('xclip -selection clipboard -t text/html', { input: html, stdio: ['pipe', 'ignore', 'ignore'] });
     } else if (platform === 'win32') {

package/cli/src/daemon.js

@@ -160,6 +160,7 @@ function injectForTarget(app, result) {
 function shutdown() {
   logEvent('INFO', 'Shutting down Quark Daemon gracefully...');
   clearInterval(pollInterval);
+  network.shutdown();
   server.close(() => {
     logEvent('INFO', 'MCP Bridge API closed.');
     process.exit(0);

package/cli/src/installer.js

@@ -44,8 +44,10 @@ function installService() {
       
       fs.mkdirSync(path.dirname(plistPath), { recursive: true });
       fs.writeFileSync(plistPath, plistContent);
-      try { execSync(`launchctl unload ${plistPath}`, { stdio: 'ignore' }); } catch(e) {}
-      execSync(`launchctl load ${plistPath}`);
+      // Use bootstrap/bootout (macOS 12+ preferred API) with load/unload as fallback
+      const uid = execSync('id -u', { encoding: 'utf8' }).trim();
+      try { execSync(`launchctl bootout gui/${uid} ${plistPath}`, { stdio: 'ignore' }); } catch(e) {}
+      execSync(`launchctl bootstrap gui/${uid} ${plistPath}`);
       console.log('✅ macOS LaunchAgent installed and started.');
 
     } else if (platform === 'linux') {
@@ -98,7 +100,8 @@ function uninstallService() {
     if (platform === 'darwin') {
       const plistPath = path.join(os.homedir(), 'Library', 'LaunchAgents', 'com.quark.daemon.plist');
       if (fs.existsSync(plistPath)) {
-        execSync(`launchctl unload ${plistPath}`);
+        const uid = execSync('id -u', { encoding: 'utf8' }).trim();
+        try { execSync(`launchctl bootout gui/${uid} com.quark.daemon`, { stdio: 'ignore' }); } catch(e) {}
         fs.unlinkSync(plistPath);
       }
     } else if (platform === 'linux') {

package/cli/src/network.js

@@ -88,7 +88,7 @@ function broadcast(text, html = null) {
     nodeId: NODE_ID,
     payload: { text, html }
   });
-  
+
   peers.forEach((ws) => {
     if (ws.readyState === WebSocket.OPEN) {
       ws.send(payload);
@@ -96,4 +96,11 @@ function broadcast(text, html = null) {
   });
 }
 
-module.exports = { init, broadcast };
+function shutdown() {
+  peers.forEach((ws) => ws.terminate());
+  peers.clear();
+  if (wss) wss.close();
+  if (bonjourInstance) bonjourInstance.destroy();
+}
+
+module.exports = { init, broadcast, shutdown };