@quantovainc/qcore 0.1.32 → 0.1.33

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "@quantovainc/qcore",
-  "version": "0.1.32",
+  "version": "0.1.33",
   "description": "Quantova's post quantum client core for JavaScript. Signs with ML-DSA-65 and builds Q1 addresses.",
   "scripts": {
     "build": "bash scripts/build.sh",
-    "test": "node test-types.js && node test-conformance.js && node test-order-nonce.js && node test-chain-binding.js && node test-sign-validate.js && node test-transport.js && node test-fee-cap.js && node test-network.js && node test-typed-order.js && node test-asset-guards.js"
+    "test": "node test-types.js && node test-conformance.js && node test-order-nonce.js && node test-chain-binding.js && node test-sign-validate.js && node test-transport.js && node test-fee-cap.js && node test-network.js && node test-typed-order.js && node test-asset-guards.js && node test-account-index.js"
   },
   "keywords": [
     "post-quantum",

package/pkg/package.json

@@ -2,7 +2,7 @@
   "name": "qcore-js",
   "type": "module",
   "description": "The JavaScript binding for the Quantova client core, generated over QCore with wasm-bindgen. The core does the key derivation, the post quantum signing, and the wire, the page does the fetch.",
-  "version": "0.1.31",
+  "version": "0.1.33",
   "license": "Apache-2.0 OR MIT",
   "repository": {
     "type": "git",

package/pkg-node/package.json

@@ -1,7 +1,7 @@
 {
   "name": "qcore-js",
   "description": "The JavaScript binding for the Quantova client core, generated over QCore with wasm-bindgen. The core does the key derivation, the post quantum signing, and the wire, the page does the fetch.",
-  "version": "0.1.31",
+  "version": "0.1.33",
   "license": "Apache-2.0 OR MIT",
   "repository": {
     "type": "git",

package/shared.js

@@ -28,7 +28,15 @@ function checkAmount(amount) {
 }
 
 function accountIndex(index) {
-  const i = BigInt(index);
+  if (typeof index === 'number' && !Number.isSafeInteger(index)) {
+    throw new Error('the account index must be a whole number in the safe integer range, a number that large silently rounds and would sign with a different account key');
+  }
+  let i;
+  try {
+    i = BigInt(index);
+  } catch {
+    throw new Error('the account index must be a whole number');
+  }
   if (i < 0n || i > 0xffffffffffffffffn) {
     throw new Error('the account index must fit in an unsigned 64 bit integer');
   }
@@ -342,7 +350,8 @@ function makeClient(core) {
       if (this._headFloor) {
         const { height, at } = this._headFloor;
         if (head < height) throw new Error(`the gateway reports head ${head} below the ${height} it reported earlier, refusing to sign`);
-        const allowed = (now - at + HEAD_SLACK_SECS) * HEAD_BLOCKS_PER_SEC;
+        const elapsed = now > at ? now - at : 0n;
+        const allowed = (elapsed + HEAD_SLACK_SECS) * HEAD_BLOCKS_PER_SEC;
         if (head > height + allowed) throw new Error(`the gateway head leapt from ${height} to ${head} faster than blocks are made, refusing to sign`);
       } else {
         this._headFloor = { height: head, at: now };
@@ -365,9 +374,10 @@ function makeClient(core) {
       const info = await this.nodeInfo();
       this._guardMainnet();
       const chainId = this._signingChainId(info);
-      const fee = info && info.fee && info.fee.transfer_quon;
-      if (fee == null) throw new Error('the gateway did not report a transfer fee');
-      if (gatewayFee(fee) > ceiling) {
+      const reported = info && info.fee && info.fee.transfer_quon;
+      if (reported == null) throw new Error('the gateway did not report a transfer fee');
+      const fee = gatewayFee(reported);
+      if (fee > ceiling) {
         throw new Error(`the gateway fee ${fee} is above the maximum you allowed ${maxFeeQuon}, refusing to sign`);
       }
       const from = core.address(seedHex, accountIndex(index));
@@ -387,9 +397,10 @@ function makeClient(core) {
       const info = await this.nodeInfo();
       this._guardMainnet();
       const chainId = this._signingChainId(info);
-      const fee = info && info.fee && info.fee.transfer_quon;
-      if (fee == null) throw new Error('the gateway did not report a transfer fee');
-      if (gatewayFee(fee) > ceiling) {
+      const reported = info && info.fee && info.fee.transfer_quon;
+      if (reported == null) throw new Error('the gateway did not report a transfer fee');
+      const fee = gatewayFee(reported);
+      if (fee > ceiling) {
         throw new Error(`the gateway fee ${fee} is above the maximum you allowed ${maxFeeQuon}, refusing to sign`);
       }
       const from = core.address(seedHex, accountIndex(index));

package/shared.mjs

@@ -28,7 +28,15 @@ function checkAmount(amount) {
 }
 
 function accountIndex(index) {
-  const i = BigInt(index);
+  if (typeof index === 'number' && !Number.isSafeInteger(index)) {
+    throw new Error('the account index must be a whole number in the safe integer range, a number that large silently rounds and would sign with a different account key');
+  }
+  let i;
+  try {
+    i = BigInt(index);
+  } catch {
+    throw new Error('the account index must be a whole number');
+  }
   if (i < 0n || i > 0xffffffffffffffffn) {
     throw new Error('the account index must fit in an unsigned 64 bit integer');
   }
@@ -342,7 +350,8 @@ function makeClient(core) {
       if (this._headFloor) {
         const { height, at } = this._headFloor;
         if (head < height) throw new Error(`the gateway reports head ${head} below the ${height} it reported earlier, refusing to sign`);
-        const allowed = (now - at + HEAD_SLACK_SECS) * HEAD_BLOCKS_PER_SEC;
+        const elapsed = now > at ? now - at : 0n;
+        const allowed = (elapsed + HEAD_SLACK_SECS) * HEAD_BLOCKS_PER_SEC;
         if (head > height + allowed) throw new Error(`the gateway head leapt from ${height} to ${head} faster than blocks are made, refusing to sign`);
       } else {
         this._headFloor = { height: head, at: now };
@@ -365,9 +374,10 @@ function makeClient(core) {
       const info = await this.nodeInfo();
       this._guardMainnet();
       const chainId = this._signingChainId(info);
-      const fee = info && info.fee && info.fee.transfer_quon;
-      if (fee == null) throw new Error('the gateway did not report a transfer fee');
-      if (gatewayFee(fee) > ceiling) {
+      const reported = info && info.fee && info.fee.transfer_quon;
+      if (reported == null) throw new Error('the gateway did not report a transfer fee');
+      const fee = gatewayFee(reported);
+      if (fee > ceiling) {
         throw new Error(`the gateway fee ${fee} is above the maximum you allowed ${maxFeeQuon}, refusing to sign`);
       }
       const from = core.address(seedHex, accountIndex(index));
@@ -387,9 +397,10 @@ function makeClient(core) {
       const info = await this.nodeInfo();
       this._guardMainnet();
       const chainId = this._signingChainId(info);
-      const fee = info && info.fee && info.fee.transfer_quon;
-      if (fee == null) throw new Error('the gateway did not report a transfer fee');
-      if (gatewayFee(fee) > ceiling) {
+      const reported = info && info.fee && info.fee.transfer_quon;
+      if (reported == null) throw new Error('the gateway did not report a transfer fee');
+      const fee = gatewayFee(reported);
+      if (fee > ceiling) {
         throw new Error(`the gateway fee ${fee} is above the maximum you allowed ${maxFeeQuon}, refusing to sign`);
       }
       const from = core.address(seedHex, accountIndex(index));