@quantiya/codevibe 1.0.5 → 1.0.7

package/bin/codevibe

@@ -103,42 +103,174 @@ show_version() {
 }
 
 # ─── Update ──────────────────────────────────────────────────────────
+#
+# NOTE: Claude Code's plugin lifecycle has known bugs as of Claude Code 2.1.x:
+#   1. `claude plugin update` lies — reports "already at latest version" based on
+#      the installed plugin's own package.json, never consults the marketplace
+#      manifest for the authoritative latest version.
+#   2. `claude plugin install` doesn't refetch — if a cache directory for the
+#      plugin exists, it reuses it silently instead of downloading the version
+#      pinned in the marketplace manifest.
+#   3. `claude plugin uninstall` doesn't delete the cached plugin directory —
+#      only removes the installed_plugins.json entry, leaving stale code on disk
+#      for the next install to silently reuse.
+#
+# This function works around all three by detecting when the installed version
+# on disk doesn't match the version the marketplace says it should be, then
+# manually clearing all stale cache paths before reinstalling and verifying.
+#
+# If Anthropic fixes these bugs, the cache-nuking path is a no-op (the version
+# comparison will always match) and the code stays correct.
+
+_read_marketplace_version() {
+  # Read the pinned source.version for codevibe-claude from the marketplace manifest.
+  # Echoes the version string, or empty on failure.
+  local manifest="$HOME/.claude/plugins/marketplaces/codevibe-marketplace/.claude-plugin/marketplace.json"
+  [ -f "$manifest" ] || return 0
+  node -p "
+    try {
+      const m = require('$manifest');
+      const p = (m.plugins || []).find(x => x.name === 'codevibe-claude');
+      (p && p.source && p.source.version) || '';
+    } catch (e) { '' }
+  " 2>/dev/null
+}
+
+_read_installed_version() {
+  # Read the installed version of codevibe-claude from installed_plugins.json.
+  # Echoes the version string, or empty if not installed.
+  local db="$HOME/.claude/plugins/installed_plugins.json"
+  [ -f "$db" ] || return 0
+  node -p "
+    try {
+      const ip = require('$db');
+      const e = (ip.plugins || {})['codevibe-claude@codevibe-marketplace'];
+      (e && e[0] && e[0].version) || '';
+    } catch (e) { '' }
+  " 2>/dev/null
+}
+
+_nuke_claude_plugin_cache() {
+  # Remove every path Claude Code's plugin loader might read stale code from.
+  rm -rf "$HOME/.claude/plugins/cache/codevibe-marketplace/codevibe-claude"
+  rm -rf "$HOME/.claude/plugins/npm-cache/node_modules/@quantiya/codevibe-claude-plugin"
+  rm -rf "$HOME/.claude/plugins/npm-cache/node_modules/codevibe-claude-plugin"
+  rm -f  "$HOME/.claude/plugins/npm-cache/package-lock.json"
+}
 
 do_update() {
   echo ""
   echo -e "${BOLD}${PURPLE}CodeVibe Update${NC}"
   echo ""
 
-  # Show current versions
+  # Show current meta-package version
   if [ -f "$PACKAGE_DIR/package.json" ]; then
     CUR_VER=$(node -p "require('$PACKAGE_DIR/package.json').version" 2>/dev/null || echo "?")
-    echo -e "  ${DIM}Current version: $CUR_VER${NC}"
+    echo -e "  ${DIM}Current meta-package: $CUR_VER${NC}"
   fi
   echo ""
 
-  # Update meta-package (pulls latest core + all plugins)
+  # ─── Step 1: Update the global meta-package (pulls latest core + plugins) ──
   echo -e "${PURPLE}▸${NC} Updating @quantiya/codevibe..."
-  npm install -g --force @quantiya/codevibe@latest 2>&1 | tail -1
-  echo -e "${GREEN}✓${NC} CodeVibe updated"
+  # Capture output so we can check npm's exit status directly instead of the
+  # pipe's (tail's exit status would mask npm failures without `set -o pipefail`).
+  local npm_output
+  if ! npm_output=$(npm install -g --force @quantiya/codevibe@latest 2>&1); then
+    echo "$npm_output" | tail -10
+    echo ""
+    echo -e "${YELLOW}!${NC} Meta-package update failed. Check the output above, fix the issue, and retry 'codevibe update'."
+    return 1
+  fi
+  echo "$npm_output" | tail -3
+  echo -e "${GREEN}✓${NC} Meta-package updated"
 
-  # Update Claude plugin in Claude Code
-  if command -v claude >/dev/null 2>&1; then
+  # ─── Step 2: Update the Claude Code plugin ─────────────────────────────────
+  if ! command -v claude >/dev/null 2>&1; then
+    echo ""
+    echo -e "${YELLOW}!${NC} claude CLI not found — skipping Claude Code plugin update"
     echo ""
-    echo -e "${PURPLE}▸${NC} Updating Claude Code plugin..."
+    echo -e "${BOLD}Updated versions:${NC}"
+    show_version
+    return 0
+  fi
 
-    # Refresh marketplace
-    if claude plugin marketplace update codevibe-marketplace 2>/dev/null; then
-      echo -e "${GREEN}✓${NC} Marketplace refreshed"
-    else
-      echo -e "${YELLOW}!${NC} Marketplace refresh skipped"
+  echo ""
+  echo -e "${PURPLE}▸${NC} Updating Claude Code plugin..."
+
+  # Refresh the marketplace manifest so we see the latest pinned version.
+  # Errors here are non-fatal at this step — the previously-cached manifest may
+  # still be usable — but the EXPECTED_VERSION read below is the real gate.
+  if claude plugin marketplace update codevibe-marketplace; then
+    echo -e "${GREEN}✓${NC} Marketplace refreshed"
+  else
+    echo -e "${YELLOW}!${NC} Marketplace refresh failed (falling back to cached manifest)"
+  fi
+
+  local EXPECTED_VERSION
+  local INSTALLED_VERSION
+  EXPECTED_VERSION=$(_read_marketplace_version)
+  INSTALLED_VERSION=$(_read_installed_version)
+
+  # EXPECTED_VERSION is required — without it we have no ground truth to verify
+  # against, so the whole cache-bug workaround is blind. Fail loudly rather than
+  # claim success we can't prove.
+  if [ -z "$EXPECTED_VERSION" ]; then
+    echo ""
+    echo -e "${YELLOW}!${NC} Could not read expected version from marketplace manifest."
+    echo -e "  ${DIM}Expected at: \$HOME/.claude/plugins/marketplaces/codevibe-marketplace/.claude-plugin/marketplace.json${NC}"
+    echo -e "  ${DIM}This usually means the marketplace refresh failed or the manifest schema has drifted.${NC}"
+    echo -e "  ${DIM}Try: claude plugin marketplace update codevibe-marketplace${NC}"
+    return 1
+  fi
+
+  echo -e "  ${DIM}installed: ${INSTALLED_VERSION:-<none>}   marketplace: ${EXPECTED_VERSION}${NC}"
+
+  # ─── Step 3: Decide if we need to force a cache-clearing reinstall ─────────
+  local NEEDS_REINSTALL=false
+  if [ -z "$INSTALLED_VERSION" ] || [ "$INSTALLED_VERSION" != "$EXPECTED_VERSION" ]; then
+    NEEDS_REINSTALL=true
+    if [ -n "$INSTALLED_VERSION" ]; then
+      echo -e "${YELLOW}!${NC} Cache is stale (${INSTALLED_VERSION} on disk, ${EXPECTED_VERSION} in marketplace)."
+      echo -e "  ${DIM}Working around Claude Code plugin update bug...${NC}"
     fi
+  fi
+
+  if [ "$NEEDS_REINSTALL" = "true" ]; then
+    # Must uninstall + nuke cache BEFORE install. `claude plugin install` will
+    # silently reuse an existing cache dir even if the marketplace version changed.
+    claude plugin uninstall codevibe-claude@codevibe-marketplace >/dev/null 2>&1 || true
+    _nuke_claude_plugin_cache
 
-    # Reinstall plugin (gets latest version from marketplace)
-    if claude plugin install codevibe-claude@codevibe-marketplace 2>/dev/null; then
-      echo -e "${GREEN}✓${NC} Claude plugin updated"
+    if claude plugin install codevibe-claude@codevibe-marketplace; then
+      echo -e "${GREEN}✓${NC} Claude plugin reinstalled"
     else
-      echo -e "${YELLOW}!${NC} Claude plugin update skipped"
+      echo ""
+      echo -e "${YELLOW}!${NC} Claude plugin install failed — try running 'codevibe update' again"
+      return 1
     fi
+  else
+    # Version already matches. Still call install to make sure installed_plugins.json
+    # is in sync, but treat any error as non-fatal since we're not actually changing state.
+    claude plugin install codevibe-claude@codevibe-marketplace >/dev/null 2>&1 || true
+    echo -e "${GREEN}✓${NC} Claude plugin already at ${INSTALLED_VERSION}"
+  fi
+
+  # ─── Step 4: Verify the installed version is now what we expected ──────────
+  # EXPECTED_VERSION is guaranteed non-empty here (we bailed earlier otherwise),
+  # so the verification is unconditional.
+  INSTALLED_VERSION=$(_read_installed_version)
+  if [ "$INSTALLED_VERSION" != "$EXPECTED_VERSION" ]; then
+    echo ""
+    echo -e "${YELLOW}!${NC} WARNING: Installed version (${INSTALLED_VERSION:-<none>}) still doesn't match expected (${EXPECTED_VERSION})."
+    echo -e "  ${DIM}Try: rm -rf ~/.claude/plugins/cache/codevibe-marketplace/codevibe-claude && codevibe update${NC}"
+    return 1
+  fi
+
+  # ─── Step 5: Tell the user about running sessions ──────────────────────────
+  if [ "$NEEDS_REINSTALL" = "true" ]; then
+    echo ""
+    echo -e "${YELLOW}!${NC} Running Claude Code sessions still have the OLD plugin server in memory."
+    echo -e "  ${DIM}Exit and restart any active session to pick up the new plugin.${NC}"
   fi
 
   echo ""

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quantiya/codevibe",
-  "version": "1.0.5",
+  "version": "1.0.7",
   "description": "CodeVibe - Monitor and control AI coding agents (Claude Code, Gemini CLI, Codex CLI) from your mobile device",
   "bin": {
     "codevibe": "./bin/codevibe",
@@ -15,7 +15,7 @@
   ],
   "dependencies": {
     "@quantiya/codevibe-core": "^1.0.3",
-    "@quantiya/codevibe-claude-plugin": "^1.0.9",
+    "@quantiya/codevibe-claude-plugin": "^1.0.10",
     "@quantiya/codevibe-gemini-plugin": "^1.0.5",
     "@quantiya/codevibe-codex-plugin": "^1.0.6"
   },