@quantiya/codevibe-gemini-plugin 1.0.19 → 1.0.21

package/bin/codevibe-gemini

@@ -43,6 +43,89 @@ done
 SCRIPT_DIR="$(cd -P "$(dirname "$SOURCE")" && pwd)"
 PLUGIN_DIR="$(dirname "$SCRIPT_DIR")"
 
+# ─── PATH augmentation ───────────────────────────────────────────────
+# When the install one-liner runs in a fresh terminal, Homebrew's
+# installer writes the shellenv eval into ~/.zprofile (and similar)
+# but the user's current shell hasn't sourced it yet. Subsequent
+# codevibe-* runs in that same terminal then fail tmux discovery
+# because /opt/homebrew/bin isn't on PATH. Prepend common locations
+# so the wrapper recovers without forcing the user to open a new
+# terminal. Prepend (not append) is deliberate: the Homebrew binary
+# install.sh just laid down should win over any older system binary
+# (e.g. a stale /usr/bin/node on Linux) at the same name. To preserve
+# the relative ordering of augmented dirs, build a single prefix
+# string and prepend it once — iterating prepend-per-dir would
+# reverse intended order. ${PATH:+:$PATH} keeps an empty starting
+# PATH from producing a trailing colon (which makes cwd searchable).
+_CV_NEW_PATHS=""
+for _CV_DIR in /opt/homebrew/bin /opt/homebrew/sbin /usr/local/bin /usr/local/sbin /opt/local/bin /usr/bin /bin; do
+  case ":$PATH:" in
+    *":$_CV_DIR:"*) ;;
+    *) [ -d "$_CV_DIR" ] && _CV_NEW_PATHS="$_CV_NEW_PATHS:$_CV_DIR" ;;
+  esac
+done
+[ -n "$_CV_NEW_PATHS" ] && export PATH="${_CV_NEW_PATHS#:}${PATH:+:$PATH}"
+unset _CV_DIR _CV_NEW_PATHS
+
+# ─── Wrapper telemetry (GA4 Measurement Protocol) ─────────────────────
+# Diagnoses agent CLI failures: pre-flight bailouts, fast-die patterns,
+# whether SessionStart hook fired, exit code. Background curl, fail
+# silently, no PII (hashed hostname + per-run random id only). Honors
+# CODEVIBE_TELEMETRY_SOURCE=test for internal testing.
+_CV_MID="G-GS74YEQTB8"
+_CV_SEC="lAfOF6OxRzSQ-NsLBRjhAg"
+_CV_CID="$(echo "$(uname -n)-$(id -u)" | (sha256sum 2>/dev/null || shasum -a 256 2>/dev/null || echo "anonymous-fallback ") | cut -c1-36)"
+_CV_RUN_ID="$(head -c 16 /dev/urandom 2>/dev/null | od -An -tx1 | tr -d ' \n' | cut -c1-32)"
+[ -z "$_CV_RUN_ID" ] && _CV_RUN_ID="fallback-$(date +%s)-$$"
+_CV_AGENT="gemini"
+_CV_SOURCE="${CODEVIBE_TELEMETRY_SOURCE:-production}"
+_CV_STARTED_AT="$(date +%s)"
+_CV_EXITED=""    # set by terminal events; suppresses trap double-fire
+_CV_PLUGIN_VERSION="$(node -p "require('$PLUGIN_DIR/package.json').version" 2>/dev/null || echo unknown)"
+_CV_MCP_LOG="${CODEVIBE_TMPDIR}/codevibe-gemini-mcp.log"
+_CV_MCP_LOG_BASELINE=0
+if [ -f "$_CV_MCP_LOG" ]; then
+  _CV_MCP_LOG_BASELINE=$(wc -l < "$_CV_MCP_LOG" 2>/dev/null | tr -d ' ')
+  [ -z "$_CV_MCP_LOG_BASELINE" ] && _CV_MCP_LOG_BASELINE=0
+fi
+_CV_TMUX_STARTED="false"
+_CV_AGENT_INVOKED="false"
+_CV_AGENT_STARTED_AT=0
+_CV_GEMINI_EXIT_FILE="${CODEVIBE_TMPDIR}/codevibe-gemini-exit-$$"
+
+# Strip an arbitrary string down to a JSON-safe identifier alphabet.
+# Removes anything that could break the hand-built JSON payload below
+# (quotes, backslashes, ANSI escapes, control bytes, tabs, newlines).
+# Truncates to 40 chars to bound the impact of pathological CLI version
+# output. Caller is responsible for emptiness check after sanitize.
+cv_sanitize() {
+  printf '%s' "$1" | LC_ALL=C tr -cd 'A-Za-z0-9._\- ' | cut -c1-40
+}
+
+# Sanitize trusted-but-still-string values that go into the payload
+# (plugin version, source label) so future schema additions can't
+# accidentally reintroduce a JSON-injection path.
+_CV_PLUGIN_VERSION="$(cv_sanitize "$_CV_PLUGIN_VERSION")"
+[ -z "$_CV_PLUGIN_VERSION" ] && _CV_PLUGIN_VERSION="unknown"
+_CV_SOURCE="$(cv_sanitize "$_CV_SOURCE")"
+[ -z "$_CV_SOURCE" ] && _CV_SOURCE="production"
+
+cv_telem() {
+  local event="$1"; shift
+  local params="$*"
+  curl -s -X POST \
+    "https://www.google-analytics.com/mp/collect?measurement_id=${_CV_MID}&api_secret=${_CV_SEC}" \
+    -H "Content-Type: application/json" \
+    -d "{\"client_id\":\"${_CV_CID}\",\"events\":[{\"name\":\"${event}\",\"params\":{\"agent\":\"${_CV_AGENT}\",\"plugin_version\":\"${_CV_PLUGIN_VERSION}\",\"source\":\"${_CV_SOURCE}\",\"run_id\":\"${_CV_RUN_ID}\"${params:+,$params}}}]}" \
+    </dev/null >/dev/null 2>&1 &
+}
+
+cv_failed() {
+  [ -n "$_CV_EXITED" ] && return 0
+  _CV_EXITED="failed"
+  cv_telem "wrapper_failed" "\"reason\":\"$1\",\"lifetime_seconds\":$(( $(date +%s) - _CV_STARTED_AT ))"
+}
+
 # Handle auth commands (login, logout, status, reset-device)
 # Delegate to codevibe-core CLI (shared auth across all plugins)
 case "$1" in
@@ -53,14 +136,42 @@ case "$1" in
             CORE_CLI="$PLUGIN_DIR/../codevibe-core/bin/codevibe.js"
         fi
         if [ -f "$CORE_CLI" ]; then
+            cv_telem "wrapper_started" "\"invocation\":\"auth_$1\",\"os\":\"$(uname -s | cv_sanitize)\",\"arch\":\"$(uname -m | cv_sanitize)\""
             exec node "$CORE_CLI" "$1"
         else
             echo "Error: codevibe-core not found. Try reinstalling: npm install -g @quantiya/codevibe"
+            cv_failed "core_not_found"
+            sleep 1
             exit 1
         fi
         ;;
 esac
 
+# Capture environment facts for the session-flow wrapper_started event.
+# Each probe is non-fatal — if a CLI is missing we record "missing" rather
+# than aborting; pre-flight checks below still gate execution. Every
+# string that lands in the JSON payload goes through cv_sanitize so an
+# agent CLI emitting ANSI escapes or quotes in `--version` can't break
+# the hand-built payload.
+_CV_GEMINI_VER="missing"
+command -v gemini >/dev/null 2>&1 && _CV_GEMINI_VER="$(gemini --version 2>/dev/null | cv_sanitize)"
+[ -z "$_CV_GEMINI_VER" ] && _CV_GEMINI_VER="unknown"
+_CV_NODE_VER="missing"
+command -v node >/dev/null 2>&1 && _CV_NODE_VER="$(node -v 2>/dev/null | cv_sanitize)"
+[ -z "$_CV_NODE_VER" ] && _CV_NODE_VER="unknown"
+_CV_TMUX_VER="missing"
+command -v tmux >/dev/null 2>&1 && _CV_TMUX_VER="$(tmux -V 2>/dev/null | cv_sanitize)"
+[ -z "$_CV_TMUX_VER" ] && _CV_TMUX_VER="unknown"
+_CV_OS_VER="$(uname -s | cv_sanitize)"
+[ -z "$_CV_OS_VER" ] && _CV_OS_VER="unknown"
+_CV_ARCH_VER="$(uname -m | cv_sanitize)"
+[ -z "$_CV_ARCH_VER" ] && _CV_ARCH_VER="unknown"
+_CV_GEMINI_AUTH="false"; [ -f "$HOME/.gemini/oauth_creds.json" ] && _CV_GEMINI_AUTH="true"
+_CV_GEMINI_SETTINGS="false"; [ -f "$HOME/.gemini/settings.json" ] && _CV_GEMINI_SETTINGS="true"
+_CV_INSIDE_TMUX="false"; [ -n "$TMUX" ] && _CV_INSIDE_TMUX="true"
+_CV_IS_TTY="false"; { [ -t 0 ] && [ -t 1 ]; } && _CV_IS_TTY="true"
+cv_telem "wrapper_started" "\"invocation\":\"session\",\"os\":\"$_CV_OS_VER\",\"arch\":\"$_CV_ARCH_VER\",\"gemini_version\":\"$_CV_GEMINI_VER\",\"node_version\":\"$_CV_NODE_VER\",\"tmux_version\":\"$_CV_TMUX_VER\",\"gemini_auth_present\":$_CV_GEMINI_AUTH,\"gemini_settings_present\":$_CV_GEMINI_SETTINGS,\"inside_tmux\":$_CV_INSIDE_TMUX,\"is_terminal\":$_CV_IS_TTY"
+
 # Export hooks directory for hook scripts to use
 export CODEVIBE_HOOKS_DIR="$PLUGIN_DIR/hooks"
 
@@ -130,7 +241,52 @@ log() {
 
 # Cleanup function to kill MCP server when wrapper exits
 cleanup() {
+    local wrapper_exit_code=$?
     log "Cleanup triggered"
+
+    # Fire wrapper_exited telemetry BEFORE killing the server so the MCP
+    # log is intact when we grep for SessionStart. cv_failed sets
+    # _CV_EXITED on pre-flight failures so this block won't double-fire.
+    if [ -z "$_CV_EXITED" ]; then
+        _CV_EXITED="exited"
+        local gemini_exit="unknown"
+        if [ -f "$_CV_GEMINI_EXIT_FILE" ]; then
+            gemini_exit="$(cat "$_CV_GEMINI_EXIT_FILE" 2>/dev/null | head -c 10 | tr -d '\n\r ')"
+            [ -z "$gemini_exit" ] && gemini_exit="unknown"
+        fi
+        local lifetime=$(( $(date +%s) - _CV_STARTED_AT ))
+        local gemini_lifetime=0
+        if [ "$_CV_AGENT_STARTED_AT" -gt 0 ] 2>/dev/null; then
+            gemini_lifetime=$(( $(date +%s) - _CV_AGENT_STARTED_AT ))
+        fi
+        local hook_fired="false"
+        if [ -f "$_CV_MCP_LOG" ]; then
+            if tail -n "+$((_CV_MCP_LOG_BASELINE + 1))" "$_CV_MCP_LOG" 2>/dev/null \
+                | grep -q "SessionStart" 2>/dev/null; then
+                hook_fired="true"
+            fi
+        fi
+        # Outcome priority: SIGINT/SIGTERM beats everything (user intent).
+        # Then "we never got far enough to invoke gemini" — distinct from
+        # "we invoked gemini via passthrough but never started a tmux of
+        # our own" (the latter is a normal direct-run, not an abort).
+        local outcome
+        if [ "$wrapper_exit_code" = "130" ] || [ "$wrapper_exit_code" = "143" ]; then
+            outcome="interrupted"
+        elif [ "$_CV_AGENT_INVOKED" = "false" ]; then
+            outcome="pre_invoke_abort"
+        elif [ "$gemini_exit" != "unknown" ] && [ "$gemini_exit" != "0" ]; then
+            outcome="error_exit"
+        elif [ "$gemini_lifetime" -lt 5 ] 2>/dev/null; then
+            outcome="early_exit"
+        elif [ "$gemini_lifetime" -lt 60 ] 2>/dev/null; then
+            outcome="clean_short"
+        else
+            outcome="clean_long"
+        fi
+        cv_telem "wrapper_exited" "\"exit_code\":$wrapper_exit_code,\"lifetime_seconds\":$lifetime,\"gemini_exit_code\":\"$gemini_exit\",\"gemini_lifetime_seconds\":$gemini_lifetime,\"tmux_session_started\":$_CV_TMUX_STARTED,\"agent_invoked\":$_CV_AGENT_INVOKED,\"session_start_hook_fired\":$hook_fired,\"terminal_outcome\":\"$outcome\""
+    fi
+
     if [ -n "$MCP_PID" ] && kill -0 "$MCP_PID" 2>/dev/null; then
         log "Stopping MCP server (PID: $MCP_PID)"
         kill "$MCP_PID" 2>/dev/null || true
@@ -138,6 +294,7 @@ cleanup() {
     fi
     # Remove PID file
     rm -f "${CODEVIBE_TMPDIR}/codevibe-gemini-mcp-$$.pid"
+    rm -f "$_CV_GEMINI_EXIT_FILE"
 }
 
 # Set up trap for cleanup
@@ -147,6 +304,8 @@ trap cleanup EXIT INT TERM
 if ! command -v tmux &> /dev/null; then
     echo "Error: tmux is required but not installed."
     echo "Install with: brew install tmux"
+    cv_failed "tmux_missing"
+    sleep 1
     exit 1
 fi
 
@@ -154,18 +313,24 @@ fi
 if ! command -v gemini &> /dev/null; then
     echo "Error: gemini CLI is not installed."
     echo "Install from: https://github.com/google-gemini/gemini-cli"
+    cv_failed "gemini_missing"
+    sleep 1
     exit 1
 fi
 
 # Check if node is installed
 if ! command -v node &> /dev/null; then
     echo "Error: Node.js is required but not installed."
+    cv_failed "node_missing"
+    sleep 1
     exit 1
 fi
 
 # Check if MCP server is built
 if [ ! -f "$PLUGIN_DIR/dist/server.js" ]; then
     echo "Error: MCP server not built. Run 'npm run build' in the plugin directory first."
+    cv_failed "server_not_built"
+    sleep 1
     exit 1
 fi
 
@@ -177,17 +342,36 @@ log "Starting codevibe-gemini with session: $SESSION_NAME"
 log "Working directory: $WORKING_DIR"
 log "Arguments: $*"
 
-# Check if we're already inside tmux
+# Check if we're already inside tmux.
+# We deliberately do NOT `exec` here — running gemini as a child process
+# lets the EXIT trap fire after it returns so wrapper_exited still gets
+# emitted on these direct-run paths. Behaviorally identical for the user
+# (gemini remains the foreground process for the duration).
 if [ -n "$TMUX" ]; then
     log "Already inside tmux, running gemini directly"
-    # Already in tmux, just run gemini
-    exec gemini "$@"
+    _CV_AGENT_INVOKED="true"
+    _CV_AGENT_STARTED_AT="$(date +%s)"
+    # `|| _CV_RC=$?` is load-bearing: with `set -e`, a non-zero exit
+    # from gemini would abort the wrapper before we capture the exit
+    # code, leaving wrapper_exited with gemini_exit_code="unknown". The
+    # `||` form catches non-zero without triggering set -e, while exit
+    # 0 leaves _CV_RC at its 0 default. printf's `|| true` keeps a
+    # disk-full failure from clobbering diagnostics.
+    _CV_RC=0
+    gemini "$@" || _CV_RC=$?
+    printf '%s' "$_CV_RC" > "$_CV_GEMINI_EXIT_FILE" 2>/dev/null || true
+    exit "$_CV_RC"
 fi
 
-# Check if running in a terminal
+# Check if running in a terminal — same direct-run treatment as above.
 if [ ! -t 0 ] || [ ! -t 1 ]; then
     log "Not running in a terminal, running gemini directly"
-    exec gemini "$@"
+    _CV_AGENT_INVOKED="true"
+    _CV_AGENT_STARTED_AT="$(date +%s)"
+    _CV_RC=0
+    gemini "$@" || _CV_RC=$?
+    printf '%s' "$_CV_RC" > "$_CV_GEMINI_EXIT_FILE" 2>/dev/null || true
+    exit "$_CV_RC"
 fi
 
 # Start MCP server in background BEFORE launching Gemini
@@ -214,6 +398,8 @@ if ! kill -0 "$MCP_PID" 2>/dev/null; then
     tail -3 "$MCP_LOG_FILE" 2>/dev/null | grep -v '^\[' | head -1
     echo ""
     echo "Server failed to start. Check $MCP_LOG_FILE for details."
+    cv_failed "server_died_on_startup"
+    sleep 1
     exit 1
 fi
 
@@ -232,10 +418,16 @@ done
 # We use a wrapper that:
 # 1. Exports the session name so prompts can find it
 # 2. Runs gemini
-# 3. Exits the tmux session when gemini exits
+# 3. Captures gemini's exit code to $_CV_GEMINI_EXIT_FILE for the
+#    wrapper's cleanup trap (tmux's own attach exit code is independent
+#    of the inner process exit, so the file is the only reliable signal)
+# 4. Exits the tmux session when gemini exits
 
 tmux new-session -d -s "$SESSION_NAME" -x "$(tput cols)" -y "$(tput lines)" \
-    "export CODEVIBE_GEMINI_TMUX_SESSION='$SESSION_NAME'; export ENVIRONMENT='$ENVIRONMENT'; $GEMINI_CMD; exit"
+    "export CODEVIBE_GEMINI_TMUX_SESSION='$SESSION_NAME'; export ENVIRONMENT='$ENVIRONMENT'; $GEMINI_CMD; printf '%s' \"\$?\" > '$_CV_GEMINI_EXIT_FILE'; exit"
+_CV_TMUX_STARTED="true"
+_CV_AGENT_INVOKED="true"
+_CV_AGENT_STARTED_AT="$(date +%s)"
 
 # Enable mouse support for scrolling
 tmux set-option -t "$SESSION_NAME" -g mouse on

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quantiya/codevibe-gemini-plugin",
-  "version": "1.0.19",
+  "version": "1.0.21",
   "description": "Control Gemini CLI from your iPhone and Android — real-time sync, approve file edits, send prompts by voice. Part of CodeVibe.",
   "main": "dist/server.js",
   "bin": {