@quantiya/codevibe-core 2.0.87 → 2.0.88

package/dist/orchestration-shell/cli.js

@@ -23604,7 +23604,7 @@ var AppSyncClient = class _AppSyncClient {
         throw logger.warn("[AppSyncClient] explicit review-scope reset rejected by old backend schema; failing closed", {
           gateId: input.gateId,
           taskId: input.taskId
-        }), err;
+        }), err.reviewScopeResetUnsupported = !0, err;
       logger.warn("[AppSyncClient] submitImplementorOutput additive fields rejected by backend schema; retrying legacy input", {
         gateId: input.gateId,
         taskId: input.taskId,
@@ -23621,7 +23621,10 @@ var AppSyncClient = class _AppSyncClient {
       };
       response = await this.graphqlRequest(mutations.submitImplementorOutput, retryVariables);
     }
-    return this.#parseAwsJson(response.data?.submitImplementorOutput, "submitImplementorOutput");
+    let parsed = this.#parseOrchestrationResult(response.data?.submitImplementorOutput, "submitImplementorOutput");
+    if (typeof parsed.gateId != "string" || parsed.gateId.length === 0 || typeof parsed.workflowState != "string" || parsed.workflowState.length === 0)
+      throw new Error("submitImplementorOutput: result missing string `gateId` / `workflowState`");
+    return { gateId: parsed.gateId, workflowState: parsed.workflowState };
   }
   /**
    * §3.C.22 — submit one reviewer seat's verdict. The full `ReviewerVerdict`
@@ -23679,7 +23682,7 @@ var AppSyncClient = class _AppSyncClient {
       throw new Error("getReviewerPrompt: gateId is required");
     if (!Number.isInteger(seatId) || seatId < 0)
       throw new Error("getReviewerPrompt: seatId must be a non-negative integer");
-    let response = await this.graphqlRequest(queries.getReviewerPrompt, { gateId, seatId }), parsed = this.#parseAwsJson(response.data?.getReviewerPrompt, "getReviewerPrompt");
+    let response = await this.graphqlRequest(queries.getReviewerPrompt, { gateId, seatId }), parsed = this.#parseOrchestrationResult(response.data?.getReviewerPrompt, "getReviewerPrompt");
     if (!parsed.encPrompt || typeof parsed.encPrompt.ciphertextB64 != "string")
       throw new Error("getReviewerPrompt: response missing encPrompt.ciphertextB64");
     let prompt = cryptoService.decryptContent(parsed.encPrompt.ciphertextB64, sessionKeyBase64);
@@ -23751,7 +23754,7 @@ var AppSyncClient = class _AppSyncClient {
    * key.
    */
   async getClassBSigningPublicKey() {
-    let response = await this.graphqlRequest(queries.getClassBSigningPublicKey, {}), parsed = this.#parseAwsJson(
+    let response = await this.graphqlRequest(queries.getClassBSigningPublicKey, {}), parsed = this.#parseOrchestrationResult(
       response.data?.getClassBSigningPublicKey,
       "getClassBSigningPublicKey"
     );
@@ -23767,7 +23770,7 @@ var AppSyncClient = class _AppSyncClient {
   async getInReviewAssignments(taskId) {
     if (typeof taskId != "string" || taskId.length === 0)
       throw new Error("getInReviewAssignments: taskId is required");
-    let response = await this.graphqlRequest(queries.getInReviewAssignments, { taskId }), parsed = this.#parseAwsJson(
+    let response = await this.graphqlRequest(queries.getInReviewAssignments, { taskId }), parsed = this.#parseOrchestrationResult(
       response.data?.getInReviewAssignments,
       "getInReviewAssignments"
     );
@@ -23785,7 +23788,7 @@ var AppSyncClient = class _AppSyncClient {
   async getTaskGroupTracks(taskGroupId) {
     if (typeof taskGroupId != "string" || taskGroupId.length === 0)
       throw new Error("getTaskGroupTracks: taskGroupId is required");
-    let response = await this.graphqlRequest(queries.getTaskGroupTracks, { taskGroupId }), parsed = this.#parseAwsJson(
+    let response = await this.graphqlRequest(queries.getTaskGroupTracks, { taskGroupId }), parsed = this.#parseOrchestrationResult(
       response.data?.getTaskGroupTracks,
       "getTaskGroupTracks"
     );
@@ -23804,7 +23807,7 @@ var AppSyncClient = class _AppSyncClient {
   async getInFlightTeamTracks(sessionId) {
     if (typeof sessionId != "string" || sessionId.length === 0)
       throw new Error("getInFlightTeamTracks: sessionId is required");
-    let response = await this.graphqlRequest(queries.getInFlightTeamTracks, { sessionId }), parsed = this.#parseAwsJson(
+    let response = await this.graphqlRequest(queries.getInFlightTeamTracks, { sessionId }), parsed = this.#parseOrchestrationResult(
       response.data?.getInFlightTeamTracks,
       "getInFlightTeamTracks"
     );
@@ -23825,7 +23828,7 @@ var AppSyncClient = class _AppSyncClient {
   async getTaskGroupStatus(taskGroupId) {
     if (typeof taskGroupId != "string" || taskGroupId.length === 0)
       throw new Error("getTaskGroupStatus: taskGroupId is required");
-    let response = await this.graphqlRequest(queries.getTaskGroupStatus, { taskGroupId }), parsed = this.#parseAwsJson(
+    let response = await this.graphqlRequest(queries.getTaskGroupStatus, { taskGroupId }), parsed = this.#parseOrchestrationResult(
       response.data?.getTaskGroupStatus,
       "getTaskGroupStatus"
     );
@@ -23989,7 +23992,11 @@ var AppSyncClient = class _AppSyncClient {
   }
   /**
    * P46b (ID-16) — parse an orchestration Lambda AWSJSON result and surface the
-   * handler's `{errorType, errorMessage}` envelope as a thrown error.
+   * handler's `{errorType, errorMessage}` envelope as a thrown error. SB-67: every read that went through a raw
+   * `#parseAwsJson` now goes through here — read raw, the envelope was data (a hang on submit, an empty list on the
+   * recovery reads). Reads parsed by hand or by `coerceAwsJsonObject` (createTaskGroup, submitMergeGateVerdict,
+   * submitTrackVerificationOutcome, claimGroupDecision, getTaskReviewSummary) check a required field and throw an
+   * untyped error on an envelope.
    */
   #parseOrchestrationResult(raw, op) {
     let parsed = this.#parseAwsJson(raw, op);
@@ -67655,6 +67662,9 @@ function classifyImplementorRoundFailure(err) {
     return AUTHORITY_REFUSAL_LABEL[err.refusal.category] ?? "the implementor was refused authority";
   if (err instanceof StaleShadowRootError)
     return `the recorded workspace-copy folder ${err.stalePath} is missing and its contents could not be accounted for (they may have been moved). Run \`codevibe doctor\` to review and clear it`;
+  let engine = err;
+  if (engine && engine.name === "AppSyncGraphQLError" && typeof engine.errorType == "string")
+    return engine.errorType === "ClientError" && String(engine.responseMessage ?? "").startsWith("payload too large") ? "the change is too large to submit for review" : "the review service rejected the submission";
   let msg = err instanceof Error ? err.message.toLowerCase() : "";
   return msg.includes("enoent") || msg.includes("spawn") || msg.includes("command not found") || msg.includes("not installed") ? "the coding agent could not be started" : "an unexpected error occurred";
 }
@@ -68777,6 +68787,11 @@ var QuorumLoop = class _QuorumLoop {
     this.inFlightImplementorGates = /* @__PURE__ */ new Set();
     /** Gates whose implementor output has been submitted. */
     this.submittedOutputGates = /* @__PURE__ */ new Set();
+    /**
+     * SB-67 (Stage 1 R1-F1) — gates whose round failed after its submission started. The engine can dispatch reviewers
+     * before it reports an error; a late dispatch for one of these gates belongs to a discarded task and is dropped.
+     */
+    this.abandonedSubmitGates = /* @__PURE__ */ new Set();
     /**
      * PHASE-CP-10-MIN (#585) #C10M-16 / Codex-H1 — the per-task ACTIVE
      * implementor context. `runImplementorRound` populates it at spawn (wiring
@@ -71382,7 +71397,13 @@ ${section}`);
         reviewScopeReset: args.reviewScopeReset
       });
       if (args.reviewScopeReset && this.reviewScopeResetTasks.delete(args.taskId), this.teamRunIsHalted(args.teamAuthority)) return;
-      if (this.submittedOutputGates.add(gateId), result && (result.workflowState === "halted" || result.workflowState === "idle")) {
+      if (this.submittedOutputGates.add(gateId), result?.replayedAfterEngineError === !0 && result.workflowState === "halted" && !isEngineEmptyArtifact(files))
+        logger.info("[QuorumLoop] submission confirmed by the engine replay of an already-resolved gate", {
+          gateId,
+          taskId: args.taskId,
+          workflowState: result.workflowState
+        });
+      else if (result && (result.workflowState === "halted" || result.workflowState === "idle")) {
         let crashedEmpty = files.length === 0 && exit.exitCode !== 0, reason = files.length === 0 ? crashedEmpty ? "The coding agent exited with an error before making any changes \u2014 nothing to review. Re-run the task; if this repeats, check the desktop log." : "The implementor produced no changes \u2014 nothing to review." : "The task was halted before review (no reviewer quorum ran).";
         (crashedEmpty ? logger.warn.bind(logger) : logger.info.bind(logger))("[QuorumLoop] execute-first born-halt surfaced synchronously (#EF-1)", {
           gateId,
@@ -71398,7 +71419,11 @@ ${section}`);
       }
     } catch (err) {
       if (this.teamRunIsHalted(args.teamAuthority)) return;
-      if (classifyImplementorQuotaFailure(void 0, err.message ?? "")) {
+      if (
+        // SB-67 (Stage 2 R1-F2): only an implementor failure can be a provider quota; once the submission started,
+        // an error is the engine's (its own `HTTP 429/503` text must not read as the coding agent's usage limit).
+        !submissionStarted && classifyImplementorQuotaFailure(void 0, err.message ?? "")
+      ) {
         logger.info("[QuorumLoop] implementor round threw a quota error \u2014 continuation fork (defensive)", {
           gateId,
           taskId: args.taskId
@@ -71416,8 +71441,8 @@ ${section}`);
       });
       let reason = classifyImplementorRoundFailure(err);
       this.surfaceHalt(`The task could not proceed \u2014 ${reason}.`);
-      let reviseFeedbackId = args.reviseFeedbackId, preserveResetForRetry = submissionStarted && args.reviewScopeReset === !0 && reviseFeedbackId !== void 0 && this.reviewScopeResetTasks.has(args.taskId);
-      this.emitProgress(
+      let reviseFeedbackId = args.reviseFeedbackId, preserveResetForRetry = submissionStarted && args.reviewScopeReset === !0 && reviseFeedbackId !== void 0 && this.reviewScopeResetTasks.has(args.taskId) && err?.reviewScopeResetUnsupported === !0;
+      submissionStarted && !preserveResetForRetry && this.abandonedSubmitGates.add(gateId), this.emitProgress(
         {
           phase: "round_failed",
           round: args.roundNumber,
@@ -73158,10 +73183,10 @@ ${section}`);
    * error propagates (the caller surfaces it fail-closed).
    */
   async submitImplementorOutputWithRetry(args) {
-    let lastErr = null;
+    let lastErr = null, replayedAfterEngineError = !1;
     for (let attempt = 0; attempt < SUBMIT_OUTPUT_MAX_ATTEMPTS; attempt++)
       try {
-        return await this.deps.appsyncClient.submitImplementorOutput(
+        let result = await this.deps.appsyncClient.submitImplementorOutput(
           {
             taskId: args.taskId,
             gateId: args.gateId,
@@ -73173,8 +73198,9 @@ ${section}`);
           },
           args.sessionKey
         );
+        return replayedAfterEngineError ? { ...result, replayedAfterEngineError } : result;
       } catch (err) {
-        if (lastErr = err, !isNotFoundError(lastErr) || attempt === SUBMIT_OUTPUT_MAX_ATTEMPTS - 1)
+        if (lastErr = err, isPossiblyAfterWriteSubmitError(lastErr) && (replayedAfterEngineError = !0), isDefinitiveSubmitRejection(lastErr) || !(isNotFoundError(lastErr) || isPossiblyAfterWriteSubmitError(lastErr)) || attempt === SUBMIT_OUTPUT_MAX_ATTEMPTS - 1)
           throw lastErr;
         await this.sleep(SUBMIT_OUTPUT_BASE_DELAY_MS * Math.pow(2, attempt));
       }
@@ -73182,6 +73208,13 @@ ${section}`);
   }
   // ─── §3.C.21 — REVIEWER_DISPATCH → spawn one seat ───────────────────────
   async handleReviewerDispatch(payload) {
+    if (this.abandonedSubmitGates.has(payload.gateId)) {
+      logger.info("[QuorumLoop] ReviewerDispatch for an abandoned submission \u2014 dropped", {
+        gateId: payload.gateId,
+        seatId: payload.seatId
+      });
+      return;
+    }
     let dispatchTaskId = this.taskByGateId.get(payload.gateId), originEpoch = this.originEpochFor(dispatchTaskId), seat = numericSeatId(payload.seatId);
     if (seat === null) {
       logger.warn("[QuorumLoop] ReviewerDispatch with non-numeric seat \u2014 dropped", {
@@ -73219,6 +73252,10 @@ ${section}`);
    */
   async spawnOneSeat(args) {
     let key = seatKey(args.gateId, args.seatId);
+    if (this.abandonedSubmitGates.has(args.gateId)) {
+      logger.info("[QuorumLoop] seat spawn dropped (abandoned submission)", { key });
+      return;
+    }
     if (this.runningSeats.has(key) || this.submittedSeats.has(key)) {
       logger.info("[QuorumLoop] seat spawn no-op (already running/submitted)", { key });
       return;
@@ -75937,6 +75974,27 @@ function diffCapturedProgress(round, files) {
     deleted
   };
 }
+var SUBMIT_DEFINITIVE_ERROR_TYPES = /* @__PURE__ */ new Set([
+  "ClientError",
+  "SessionError",
+  "Unauthorized",
+  "CryptoError",
+  "BudgetExhausted",
+  "NotImplemented"
+]), RUST_WHITESPACE_ONLY = /^[\t\n\v\f\r \u0085\u00A0\u1680\u2000-\u200A\u2028\u2029\u202F\u205F\u3000]*$/;
+function isEngineEmptyArtifact(files) {
+  return files.every(
+    (f) => RUST_WHITESPACE_ONLY.test(f.content) && f.change_kind.trim().toLowerCase() !== "deleted"
+  );
+}
+function isDefinitiveSubmitRejection(err) {
+  let e = err;
+  return e.reviewScopeResetUnsupported === !0 || e.name === "AppSyncGraphQLError" && typeof e.errorType == "string" && SUBMIT_DEFINITIVE_ERROR_TYPES.has(e.errorType);
+}
+function isPossiblyAfterWriteSubmitError(err) {
+  let e = err;
+  return e.name === "AppSyncGraphQLError" && typeof e.errorType == "string" && !isDefinitiveSubmitRejection(err);
+}
 function isNotFoundError(err) {
   let m = err.message.toLowerCase();
   return m.includes("notfound") || m.includes("not found") || m.includes("not yet written") || m.includes("not present") || m.includes("gatenotfound");

package/dist/orchestration-shell/quorum-loop.d.ts

@@ -57,6 +57,8 @@ export declare function failureReasonTemplate(agentKind: ReviewerAgentKind, reas
  *     "blocked by the local authority allowlist", etc.).
  *   - A spawn/start failure (ENOENT / "spawn" / "not found" on the agent binary)
  *     → a generic "the agent could not be started" label.
+ *   - The engine's typed rejection of a submission (SB-67) → "the change is too large to submit for review"
+ *     for PayloadTooLarge, else "the review service rejected the submission".
  *   - Anything else → a generic "an unexpected error occurred" label.
  *
  * Exported for the sanitization test (proves no raw message leaks).
@@ -1027,6 +1029,11 @@ export declare class QuorumLoop {
     private readonly inFlightImplementorGates;
     /** Gates whose implementor output has been submitted. */
     private readonly submittedOutputGates;
+    /**
+     * SB-67 (Stage 1 R1-F1) — gates whose round failed after its submission started. The engine can dispatch reviewers
+     * before it reports an error; a late dispatch for one of these gates belongs to a discarded task and is dropped.
+     */
+    private readonly abandonedSubmitGates;
     /**
      * PHASE-CP-10-MIN (#585) #C10M-16 / Codex-H1 — the per-task ACTIVE
      * implementor context. `runImplementorRound` populates it at spawn (wiring
@@ -3087,4 +3094,8 @@ export declare class QuorumLoop {
     _replaceShadowForRound0UnlockedForTests(taskId: string): Promise<void>;
     _ensureShadowUnlockedForTests(taskId: string): Promise<WorkspaceShadow>;
 }
+export declare function isEngineEmptyArtifact(files: readonly {
+    change_kind: string;
+    content: string;
+}[]): boolean;
 export { reviewerAgentToLeAgent, renderAgenticResolveBrief };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quantiya/codevibe-core",
-  "version": "2.0.87",
+  "version": "2.0.88",
   "description": "Core library for CodeVibe plugins - shared keychain, crypto, AppSync, and auth functionality",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",