@qualweb/best-practices 0.7.7 → 0.7.9

package/dist/best-practices/QW-BP28.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"QW-BP28.d.ts","sourceRoot":"","sources":["../../src/best-practices/QW-BP28.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,qBAAqB,CAAC;AAGrD,OAAO,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAC;AAE1D,cAAM,OAAQ,SAAQ,YAAY;IAGhC,OAAO,CAAC,OAAO,EAAE,SAAS,GAAG,IAAI;CA2BlC;AAED,OAAO,EAAE,OAAO,EAAE,CAAC"}
+{"version":3,"file":"QW-BP28.d.ts","sourceRoot":"","sources":["../../src/best-practices/QW-BP28.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,qBAAqB,CAAC;AAGrD,OAAO,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAC;AAE1D,cAAM,OAAQ,SAAQ,YAAY;IAGhC,OAAO,CAAC,OAAO,EAAE,SAAS,GAAG,IAAI;CAqDlC;AAED,OAAO,EAAE,OAAO,EAAE,CAAC"}

package/dist/best-practices/QW-BP28.js

@@ -17,24 +17,44 @@ class QW_BP28 extends BestPractice_object_1.BestPractice {
     execute(element) {
         let verdict;
         let resultCode;
-        const hasH1 = element.getElements('[role="heading"][aria-level="1"], h1');
-        if (hasH1.length === 1) {
+        const candidates = element.getElements('h1, [role="heading"][aria-level="1"]');
+        const accessibleH1s = candidates.filter(h1 => {
+            const hasText = h1.getElementText().trim().length > 0;
+            const rect = h1.getBoundingBox();
+            const hasSize = rect.width > 0 && rect.height > 0;
+            if (!hasText || !hasSize || h1.isOffScreen()) {
+                return false;
+            }
+            let parent = h1.getElementParent();
+            while (parent) {
+                const propertyDisplay = parent.getElementStyleProperty('display', null);
+                const propertyAriaHidden = parent.getElementAttribute('aria-hidden') === 'true';
+                const propertyOverflow = parent.getElementStyleProperty('overflow', null);
+                const boxDimensions = parent.getBoundingBox();
+                if (propertyDisplay === 'none' || propertyAriaHidden) {
+                    return false;
+                }
+                if ((boxDimensions.height <= 0 || boxDimensions.width <= 0) && propertyOverflow === 'hidden') {
+                    return false;
+                }
+                parent = parent.getElementParent();
+            }
+            return true;
+        });
+        const count = accessibleH1s.length;
+        if (count <= 1) {
             verdict = evaluation_1.Verdict.PASSED;
             resultCode = 'P1';
         }
-        else if (hasH1.length === 0) {
+        else if (count > 1) {
             verdict = evaluation_1.Verdict.FAILED;
             resultCode = 'F1';
-            const test = new evaluation_1.Test();
-            test.verdict = verdict;
-            test.resultCode = resultCode;
-            this.addTestResult(test);
         }
         else {
             verdict = evaluation_1.Verdict.FAILED;
             resultCode = 'F2';
         }
-        hasH1.forEach((element) => {
+        candidates.forEach((element) => {
             const test = new evaluation_1.Test();
             test.verdict = verdict;
             test.resultCode = resultCode;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@qualweb/best-practices",
-  "version": "0.7.7",
+  "version": "0.7.9",
   "description": "QualWeb best practices",
   "files": [
     "dist/*"
@@ -66,10 +66,10 @@
   "author": "João Vicente",
   "license": "ISC",
   "devDependencies": {
-    "@qualweb/core": "^0.8.4",
+    "@qualweb/core": "^0.8.9",
     "@qualweb/locale": "0.2.2",
-    "@qualweb/qw-page": "0.3.2",
-    "@qualweb/util": "0.6.4",
+    "@qualweb/qw-page": "0.3.5",
+    "@qualweb/util": "0.6.5",
     "@tsconfig/recommended": "^1.0.3",
     "@types/mocha": "^10.0.6",
     "@types/node": "^16.11.12",