@qooxdoo/framework 8.0.0-beta.2 → 8.0.0-beta.3

package/source/class/qx/test/core/Property.js

@@ -36,7 +36,7 @@ qx.Class.define("qx.test.core.Property", {
         extend: qx.core.Object
       });
 
-      qx.Class.define("qx.test.cpnfv8.Superclass", {//cbh
+      qx.Class.define("qx.test.cpnfv8.Superclass", {
         extend: qx.test.cpnfv8.Object,
 
         construct(bRunning = true) {
@@ -170,11 +170,6 @@ qx.Class.define("qx.test.core.Property", {
             qx.test.cpnfv8.ExternalStorage._subclassStorage[property.getPropertyName()] = value;
           },
 
-          /**@override */
-          isAsyncStorage() {
-            return false;
-          },
-
           /**@override */
           get(thisObj, prop) {
             console.log("in externallyStored getter");
@@ -187,6 +182,11 @@ qx.Class.define("qx.test.core.Property", {
             qx.test.cpnfv8.ExternalStorage._subclassStorage[property.getPropertyName()] = value;
           },
 
+          /**@override */
+          supportsGetAsync() {
+            return false;
+          },
+
           /**@override */
           dereference(prop, property) {}
         },
@@ -235,7 +235,6 @@ qx.Class.define("qx.test.core.Property", {
           },
           delay: {
             init: 0,
-            async: true,
             getAsync: async (prop, self) => {
               let p;
               p = new qx.Promise((resolve, reject) => {
@@ -1700,7 +1699,6 @@ qx.Class.define("qx.test.core.Property", {
           propTwo: {
             init: null,
             nullable: true,
-            async: true,
             apply: "_applyPropTwo",
             event: "changePropTwo"
           }
@@ -2323,7 +2321,6 @@ qx.Class.define("qx.test.core.Property", {
         extend: qx.core.Object,
         properties: {
           foo: {
-            async: true,
             init: 7,
             apply: function (value, old) {
               return new qx.Promise((resolve, reject) => {
@@ -2353,27 +2350,36 @@ qx.Class.define("qx.test.core.Property", {
 
     /**
      * Ensures that an error is thrown when trying to get an async property synchronously
-     * when the property is not ready yet, even if it has an init value.
+     * when the property is not ready yet.
      */
     testGetSyncWhenNotReady() {
       qx.Class.undefine("qx.test.cpnfv8.GetSyncTest");
+
+      let fooCached = undefined;
       var Clazz = qx.Class.define("qx.test.cpnfv8.GetSyncTest", {
         extend: qx.core.Object,
         properties: {
           foo: {
-            async: true,
-            init: 7
+            get() {
+              return fooCached;
+            },
+            getAsync() {
+              if (fooCached === undefined) {
+                fooCached = 7;
+              }
+              return fooCached;
+            },
+            set(value) {
+              fooCached = value;
+            }
           }
         }
       });
 
       const doit = async () => {
         let instance = new Clazz();
-        //The property storage will be set to the init value during construction,
-        //so we must reset it manually.
-        delete instance.$$propertyValues.foo;
         let prop = qx.Class.getByProperty(Clazz, "foo");
-        this.assertFalse(prop.isInitialized(instance), "Property foo should not be initialized");
+        this.assertFalse(prop.hasLocalValue(instance), "Property foo should not be locally defined");
         this.assertUndefined(instance.getSafe("foo"));
         try {
           instance.getFoo();

package/source/class/qx/test/data/singlevalue/Async.js

@@ -30,6 +30,19 @@ qx.Class.define("qx.test.data.singlevalue.Async", {
     __b2: null,
 
     setUp() {
+      qx.Bootstrap.undefine("qx.test.data.singlevalue.async.AsyncPropertyStorage");
+      qx.Bootstrap.define("qx.test.data.singlevalue.async.AsyncPropertyStorage", {
+        extend: qx.core.property.SimplePropertyStorage,
+        members: {
+          /**
+           * @Override
+           */
+          supportsGetAsync() {
+            return true;
+          }
+        }
+      });
+
       qx.Class.undefine("qx.test.data.singlevalue.async.Test");
       const Clazz = qx.Class.define("qx.test.data.singlevalue.async.Test", {
         extend: qx.core.Object,
@@ -38,17 +51,17 @@ qx.Class.define("qx.test.data.singlevalue.Async", {
            * The async input
            */
           ai: {
-            async: true,
             nullable: true,
-            init: null
+            init: null,
+            storage: qx.test.data.singlevalue.async.AsyncPropertyStorage
           },
           /**
            * The async output
            */
           ao: {
-            async: true,
             nullable: true,
-            init: null
+            init: null,
+            storage: qx.test.data.singlevalue.async.AsyncPropertyStorage
           },
           /**
            * Syncronous input

package/source/class/qx/test/performance/Property.js

@@ -50,7 +50,6 @@ qx.Class.define("qx.test.performance.Property", {
             nullable: true,
             check: "String",
             event: "changeAlpha",
-            async: true,
             apply: () => {}
           }
         }

package/source/class/qx/test/ui/core/SingleSelectionManager.js

@@ -0,0 +1,150 @@
+/* ************************************************************************
+
+   qooxdoo - the new era of web development
+
+   http://qooxdoo.org
+
+   Copyright:
+     2025 Qooxdoo contributors
+
+   License:
+     MIT: https://opensource.org/licenses/MIT
+     See the LICENSE file in the project's top-level directory for details.
+
+************************************************************************ */
+
+/**
+ * Minimal ISingleSelectionProvider implementation for unit testing.
+ *
+ * @internal
+ * @ignore(qx.test.ui.core.MockSingleSelectionProvider)
+ */
+qx.Class.define("qx.test.ui.core.MockSingleSelectionProvider", {
+  extend: qx.core.Object,
+  implement: [qx.ui.core.ISingleSelectionProvider],
+
+  construct(items) {
+    super();
+    this._items = items;
+  },
+
+  members: {
+    _items: null,
+
+    getItems() {
+      return this._items || [];
+    },
+
+    isItemSelectable(item) {
+      return true;
+    }
+  }
+});
+
+/**
+ * Tests for qx.ui.core.SingleSelectionManager
+ */
+qx.Class.define("qx.test.ui.core.SingleSelectionManager", {
+  extend: qx.dev.unit.TestCase,
+
+  members: {
+    __manager: null,
+    __provider: null,
+    __items: null,
+
+    setUp() {
+      this.__items = [new qx.core.Object(), new qx.core.Object(), new qx.core.Object()];
+      this.__provider = new qx.test.ui.core.MockSingleSelectionProvider(this.__items);
+      this.__manager = new qx.ui.core.SingleSelectionManager(this.__provider);
+    },
+
+    tearDown() {
+      this.__manager.dispose();
+      this.__provider.dispose();
+      for (var item of this.__items) {
+        item.dispose();
+      }
+      this.__items = null;
+    },
+
+    /**
+     * Regression test for the fix: resetSelected() with allowEmptySelection=false
+     * must NOT fire changeSelected when the first item is already selected.
+     */
+    testNoSpuriousEventWhenResetSelectedWithFirstItemAlreadySelected() {
+      this.__manager.setAllowEmptySelection(false);
+      this.__manager.resetSelected();
+      this.assertIdentical(this.__items[0], this.__manager.getSelected(), "item[0] should be auto-selected");
+
+      var eventCount = 0;
+      this.__manager.addListener("changeSelected", function () {
+        eventCount++;
+      });
+
+      this.__manager.resetSelected();
+
+      this.assertEquals(0, eventCount, "changeSelected must not fire when selection is unchanged");
+      this.assertIdentical(this.__items[0], this.__manager.getSelected(), "Selection must still be item[0]");
+    },
+
+    /**
+     * resetSelected() when another item is selected must fire changeSelected
+     * and switch back to item[0].
+     */
+    testEventFiredWhenResetSelectedChangesSelection() {
+      this.__manager.setAllowEmptySelection(false);
+      this.__manager.setSelected(this.__items[1]);
+
+      var eventCount = 0;
+      var eventData = null;
+      this.__manager.addListener("changeSelected", function (e) {
+        eventCount++;
+        eventData = e.getData();
+      });
+
+      this.__manager.resetSelected();
+
+      this.assertEquals(1, eventCount, "changeSelected must fire when selection changes");
+      this.assertIdentical(this.__items[0], eventData, "Event data should be item[0]");
+      this.assertIdentical(this.__items[0], this.__manager.getSelected(), "item[0] should be selected after reset");
+    },
+
+    /**
+     * setSelected() with the already-selected item must not fire changeSelected
+     * (pre-existing early-exit guard).
+     */
+    testNoEventWhenSetSelectedWithSameItem() {
+      this.__manager.setSelected(this.__items[0]);
+
+      var eventCount = 0;
+      this.__manager.addListener("changeSelected", function () {
+        eventCount++;
+      });
+
+      this.__manager.setSelected(this.__items[0]);
+
+      this.assertEquals(0, eventCount, "changeSelected must not fire when setting the same item");
+    },
+
+    /**
+     * Switching allowEmptySelection from true to false on an empty manager
+     * must auto-select item[0] and fire changeSelected exactly once.
+     */
+    testAllowEmptySelectionFalseTriggersAutoSelect() {
+      this.assertTrue(this.__manager.isSelectionEmpty(), "Selection should be empty initially");
+
+      var eventCount = 0;
+      var eventData = null;
+      this.__manager.addListener("changeSelected", function (e) {
+        eventCount++;
+        eventData = e.getData();
+      });
+
+      this.__manager.setAllowEmptySelection(false);
+
+      this.assertEquals(1, eventCount, "changeSelected must fire when auto-selecting the first item");
+      this.assertIdentical(this.__items[0], eventData, "Event data should be item[0]");
+      this.assertIdentical(this.__items[0], this.__manager.getSelected(), "item[0] should be auto-selected");
+    }
+  }
+});

package/source/class/qx/tool/compiler/cli/api/CompilerApi.js

@@ -51,8 +51,7 @@ qx.Class.define("qx.tool.compiler.cli.api.CompilerApi", {
       init: null,
       nullable: true,
       check: "qx.tool.compiler.cli.Command",
-      event: "changeCommand",
-      async: true
+      event: "changeCommand"
     }
   },
 

package/source/class/qx/ui/core/SingleSelectionManager.js

@@ -226,10 +226,6 @@ qx.Class.define("qx.ui.core.SingleSelectionManager", {
       var oldSelected = this.__selected;
       var newSelected = item;
 
-      if (newSelected != null && oldSelected === newSelected) {
-        return;
-      }
-
       if (!this.isAllowEmptySelection() && newSelected == null) {
         var firstElement = this.getSelectables(true)[0];
 
@@ -238,6 +234,10 @@ qx.Class.define("qx.ui.core.SingleSelectionManager", {
         }
       }
 
+      if (newSelected !== null && newSelected === oldSelected) {
+        return;
+      }
+
       this.__selected = newSelected;
       this.fireDataEvent("changeSelected", newSelected, oldSelected);
     },

package/source/class/qx/ui/form/validation/Manager.js

@@ -488,7 +488,7 @@ qx.Class.define("qx.ui.form.validation.Manager", {
 
             let msg = item.getInvalidMessage();
             if (
-              msg &&
+              !msg &&
               qx.core.Environment.get(
                 "qx.ui.form.validation.Manager.allowDefaultInvalidMessage"
               )