@qooxdoo/framework 8.0.0-beta.1 → 8.0.0-beta.3

package/source/class/qx/data/SingleValueBinding.js

@@ -13,7 +13,7 @@
 
    Authors:
      * John Spackman (https://github.com/johnspackman, john.spackman@zenesis.com)
-     * Patryk Malinowski (https://github.com/patryk-m-malinowski, pmalinowski@vmn.digital)
+     * Patryk Malinowski (https://github.com/patryk-m-malinowski, pmalinowski116@gmail.com)
 
 ************************************************************************ */
 
@@ -97,6 +97,12 @@ qx.Class.define("qx.data.SingleValueBinding", {
    *       be called if the set of the value fails.
    * @property {string} ignoreConverter A string which will be matched using the current
    *       property chain. If it matches, the converter will not be called.
+   * @property {boolean} async If true, the following will happen:
+   * - The binding's init promise (returned by `getInitPromise`) will resolve only after the initial value has been set on the target. 
+   * If any properties in the source and target chains have async getters,
+   * the initial set may happen on a later tick.
+   * - The binding will call setAsync on the target value instead of the synchronous `set` and the init promise will resolve after the initial setAsync call has resolved.
+   * 
    * 
    *
    * @callback converter
@@ -126,6 +132,7 @@ qx.Class.define("qx.data.SingleValueBinding", {
       throw new Error("SourcePath and targetPath must be specified");
     }
     this.__options = options ?? {};
+    this.__async = !!this.__options.async;
     let tracker = {};
 
     const Utils = qx.event.Utils;
@@ -169,10 +176,14 @@ qx.Class.define("qx.data.SingleValueBinding", {
   },
 
   members: {
+    /**
+     * Whether this binding is asynchronous
+     */
+    __async: false,
     /**
      * @type {*}
      */
-    __value: null,
+    __value: undefined,
     /**
      * @type {qx.core.Object}
      */
@@ -202,6 +213,14 @@ qx.Class.define("qx.data.SingleValueBinding", {
      */
     __options: null,
 
+    /**
+     * 
+     * @returns {boolean}
+     */
+    isAsync() {
+      return this.__async;
+    },
+
     /**
      * Promises/A+ thenable compliance, this means that you can await the binding for initialisation
      * https://promisesaplus.com/
@@ -284,7 +303,7 @@ qx.Class.define("qx.data.SingleValueBinding", {
         SingleValueBinding.__bindingsBySource[value.toHashCode()][this.toHashCode()] = this;
 
         //Set the input on the first segment of the source path
-        let promise = this.__sourceSegments[0].setInput(value);
+        let out = this.__sourceSegments[0].setInput(value);
         const cb = () => {
           if (qx.core.Environment.get("qx.debug")) {
             this.assertNotNull(
@@ -294,10 +313,8 @@ qx.Class.define("qx.data.SingleValueBinding", {
           }
         };
 
-        let out;
-
-        if (qx.Promise.isPromise(promise)) {
-          out = promise.then(cb);
+        if (qx.Promise.isPromise(out)) {
+          out = out.then(cb);
         } else {
           out = cb();
         }
@@ -322,7 +339,7 @@ qx.Class.define("qx.data.SingleValueBinding", {
       }
       this.__record = null; // invalidate record representation cache
       this.__targetSegments = qx.data.SingleValueBinding.__parseSegments(this, value);
-      this.__targetSegments.at(-1).addListener("changeInput", this.__updateTarget, this);
+      this.__targetSegments.at(-1).setChangeInputCallback(() => this.__updateTarget());
     },
 
     /**
@@ -579,27 +596,6 @@ qx.Class.define("qx.data.SingleValueBinding", {
       return out;
     },
 
-    /**
-     * Splits a property path into segments.
-     * @param {string} path
-     * @returns {string[]} an array of segments, split by dot and square brackets.
-     * For example, splitSegments(`a.b[0].c`) will return `["a", "b", "[0]", "c"]`
-     */
-    splitSegments(path) {
-      let out = [];
-      for (let dotSplit of path.split(".")) {
-        let bracketSplits = dotSplit.split("[");
-        for (let i = 0; i < bracketSplits.length; i++) {
-          let bracketSplit = bracketSplits[i];
-          if (i > 0) {
-            bracketSplit = "[" + bracketSplit;
-          }
-          out.push(bracketSplit);
-        }
-      }
-      return out.filter(s => s.length > 0);
-    },
-
     /**
      * Finds all bindings for an object, as either a source or target
      *
@@ -675,72 +671,6 @@ qx.Class.define("qx.data.SingleValueBinding", {
       }
     },
 
-    /**
-     * Helper method that sets a value for a named property
-     *
-     * @param {qx.core.Object} target object to have a property set
-     * @param {String} propertyName the name of the property
-     * @param {Object?} value the value to set
-     */
-    set(target, propertyName, value) {
-      let prop = qx.util.PropertyUtil.getProperty(target.constructor, propertyName);
-      if (!prop) {
-        let setFuncName = "set" + qx.lang.String.firstUp(propertyName);
-        if (typeof target[setFuncName] == "function") {
-          return target[setFuncName](value);
-        } else {
-          throw new Error(`Property ${propertyName} not found on ${target.classname}`);
-        }
-      }
-
-      if (prop.isAsync()) {
-        return prop.setAsync(target, value);
-      } else {
-        return prop.set(target, value);
-      }
-    },
-
-    /**
-     * Helper method to get a value of a named property
-     *
-     * @param {qx.core.Object} target object to have a property get
-     * @param {String} propertyName the name of the property
-     * @returns {Object?} the property value
-     */
-    get(target, propertyName) {
-      let prop = qx.util.PropertyUtil.getProperty(target.constructor, propertyName);
-      if (prop.isAsync()) {
-        return prop.getAsync(target);
-      } else {
-        return prop.get(target);
-      }
-    },
-
-    /**
-     * Helper method that resets a named property
-     *
-     * @param {qx.core.Object} target object to have a property set
-     * @param {String} propertyName the name of the property
-     
-     */
-    reset(target, propertyName) {
-      let prop = qx.util.PropertyUtil.getProperty(target.constructor, propertyName);
-      if (!prop) {
-        let setFuncName = "reset" + qx.lang.String.firstUp(propertyName);
-        if (typeof target[setFuncName] == "function") {
-          return target[setFuncName]();
-        } else {
-          throw new Error(`Property ${propertyName} not found on ${target.classname}`);
-        }
-      }
-
-      if (prop.isAsync()) {
-        return prop.resetAsync(target);
-      } else {
-        return prop.reset(target);
-      }
-    },
-
     /**
      *
      * Internal helper for getting the current set value at the property chain.
@@ -785,26 +715,52 @@ qx.Class.define("qx.data.SingleValueBinding", {
      * @return {qx.data.binding.AbstractSegment[]?} the new array of segments
      */
     __parseSegments(binding, path) {
-      let segsStrings = qx.data.SingleValueBinding.splitSegments(path);
+      let segsStrings = this.__splitSegments(path);
+      //should be let segsStrings = path.split(/\.|(?=\[)|(?<=\])/g);// split by dot or square brackets, but keep the brackets as part of the segments
+      //but this breaks our Rhino because it's really old
+      //TODO update Rhino
+
       let segments = [];
 
-      for (let seg of segsStrings) {
+      let previous;
+      for (let segStr of segsStrings) {
+        let seg;
         //if it's an array index:
-        if (seg.startsWith("[")) {
-          segments.push(new qx.data.binding.ArrayIndexSegment(binding, seg));
+        if (segStr.startsWith("[")) {
+          seg = new qx.data.binding.ArrayIndexSegment(binding, segStr);
         } else {
           //otherwise, it's a normal path
-          segments.push(new qx.data.binding.PropNameSegment(binding, seg));
+          seg = new qx.data.binding.PropNameSegment(binding, segStr);
         }
-      }
-
-      segments.forEach((seg, index) => {
-        if (index < segments.length - 1) {
-          seg.setOutputReceiver(segments[index + 1]);
+        if (previous) {
+          previous.setOutputReceiver(seg);
         }
-      });
+        previous = seg;
+        segments.push(seg);
+      }      
 
       return segments;
-    }
+    },
+
+    /**
+     * Splits a property path into segments.
+     * @param {string} path
+     * @returns {string[]} an array of segments, split by dot and square brackets.
+     * For example, splitSegments(`a.b[0].c`) will return `["a", "b", "[0]", "c"]`
+     */
+    __splitSegments(path) {
+      let out = [];
+      for (let dotSplit of path.split(".")) {
+        let bracketSplits = dotSplit.split("[");
+        for (let i = 0; i < bracketSplits.length; i++) {
+          let bracketSplit = bracketSplits[i];
+          if (i > 0) {
+            bracketSplit = "[" + bracketSplit;
+          }
+          out.push(bracketSplit);
+        }
+      }
+      return out.filter(s => s.length > 0);
+    },
   }
 });

package/source/class/qx/data/binding/AbstractSegment.js

@@ -12,7 +12,7 @@
      See the LICENSE file in the project's top-level directory for details.
 
    Authors:
-     * John Spackman (https://github.com/johnspackman, john.spackman@zenesis.com)
+   * Patryk Malinowski (https://github.com/patryk-m-malinowski, pmalinowski116@gmail.com)
 
 ************************************************************************ */
 
@@ -47,15 +47,12 @@ qx.Class.define("qx.data.binding.AbstractSegment", {
     }
   },
 
-  /**
-   * Fired when this segment's input changed, and it has been received and fully processed by the next segments in the chain,
-   * i.e. any async set/get operations have completed.
-   */
-  events: {
-    changeInput: "qx.event.type.Data"
-  },
-
   members: {
+    /**
+     * Called when this segment's input changed, and it has been received and fully processed by the next segments in the chain,
+     * i.e. any async set/get operations have completed.
+     */
+    __changeInputCallback: () => {},
     /**
      * @type {qx.data.SingleValueBinding}
      */
@@ -70,6 +67,14 @@ qx.Class.define("qx.data.binding.AbstractSegment", {
      */
     __outputReceiver: null,
 
+    /**
+     * 
+     * @param {Function} callback 
+     */
+    setChangeInputCallback(callback) {
+      this.__changeInputCallback = callback;
+    },
+
     /**
      *
      * @returns {qx.data.SingleValueBinding} the binding that this segment belongs to. Useful for debugging purposes.
@@ -125,9 +130,9 @@ qx.Class.define("qx.data.binding.AbstractSegment", {
 
       let out = this._applyInput(value, old);
       if (qx.lang.Type.isPromise(out)) {
-        return out.then(() => this.fireDataEvent("changeInput", value, old));
+        return out.then(() => this.__changeInputCallback(value, old));
       } else {
-        return this.fireDataEvent("changeInput", value, old);
+        return this.__changeInputCallback(value, old);
       }
     },
 

package/source/class/qx/data/binding/ArrayIndexSegment.js

@@ -12,7 +12,7 @@
      See the LICENSE file in the project's top-level directory for details.
 
    Authors:
-     * John Spackman (https://github.com/johnspackman, john.spackman@zenesis.com)
+    * Patryk Malinowski (https://github.com/patryk-m-malinowski, pmalinowski116@gmail.com)
 
 ************************************************************************ */
 
@@ -51,7 +51,7 @@ qx.Class.define("qx.data.binding.ArrayIndexSegment", {
   destruct() {
     let input = this.getInput();
     if (input) {
-      if (this.getInput() instanceof qx.data.Array) {
+      if (this.__isListData(this.getInput())) {
         this.getInput().removeListener("change", this.__onChangeContents, this);
       }
     }
@@ -71,19 +71,23 @@ qx.Class.define("qx.data.binding.ArrayIndexSegment", {
       return this.__string;
     },
 
+    __isListData(input) {
+      return qx.Interface.objectImplements(input, qx.data.IListData);
+    },
+
     /**
      * @override
      */
     _applyInput(value, oldValue) {
       if (oldValue) {
         this.setEventName(null);
-        if (oldValue instanceof qx.data.Array) {
+        if (this.__isListData(oldValue)) {
           oldValue.removeListener("change", this.__onChangeContents, this);
         }
       }
 
       if (value) {
-        if (value instanceof qx.data.Array) {
+        if (this.__isListData(value)) {
           value.addListener("change", this.__onChangeContents, this);
           this.setEventName("change");
         }
@@ -108,8 +112,10 @@ qx.Class.define("qx.data.binding.ArrayIndexSegment", {
         return undefined;
       }
 
-      if (input instanceof qx.data.Array) {
-        input = input.toArray();
+      if (this.__isListData(input)) {
+        const len = input.getLength();
+        const idx = this.__index === -1 ? len - 1 : this.__index;
+        return idx >= len ? undefined : input.getItem(idx);
       }
 
       if (this.__index >= input.length) {
@@ -126,11 +132,12 @@ qx.Class.define("qx.data.binding.ArrayIndexSegment", {
       if (!input) {
         return;
       }
-      let index = this.__index == -1 ? input.length - 1 : this.__index;
-      if (input instanceof qx.data.Array) {
-        input.setItem(index, targetValue);
+      if (this.__isListData(input)) {
+        const idx = this.__index === -1 ? input.getLength() - 1 : this.__index;
+        input.setItem(idx, targetValue);
       } else {
-        input[index] = targetValue;
+        const idx = this.__index === -1 ? input.length - 1 : this.__index;
+        input[idx] = targetValue;
       }
     },
 

package/source/class/qx/data/binding/IInputReceiver.js

@@ -7,7 +7,7 @@ qx.Interface.define("qx.data.binding.IInputReceiver", {
      *
      * @param {*} value
      * @returns {Promise?} If the operation is asynchronous, it should return a Promise which resolves when it has completed.
-     * If it's synchrous, it should return null.
+     * If it's synchronous, it should return null.
      */
     setInput(input) {}
   }

package/source/class/qx/data/binding/PropNameSegment.js

@@ -12,7 +12,7 @@
      See the LICENSE file in the project's top-level directory for details.
 
    Authors:
-     * John Spackman (https://github.com/johnspackman, john.spackman@zenesis.com)
+     * Patryk Malinowski (https://github.com/patryk-m-malinowski, pmalinowski116@gmail.com)
 
 ************************************************************************ */
 
@@ -69,6 +69,10 @@ qx.Class.define("qx.data.binding.PropNameSegment", {
      * Apply for `input`
      */
     _applyInput(value, oldValue) {
+      if (!this.getOutputReceiver()) {
+        return;
+      }
+
       if (oldValue) {
         let eventName = this.__getEventName(oldValue);
         eventName && oldValue.removeListener(eventName, this.__onChangeInputProperty, this);
@@ -81,9 +85,7 @@ qx.Class.define("qx.data.binding.PropNameSegment", {
         this.setEventName(eventName);
       }
 
-      if (this.getOutputReceiver()) {
-        return this.updateOutput();
-      }
+      return this.updateOutput();
     },
 
     updateOutput() {
@@ -95,10 +97,15 @@ qx.Class.define("qx.data.binding.PropNameSegment", {
         if (property === null) {
           return this._setOutput(null);
         }
-        if (!property.isAsync() || property.isInitialized(input)) {
-          let nextInput = property.get(input, this.__propName);
+        if (!property.supportsGetAsync() || property.hasLocalValue(input)) {
+          let nextInput = property.get(input);
           return this._setOutput(nextInput);
         } else {
+          if (qx.core.Environment.get("qx.debug")) {
+            if (!(this.getBinding()?.isAsync())) {
+              this.warn(`In binding ${this}, property "${this.__propName}" wasn't available synchronously but the binding is not async. This will cause the target to be updated in a later tick. If you want to await the initial set, use 'object.bindAsync' or add 'async: true' in the binding options.`);
+            }
+          }
           let promise = property.getAsync(input);
           return promise.then(nextInput => this._setOutput(nextInput));
         }
@@ -109,13 +116,31 @@ qx.Class.define("qx.data.binding.PropNameSegment", {
      * @override
      */
     setTargetValue(targetValue) {
-      if (this.getInput() == null || this.getInput() === undefined) {
+      let input = this.getInput();
+      if (input == null || input === undefined) {
         return;
       }
+
+      let async = this.getBinding()?.isAsync();
+      
+      //get the setter method name
+      let upname = qx.lang.String.firstUp(this.__propName);
+
+      let method;
       if (targetValue !== undefined) {
-        return qx.data.SingleValueBinding.set(this.getInput(), this.__propName, targetValue);
+        if (async) {
+          method = `set${upname}Async`;
+        } else {
+          method = `set${upname}`;
+        }
+        return input[method](targetValue);
       } else {
-        return qx.data.SingleValueBinding.reset(this.getInput(), this.__propName);
+        if (async) {
+          method = `reset${upname}Async`;
+        } else {
+          method = `reset${upname}`;
+        }
+        return input[method]();
       }
     },
 
@@ -125,9 +150,7 @@ qx.Class.define("qx.data.binding.PropNameSegment", {
      * @param {qx.event.type.Data} evt
      */
     __onChangeInputProperty(evt) {
-      if (this.getOutputReceiver()) {
-        return this._setOutput(evt.getData());
-      }
+      return this._setOutput(evt.getData());
     },
 
     /**

package/source/class/qx/dev/unit/TestCase.js

@@ -201,7 +201,10 @@ qx.Class.define("qx.dev.unit.TestCase", {
       if (this.__autoDispose) {
         this.__autoDispose.forEach(function (obj) {
           if (!obj.isDisposed()) {
-            if (obj instanceof qx.ui.core.Widget) {
+            // Do not make an actual reference to qx.ui.core.Widget otherwise the compiler will load
+            // dependencies and that prevents this class from being used in node-only builds
+            const Widget = qx.Class.getByName("qx.ui.core.Widget");
+            if (obj instanceof Widget) {
               obj.destroy();
             } else if (obj instanceof qx.core.Object) {
               obj.dispose();

package/source/class/qx/event/handler/Focus.js

@@ -1344,8 +1344,9 @@ qx.Class.define("qx.event.handler.Focus", {
           return focusedElement;
         }
         if (qx.Class.isClass("qx.ui.core.Widget")) {
+          const Widget = qx.Class.getByName("qx.ui.core.Widget");
           // Check compound widgets
-          var widget = qx.ui.core.Widget.getWidgetByElement(focusedElement),
+          var widget = Widget.getWidgetByElement(focusedElement),
             textField =
               widget &&
               widget.getChildControl &&

package/source/class/qx/html/Jsx.js

@@ -48,11 +48,10 @@ qx.Class.define("qx.html.Jsx", {
      *
      * @param tagname {String|Function} the name of the tag
      * @param attributes {Record<string, any>} map of attribute values
-     * @param children {qx.html.Node[]} array of children
+     * @param children {...qx.html.Node} children
      * @return {qx.html.Element|qx.data.Array}
      */
-    createElement(tagname, attributes) {
-      const children = qx.lang.Array.fromArguments(arguments, 2);
+    createElement(tagname, attributes, ...children) {
       attributes ??= {};
 
       // CSS CUSTOM PROPERTIES

package/source/class/qx/html/Node.js

@@ -889,10 +889,10 @@ qx.Class.define("qx.html.Node", {
     /**
      * Append all given children at the end of this element.
      *
-     * @param varargs {qx.html.Element} elements to insert
+     * @param {...qx.html.Element} children elements to insert
      * @return {qx.html.Element} this object (for chaining support)
      */
-    add(varargs) {
+    add(...children) {
       var self = this;
       function addImpl(arr) {
         arr.forEach(function (child) {
@@ -917,7 +917,7 @@ qx.Class.define("qx.html.Node", {
           self._children.push(child);
         });
       }
-      addImpl(qx.lang.Array.fromArguments(arguments));
+      addImpl(children);
 
       // Chaining support
       return this;

package/source/class/qx/io/jsonrpc/Client.js

@@ -406,6 +406,6 @@ qx.Class.define("qx.io.jsonrpc.Client", {
      * @deprecated
      * Behavior in v8 will be as if the environment variable value is `true`, but the environment variable will no longer be available.
      */
-    "qx.io.jsonrpc.forwardTransportPromiseRejectionToRequest": false
+    "qx.io.jsonrpc.forwardTransportPromiseRejectionToRequest": true
   }
 });

package/source/class/qx/promise/NativeWrapper.js

@@ -13,7 +13,7 @@
 
    Authors:
  * John Spackman (john.spackman@zenesis.com)
- * Patryk Malinowski (pmalinowski@vmn.digital)
+ * Patryk Malinowski (https://github.com/patryk-m-malinowski, pmalinowski116@gmail.com)
 
  ************************************************************************ */