@qooxdoo/framework 7.9.2 → 8.0.0-beta.1

package/source/class/qx/test/data/singlevalue/Deep.js

@@ -18,59 +18,12 @@
 /**
  * Test-Class for testing the single value binding
  *
- * @ignore(qx.test.MultiBinding)
+ * @ignore(qx.test.data.MultiBinding)
  */
 qx.Class.define("qx.test.data.singlevalue.Deep", {
   extend: qx.dev.unit.TestCase,
   include: [qx.dev.unit.MMock],
 
-  construct() {
-    super();
-
-    // define a test class
-    qx.Class.define("qx.test.MultiBinding", {
-      extend: qx.core.Object,
-
-      properties: {
-        child: {
-          check: "qx.test.MultiBinding",
-          event: "changeChild",
-          nullable: true
-        },
-
-        childWithout: {
-          check: "qx.test.MultiBinding",
-          nullable: true
-        },
-
-        name: {
-          check: "String",
-          nullable: true,
-          init: "Juhu",
-          event: "changeName"
-        },
-
-        array: {
-          init: null,
-          event: "changeArray"
-        },
-
-        lab: {
-          event: "changeLable"
-        }
-      },
-
-      destruct() {
-        if (this.getLab()) {
-          this.getLab().dispose();
-        }
-        if (this.getArray()) {
-          this.getArray().dispose();
-        }
-      }
-    });
-  },
-
   members: {
     __a: null,
     __b1: null,
@@ -78,19 +31,19 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
     __label: null,
 
     setUp() {
-      this.__a = new qx.test.MultiBinding().set({
+      this.__a = new qx.test.data.MultiBinding().set({
         name: "a",
         lab: new qx.test.data.singlevalue.TextFieldDummy(""),
         array: new qx.data.Array(["one", "two", "three"])
       });
 
-      this.__b1 = new qx.test.MultiBinding().set({
+      this.__b1 = new qx.test.data.MultiBinding().set({
         name: "b1",
         lab: new qx.test.data.singlevalue.TextFieldDummy(""),
         array: new qx.data.Array(["one", "two", "three"])
       });
 
-      this.__b2 = new qx.test.MultiBinding().set({
+      this.__b2 = new qx.test.data.MultiBinding().set({
         name: "b2",
         lab: new qx.test.data.singlevalue.TextFieldDummy(""),
         array: new qx.data.Array(["one", "two", "three"])
@@ -137,13 +90,17 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       var m = qx.data.marshal.Json.createModel({ a: null });
       var t = qx.data.marshal.Json.createModel({ a: null });
 
-      var spy = this.spy(function () {
-        return 123;
+      var called = false;
+      m.bind("a.b", t, "a", {
+        converter: (data, model, source, target) => {
+          this.assertFalse(called, "Converter already called!");
+          called = true;
+          this.assertEquals(source, m, "Source is not as expected");
+          this.assertEquals(target, t, "Target is not as expected");
+          return 123;
+        }
       });
-      m.bind("a.b", t, "a", { converter: spy });
 
-      this.assertCalledOnce(spy);
-      this.assertCalledWith(spy, undefined, undefined, m, t);
       this.assertEquals(123, t.getA());
 
       m.dispose();
@@ -157,46 +114,30 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
 
       // create the binding
       // a --> b1 --> label
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.name",
-        this.__label,
-        "value"
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "child.name", this.__label, "value");
 
       // just set the name of the second component
       this.__b1.setName("B1");
-      this.assertEquals(
-        "B1",
-        this.__label.getValue(),
-        "Deep binding does not work with updating the first parameter."
-      );
+      this.assertEquals("B1", this.__label.getValue(), "Deep binding does not work with updating the first parameter.");
 
       // change the second component
       // a --> b2 --> label
       this.__a.setChild(this.__b2);
-      this.assertEquals(
-        "b2",
-        this.__label.getValue(),
-        "Deep binding does not work with updating the first parameter."
-      );
+      this.assertEquals("b2", this.__label.getValue(), "Deep binding does not work with updating the first parameter.");
 
       // check for the null value
       // a --> null
       this.__a.setChild(null);
-      this.assertNull(
-        this.__label.getValue(),
-        "Binding does not work with null."
-      );
+      this.assertNull(this.__label.getValue(), "Binding does not work with null.");
     },
 
     testDepthOf3(attribute) {
       // create a hierarchy
-      var c1 = new qx.test.MultiBinding().set({
+      var c1 = new qx.test.data.MultiBinding().set({
         name: "c1"
       });
 
-      var c2 = new qx.test.MultiBinding().set({
+      var c2 = new qx.test.data.MultiBinding().set({
         name: "c2"
       });
 
@@ -207,68 +148,45 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__b2.setChild(c2);
 
       // create the binding
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.child.name",
-        this.__label,
-        "value"
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "child.child.name", this.__label, "value");
 
       // just set the name of the last component
       c1.setName("C1");
-      this.assertEquals(
-        "C1",
-        this.__label.getValue(),
-        "Deep binding does not work with updating the third parameter."
-      );
+      this.assertEquals("C1", this.__label.getValue(), "Deep binding does not work with updating the third parameter.");
 
       // change the middle child
       // a --> b2 --> c2 --> label
       this.__a.setChild(this.__b2);
-      this.assertEquals(
-        "c2",
-        this.__label.getValue(),
-        "Deep binding does not work with updating the second parameter."
-      );
+      this.assertEquals("c2", this.__label.getValue(), "Deep binding does not work with updating the second parameter.");
 
       // set the middle child to null
       // a --> null
       this.__a.setChild(null);
-      this.assertNull(
-        this.__label.getValue(),
-        "Deep binding does not work with first null child."
-      );
+      this.assertNull(this.__label.getValue(), "Deep binding does not work with first null child.");
 
       // set only two childs
       // a --> b1 --> null
       this.__b1.setChild(null);
       this.__a.setChild(this.__b1);
-      this.assertNull(
-        this.__label.getValue(),
-        "Deep binding does not work with second null child."
-      );
+      this.assertNull(this.__label.getValue(), "Deep binding does not work with second null child.");
 
       // set the childs in a row
       // a --> b1 --> c1 --> label
       this.__b1.setChild(c1);
-      this.assertEquals(
-        "C1",
-        this.__label.getValue(),
-        "Deep binding does not work with updating the third parameter."
-      );
+      this.assertEquals("C1", this.__label.getValue(), "Deep binding does not work with updating the third parameter.");
     },
 
     testDepthOf5(attribute) {
       // create a hierarchy
-      var c = new qx.test.MultiBinding().set({
+      var c = new qx.test.data.MultiBinding().set({
         name: "c"
       });
 
-      var d = new qx.test.MultiBinding().set({
+      var d = new qx.test.data.MultiBinding().set({
         name: "d"
       });
 
-      var e = new qx.test.MultiBinding().set({
+      var e = new qx.test.data.MultiBinding().set({
         name: "e"
       });
 
@@ -279,19 +197,10 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       d.setChild(e);
 
       // create the binding
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.child.child.child.name",
-        this.__label,
-        "value"
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "child.child.child.child.name", this.__label, "value");
 
       // test if the binding did work
-      this.assertEquals(
-        "e",
-        this.__label.getValue(),
-        "Deep binding does not work with updating the third parameter."
-      );
+      this.assertEquals("e", this.__label.getValue(), "Deep binding does not work with updating the third parameter.");
     },
 
     testWrongDeep() {
@@ -330,31 +239,18 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       qx.data.SingleValueBinding.bind(this.__a, "name", this.__label, "value");
 
       // chech the initial value
-      this.assertEquals(
-        "a",
-        this.__label.getValue(),
-        "Single property names don't work!"
-      );
+      this.assertEquals("a", this.__label.getValue(), "Single property names don't work!");
 
       // check the binding
       this.__a.setName("A");
-      this.assertEquals(
-        "A",
-        this.__label.getValue(),
-        "Single property names don't work!"
-      );
+      this.assertEquals("A", this.__label.getValue(), "Single property names don't work!");
     },
 
     testDebug(attribute) {
       // build the structure
       this.__a.setChild(this.__b1);
       // bind the stuff together
-      var id = qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.name",
-        this.__label,
-        "value"
-      );
+      var id = qx.data.SingleValueBinding.bind(this.__a, "child.name", this.__label, "value");
 
       // log this binding in the console
       qx.data.SingleValueBinding.showBindingInLog(this.__a, id);
@@ -364,53 +260,25 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       // build the structure
       this.__a.setChild(this.__b1);
       // bind the stuff together
-      var id = qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.name",
-        this.__label,
-        "value"
-      );
+      var id = qx.data.SingleValueBinding.bind(this.__a, "child.name", this.__label, "value");
 
       // check the binding
       this.__b1.setName("A");
-      this.assertEquals(
-        "A",
-        this.__label.getValue(),
-        "Single property names don't work!"
-      );
+      this.assertEquals("A", this.__label.getValue(), "Single property names don't work!");
 
       // remove the binding
       qx.data.SingleValueBinding.removeBindingFromObject(this.__a, id);
 
       // check the binding again
       this.__a.setName("A2");
-      this.assertEquals(
-        "A",
-        this.__label.getValue(),
-        "Removing does not work!"
-      );
+      this.assertEquals("A", this.__label.getValue(), "Removing does not work!");
 
       // smoke Test for the remove
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.name",
-        this.__label,
-        "value"
-      );
-
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.name",
-        this.__label,
-        "value"
-      );
-
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "child.name",
-        this.__label,
-        "value"
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "child.name", this.__label, "value");
+
+      qx.data.SingleValueBinding.bind(this.__a, "child.name", this.__label, "value");
+
+      qx.data.SingleValueBinding.bind(this.__a, "child.name", this.__label, "value");
     },
 
     testArrayDeep() {
@@ -419,112 +287,79 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__b1.setChild(this.__b2);
       this.__b2.setChild(this.__b1);
 
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "array[0].child.name",
-        this.__label,
-        "value"
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "array[0].child.name", this.__label, "value");
 
-      this.assertEquals(
-        "b2",
-        this.__label.getValue(),
-        "Deep binding does not work."
-      );
+      this.assertEquals("b2", this.__label.getValue(), "Deep binding does not work.");
 
       this.__a.getArray().pop();
       this.assertNull(this.__label.getValue(), "Deep binding does not work.");
 
       this.__a.getArray().push(this.__b2);
-      this.assertEquals(
-        "b1",
-        this.__label.getValue(),
-        "Deep binding does not work."
-      );
+      this.assertEquals("b1", this.__label.getValue(), "Deep binding does not work.");
 
       this.__b1.setName("B1");
-      this.assertEquals(
-        "B1",
-        this.__label.getValue(),
-        "Deep binding does not work."
-      );
+      this.assertEquals("B1", this.__label.getValue(), "Deep binding does not work.");
+    },
+
+    /**
+     * Tests that if the path becomes broken,
+     * the target is reset to the init value,
+     * which may not be null!
+     */
+    testTargetInitNotNull() {
+      this.__a.setArray(new qx.data.Array([this.__a]));
+      this.__a.setChild(this.__a);
+      this.__a.setName("Jakub");
+
+      this.assertEquals("b2", this.__b2.getName(), "b2 name changed unexpectedly");
+
+      qx.data.SingleValueBinding.bind(this.__a, "array[0].child.name", this.__b2, "name");
+
+      this.assertEquals("Jakub", this.__b2.getName());
+      this.__a.getArray().pop();
+      this.assertEquals("Juhu", this.__b2.getName());
+
+      this.__a.getArray().push(this.__a);
+      this.assertEquals("Jakub", this.__b2.getName());
+      this.__a.resetChild();
+      this.assertEquals("Juhu", this.__b2.getName(), "Resetting child does not work.");
     },
 
     testDeepTarget() {
       qx.data.SingleValueBinding.bind(this.__a, "name", this.__b1, "lab.value");
 
-      this.assertEquals(
-        "a",
-        this.__b1.getLab().getValue(),
-        "Deep binding on the target does not work."
-      );
+      this.assertEquals("a", this.__b1.getLab().getValue(), "Deep binding on the target does not work.");
     },
 
     testDeepTarget2() {
       this.__b2.setChild(this.__b1);
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "name",
-        this.__b2,
-        "child.lab.value"
-      );
-
-      this.assertEquals(
-        "a",
-        this.__b1.getLab().getValue(),
-        "Deep binding on the target does not work."
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "name", this.__b2, "child.lab.value");
+
+      this.assertEquals("a", this.__b1.getLab().getValue(), "Deep binding on the target does not work.");
     },
 
     testDeepTargetNull() {
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "name",
-        this.__b2,
-        "child.lab.value"
-      );
-
-      this.assertEquals(
-        "",
-        this.__b1.getLab().getValue(),
-        "Deep binding on the target does not work."
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "name", this.__b2, "child.lab.value");
+
+      this.assertEquals("", this.__b1.getLab().getValue(), "Deep binding on the target does not work.");
     },
 
     testDeepTargetArray() {
       this.__a.getArray().dispose();
       this.__a.setArray(new qx.data.Array([this.__b1]));
 
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "name",
-        this.__a,
-        "array[0].lab.value"
-      );
-
-      this.assertEquals(
-        "a",
-        this.__b1.getLab().getValue(),
-        "Deep binding on the target does not work."
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "name", this.__a, "array[0].lab.value");
+
+      this.assertEquals("a", this.__b1.getLab().getValue(), "Deep binding on the target does not work.");
     },
 
     testDeepTargetArrayLast() {
       this.__a.getArray().dispose();
       this.__a.setArray(new qx.data.Array([this.__b1]));
 
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "name",
-        this.__a,
-        "array[last].lab.value"
-      );
-
-      this.assertEquals(
-        "a",
-        this.__b1.getLab().getValue(),
-        "Deep binding on the target does not work."
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "name", this.__a, "array[last].lab.value");
+
+      this.assertEquals("a", this.__b1.getLab().getValue(), "Deep binding on the target does not work.");
     },
 
     testDeepTargetChange() {
@@ -548,17 +383,11 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       var oldLabel = this.__b1.getLab();
       var newLabel = new qx.test.data.singlevalue.TextFieldDummy("x");
 
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "name",
-        this.__b1,
-        "lab.value",
-        {
-          converter(data) {
-            return data + "...";
-          }
+      qx.data.SingleValueBinding.bind(this.__a, "name", this.__b1, "lab.value", {
+        converter(data) {
+          return data + "...";
         }
-      );
+      });
 
       this.__b1.setLab(newLabel);
       this.assertEquals("a...", this.__b1.getLab().getValue());
@@ -577,12 +406,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__b1.setChild(this.__b2);
       this.__b2.setChild(this.__b1);
 
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "child.child.lab.value"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "child.child.lab.value");
 
       // check the default set
       this.__label.setValue("123");
@@ -604,12 +428,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__b1.setChild(this.__b2);
       this.__b2.setChild(this.__b1);
 
-      var id = qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "child.child.lab.value"
-      );
+      var id = qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "child.child.lab.value");
 
       // check the default set
       this.__label.setValue("123");
@@ -619,11 +438,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
 
       // change the child of __a
       this.__a.setChild(this.__b2);
-      this.assertEquals(
-        "",
-        this.__b1.getLab().getValue(),
-        "listener still there"
-      );
+      this.assertEquals("", this.__b1.getLab().getValue(), "listener still there");
 
       // set another label value
       this.__label.setValue("456");
@@ -632,12 +447,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
     },
 
     testDeepTargetChangeArray() {
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "array[0]"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "array[0]");
 
       this.__label.setValue("123");
       this.assertEquals("123", this.__a.getArray().getItem(0));
@@ -656,12 +466,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
     },
 
     testDeepTargetChangeArrayLast() {
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "array[last]"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "array[last]");
 
       this.__label.setValue("123");
       this.assertEquals("123", this.__a.getArray().getItem(2));
@@ -685,12 +490,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__b1.setChild(this.__b2);
       this.__b2.setChild(this.__b1);
 
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "child.child.array[0]"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "child.child.array[0]");
 
       // check the default set
       this.__label.setValue("123");
@@ -703,11 +503,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       // set another label value
       this.__label.setValue("456");
       this.assertEquals("456", this.__b1.getArray().getItem(0));
-      this.assertEquals(
-        "123",
-        this.__b2.getArray().getItem(0),
-        "binding still exists"
-      );
+      this.assertEquals("123", this.__b2.getArray().getItem(0), "binding still exists");
     },
 
     testDeepTargetChangeMiddleArray() {
@@ -716,12 +512,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__a.setArray(array);
       oldArray.dispose();
 
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "array[0].lab.value"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "array[0].lab.value");
 
       this.__label.setValue("123");
       this.assertEquals("123", this.__b1.getLab().getValue());
@@ -740,12 +531,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__a.setArray(array);
       oldArray.dispose();
 
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "array[last].lab.value"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "array[last].lab.value");
 
       this.__label.setValue("123");
       this.assertEquals("123", this.__b1.getLab().getValue());
@@ -761,12 +547,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
     testDeepTargetChangeWithoutEvent() {
       this.__a.setChildWithout(this.__b1);
 
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "childWithout.name"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "childWithout.name");
 
       this.__label.setValue("123");
       this.assertEquals("123", this.__b1.getName());
@@ -784,12 +565,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
       this.__b1.setChildWithout(this.__b2);
       this.__b2.setChildWithout(this.__b1);
 
-      qx.data.SingleValueBinding.bind(
-        this.__label,
-        "value",
-        this.__a,
-        "child.childWithout.name"
-      );
+      qx.data.SingleValueBinding.bind(this.__label, "value", this.__a, "child.childWithout.name");
 
       this.__label.setValue("123");
       this.assertEquals("123", this.__b2.getName());
@@ -813,12 +589,7 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
 
       this.__a.setName(null);
 
-      qx.data.SingleValueBinding.bind(
-        this.__a,
-        "name",
-        this.__a,
-        "child.child.name"
-      );
+      qx.data.SingleValueBinding.bind(this.__a, "name", this.__a, "child.child.name");
 
       this.assertEquals(this.__a.getName(), this.__b2.getName());
 
@@ -856,6 +627,56 @@ qx.Class.define("qx.test.data.singlevalue.Deep", {
         this.error(e);
         this.assertTrue(false, e.message);
       }
+    },
+
+    testManualBidirectional() {
+      let Dummy = qx.Class.define("qx.test.data.singlevalue.Deep.Dummy", {
+        extend: qx.core.Object,
+        properties: {
+          value: {
+            init: null,
+            nullable: true,
+            event: "changeValue"
+          },
+          booleanProp: {
+            init: true,
+            check: "Boolean",
+            event: "changeBooleanProp"
+          }
+        }
+      });
+
+      let CheckBox = qx.Class.define("qx.test.data.singlevalue.Deep.CheckBox", {
+        extend: qx.core.Object,
+        properties: {
+          value: {
+            init: true,
+            check: "Boolean",
+            event: "changeValue"
+          }
+        }
+      });
+
+      let cbx = new CheckBox("Check me");
+      let ed = new Dummy();
+      let val = new Dummy();
+      ed.bind("value.booleanProp", cbx, "value", {
+        converter: value => !value
+      });
+      cbx.bind("value", ed, "value.booleanProp", {
+        converter: value => !value
+      });
+      ed.setValue(val);
+      this.assertTrue(val.getBooleanProp(), "Source value changed spuriously");
+      ed.setValue(null);
+      this.assertTrue(val.getBooleanProp(), "Source value changed spuriously (2)");
+      ed.setValue(val);
+      cbx.setValue(true);
+      this.assertFalse(val.getBooleanProp(), "Source value not updated from target");
+      cbx.setValue(false);
+      this.assertTrue(val.getBooleanProp(), "Source value not updated from target (2)");
+      val.setValue(true);
+      this.assertFalse(cbx.getValue(), "Target value not updated from source");
     }
   }
 });