@qooxdoo/framework 7.9.1 → 7.9.3

package/source/class/qx/test/ui/core/Blocker.js

@@ -235,6 +235,127 @@ qx.Class.define("qx.test.ui.core.Blocker", {
 
       txt.destroy();
       this.flush();
+    },
+
+    testBlockContent() {
+      // Create a container widget with specific position
+      var container = new qx.ui.container.Composite(new qx.ui.layout.Canvas());
+      this.getRoot().add(container, { left: 100, top: 50 });
+      container.setWidth(200);
+      container.setHeight(150);
+      this.flush();
+
+      // Create blocker for the container
+      var blocker = new qx.ui.core.Blocker(container);
+      var blockerElement = blocker.getBlockerElement();
+
+      // Block content
+      blocker.blockContent(10);
+      this.flush();
+
+      this.assertTrue(blocker.isBlocked(), "blocker should be blocked");
+      this.assertTrue(blockerElement.isIncluded(), "blocker element should be included");
+
+      // Verify blocker dimensions match container
+      var styles = blockerElement.getAllStyles();
+      this.assertEquals("200px", styles.width, "blocker width should match container width");
+      this.assertEquals("150px", styles.height, "blocker height should match container height");
+
+      // Verify blocker position is 0,0 (relative to container, not layout parent)
+      // This is the fix for issue #10411
+      this.assertEquals("0px", styles.left, "blocker left should be 0 when blocking content");
+      this.assertEquals("0px", styles.top, "blocker top should be 0 when blocking content");
+
+      // Cleanup
+      blocker.unblock();
+      blocker.dispose();
+      container.destroy();
+      this.flush();
+    },
+
+    testBlockContentPositioning() {
+      // Create a container at a non-zero position
+      var container = new qx.ui.container.Composite(new qx.ui.layout.Canvas());
+      this.getRoot().add(container, { left: 150, top: 100 });
+      container.setWidth(300);
+      container.setHeight(200);
+      this.flush();
+
+      var blocker = new qx.ui.core.Blocker(container);
+      var blockerElement = blocker.getBlockerElement();
+
+      // Block the content
+      blocker.blockContent(5);
+      this.flush();
+
+      var styles = blockerElement.getAllStyles();
+
+      // The blocker should be positioned at 0,0 relative to the container
+      // NOT at the container's position (150, 100)
+      this.assertEquals("0px", styles.left, "blocker should be at left: 0");
+      this.assertEquals("0px", styles.top, "blocker should be at top: 0");
+      this.assertEquals("300px", styles.width, "blocker width should match container");
+      this.assertEquals("200px", styles.height, "blocker height should match container");
+
+      // Cleanup
+      blocker.unblock();
+      blocker.dispose();
+      container.destroy();
+      this.flush();
+    },
+
+    testNormalBlockVsBlockContent() {
+      // Create two containers to compare normal block vs blockContent
+      var container1 = new qx.ui.container.Composite(new qx.ui.layout.Canvas());
+      var container2 = new qx.ui.container.Composite(new qx.ui.layout.Canvas());
+
+      this.getRoot().add(container1, { left: 50, top: 50 });
+      this.getRoot().add(container2, { left: 300, top: 50 });
+
+      container1.setWidth(100);
+      container1.setHeight(100);
+      container2.setWidth(100);
+      container2.setHeight(100);
+
+      this.flush();
+
+      var blocker1 = new qx.ui.core.Blocker(container1);
+      var blocker2 = new qx.ui.core.Blocker(container2);
+
+      // Normal block - blocker is added to layout parent
+      blocker1.block();
+      this.flush();
+
+      var styles1 = blocker1.getBlockerElement().getAllStyles();
+
+      // BlockContent - blocker is added to the widget itself
+      blocker2.blockContent(5);
+      this.flush();
+
+      var styles2 = blocker2.getBlockerElement().getAllStyles();
+
+      // Normal block: blocker positioned at container's position in layout parent
+      this.assertEquals("50px", styles1.left, "normal block uses container's left position");
+      this.assertEquals("50px", styles1.top, "normal block uses container's top position");
+
+      // BlockContent: blocker positioned at 0,0 relative to container
+      this.assertEquals("0px", styles2.left, "blockContent uses 0 for left position");
+      this.assertEquals("0px", styles2.top, "blockContent uses 0 for top position");
+
+      // Both should have same dimensions as their containers
+      this.assertEquals("100px", styles1.width);
+      this.assertEquals("100px", styles1.height);
+      this.assertEquals("100px", styles2.width);
+      this.assertEquals("100px", styles2.height);
+
+      // Cleanup
+      blocker1.unblock();
+      blocker2.unblock();
+      blocker1.dispose();
+      blocker2.dispose();
+      container1.destroy();
+      container2.destroy();
+      this.flush();
     }
   }
 });

package/source/class/qx/test/ui/tree/virtual/Tree.js

@@ -260,6 +260,42 @@ qx.Class.define("qx.test.ui.tree.virtual.Tree", {
       this.__testBuildLookupTable(expected);
     },
 
+    /**
+     * Test for issue #9390: VirtualTree doesn't render if hideRoot is true
+     * when adding nodes dynamically
+     */
+    testDynamicNodesWithHiddenRoot() {
+      // Create initial model
+      var root = this.createModelAndSetModel(1);
+
+      // Set hideRoot before adding nodes
+      this.tree.setHideRoot(true);
+
+      // Flush to ensure initial rendering
+      this.flush();
+
+      // Get initial visible items (should be root's children)
+      var expectedBefore = this.getVisibleItemsFrom(root, [root]);
+      this.__testBuildLookupTable(expectedBefore);
+
+      // Dynamically add a new branch to the root
+      var newBranch = new qx.test.ui.tree.virtual.Node("Dynamic Branch");
+      this._createNodes(newBranch, 1);
+      root.getChildren().push(newBranch);
+
+      // The tree should automatically update without calling refresh()
+      // Expected items should now include the new branch
+      var expectedAfter = this.getVisibleItemsFrom(root, [root]);
+      this.__testBuildLookupTable(expectedAfter);
+
+      // Verify the new branch is in the lookup table
+      var lookupTable = this.tree.getLookupTable();
+      this.assertTrue(
+        lookupTable.contains(newBranch),
+        "New dynamically added branch should be visible in tree with hidden root"
+      );
+    },
+
     testBuildLookupWithoutLeafs() {
       var root = this.createModelAndSetModel(2);
 

package/source/class/qx/test/util/DateFormat.js

@@ -969,7 +969,7 @@ qx.Class.define("qx.test.util.DateFormat", {
         var timezoneOffset = date.getTimezoneOffset();
         var timezoneSign = timezoneOffset > 0 ? 1 : -1;
         var timezoneHours = Math.floor(Math.abs(timezoneOffset) / 60);
-        var timezoneMinutes = Math.abs(timezoneOffset) % 60;
+        var timezoneMinutes = Math.trunc(Math.abs(timezoneOffset)) % 60;
 
         var localTimeZone =
           "GMT" +

package/source/class/qx/theme/classic/Appearance.js

@@ -1465,6 +1465,27 @@ qx.Theme.define("qx.theme.classic.Appearance", {
       }
     },
 
+    "selectbox-arrow-button": "widget",
+
+    /*
+    ---------------------------------------------------------------------------
+      CHECKED SELECT BOX
+    ---------------------------------------------------------------------------
+    */
+
+    "checked-selectbox": "selectbox",
+
+    "checked-selectbox/allNone": {
+      include: "button"
+    },
+
+    "checked-selectbox/tag": "tag",
+
+    tag: {
+      alias: "button",
+      include: "button"
+    },
+
     /*
     ---------------------------------------------------------------------------
       DATE CHOOSER

package/source/class/qx/theme/indigo/ColorDark.js

@@ -28,6 +28,8 @@ qx.Theme.define("qx.theme.indigo.ColorDark", {
     "highlight-shade": "#dddddd",
 
     // backgrounds
+	"datechooser-background-selected-dark": "#333",
+	"datechooser-background": "#666",
     "background-selected": "#666666",
     "background-selected-disabled": "#777777",
     "background-selected-dark": "#333333",

package/source/class/qx/theme/modern/Appearance.js

@@ -1728,6 +1728,27 @@ qx.Theme.define("qx.theme.modern.Appearance", {
       }
     },
 
+    "selectbox-arrow-button": "widget",
+
+    /*
+    ---------------------------------------------------------------------------
+      CHECKED SELECT BOX
+    ---------------------------------------------------------------------------
+    */
+
+    "checked-selectbox": "selectbox",
+
+    "checked-selectbox/allNone": {
+      include: "button"
+    },
+
+    "checked-selectbox/tag": "tag",
+
+    tag: {
+      alias: "button",
+      include: "button"
+    },
+
     /*
     ---------------------------------------------------------------------------
       DATE CHOOSER

package/source/class/qx/theme/simple/Appearance.js

@@ -1238,6 +1238,27 @@ qx.Theme.define("qx.theme.simple.Appearance", {
       }
     },
 
+    "selectbox-arrow-button": "widget",
+
+    /*
+    ---------------------------------------------------------------------------
+      CHECKED SELECT BOX
+    ---------------------------------------------------------------------------
+    */
+
+    "checked-selectbox": "selectbox",
+
+    "checked-selectbox/allNone": {
+      include: "button"
+    },
+
+    "checked-selectbox/tag": "tag",
+
+    tag: {
+      alias: "button",
+      include: "button"
+    },
+
     /*
     ---------------------------------------------------------------------------
       COMBO BOX
@@ -1911,11 +1932,11 @@ qx.Theme.define("qx.theme.simple.Appearance", {
           textColor: states.disabled
             ? "text-disabled"
             : states.weekend
-            ? "background-selected-dark"
-            : "background",
+            ? "datechooser-background-selected-dark"
+            : "datechooser-background",
           backgroundColor: states.weekend
-            ? "background"
-            : "background-selected-dark",
+            ? "datechooser-background"
+            : "datechooser-background-selected-dark",
           paddingTop: 2
         };
       }
@@ -1947,7 +1968,8 @@ qx.Theme.define("qx.theme.simple.Appearance", {
       style(states) {
         return {
           textAlign: "center",
-          textColor: "background-selected-dark",
+          textColor: "datechooser-background",
+		  backgroundColor: "datechooser-background-selected-dark",
           padding: [2, 4],
           decorator: states.header
             ? "datechooser-week-header"

package/source/class/qx/theme/tangible/Appearance.js

@@ -1313,6 +1313,8 @@ qx.Theme.define("qx.theme.tangible.Appearance", {
       }
     },
 
+    "selectbox-arrow-button": "widget",
+
     /*
     ---------------------------------------------------------------------------
       CHECKED SELECT BOX

package/source/class/qx/tool/compiler/ClassFile.js

@@ -810,7 +810,13 @@ qx.Class.define("qx.tool.compiler.ClassFile", {
           } else if (param.type == "ArrayPattern") {
             param.elements.forEach(elem => addDecl(elem));
           } else if (param.type == "ObjectPattern") {
-            param.properties.forEach(prop => addDecl(prop.value));
+            param.properties.forEach(prop => {
+              if (prop.type == "RestElement") {
+                addDecl(prop);
+              } else {
+                addDecl(prop.value);
+              }
+            });
           } else {
             t.addMarker("testForFunctionParameterType", node.loc, param.type);
           }
@@ -1516,6 +1522,9 @@ qx.Class.define("qx.tool.compiler.ClassFile", {
               });
             }
             path.traverse(VISITOR);
+          } else if (keyName == "delegate") {
+            path.skip();
+            path.traverse(VISITOR);
           } else if (keyName == "aliases") {
             path.skip();
             if (!prop.value.properties) {
@@ -1703,7 +1712,8 @@ qx.Class.define("qx.tool.compiler.ClassFile", {
             ClassDeclaration: 1,
             ClassMethod: 1,
             LabeledStatement: 1,
-            BreakStatement: 1
+            BreakStatement: 1,
+            ContinueStatement: 1
           };
 
           // These are AST node types we expect to find at the root of the identifier, and which will
@@ -2149,7 +2159,7 @@ qx.Class.define("qx.tool.compiler.ClassFile", {
                   t.addMarker(
                     "translate.invalidMessageId",
                     path.node.loc,
-                    arg0
+                    arg0 ?? ""
                   );
                 } else {
                   addTranslation({ msgid: arg0 });
@@ -2164,8 +2174,8 @@ qx.Class.define("qx.tool.compiler.ClassFile", {
                   t.addMarker(
                     "translate.invalidMessageIds",
                     path.node.loc,
-                    arg0,
-                    arg1
+                    arg0 ?? "",
+                    arg1 ?? ""
                   );
                 } else {
                   addTranslation({ msgid: arg0, msgid_plural: arg1 });
@@ -2387,7 +2397,9 @@ qx.Class.define("qx.tool.compiler.ClassFile", {
                 // Object destructuring `var {a,b} = {...}`
               } else if (decl.id.type == "ObjectPattern") {
                 decl.id.properties.forEach(prop => {
-                  if (prop.value.type == "AssignmentPattern") {
+                  if (prop.type == "RestElement") {
+                    t.addDeclaration(prop.argument.name);
+                  } else if (prop.value.type == "AssignmentPattern") {
                     t.addDeclaration(prop.value.left.name);
                   } else {
                     t.addDeclaration(prop.value.name);

package/source/class/qx/tool/compiler/resources/Asset.js

@@ -167,7 +167,7 @@ qx.Class.define("qx.tool.compiler.resources.Asset", {
 
     async load() {
       if (this.__loaders) {
-        this.__loaders.forEach(loader => loader.load(this));
+        await Promise.all(this.__loaders.map(loader => loader.load(this)));
       }
     },
 

package/source/class/qx/tool/compiler/targets/meta/PackageJavascript.js

@@ -85,12 +85,16 @@ qx.Class.define("qx.tool.compiler.targets.meta.PackageJavascript", {
 
       if (pkg.isEmbedAllJavascript()) {
         this.__sourceMapOffsets = [];
+        let packageWs = new qx.tool.utils.Utils.LineCountingTransform();
         let strip = new qx.tool.utils.Utils.StripSourceMapTransform();
-        strip.pipe(ws);
+        strip.pipe(packageWs);
+        packageWs.pipe(ws, {
+          end: false
+        });
         await new Promise(async resolve => {
           for (let i = 0; i < pkg.getJavascriptMetas().length; i++) {
             let js = pkg.getJavascriptMetas()[i];
-            this.__sourceMapOffsets.push(ws.getLineNumber());
+            this.__sourceMapOffsets.push(packageWs.getLineNumber());
             await js.unwrap().writeSourceCodeToStream(strip);
             strip.write("\n");
           }

package/source/class/qx/ui/core/Blocker.js

@@ -132,6 +132,7 @@ qx.Class.define("qx.ui.core.Blocker", {
   members: {
     __blocker: null,
     __blockerCount: 0,
+    __blockingContent: false,
 
     __activeElements: null,
     __focusElements: null,
@@ -186,11 +187,17 @@ qx.Class.define("qx.ui.core.Blocker", {
      * @param bounds {Map} Map with the new width, height, left and top values
      */
     _updateBlockerBounds(bounds) {
+      // When blocking content, the blocker is a child of the widget itself,
+      // so it should be positioned at 0,0 relative to the widget.
+      // Otherwise, it's positioned relative to the layout parent.
+      var left = this.__blockingContent ? 0 : bounds.left;
+      var top = this.__blockingContent ? 0 : bounds.top;
+
       this.getBlockerElement().setStyles({
         width: bounds.width + "px",
         height: bounds.height + "px",
-        left: bounds.left + "px",
-        top: bounds.top + "px"
+        left: left + "px",
+        top: top + "px"
       });
     },
 
@@ -338,7 +345,7 @@ qx.Class.define("qx.ui.core.Blocker", {
         if (!this.__appearListener) {
           this.__appearListener = this._widget.addListenerOnce(
             "appear",
-            this._block.bind(this, zIndex)
+            this._block.bind(this, zIndex, blockContent)
           );
         }
         return;
@@ -358,6 +365,9 @@ qx.Class.define("qx.ui.core.Blocker", {
 
       this.__blockerCount++;
       if (this.__blockerCount < 2) {
+        // Track if we're blocking content (blocker is child of widget)
+        this.__blockingContent = blockContent === true;
+
         this._backupActiveWidget();
 
         var bounds = this._widget.getBounds();
@@ -442,6 +452,9 @@ qx.Class.define("qx.ui.core.Blocker", {
       blocker.removeListener("keyup", this.__stopTabEvent, this);
       blocker.exclude();
 
+      // Reset blocking content state
+      this.__blockingContent = false;
+
       this.fireEvent("unblocked", qx.event.type.Event);
     },
 

package/source/class/qx/ui/core/MExecutable.js

@@ -61,7 +61,11 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
 
   members: {
     __executableBindingIds: null,
-    __semaphore: false,
+    
+    /**
+     * @type {Boolean} Whether the command already executed. The protection flag to stop the second command execution.
+     */
+    __commandExecuted: false,
     __executeListenerId: null,
 
     /**
@@ -83,10 +87,10 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
       var cmd = this.getCommand();
 
       if (cmd) {
-        if (this.__semaphore) {
-          this.__semaphore = false;
+        if (this.__commandExecuted) {
+          this.__commandExecuted = false;
         } else {
-          this.__semaphore = true;
+          this.__commandExecuted = true;
           cmd.execute(this);
         }
       }
@@ -100,15 +104,13 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
      * @param e {qx.event.type.Event} The execute event of the command.
      */
     __onCommandExecute(e) {
+      if (this.__commandExecuted) {
+        this.__commandExecuted = false;
+        return;
+      }
+      this.__commandExecuted = true;
       if (this.isEnabled()) {
-        if (this.__semaphore) {
-          this.__semaphore = false;
-          return;
-        }
-        if (this.isEnabled()) {
-          this.__semaphore = true;
-          this.execute();
-        }
+        this.execute();
       }
     },
 

package/source/class/qx/ui/form/validation/Manager.js

@@ -484,7 +484,7 @@ qx.Class.define("qx.ui.form.validation.Manager", {
 
             let msg = item.getInvalidMessage();
             if (
-              msg &&
+              !msg &&
               qx.core.Environment.get(
                 "qx.ui.form.validation.Manager.allowDefaultInvalidMessage"
               )

package/source/class/qx/ui/mobile/dialog/Popup.js

@@ -140,11 +140,16 @@ qx.Class.define("qx.ui.mobile.dialog.Popup", {
     __widget: null,
     __titleWidget: null,
     __lastPopupDimension: null,
+    /**
+     * Flag which ignores event domupdated caused by this widget and stopps infinite recursive `_updatePosition` calls
+     */
+    __updatePositionStarted: false,
 
     /**
      * Event handler. Called whenever the position of the popup should be updated.
      */
     _updatePosition() {
+      this.__updatePositionStarted = true;
       // Traverse single anchor classes for removal, for preventing 'domupdated' event if no CSS classes changed.
       var anchorClasses = ["top", "bottom", "left", "right", "anchor"];
       for (var i = 0; i < anchorClasses.length; i++) {
@@ -446,7 +451,14 @@ qx.Class.define("qx.ui.mobile.dialog.Popup", {
         flex: 1
       });
 
-      widget.addListener("domupdated", this._updatePosition, this);
+      widget.addListener("domupdated", () => {
+        if (!this.__updatePositionStarted){
+          this._updatePosition();
+        }
+        else {
+          this.__updatePositionStarted = false;
+        }
+      }, this);
 
       this.__widget = widget;
     },

package/source/class/qx/ui/table/Table.js

@@ -1570,10 +1570,11 @@ qx.Class.define("qx.ui.table.Table", {
      *          visible.
      */
     setFocusedCell(col, row, scrollVisible) {
-      if (
-        !this.isEditing() &&
-        (col != this.__focusedCol || row != this.__focusedRow)
-      ) {
+      let cellChanged = col != this.__focusedCol || row != this.__focusedRow;
+      if (this.isEditing() && cellChanged) {
+        this.stopEditing();
+      }
+      if (!this.isEditing() && cellChanged) {
         if (col === null) {
           col = 0;
         }

package/source/class/qx/ui/table/pane/Scroller.js

@@ -1973,16 +1973,14 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
     _onFocusinCellEditorAddBlurListener(e) {
       this.debug("executed FOCUSIN event listener for hash: " + e.getTarget().$$hash);
       qx.event.Timer.once(function() {
-        this._cellEditor.addListenerOnce('blur', this._onBlurCellEditorStopEditing, this);
-        this.debug('added BLUR listener to hash: ' + this._cellEditor.$$hash);
+        this._cellEditor.addListener('focusout', this._onFocusoutCellEditorStopEditing, this);
+        this.debug('added FOCUSOUT listener to hash: ' + this._cellEditor.$$hash);
       }, this, 1);
     },
 
-    /**
-     * Stop editing whenever the cell editor blurs.
-     */
-    _onBlurCellEditorStopEditing(e) {
-      this.debug("executed BLUR listener for hash " + e.getTarget().$$hash);
+
+    _onFocusoutCellEditorStopEditing(e) {
+      this.debug("executed FOCUSOUT listener for hash " + e.getTarget().$$hash);
       if (this._cellEditor === e.getTarget()) {
         this.debug('hash: ' + this._cellEditor.$$hash);
         switch (this.getTable().getCellEditorBlurAction()) {
@@ -2408,4 +2406,4 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
       "__clipperContainer"
     );
   }
-});
+});

package/source/class/qx/ui/tree/VirtualTree.js

@@ -761,7 +761,10 @@ qx.Class.define("qx.ui.tree.VirtualTree", {
           }
         }
 
-        if (this.__lookupTable.indexOf(item) != -1) {
+        // Issue #9390: When hideRoot is true, the root is not in the lookup table,
+        // but we still need to update when its children change
+        var isRootAndHidden = this.isHideRoot() && item === this.getModel();
+        if (this.__lookupTable.indexOf(item) != -1 || isRootAndHidden) {
           this.__applyModelChanges();
         }
       }

package/source/class/qx/util/format/DateFormat.js

@@ -476,8 +476,9 @@ qx.Class.define("qx.util.format.DateFormat", {
 
       var timezoneOffset = date.getTimezoneOffset();
       var timezoneSign = timezoneOffset > 0 ? 1 : -1;
-      var timezoneHours = Math.floor(Math.abs(timezoneOffset) / 60);
-      var timezoneMinutes = Math.abs(timezoneOffset) % 60;
+      var absTimezoneOffset = Math.abs(timezoneOffset);
+      var timezoneHours = Math.floor(absTimezoneOffset / 60);
+      var timezoneMinutes = Math.trunc(absTimezoneOffset) % 60;
 
       // Create the output
       this.__initFormatTree();