@qooxdoo/framework 7.8.0 → 7.9.0

package/source/class/qx/test/data/controller/List.js

@@ -25,7 +25,13 @@ qx.Class.define("qx.test.data.controller.List", {
   include: qx.dev.unit.MMock,
 
   members: {
+    /**
+     * @type {qx.ui.form.List}
+     */
     __list: null,
+    /**
+     * @type {qx.data.controller.List}
+     */
     __controller: null,
     __data: null,
     __model: null,

package/source/class/qx/test/data/marshal/Json.js

@@ -1498,6 +1498,35 @@ qx.Class.define("qx.test.data.marshal.Json", {
 
       model.dispose();
       qx.Class.undefine("qx.test.Array");
+    },
+
+    testNonPojoObjects() {
+      function NativeClass() {
+        this.foo = "bar";
+      }
+
+      NativeClass.prototype.myMethod = function () {
+        return "method";
+      };
+
+      let data = {
+        name: "Michael",
+        nonPojo: new NativeClass()
+      };
+
+      this.__marshaler.dispose();
+      this.__marshaler = new qx.data.marshal.Json();
+      this.__marshaler.toClass(data);
+      var model = this.__marshaler.toModel(data);
+
+      this.assertEquals("Michael", model.getName());
+
+      if (qx.core.Environment.get("qx.data.marshal.Json.breakOnNonPojos")) {
+        this.assertEquals("method", model.getNonPojo().myMethod());
+        this.assertEquals("bar", model.getNonPojo().foo);
+      } else {
+        this.assertEquals("bar", model.getNonPojo().getFoo());
+      }
     }
   }
 });

package/source/class/qx/test/io/request/Xhr.js

@@ -760,6 +760,12 @@ qx.Class.define("qx.test.io.request.Xhr", {
         this.skip("Skipping because qx.promise==false");
       }
 
+      if (qx.core.Environment.get("qx.Promise.useNativePromise")) {
+        this.skip(
+          "Skipping because qx.Promise.useNativePromise===true, meaning we can't cancel promises."
+        );
+      }
+
       this.setUpFakeTransport();
       var req = this.req;
 
@@ -818,6 +824,11 @@ qx.Class.define("qx.test.io.request.Xhr", {
       if (!qx.core.Environment.get("qx.promise")) {
         this.skip("Skipping because qx.promise==false");
       }
+      if (qx.core.Environment.get("qx.Promise.useNativePromise")) {
+        this.skip(
+          "Skipping because qx.Promise.useNativePromise===true, meaning we can't cancel promises."
+        );
+      }
 
       this.setUpFakeTransport();
       var req = this.req;
@@ -863,6 +874,11 @@ qx.Class.define("qx.test.io.request.Xhr", {
       if (!qx.core.Environment.get("qx.promise")) {
         this.skip("Skipping because qx.promise==false");
       }
+      if (qx.core.Environment.get("qx.Promise.useNativePromise")) {
+        this.skip(
+          "Skipping because qx.Promise.useNativePromise===true, meaning we can't cancel promises."
+        );
+      }
 
       this.setUpFakeTransport();
       var req = this.req;

package/source/class/qx/test/lang/Type.js

@@ -42,6 +42,156 @@ qx.Class.define("qx.test.lang.Type", {
       this.assertFalse(Type.isString(document.getElementById("ReturenedNull")));
     },
 
+    testIsPojo() {
+      var isPojo = qx.lang.Type.isPojo;
+
+      //Class Person extends Object
+      function Person() {
+        this.name = "Mary";
+        this.surname = "Berry";
+      }
+
+      Person.prototype.getFullName = function () {
+        return this.name + " " + this.surname;
+      };
+
+      Person.prototype.properties = function () {
+        return "Properties";
+      };
+
+      //Class Child extends Person
+      function Child() {
+        Person.call(this);
+      }
+
+      Child.prototype = Object.create(Person.prototype);
+      Child.prototype.constructor = Child;
+
+      Child.prototype.childMethod = function () {
+        return "Child method";
+      };
+
+      // Simple POJO, should return true
+      this.assertTrue(isPojo({ foo: 1 }));
+
+      //Arrays, strings, numbers, and booleans are not POJOs
+      this.assertFalse(isPojo([]));
+      this.assertFalse(isPojo(null));
+      this.assertFalse(isPojo(new qx.data.Array()));
+      this.assertFalse(isPojo("hello"));
+      this.assertFalse(isPojo(12));
+      this.assertFalse(isPojo(true));
+
+      //Class instance which does not inherit
+      var nonInheritance = new Person();
+      this.assertFalse(isPojo(nonInheritance));
+
+      //Class instance with class that inherits
+      var withInheritance = new Child();
+      this.assertFalse(isPojo(withInheritance));
+
+      //POJO with class prototype
+      var pojoWithClassPrototype = { age: 22 };
+      Object.setPrototypeOf(pojoWithClassPrototype, Person.prototype);
+      this.assertFalse(isPojo(pojoWithClassPrototype));
+
+      //POJO with an object prototype
+      //Should return true
+      var pojoWithObjectPrototype = { extraproperty: "Nuts" };
+      var proto = {
+        protoMethod() {
+          return "protomethod";
+        }
+      };
+      Object.setPrototypeOf(pojoWithObjectPrototype, proto);
+      this.assertTrue(isPojo(pojoWithObjectPrototype));
+
+      //Object which has a POJO prototype, which in turn has a class prototype
+      //Should return false
+      var prototypeIsObjectThenConstructor = { extraproperty: "Nuts" };
+      var proto = {
+        protoMethod() {
+          return "protomethod";
+        }
+      };
+
+      Object.setPrototypeOf(prototypeIsObjectThenConstructor, proto);
+      Object.setPrototypeOf(proto, Person.prototype);
+      this.assertFalse(isPojo(prototypeIsObjectThenConstructor));
+
+      //Object which has a POJO prototype, which in turn has a POJO prototype
+      //Should return true
+      var obj = {
+        nuts: 345
+      };
+
+      var proto1 = {
+        myMethod() {
+          return "proto1.myMethod";
+        }
+      };
+
+      Object.setPrototypeOf(obj, proto1);
+      var proto2 = {
+        myMethod() {
+          return "proto2.myMethod";
+        },
+
+        method2() {
+          return "proto2.method2";
+        }
+      };
+
+      Object.setPrototypeOf(proto1, proto2);
+
+      this.assertEquals("proto1.myMethod", obj.myMethod());
+      this.assertEquals("proto2.method2", obj.method2());
+      this.assertTrue(isPojo(obj));
+
+      //Object which is instance of a class, where the class has a prototype which is not Object.prototype
+      //Must return false
+      function NonObjectPrototype() {
+        this.foo = "foo";
+      }
+
+      var proto = {
+        myMethod() {
+          return "proto.myMethod";
+        }
+      };
+
+      NonObjectPrototype.prototype = proto;
+      NonObjectPrototype.prototype.constructor = NonObjectPrototype;
+      NonObjectPrototype.prototype.extraMethod = function () {
+        return "extraMethod";
+      };
+
+      var obj = new NonObjectPrototype();
+
+      this.assertEquals("proto.myMethod", obj.myMethod());
+      this.assertEquals("extraMethod", obj.extraMethod());
+      this.assertEquals("foo", obj.foo);
+      this.assertFalse(isPojo(obj));
+
+      //Qooxdoo objects must not be POJOs
+      var obj = new qx.core.Object();
+      this.assertFalse(isPojo(obj));
+
+      //ES6 class must not be a POJO
+      class ES6Class {
+        constructor() {
+          this.foo = "bar";
+        }
+
+        method() {
+          return "method: " + this.foo;
+        }
+      }
+
+      var obj = new ES6Class();
+      this.assertFalse(isPojo(obj));
+    },
+
     testIsArray() {
       var Type = qx.lang.Type;
 
@@ -64,6 +214,7 @@ qx.Class.define("qx.test.lang.Type", {
     },
 
     testIsObject() {
+      //note: old testIsObject
       var Type = qx.lang.Type;
 
       this.assertTrue(Type.isObject({}));

package/source/class/qx/theme/indigo/ColorDark.js

@@ -95,7 +95,7 @@ qx.Theme.define("qx.theme.indigo.ColorDark", {
     // used in table code
     "table-header-cell": "#ebeadb",
     "table-row-background-focused-selected": "#666666",
-    "table-row-background-focused": "#666666",
+    "table-row-background-focused": "#444444",
     "table-row-background-selected": "#666666",
     "table-row-background-even": "#333333",
     "table-row-background-odd": "#333333",

package/source/class/qx/ui/core/MPlacement.js

@@ -205,6 +205,7 @@ qx.Mixin.define("qx.ui.core.MPlacement", {
     __ptwLiveUpdateDisappearListener: null,
     /**@type {Record<"top" | "right" | "bottom" | "left", number> | null}*/
     __lastKnownCoords: null,
+    __lastKnownSize: null,
 
     /**
      * Returns the location data like {qx.bom.element.Location#get} does,
@@ -378,17 +379,23 @@ qx.Mixin.define("qx.ui.core.MPlacement", {
 
       var coords =
         target.getContentLocation() || this.getLayoutLocation(target);
+      var size = this.__getPlacementSize();
 
       if (coords != null) {
-        if (
-          coords.top === this.__lastKnownCoords?.top &&
-          coords.right === this.__lastKnownCoords?.right &&
-          coords.bottom === this.__lastKnownCoords?.bottom &&
-          coords.left === this.__lastKnownCoords?.left
-        ) {
+
+        const boundsAreEqual = (bound1, bound2) => bound1 && bound2 &&
+          bound1.top === bound2.top &&
+          bound1.right === bound2.right &&
+          bound1.bottom === bound2.bottom &&
+          bound1.left === bound2.left;
+
+        if (boundsAreEqual(coords, this.__lastKnownCoords) &&
+          boundsAreEqual(size, this.__lastKnownSize)) {
           return true;
         }
+
         this.__lastKnownCoords = coords;
+        this.__lastKnownSize = size;
         this._place(coords);
         return true;
       } else {
@@ -527,7 +534,7 @@ qx.Mixin.define("qx.ui.core.MPlacement", {
      * <code>_computePlacementSize</code>, which returns the size.
      *
      *  @param callback {Function} This function will be called with the size as
-     *    first argument
+     *    first argument. If it is null, the size is returned directly.
      */
     __getPlacementSize(callback) {
       var size = null;
@@ -538,6 +545,10 @@ qx.Mixin.define("qx.ui.core.MPlacement", {
         var size = this.getBounds();
       }
 
+      if (!callback) {
+        return {...size};
+      }
+
       if (size == null) {
         this.addListenerOnce("appear", () => {
           this.__getPlacementSize(callback);

package/source/class/qx/ui/table/pane/Scroller.js

@@ -1975,7 +1975,7 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
       qx.event.Timer.once(function() {
         this._cellEditor.addListenerOnce('blur', this._onBlurCellEditorStopEditing, this);
         this.debug('added BLUR listener to hash: ' + this._cellEditor.$$hash);
-      }, this, 0);
+      }, this, 1);
     },
 
     /**

package/source/class/qx/util/ConcurrencyLimiter.js

@@ -0,0 +1,78 @@
+/**
+ * Utility class to limit the number of concurrent executions of async functions.
+ *
+ * @typedef {Object} TaskEntry
+ * @template T
+ * @property {() => Promise<T>} task The function to execute.
+ * @property {(value: T) => void} resolve The function to call when the task resolves.
+ * @property {(reason: any) => void} reject The function to call when the task rejects.
+ */
+qx.Class.define("qx.util.ConcurrencyLimiter", {
+  extend: qx.core.Object,
+
+  /**
+   * @param {Number?Infinity} limit The maximum number of concurrent executions. If Infinity, no limit is applied.
+   */
+  construct(limit = Infinity) {
+    super();
+    this.__limit = limit;
+
+    this.__queue = [];
+    this.__running = 0;
+  },
+
+  members: {
+    /**
+     * @type {TaskEntry<*>[]}
+     * The tasks that are waiting to be executed
+     */
+    __queue: null,
+
+    /**
+     * Number of currently running tasks.
+     */
+    __running: null,
+
+    /**
+     * Queues a function to be executed.
+     * If the limit is reached, the function will be put on hold until a slot is available.
+     *
+     * @template T
+     * @param {() => Promise<T>} task The function to execute.
+     * @returns {Promise<T>} The promise that will be resolved when the function is executed.
+     *  If the function rejects, the promise will also reject.
+     */
+    add(task) {
+      return new Promise((resolve, reject) => {
+        this.__queue.push({ task, resolve, reject });
+        this.__checkQueue();
+      });
+    },
+
+    /**
+     * Checks the queue to see if anything can be executed,
+     * and executes the next item in the queue if the limit is not reached.
+     * Once the item has finished executing, it will check the queue again.
+     */
+    __checkQueue() {
+      if (this.__running == this.__limit) {
+        return;
+      }
+
+      let next = this.__queue.shift();
+      if (!next) {
+        return;
+      }
+
+      let { task, resolve, reject } = next;
+
+      this.__running++;
+      task()
+        .then(resolve, reject)
+        .finally(() => {
+          this.__running--;
+          this.__checkQueue();
+        });
+    }
+  }
+});

package/source/resource/qx/tool/website/build/404.html

@@ -18,7 +18,6 @@
     <title>Qooxdoo Application Server</title>
     <meta name="description" content="">
     <link rel="stylesheet" type="text/css" href="/qooxdoo.css">
-    <script type="text/javascript" src="/assets/bluebird.min.js"></script>
     <script type="text/javascript" src="/assets/jquery.js"></script>
     <script type="text/javascript" src="/scripts/serve.js"></script>
 </head>
@@ -201,11 +200,11 @@
       </div>
       <div class="container text-center d-none d-sm-block p-4">
         <img class="img p-4" src="/assets/qx-white.svg">
-        <span class="text-light">&copy; 2005-2018 Qooxdoo Contributors</span>
+        <span class="text-light">&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</span>
       </div>
       <div class="container text-center d-block d-sm-none p-4">
         <img class="img-fluid p-4" src="/assets/qx-white.svg">
-        <p>&copy; 2005-2017 Qooxdoo Contributors</p>
+        <p>&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</p>
       </div>
     </div>
 
@@ -213,28 +212,7 @@
     <!-- jQuery first, then Popper.js, then Bootstrap JS -->
     <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.12.9/umd/popper.min.js" integrity="sha384-ApNbgh9B+Y1QKtv3Rn7W3mgPxhU9K/ScQsAP7hUibX39j7fakFPskvXusvfa0b4Q" crossorigin="anonymous"></script>
     <script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta.3/js/bootstrap.min.js" integrity="sha384-a5N7Y/aK3qNeh15eJKGWxsqtnX/wWdSZSKp+81YjTmS15nvnvxKHuzaWwXHDli+4" crossorigin="anonymous"></script>
-    <script type="text/javascript">
-        $(function () {
-          $('[data-toggle="tooltip"]').tooltip()
-        })
-        var scroll = (function (event) {
-          var scroll = $(window).scrollTop();
-          if (scroll < 250) {
-            $(navigatopnBar).css('background-color', 'transparent');
-            $(navigationLogo).css('width', '0');
-            $(navigationLogo).addClass('invisible');
-          } else {
-            $(navigatopnBar).css('background-color', 'rgba(0, 40, 56, 0.9)');
-            $(navigationLogo).css('width', '');
-            $(navigationLogo).removeClass('invisible');
-          }
-        });
-        $(window).scroll(scroll);
-        scroll();
-    </script>
-
-
-
+    <script src="/assets/common.js" type="text/javascript"></script>
   </body>
 
 </html>

package/source/resource/qx/tool/website/build/about.html

@@ -18,7 +18,6 @@
     <title>About</title>
     <meta name="description" content="">
     <link rel="stylesheet" type="text/css" href="/qooxdoo.css">
-    <script type="text/javascript" src="/assets/bluebird.min.js"></script>
     <script type="text/javascript" src="/assets/jquery.js"></script>
     <script type="text/javascript" src="/scripts/serve.js"></script>
 </head>
@@ -184,11 +183,11 @@
       </div>
       <div class="container text-center d-none d-sm-block p-4">
         <img class="img p-4" src="/assets/qx-white.svg">
-        <span class="text-light">&copy; 2005-2018 Qooxdoo Contributors</span>
+        <span class="text-light">&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</span>
       </div>
       <div class="container text-center d-block d-sm-none p-4">
         <img class="img-fluid p-4" src="/assets/qx-white.svg">
-        <p>&copy; 2005-2017 Qooxdoo Contributors</p>
+        <p>&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</p>
       </div>
     </div>
 
@@ -196,28 +195,7 @@
     <!-- jQuery first, then Popper.js, then Bootstrap JS -->
     <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.12.9/umd/popper.min.js" integrity="sha384-ApNbgh9B+Y1QKtv3Rn7W3mgPxhU9K/ScQsAP7hUibX39j7fakFPskvXusvfa0b4Q" crossorigin="anonymous"></script>
     <script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta.3/js/bootstrap.min.js" integrity="sha384-a5N7Y/aK3qNeh15eJKGWxsqtnX/wWdSZSKp+81YjTmS15nvnvxKHuzaWwXHDli+4" crossorigin="anonymous"></script>
-    <script type="text/javascript">
-        $(function () {
-          $('[data-toggle="tooltip"]').tooltip()
-        })
-        var scroll = (function (event) {
-          var scroll = $(window).scrollTop();
-          if (scroll < 250) {
-            $(navigatopnBar).css('background-color', 'transparent');
-            $(navigationLogo).css('width', '0');
-            $(navigationLogo).addClass('invisible');
-          } else {
-            $(navigatopnBar).css('background-color', 'rgba(0, 40, 56, 0.9)');
-            $(navigationLogo).css('width', '');
-            $(navigationLogo).removeClass('invisible');
-          }
-        });
-        $(window).scroll(scroll);
-        scroll();
-    </script>
-
-
-
+    <script src="/assets/common.js" type="text/javascript"></script>
   </body>
 
 </html>

package/source/resource/qx/tool/website/build/assets/common.js

@@ -0,0 +1,20 @@
+var currentYear = new Date().getFullYear(); 
+$(".current-year").text(currentYear);
+
+$(function () {
+  $('[data-toggle="tooltip"]').tooltip();
+})
+var scroll = (function (event) {
+  var scroll = $(window).scrollTop();
+  if (scroll < 250) {
+    $(navigatopnBar).css('background-color', 'transparent');
+    $(navigationLogo).css('width', '0');
+    $(navigationLogo).addClass('invisible');
+  } else {
+    $(navigatopnBar).css('background-color', 'rgba(0, 40, 56, 0.9)');
+    $(navigationLogo).css('width', '');
+    $(navigationLogo).removeClass('invisible');
+  }
+});
+$(window).scroll(scroll);
+scroll();

package/source/resource/qx/tool/website/build/diagnostics/dependson.html

@@ -18,7 +18,6 @@
     <title>Qooxdoo Application Server</title>
     <meta name="description" content="">
     <link rel="stylesheet" type="text/css" href="/qooxdoo.css">
-    <script type="text/javascript" src="/assets/bluebird.min.js"></script>
     <script type="text/javascript" src="/assets/jquery.js"></script>
     <script type="text/javascript" src="/scripts/serve.js"></script>
 </head>
@@ -196,11 +195,11 @@
       </div>
       <div class="container text-center d-none d-sm-block p-4">
         <img class="img p-4" src="/assets/qx-white.svg">
-        <span class="text-light">&copy; 2005-2018 Qooxdoo Contributors</span>
+        <span class="text-light">&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</span>
       </div>
       <div class="container text-center d-block d-sm-none p-4">
         <img class="img-fluid p-4" src="/assets/qx-white.svg">
-        <p>&copy; 2005-2017 Qooxdoo Contributors</p>
+        <p>&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</p>
       </div>
     </div>
 
@@ -208,28 +207,7 @@
     <!-- jQuery first, then Popper.js, then Bootstrap JS -->
     <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.12.9/umd/popper.min.js" integrity="sha384-ApNbgh9B+Y1QKtv3Rn7W3mgPxhU9K/ScQsAP7hUibX39j7fakFPskvXusvfa0b4Q" crossorigin="anonymous"></script>
     <script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta.3/js/bootstrap.min.js" integrity="sha384-a5N7Y/aK3qNeh15eJKGWxsqtnX/wWdSZSKp+81YjTmS15nvnvxKHuzaWwXHDli+4" crossorigin="anonymous"></script>
-    <script type="text/javascript">
-        $(function () {
-          $('[data-toggle="tooltip"]').tooltip()
-        })
-        var scroll = (function (event) {
-          var scroll = $(window).scrollTop();
-          if (scroll < 250) {
-            $(navigatopnBar).css('background-color', 'transparent');
-            $(navigationLogo).css('width', '0');
-            $(navigationLogo).addClass('invisible');
-          } else {
-            $(navigatopnBar).css('background-color', 'rgba(0, 40, 56, 0.9)');
-            $(navigationLogo).css('width', '');
-            $(navigationLogo).removeClass('invisible');
-          }
-        });
-        $(window).scroll(scroll);
-        scroll();
-    </script>
-
-
-
+    <script src="/assets/common.js" type="text/javascript"></script>
   </body>
 
 </html>

package/source/resource/qx/tool/website/build/diagnostics/requiredby.html

@@ -18,7 +18,6 @@
     <title>Qooxdoo Application Server</title>
     <meta name="description" content="">
     <link rel="stylesheet" type="text/css" href="/qooxdoo.css">
-    <script type="text/javascript" src="/assets/bluebird.min.js"></script>
     <script type="text/javascript" src="/assets/jquery.js"></script>
     <script type="text/javascript" src="/scripts/serve.js"></script>
 </head>
@@ -198,11 +197,11 @@
       </div>
       <div class="container text-center d-none d-sm-block p-4">
         <img class="img p-4" src="/assets/qx-white.svg">
-        <span class="text-light">&copy; 2005-2018 Qooxdoo Contributors</span>
+        <span class="text-light">&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</span>
       </div>
       <div class="container text-center d-block d-sm-none p-4">
         <img class="img-fluid p-4" src="/assets/qx-white.svg">
-        <p>&copy; 2005-2017 Qooxdoo Contributors</p>
+        <p>&copy; 2005-<span class="current-year"></span> Qooxdoo Contributors</p>
       </div>
     </div>
 
@@ -210,25 +209,7 @@
     <!-- jQuery first, then Popper.js, then Bootstrap JS -->
     <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.12.9/umd/popper.min.js" integrity="sha384-ApNbgh9B+Y1QKtv3Rn7W3mgPxhU9K/ScQsAP7hUibX39j7fakFPskvXusvfa0b4Q" crossorigin="anonymous"></script>
     <script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta.3/js/bootstrap.min.js" integrity="sha384-a5N7Y/aK3qNeh15eJKGWxsqtnX/wWdSZSKp+81YjTmS15nvnvxKHuzaWwXHDli+4" crossorigin="anonymous"></script>
-    <script type="text/javascript">
-        $(function () {
-          $('[data-toggle="tooltip"]').tooltip()
-        })
-        var scroll = (function (event) {
-          var scroll = $(window).scrollTop();
-          if (scroll < 250) {
-            $(navigatopnBar).css('background-color', 'transparent');
-            $(navigationLogo).css('width', '0');
-            $(navigationLogo).addClass('invisible');
-          } else {
-            $(navigatopnBar).css('background-color', 'rgba(0, 40, 56, 0.9)');
-            $(navigationLogo).css('width', '');
-            $(navigationLogo).removeClass('invisible');
-          }
-        });
-        $(window).scroll(scroll);
-        scroll();
-    </script>
+    <script src="/assets/common.js" type="text/javascript"></script>