@qooxdoo/framework 7.7.2 → 7.9.0

package/source/class/qx/io/jsonrpc/protocol/Request.js

@@ -29,10 +29,17 @@ qx.Class.define("qx.io.jsonrpc.protocol.Request", {
      */
     __current_request_id: 0,
 
+    /**
+     * Returns the current request id
+     * @returns {Number}
+     */
     getCurrentId() {
       return qx.io.jsonrpc.protocol.Request.__current_request_id;
     },
 
+    /**
+     * Resets the request id to zero
+     */
     resetId() {
       qx.io.jsonrpc.protocol.Request.__current_request_id = 0;
     }
@@ -69,13 +76,14 @@ qx.Class.define("qx.io.jsonrpc.protocol.Request", {
     __promise: null,
 
     /**
-     * Getter for promise which resolves with the result to the request
+     * Getter for promise which resolves with the result to the request, if successful
      * @return {qx.Promise}
      */
     getPromise() {
       return this.__promise;
     },
 
+
     /**
      * Determines how an exception during transport is handled. Standard
      * behavior is to reject the request's promise with that exception.
@@ -84,11 +92,7 @@ qx.Class.define("qx.io.jsonrpc.protocol.Request", {
      * @param {qx.io.exception.Transport} exception
      */
     handleTransportException(exception) {
-      try {
-        this.getPromise().reject(exception);
-      } catch (e) {
-        this.warn("Promise has already been rejected");
-      }
+      this.__promise.reject(exception);
     }
   }
 });

package/source/class/qx/lang/Type.js

@@ -52,15 +52,48 @@ qx.Bootstrap.define("qx.lang.Type", {
     isArray: qx.Bootstrap.isArray,
 
     /**
-     * Whether the value is an object. Note that built-in types like Window are
-     * not reported to be objects.
      *
+     * Whether the value is an POJO (ie {})
+     * or an object which is created from a ES6-style class or prototypical-inheritance-based class;
+     * if you need to determine whether something is a POJO and not created from a class, use isPojo instead
+     *
+     * Note that built-in types like Window are not deemed to be objects.
      * @signature function(value)
-     * @param value {var} Value to check.
+     * @param {*} value value to check.
      * @return {Boolean} Whether the value is an object.
      */
     isObject: qx.Bootstrap.isObject,
 
+    /**
+     * Whether the value is strictly a POJO.
+     * Its prototype chain must not contain any constructors which are not the Object constructor i.e. traditional prototype-based classes or ES6 classes.
+     *
+     * @param {*} value
+     * @returns {Boolean} Whether the value is strictly a POJO.
+     */
+    isPojo(value) {
+      if (qx.Bootstrap.getClass(value) != "Object") {
+        return false;
+      }
+
+      let prototype = Object.getPrototypeOf(value);
+      while (true) {
+        if (prototype === Object.prototype) {
+          return true;
+        }
+
+        if (
+          prototype.constructor &&
+          prototype.constructor !== Object.prototype.constructor
+        ) {
+          return false;
+        }
+
+        //loop tail
+        prototype = Object.getPrototypeOf(prototype);
+      }
+    },
+
     /**
      * Whether the value is a function.
      *