@qooxdoo/framework 7.5.0 → 7.6.0

package/source/class/qx/ui/core/Widget.js

@@ -2122,24 +2122,17 @@ qx.Class.define("qx.ui.core.Widget", {
     // property apply
     _applyTextColor(value, old) {
       // empty template
-    },
-
-    // property apply
+    }, // property apply
     _applyZIndex(value, old) {
       this.getContentElement().setStyle("zIndex", value == null ? 0 : value);
-    },
-
-    // property apply
+    }, // property apply
     _applyVisibility(value, old) {
       var content = this.getContentElement();
-
       if (value === "visible") {
         content.show();
       } else {
         content.hide();
-      }
-
-      // only force a layout update if visibility change from/to "exclude"
+      } // only force a layout update if visibility change from/to "exclude"
       var parent = this.$$parent;
       if (
         parent &&
@@ -2187,31 +2180,19 @@ qx.Class.define("qx.ui.core.Widget", {
     // property apply
     _applyFont(value, old) {
       // empty template
-    },
-
-    /*
-    ---------------------------------------------------------------------------
-      DYNAMIC THEME SWITCH SUPPORT
-    ---------------------------------------------------------------------------
-    */
-
+    }, // ---------------------------------------------------------------------------
+    // DYNAMIC THEME SWITCH SUPPORT
+    // ---------------------------------------------------------------------------
     // overridden
     _onChangeTheme() {
       if (this.isDisposed()) {
         return;
       }
-
-      super._onChangeTheme();
-
-      // update the appearance
-      this.updateAppearance();
-
-      // DECORATOR //
+      super._onChangeTheme(); // update the appearance
+      this.updateAppearance(); // DECORATOR //
       var value = this.getDecorator();
       this._applyDecorator(null, value);
-      this._applyDecorator(value);
-
-      // FONT //
+      this._applyDecorator(value); // FONT //
       value = this.getFont();
       if (qx.lang.Type.isString(value)) {
         this._applyFont(value, value);
@@ -2561,30 +2542,24 @@ qx.Class.define("qx.ui.core.Widget", {
     syncWidget(jobs) {
       // empty implementation
     },
-
     /*
     ---------------------------------------------------------------------------
-      EVENT SUPPORT
+    EVENT SUPPORT
     ---------------------------------------------------------------------------
-    */
-
-    /**
+    */ /**
      * Returns the next event target in the parent chain. May
      * also return the widget itself if it is not anonymous.
      *
      * @return {qx.ui.core.Widget} A working event target of this widget.
      *    May be <code>null</code> as well.
-     */
-    getEventTarget() {
+     */ getEventTarget() {
       var target = this;
-
       while (target.getAnonymous()) {
         target = target.getLayoutParent();
         if (!target) {
           return null;
         }
       }
-
       return target;
     },
 
@@ -2751,17 +2726,13 @@ qx.Class.define("qx.ui.core.Widget", {
     // property apply
     _applyNativeContextMenu(value, old, name) {
       // empty body to allow overriding
-    },
-
-    // property apply
+    }, // property apply
     _applyContextMenu(value, old) {
       if (old) {
         old.removeState("contextmenu");
-
         if (old.getOpener() == this) {
           old.resetOpener();
         }
-
         if (!value) {
           this.removeListener("contextmenu", this._onContextMenuOpen);
           this.removeListener("longtap", this._onContextMenuOpen);

package/source/class/qx/ui/form/AbstractField.js

@@ -462,8 +462,14 @@ qx.Class.define("qx.ui.form.AbstractField", {
       // Apply
       var styles;
       if (value) {
-        this.__font = qx.theme.manager.Font.getInstance().resolve(value);
-        if (this.__font instanceof qx.bom.webfonts.WebFont) {
+        if (qx.lang.Type.isString(value)) {
+          value = qx.theme.manager.Font.getInstance().resolve(value);
+        }
+        this.__font = value;
+        if (
+          this.__font instanceof qx.bom.webfonts.WebFont &&
+          !this.__font.isValid()
+        ) {
           this.__webfontListenerId = this.__font.addListener(
             "changeStatus",
             this._onWebFontStatusChange,

package/source/class/qx/ui/form/FileSelectorButton.js

@@ -139,6 +139,11 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
       this.__inputObject.setAttribute(attr, value);
     },
 
+    setEnabled(value){
+      this.__inputObject.setEnabled(value);
+      super.setEnabled(value);
+    },
+
     _createContentElement() {
       let id = "qxFileSelector_" + (++qx.ui.form.FileSelectorButton._fileInputElementIdCounter);
       let input = (this.__inputObject = new qx.html.Input(

package/source/class/qx/ui/table/pane/FocusIndicator.js

@@ -124,8 +124,9 @@ qx.Class.define("qx.ui.table.pane.FocusIndicator", {
               wl = deco.getWidthLeft();
             }
           }
-          var userHeight = rowHeight + (wl + wr - 2);
-          var userTop = (row - firstRow) * rowHeight - (wr - 1);
+          var userHeight = rowHeight + (wt + wb - 2);
+          var renderedRowHeight = this.__scroller.getTablePane().getRenderedRowHeight();
+          var userTop = Math.floor((row - firstRow) * renderedRowHeight) - (wt - 1);
           if (
             editing &&
             this.__scroller.getMinCellEditHeight() &&
@@ -139,9 +140,9 @@ qx.Class.define("qx.ui.table.pane.FocusIndicator", {
           }
 
           this.setUserBounds(
-            paneModel.getColumnLeft(col) - (wt - 1),
+            paneModel.getColumnLeft(col) - (wl - 1),
             userTop,
-            columnModel.getColumnWidth(col) + (wt + wb - 3),
+            columnModel.getColumnWidth(col) + (wl + wr - 3),
             userHeight
           );
 

package/source/class/qx/ui/table/pane/Pane.js

@@ -710,6 +710,20 @@ qx.Class.define("qx.ui.table.pane.Pane", {
       this.__lastColCount = colCount;
       this.__lastRowCount = rowCount;
       this.fireEvent("paneUpdated");
+    },
+
+    getRenderedRowHeight() {
+      var rowHeight = this.getTable().getRowHeight();
+
+      var elem = this.getContentElement().getDomElement();
+      if (elem && elem.firstChild) {
+        // pane has been rendered
+        var tableBody = elem.firstChild;
+        if (tableBody.childNodes && tableBody.childNodes.length > 0) {
+          rowHeight = tableBody.childNodes[0].getBoundingClientRect().height;
+        }
+      }
+      return rowHeight;
     }
   },
 

package/source/class/qx/ui/table/pane/Scroller.js

@@ -833,7 +833,7 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
       }
       var scrollbar = this.__verScrollBar;
       this.__inOnScrollY = true;
-      // calculate delta so that one row is scrolled at an minimum
+      // calculate delta so that one row is scrolled at a minimum
       var rowHeight = this.getTable().getRowHeight();
       var delta = e.getData() - e.getOldData();
       if (Math.abs(delta) > 1 && Math.abs(delta) < rowHeight) {
@@ -2037,12 +2037,12 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
 
       if (pageY >= panePos.top && pageY <= panePos.bottom) {
         // This event is in the pane -> Get the row
-        var rowHeight = this.getTable().getRowHeight();
+        var rowHeight = this.__tablePane.getRenderedRowHeight()
 
         var scrollY = this.__verScrollBar.getPosition();
 
         if (this.getTable().getKeepFirstVisibleRowComplete()) {
-          scrollY = Math.floor(scrollY / rowHeight) * rowHeight;
+          scrollY = Math.floor(scrollY / this.getTable().getRowHeight()) * rowHeight;
         }
 
         var tableY = scrollY + pageY - panePos.top;

package/source/class/qx/ui/virtual/core/Scroller.js

@@ -145,12 +145,18 @@ qx.Class.define("qx.ui.virtual.core.Scroller", {
 
     // overridden
     _onScrollBarX(e) {
-      this.__pane.setScrollX(e.getData());
+      // Use Math.round to convert possible decimal values to 
+      // integer values if a zoom level not equal to 100 is 
+      // set in the browser
+      this.__pane.setScrollX(Math.round(e.getData()));
     },
 
     // overridden
     _onScrollBarY(e) {
-      this.__pane.setScrollY(e.getData());
+      // Use Math.round to convert possible decimal values to 
+      // integer values if a zoom level not equal to 100 is 
+      // set in the browser
+      this.__pane.setScrollY(Math.round(e.getData()));
     }
   },
 

package/source/class/qx/ui/window/Window.js

@@ -639,16 +639,17 @@ qx.Class.define("qx.ui.window.Window", {
         return;
       }
 
-      if (
-        this.fireNonBubblingEvent("beforeClose", qx.event.type.Event, [
-          false,
-          true
-        ])
-      ) {
-        this.hide();
-        this.fireEvent("close");
+      if (! this.fireNonBubblingEvent(
+              "beforeClose",
+              qx.event.type.Event,
+              [ false, true ])) {
+        // preventDefault() was called
+        return;
       }
 
+      this.hide();
+      this.fireEvent("close");
+
       // If automatically destroying the window upon close was requested, do
       // so now. (Note that we explicitly re-obtain the autoDestroy property
       // value, allowing the user's close handler to enable/disable it before