@qooxdoo/framework 7.2.1 → 7.3.1

package/source/class/qx/tool/compiler/targets/meta/Browserify.js

@@ -55,9 +55,9 @@ qx.Class.define("qx.tool.compiler.targets.meta.Browserify", {
         this.__appMeta.getEnvironmentValue("qx.compiler.applicationType") ==
         "browser"
       ) {
-        // Get a Set of unique `require`d CommonJS module names from
-        // all classes
-        for (let className in db.classInfo) {
+        // Get a Set of unique `require`d CommonJS module names from classes needed by the application
+        let classnames = this.__appMeta.getApplication().getDependencies();
+        for (let className of classnames) {
           let classInfo = db.classInfo[className];
           if (classInfo.commonjsModules) {
             Object.keys(classInfo.commonjsModules).forEach(moduleName => {
@@ -121,16 +121,18 @@ qx.Class.define("qx.tool.compiler.targets.meta.Browserify", {
           let message = [];
 
           message.push(`ERROR: could not locate require()d module: "${id}"`);
-          message.push("  required from:");
-
-          try {
-            [...references[id]].forEach(refs => {
-              refs.forEach(ref => {
-                message.push(`    ${ref}`);
+          if (references[id]) {
+            message.push("  required from:");
+
+            try {
+              [...references[id]].forEach(refs => {
+                refs.forEach(ref => {
+                  message.push(`    ${ref}`);
+                });
               });
-            });
-          } catch (e) {
-            message.push(`    <compile.json:application.localModules'>`);
+            } catch (e) {
+              message.push(`    <compile.json:application.localModules'>`);
+            }
           }
 
           qx.tool.compiler.Console.error(message.join("\n"));
@@ -159,8 +161,13 @@ qx.Class.define("qx.tool.compiler.targets.meta.Browserify", {
         b.bundle((e, output) => {
           if (e) {
             // We've already handled the case of missing module. This is something else.
-            qx.tool.compiler.Console.error(`Failed: ${e}`);
-            throw e;
+            qx.tool.compiler.Console.error(
+              `Unable to browserify - this is probably because a module is being require()'d which is not compatible with Browserify: ${e.message}`
+            );
+
+            // Do not throw an error here, otherwise a problem in the users code will kill the watch with pages of error
+            resolve(null);
+            return;
           }
 
           ws.write(output);

package/source/class/qx/tool/compiler/targets/meta/Uglify.js

@@ -127,10 +127,12 @@ qx.Class.define("qx.tool.compiler.targets.meta.Uglify", {
       await fs.writeFileAsync(outJsFilename + ".map", result.map, {
         encoding: "utf8"
       });
+
       if (this._appMeta.getTarget().isSaveUnminified()) {
         await fs.writeFileAsync(outJsFilename + ".unminified", inSourceCode, {
           encoding: "utf8"
         });
+
         await fs.writeFileAsync(
           outJsFilename + ".unminified.map",
           JSON.stringify(inSourceMap, null, 2),

package/source/class/qx/tool/config/Abstract.js

@@ -299,6 +299,10 @@ qx.Class.define("qx.tool.config.Abstract", {
           );
         }
       }
+      if (data.$schema === undefined) {
+         // don't validate if there is no schema
+         this.setValidate(false);
+      }
       // load schema if validation is enabled
       if (this.isValidate() && this.getVersion() !== null) {
         // check initial data

package/source/class/qx/ui/basic/Image.js

@@ -785,7 +785,7 @@ qx.Class.define("qx.ui.basic.Image", {
       if (this.getScale()) {
         el.setStyle("fontSize", (width > height ? height : width) + "px");
       } else {
-        var source = this.getSource();
+        var source = qx.util.AliasManager.getInstance().resolve(this.getSource());
         var sparts = source.split("/");
         var font = this.__getFont(source);
         var size = parseInt(sparts[2] || font.getSize());

package/source/class/qx/ui/basic/Label.js

@@ -368,6 +368,7 @@ qx.Class.define("qx.ui.basic.Label", {
         this.__fixEllipsis();
       }
       if (rich && this.getBreakWithinWords()) {
+        styles = qx.lang.Object.clone(styles);
         styles.wordBreak = "break-all";
       }
 
@@ -461,12 +462,10 @@ qx.Class.define("qx.ui.basic.Label", {
 
     // property apply
     _applyBreakWithinWords(value, old) {
-      if (this.isRich()) {
         this.getContentElement().setStyle(
           "wordBreak",
-          value ? "break-all" : "normal"
+        this.isRich() && value ? "break-all" : "normal"
         );
-      }
     },
 
     /**

package/source/class/qx/ui/container/Composite.js

@@ -112,16 +112,5 @@ qx.Class.define("qx.ui.container.Composite", {
         child
       ]);
     }
-  },
-
-  /*
-  *****************************************************************************
-     DEFER
-  *****************************************************************************
-  */
-
-  defer(statics, members) {
-    qx.ui.core.MChildrenHandling.remap(members);
-    qx.ui.core.MLayoutHandling.remap(members);
   }
 });

package/source/class/qx/ui/control/DateChooser.js

@@ -204,6 +204,28 @@ qx.Class.define("qx.ui.control.DateChooser", {
       nullable: true,
       event: "changeValue",
       apply: "_applyValue"
+    },
+
+    /**
+     * The minimal date value of the widget. Dates which are less
+     * than this property value will be shown as disabled (not clickable).
+     */
+    minValue: {
+      check: "Date",
+      init: null,
+      nullable: true,
+      apply: "_applyMinValue"
+    },
+
+    /**
+     * The maximal date value of the widget. Dates which are greater
+     * than this property value will be shown as disabled (not clickable).
+     */
+    maxValue: {
+      check: "Date",
+      init: null,
+      nullable: true,
+      apply: "_applyMaxValue"
     }
   },
 
@@ -415,6 +437,14 @@ qx.Class.define("qx.ui.control.DateChooser", {
       }
     },
 
+    _applyMinValue(){
+      this._updateDatePane();
+    },
+
+    _applyMaxValue(){
+      this._updateDatePane();
+    },
+
     /*
     ---------------------------------------------------------------------------
       EVENT HANDLER
@@ -724,6 +754,7 @@ qx.Class.define("qx.ui.control.DateChooser", {
 
           dayLabel.setValue("" + dayOfMonth);
           dayLabel.dateTime = helpDate.getTime();
+          dayLabel.setEnabled(!this.__exceedsLimits(helpDate));
 
           // Go to the next day
           helpDate.setDate(helpDate.getDate() + 1);
@@ -733,6 +764,14 @@ qx.Class.define("qx.ui.control.DateChooser", {
       monthYearFormat.dispose();
       weekDayFormat.dispose();
       weekFormat.dispose();
+    },
+
+    __exceedsLimits(date){
+      const d = new Date(date);
+      d.setHours(0,0,0,0);
+      var exceedsMin = this.getMinValue() !== null && d < this.getMinValue();
+      var exceedsMax = this.getMaxValue() !== null && d > this.getMaxValue();
+      return exceedsMin || exceedsMax;
     }
   },
 

package/source/class/qx/ui/core/MChildrenHandling.js

@@ -178,8 +178,12 @@ qx.Mixin.define("qx.ui.core.MChildrenHandling", {
      * this methods in the defer block of the including class.
      *
      * @param members {Map} The including classes members map
+     * @deprecated {7.0} this is not necessary in modern compilers and leads to unexpected behaviour
      */
     remap(members) {
+      if (qx.core.Environment.get("qx.debug")) {
+        qx.log.Logger.debug("Calling qx.ui.core.MChildrenHandling.remap is deprecated, please dont use it");
+      }
       members.getChildren = members._getChildren;
       members.hasChildren = members._hasChildren;
       members.indexOf = members._indexOf;

package/source/class/qx/ui/core/MLayoutHandling.js

@@ -68,8 +68,12 @@ qx.Mixin.define("qx.ui.core.MLayoutHandling", {
      * this methods in the defer block of the including class.
      *
      * @param members {Map} The including classes members map
+     * @deprecated {7.0} this is not necessary in modern compilers and leads to unexpected behaviour
      */
     remap(members) {
+      if (qx.core.Environment.get("qx.debug")) {
+        qx.log.Logger.debug("Calling qx.ui.core.MLayoutHandling.remap is deprecated, please dont use it");
+      }
       members.getLayout = members._getLayout;
       members.setLayout = members._setLayout;
     }

package/source/class/qx/ui/core/MRemoteLayoutHandling.js

@@ -43,7 +43,12 @@ qx.Mixin.define("qx.ui.core.MRemoteLayoutHandling", {
      *     <code>null</code> to reset the layout.
      */
     setLayout(layout) {
-      this.getChildrenContainer().setLayout(layout);
+      var container = this.getChildrenContainer();
+      if (container === this) {
+        container._setLayout(layout);
+      } else {
+        container.setLayout(layout);
+      }
     },
 
     /**
@@ -52,7 +57,11 @@ qx.Mixin.define("qx.ui.core.MRemoteLayoutHandling", {
      * @return {qx.ui.layout.Abstract} The widget's layout manager
      */
     getLayout() {
-      return this.getChildrenContainer().getLayout();
+      var container = this.getChildrenContainer();
+      if (container === this) {
+        return container._getLayout();
+      }
+      return container.getLayout();
     }
   }
 });

package/source/class/qx/ui/form/FileSelectorButton.js

@@ -21,11 +21,11 @@
  * files from the local filesystem. A FileList is returned which allows access
  * to the content of the selected files from javascript. The file(s) can now be
  *  processed in javascript, or it/they can be uploaded to a server.
- * 
+ *
  * *Example*
  *
  * Post the content of the file to the server.
- * 
+ *
  * ```javascript
  * let button = new qx.ui.form.FileSelectorButton("Select File");
  * button.addListener('changeFileSelection',function(e){
@@ -40,9 +40,9 @@
  *   });
  * });
  * ```
- * 
+ *
  * Process the file directly in javascript using the FileReader API.
- * 
+ *
  * ```javascript
  * let button = new qx.ui.form.FileSelectorButton("Select File");
  * button.addListener('changeFileSelection',function(e){
@@ -55,14 +55,18 @@
  *   const file = fileList[0];
  *   reader.readAsText(file.slice(0,4));
  * });
-
-*
+ * ```
+ *
  * [MDN Documentation](https://developer.mozilla.org/en-US/docs/Web/API/File_API/Using_files_from_web_applications)
  */
 
-let InputElementIdCounter = 0;
 qx.Class.define("qx.ui.form.FileSelectorButton", {
   extend: qx.ui.form.Button,
+
+  statics: {
+    _fileInputElementIdCounter: 0
+  },
+
   events: {
     /**
      * The event is fired when the file selection changes.
@@ -72,6 +76,7 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
      */
     changeFileSelection: "qx.event.type.Data"
   },
+
   properties: {
     /**
      * What type of files should be offered in the fileselection dialog.
@@ -87,6 +92,7 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
       check: "String",
       apply: "_applyAttribute"
     },
+
     /**
      * Specify that the camera should be used for getting the "file". The
      * value defines which camera should be used for capturing images.
@@ -98,6 +104,7 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
       check: ["user", "environment"],
       apply: "_applyAttribute"
     },
+
     /**
      * Set to "true" if you want to allow the selection of multiple files.
      */
@@ -106,6 +113,7 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
       check: "Boolean",
       apply: "_applyAttribute"
     },
+
     /**
      * If present, indicates that only directories should be available for
      * selection.
@@ -116,13 +124,14 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
       apply: "_applyAttribute"
     }
   },
+
   members: {
     __inputObject: null,
 
-    _applyAttribute: function (value, old, attr) {
+    _applyAttribute(value, old, attr) {
       if (attr === "directoriesOnly") {
         // while the name of the attribute indicates that this only
-        // works for webkit borwsers, this is not the case. These
+        // works for webkit browsers, this is not the case. These
         // days the attribute is supported by
         // [everyone](https://caniuse.com/?search=webkitdirectory).
         attr = "webkitdirectory";
@@ -130,22 +139,25 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
       this.__inputObject.setAttribute(attr, value);
     },
 
-    _createContentElement: function () {
-      let id = "qxFileSelector_" + InputElementIdCounter++;
+    _createContentElement() {
+      let id = "qxFileSelector_" + (++qx.ui.form.FileSelectorButton._fileInputElementIdCounter);
       let input = (this.__inputObject = new qx.html.Input(
         "file",
-        { display: "none" },
+        null,
         { id: id }
       ));
+
       let label = new qx.html.Element("label", {}, { for: id });
-      label.addListenerOnce(
-        "appear",
-        e => {
-          label.add(input);
-        }
-      );
+      label.addListenerOnce("appear", e => {
+        label.add(input);
+      });
+
       input.addListenerOnce("appear", e => {
         let inputEl = input.getDomElement();
+        // since qx.html.Node does not even create the
+        // domNode if it is not set to visible initially
+        // we have to quickly hide it after creation.
+        input.setVisible(false);
         inputEl.addEventListener("change", e => {
           this.fireDataEvent("changeFileSelection", inputEl.files);
           inputEl.value = "";

package/source/class/qx/ui/form/MForm.js

@@ -55,8 +55,9 @@ qx.Mixin.define("qx.ui.form.MForm", {
      * Message which is shown in an invalid tooltip.
      */
     invalidMessage: {
+      init: null,
+      nullable: true,
       check: "String",
-      init: "",
       event: "changeInvalidMessage"
     },
 
@@ -67,7 +68,7 @@ qx.Mixin.define("qx.ui.form.MForm", {
     requiredInvalidMessage: {
       check: "String",
       nullable: true,
-      event: "changeInvalidMessage"
+      event: "changeRequiredInvalidMessage"
     }
   },
 

package/source/class/qx/ui/form/Slider.js

@@ -80,17 +80,17 @@ qx.Class.define("qx.ui.form.Slider", {
     this.getContentElement().setAttribute("role", "slider");
 
     // Add listeners
-    this.addListener("keypress", this._onKeyPress);
-    this.addListener("roll", this._onRoll);
-    this.addListener("pointerdown", this._onPointerDown);
-    this.addListener("pointerup", this._onPointerUp);
-    this.addListener("losecapture", this._onPointerUp);
-    this.addListener("resize", this._onUpdate);
+    this.addListener("keypress", this._onKeyPress, this);
+    this.addListener("roll", this._onRoll, this);
+    this.addListener("pointerdown", this._onPointerDown, this);
+    this.addListener("pointerup", this._onPointerUp, this);
+    this.addListener("losecapture", this._onPointerUp, this);
+    this.addListener("resize", this._onUpdate, this);
 
     // Stop events
-    this.addListener("contextmenu", this._onStopEvent);
-    this.addListener("tap", this._onStopEvent);
-    this.addListener("dbltap", this._onStopEvent);
+    this.addListener("contextmenu", this._onStopEvent, this);
+    this.addListener("tap", this._onStopEvent, this);
+    this.addListener("dbltap", this._onStopEvent, this);
 
     // Initialize orientation
     if (orientation != null) {
@@ -256,8 +256,8 @@ qx.Class.define("qx.ui.form.Slider", {
           control = new qx.ui.core.Widget();
 
           control.addListener("resize", this._onUpdate, this);
-          control.addListener("pointerover", this._onPointerOver);
-          control.addListener("pointerout", this._onPointerOut);
+          control.addListener("pointerover", this._onPointerOver, this);
+          control.addListener("pointerout", this._onPointerOut, this);
           this._add(control);
           break;
       }
@@ -437,7 +437,7 @@ qx.Class.define("qx.ui.form.Slider", {
       }
 
       // Register move listener
-      this.addListener("pointermove", this._onPointerMove);
+      this.addListener("pointermove", this._onPointerMove, this);
 
       // Activate capturing
       this.capture();
@@ -524,7 +524,7 @@ qx.Class.define("qx.ui.form.Slider", {
       }
 
       // Remove move listener again
-      this.removeListener("pointermove", this._onPointerMove);
+      this.removeListener("pointermove", this._onPointerMove, this);
 
       // Stop event
       if (e.getType() === "pointerup") {

package/source/class/qx/ui/form/validation/Manager.js

@@ -482,7 +482,13 @@ qx.Class.define("qx.ui.form.validation.Manager", {
               continue;
             }
 
-            tooltip.setLabel(item.getInvalidMessage());
+            let msg = item.getInvalidMessage();
+            if (!msg && qx.core.Environment.get("qx.ui.form.validation.Manager.allowDefaultInvalidMessage")) {
+              msg = "Invalid field";
+            } else if (qx.core.Environment.get("qx.debug")) {
+              this.assertTrue(msg != null && msg.length > 0);
+            }
+            tooltip.setLabel(msg);
 
             if (tooltip.getPlaceMethod() == "mouse") {
               var location = item.getContentLocation();
@@ -531,12 +537,25 @@ qx.Class.define("qx.ui.form.validation.Manager", {
       for (var i = 0; i < this.__formItems.length; i++) {
         var formItem = this.__formItems[i].item;
         if (!formItem.getValid()) {
-          messages.push(formItem.getInvalidMessage());
+          let msg = formItem.getInvalidMessage();
+          if (!msg && qx.core.Environment.get("qx.ui.form.validation.Manager.allowDefaultInvalidMessage")) {
+            msg = "Invalid field";
+          } else if (qx.core.Environment.get("qx.debug")) {
+            this.assertTrue(msg !== null && msg.length > 0);
+          }
+          messages.push(msg);
         }
       }
+
       // add the forms fail message
-      if (this.getInvalidMessage() != "") {
-        messages.push(this.getInvalidMessage());
+      if (!this.isValid()) {
+        let msg = this.getInvalidMessage();
+        if (!msg && qx.core.Environment.get("qx.ui.form.validation.Manager.allowDefaultInvalidMessage")) {
+          msg = "Invalid field";
+        } else if (qx.core.Environment.get("qx.debug")) {
+          this.assertTrue(msg !== null && msg.length > 0);
+        }
+        messages.push(msg);
       }
 
       return messages;
@@ -643,5 +662,11 @@ qx.Class.define("qx.ui.form.validation.Manager", {
   destruct() {
     this._showToolTip(true);
     this.__formItems = null;
+  },
+
+  environment: {
+    // Whether to assume a default "Invalid Field" message for invalid fields; if false, an 
+    //  exception will be raised if invalid fields do not have an `invalidMessage`
+    "qx.ui.form.validation.Manager.allowDefaultInvalidMessage": true
   }
 });

package/source/class/qx/ui/layout/Canvas.js

@@ -286,7 +286,10 @@ qx.Class.define("qx.ui.layout.Canvas", {
           if (top == null && bottom == null) {
             switch (child.getAlignY()) {
               case "middle":
-                top = Math.round((availHeight - size.height) / 2 - marginBottom);
+                top = Math.round(
+                  (availHeight - size.height) / 2 - marginBottom
+                );
+
                 break;
               case "bottom":
                 bottom = 0;

package/source/class/qx/ui/tabview/Page.js

@@ -256,6 +256,15 @@ qx.Class.define("qx.ui.tabview.Page", {
     ---------------------------------------------------------------------------
     */
 
+    /**
+     * By default, widgets are added to `this`
+     *
+     * @return {qx.ui.core.Widget} the widget to add to
+     */
+    getChildrenContainer() {
+      return this;
+    },
+
     /**
      * Returns the button used within this page. This method is used by
      * the TabView to access the button.

package/source/class/qx/ui/tabview/ScrollingPage.js

@@ -0,0 +1,54 @@
+/* ************************************************************************
+
+   qooxdoo - the new era of web development
+
+   http://qooxdoo.org
+
+   Copyright:
+     2022 Zenesis Limited, https://www.zenesis.com
+
+   License:
+     MIT: https://opensource.org/licenses/MIT
+     See the LICENSE file in the project's top-level directory for details.
+
+   Authors:
+     * John Spackman (johnspackman)
+
+************************************************************************ */
+
+/**
+ * A scrolling page uses a `qx.ui.container.Scroll` to make sure that the contents
+ * never cause the parent TabView to size outside of it's natural boundaries; a
+ * side effect of this is that if you use all `ScrollingPage` and do not use `Page`
+ * instances, then the tabview will be very small unless you use a layout which will
+ * expand the TabView.
+ */
+qx.Class.define("qx.ui.tabview.ScrollingPage", {
+  extend: qx.ui.tabview.Page,
+
+  /**
+   * @param label {String} Initial label of the tab
+   * @param icon {String} Initial icon of the tab
+   */
+  construct(label, icon) {
+    super(label, icon);
+    this._setLayout(new qx.ui.layout.Grow());
+    this.__childContainer = new qx.ui.container.Composite();
+    let scroll = new qx.ui.container.Scroll(this.__childContainer);
+    this._add(scroll);
+  },
+
+  members: {
+    /** @type{qx.ui.core.Widget} the container that the user's children are added to */
+    __childContainer: null,
+
+    /**
+     * Make sure that children are added to the scrolling container
+     *
+     * @return {qx.ui.core.Widget} the widget to add to
+     */
+    getChildrenContainer() {
+      return this.__childContainer;
+    }
+  }
+});

package/source/class/qx/ui/toolbar/FileSelectorButton.js

@@ -22,8 +22,8 @@
 
 qx.Class.define("qx.ui.toolbar.FileSelectorButton", {
   extend: qx.ui.form.FileSelectorButton,
-  construct: function (label, icon, command) {
-    this.base(arguments, label, icon, command);
+  construct(label, icon, command) {
+    super(label, icon, command);
     // Toolbar buttons should not support the keyboard events
     this.removeListener("keydown", this._onKeyDown);
     this.removeListener("keyup", this._onKeyUp);
@@ -33,10 +33,12 @@ qx.Class.define("qx.ui.toolbar.FileSelectorButton", {
       refine: true,
       init: "toolbar-button"
     },
+
     show: {
       refine: true,
       init: "inherit"
     },
+
     focusable: {
       refine: true,
       init: false
@@ -45,8 +47,8 @@ qx.Class.define("qx.ui.toolbar.FileSelectorButton", {
 
   members: {
     // overridden
-    _applyVisibility: function (value, old) {
-      this.base(arguments, value, old);
+    _applyVisibility(value, old) {
+      super._applyVisibility(value, old);
       // trigger a appearance recalculation of the parent
       let parent = this.getLayoutParent();
       if (parent && parent instanceof qx.ui.toolbar.PartContainer) {

package/source/class/qx/ui/toolbar/ToolBar.js

@@ -41,14 +41,18 @@ qx.Class.define("qx.ui.toolbar.ToolBar", {
   *****************************************************************************
   */
 
-  construct() {
+  /**
+   * Constructor
+   * @param {qx.ui.layout.Abstract?} layout optional layout, defaults to qx.ui.layout.HBox
+   */
+  construct(layout) {
     super();
 
     // ARIA attrs
     this.getContentElement().setAttribute("role", "toolbar");
 
     // add needed layout
-    this._setLayout(new qx.ui.layout.HBox());
+    this._setLayout(layout || new qx.ui.layout.HBox());
 
     // initialize the overflow handling
     this.__removedItems = [];

package/source/resource/qx/tool/schema/compile-1-0-0.json

@@ -224,6 +224,10 @@
             "description": "The folder where the deploy outputs to.",
             "type": "string"
           },
+          "proxySourcePath": {
+            "description": "The folder containing proxy classes (normally machine generated) to take precedence over those found in normal library sources",
+            "type": "string"
+          },
           "targetClass": {
             "description": "If you want to use more than the two default target types and/or use custom target classes, you can use the targetClass key to supply the name of the class as a string.",
             "type": "string"