@qooxdoo/framework 7.1.1 → 7.2.0

package/source/class/qx/ui/form/VirtualSelectBox.js

@@ -511,46 +511,30 @@ qx.Class.define("qx.ui.form.VirtualSelectBox", {
       this._add(input);
 
       var dropdown = this.getChildControl("dropdown");
-      dropdown.addListener(
-        "appear",
-        function () {
-          // we must delay so that the focus is only set once the list is ready
-          window.setTimeout(function () {
-            input.focus();
-          }, 0);
-        },
-        this
-      );
+      dropdown.addListener("appear", () => {
+        // we must delay so that the focus is only set once the list is ready
+        window.setTimeout(function () {
+          input.focus();
+        }, 0);
+      });
 
-      dropdown.addListener(
-        "disappear",
-        function () {
-          input.blur();
-          // clear filter
-          var sel = this.getValue();
-          input.resetValue();
-          this.setValue(sel);
-        },
-        this
-      );
+      dropdown.addListener("disappear", () => {
+        input.blur();
+        // clear filter
+        var sel = this.getValue();
+        input.resetValue();
+        this.setValue(sel);
+      });
 
-      input.addListener(
-        "blur",
-        function (e) {
-          this.close();
-        },
-        this
-      );
+      input.addListener("blur", e => {
+        this.close();
+      });
 
-      input.addListener(
-        "changeValue",
-        function (e) {
-          if (this.__filterUpdateRunning === 0) {
-            this.__updateDelegate();
-          }
-        },
-        this
-      );
+      input.addListener("changeValue", e => {
+        if (this.__filterUpdateRunning === 0) {
+          this.__updateDelegate();
+        }
+      });
     },
 
     __getHighlightStyleFromAppearance() {

package/source/class/qx/ui/layout/Canvas.js

@@ -235,7 +235,7 @@ qx.Class.define("qx.ui.layout.Canvas", {
           if (left == null && right == null) {
             switch (child.getAlignX()) {
               case "center":
-                left = (availWidth - size.width) / 2 - marginRight;
+                left = Math.round((availWidth - size.width) / 2 - marginRight);
                 break;
               case "right":
                 right = 0;
@@ -286,7 +286,7 @@ qx.Class.define("qx.ui.layout.Canvas", {
           if (top == null && bottom == null) {
             switch (child.getAlignY()) {
               case "middle":
-                top = (availHeight - size.height) / 2 - marginBottom;
+                top = Math.round((availHeight - size.height) / 2 - marginBottom);
                 break;
               case "bottom":
                 bottom = 0;

package/source/class/qx/ui/mobile/container/MIScroll.js

@@ -165,13 +165,9 @@ qx.Mixin.define("qx.ui.mobile.container.MIScroll", {
         loader.open("GET", path);
         loader.send();
       } else {
-        this.addListenerOnce(
-          "appear",
-          function () {
-            this._setScroll(this.__createScrollInstance());
-          },
-          this
-        );
+        this.addListenerOnce("appear", () => {
+          this._setScroll(this.__createScrollInstance());
+        });
       }
     },
 

package/source/class/qx/ui/progressive/headfoot/Progress.js

@@ -124,45 +124,33 @@ qx.Class.define("qx.ui.progressive.headfoot.Progress", {
 
       // Listen for the "renderStart" event, to save the number of elements on
       // the queue, and to set ourself visible
-      progressive.addListener(
-        "renderStart",
-        function (e) {
-          this.__total = e.getData().initial;
-          this.show();
-        },
-        this
-      );
+      progressive.addListener("renderStart", e => {
+        this.__total = e.getData().initial;
+        this.show();
+      });
 
       // Listen for the "progress" event, to update the progress bar
-      progressive.addListener(
-        "progress",
-        function (e) {
-          var complete = 1.0 - e.getData().remaining / this.__total;
-          var mySize = this.getBounds();
-          if (mySize) {
-            var barWidth = Math.floor(
-              (mySize.width - this.__percentDone.getBounds().width) * complete
-            );
-
-            var percent = Math.floor(complete * 100) + "%";
-
-            if (!isNaN(barWidth)) {
-              this.__progressBar.setMinWidth(barWidth);
-              this.__percentDone.setLabel(percent);
-            }
+      progressive.addListener("progress", e => {
+        var complete = 1.0 - e.getData().remaining / this.__total;
+        var mySize = this.getBounds();
+        if (mySize) {
+          var barWidth = Math.floor(
+            (mySize.width - this.__percentDone.getBounds().width) * complete
+          );
+
+          var percent = Math.floor(complete * 100) + "%";
+
+          if (!isNaN(barWidth)) {
+            this.__progressBar.setMinWidth(barWidth);
+            this.__percentDone.setLabel(percent);
           }
-        },
-        this
-      );
+        }
+      });
 
       // Listen for the "renderEnd" event to make ourself invisible
-      progressive.addListener(
-        "renderEnd",
-        function (e) {
-          this.exclude();
-        },
-        this
-      );
+      progressive.addListener("renderEnd", e => {
+        this.exclude();
+      });
     }
   },
 

package/source/class/qx/ui/progressive/renderer/table/Row.js

@@ -285,7 +285,7 @@ qx.Class.define("qx.ui.progressive.renderer.table.Row", {
           dataIndex: i,
           cellData: data[i],
           height: height,
-          rowRenderer: this     // useful, e.g., for getting default row height
+          rowRenderer: this // useful, e.g., for getting default row height
         };
 
         // Render this cell

package/source/class/qx/ui/splitpane/Pane.js

@@ -156,32 +156,24 @@ qx.Class.define("qx.ui.splitpane.Pane", {
       var splitter = this.getChildControl("splitter");
       var splitterWidth = splitter.getWidth();
       if (!splitterWidth) {
-        splitter.addListenerOnce(
-          "appear",
-          function () {
-            this.__setBlockerPosition();
-          },
-          this
-        );
+        splitter.addListenerOnce("appear", () => {
+          this.__setBlockerPosition();
+        });
       }
 
       // resize listener to remove the blocker in case the splitter
       // is removed.
-      splitter.addListener(
-        "resize",
-        function (e) {
-          var bounds = e.getData();
-          if (
-            this.getChildControl("splitter").isKnobVisible() &&
-            (bounds.height == 0 || bounds.width == 0)
-          ) {
-            this.__blocker.hide();
-          } else {
-            this.__blocker.show();
-          }
-        },
-        this
-      );
+      splitter.addListener("resize", e => {
+        var bounds = e.getData();
+        if (
+          this.getChildControl("splitter").isKnobVisible() &&
+          (bounds.height == 0 || bounds.width == 0)
+        ) {
+          this.__blocker.hide();
+        } else {
+          this.__blocker.show();
+        }
+      });
     },
 
     /**

package/source/class/qx/ui/table/MTableContextMenu.js

@@ -24,77 +24,69 @@ qx.Mixin.define("qx.ui.table.MTableContextMenu", {
     // Add an event listener to handle context menu events.  The actual menu
     // is built by a function registered with a call to
     // setContextMenuHandler(col, handler).
-    this.addListener(
-      "cellContextmenu",
-      function (e) {
-        var contextMenu = this.getContextMenu();
-
-        // Dispose of any previously existing context menu
-        if (contextMenu && !contextMenu.isDisposed()) {
-          // Dispose of the context menu.
-          contextMenu.hide();
-          this.setContextMenu(null);
-          this.getApplicationRoot().remove(contextMenu);
-          contextMenu.dispose();
-          contextMenu = null;
-        }
-
-        // Get the context menu handler for the column on which the context
-        // menu request was issued.
-        var col = e.getColumn();
-        var contextMenuHandler = this.getContextMenuHandler(col);
-
-        // If there's no context menu handler for this column, we have nothing
-        // to do.
-        if (typeof contextMenuHandler !== "function") {
-          return;
-        }
-
-        // Get the context object for the handler function
-        var handlerContext = this.__contextMenuHandlerContext[col];
-
-        // Get the data model
-        var tableModel = this.getTableModel();
-
-        // Create a context menu for this tree.
-        contextMenu = new qx.ui.menu.Menu();
-
-        // Don't display context menus from the context menu
-        contextMenu.addListener("contextmenu", function (e) {
-          e.preventDefault();
-        });
-
-        // This prevents the display of context menu on table header cells
-        contextMenu.addListenerOnce(
-          "disappear",
-          function () {
-            this.setContextMenu(null);
-          },
-          this
-        );
-
-        // Call the context menu handler for this column.
-        var bShowContextMenu = contextMenuHandler.call(
-          handlerContext,
-          col,
-          e.getRow(),
-          this,
-          tableModel,
-          contextMenu
-        );
-
-        // If we were told not to display the context menu...
-        if (!bShowContextMenu) {
-          // ... then we're all done here.
-          contextMenu.dispose();
-          return;
-        }
-
-        // Set the context menu
-        this.setContextMenu(contextMenu);
-      },
-      this
-    );
+    this.addListener("cellContextmenu", e => {
+      var contextMenu = this.getContextMenu();
+
+      // Dispose of any previously existing context menu
+      if (contextMenu && !contextMenu.isDisposed()) {
+        // Dispose of the context menu.
+        contextMenu.hide();
+        this.setContextMenu(null);
+        this.getApplicationRoot().remove(contextMenu);
+        contextMenu.dispose();
+        contextMenu = null;
+      }
+
+      // Get the context menu handler for the column on which the context
+      // menu request was issued.
+      var col = e.getColumn();
+      var contextMenuHandler = this.getContextMenuHandler(col);
+
+      // If there's no context menu handler for this column, we have nothing
+      // to do.
+      if (typeof contextMenuHandler !== "function") {
+        return;
+      }
+
+      // Get the context object for the handler function
+      var handlerContext = this.__contextMenuHandlerContext[col];
+
+      // Get the data model
+      var tableModel = this.getTableModel();
+
+      // Create a context menu for this tree.
+      contextMenu = new qx.ui.menu.Menu();
+
+      // Don't display context menus from the context menu
+      contextMenu.addListener("contextmenu", function (e) {
+        e.preventDefault();
+      });
+
+      // This prevents the display of context menu on table header cells
+      contextMenu.addListenerOnce("disappear", () => {
+        this.setContextMenu(null);
+      });
+
+      // Call the context menu handler for this column.
+      var bShowContextMenu = contextMenuHandler.call(
+        handlerContext,
+        col,
+        e.getRow(),
+        this,
+        tableModel,
+        contextMenu
+      );
+
+      // If we were told not to display the context menu...
+      if (!bShowContextMenu) {
+        // ... then we're all done here.
+        contextMenu.dispose();
+        return;
+      }
+
+      // Set the context menu
+      this.setContextMenu(contextMenu);
+    });
 
     // Provide an array in which context menu handlers will be stored.  The
     // array is indexed by column number.

package/source/class/qx/ui/table/Table.js

@@ -1720,13 +1720,9 @@ qx.Class.define("qx.ui.table.Table", {
       // if the dom element is not available, the table hasn't been rendered
       if (!elem) {
         // postpone the scroll until the table has appeared
-        this.addListenerOnce(
-          "appear",
-          function () {
-            this.scrollCellVisible(col, row);
-          },
-          this
-        );
+        this.addListenerOnce("appear", () => {
+          this.scrollCellVisible(col, row);
+        });
       }
 
       var columnModel = this.getTableColumnModel();

package/source/class/qx/ui/table/model/Abstract.js

@@ -73,7 +73,8 @@ qx.Class.define("qx.ui.table.model.Abstract", {
      * current implementations so only introduce the change from QX v8.
      * Ref: https://github.com/qooxdoo/qooxdoo/pull/10377#discussion_r818697343
      */
-    THROW_ON_MODEL_CHANGE_DURING_EDIT: parseInt(qx.core.Environment.get("qx.version"), 10) >= 8
+    THROW_ON_MODEL_CHANGE_DURING_EDIT:
+      parseInt(qx.core.Environment.get("qx.version"), 10) >= 8
   },
 
   members: {
@@ -320,7 +321,9 @@ qx.Class.define("qx.ui.table.model.Abstract", {
         return;
       }
       if (this.getTable() && this.getTable().isEditing()) {
-        throw new Error("A cell is currently being edited. Commit or cancel the edit before setting the table data");
+        throw new Error(
+          "A cell is currently being edited. Commit or cancel the edit before setting the table data"
+        );
       }
     }
   },

package/source/class/qx/ui/table/pane/Scroller.js

@@ -1852,18 +1852,14 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
         } else {
           // prevent tap event from bubbling up to the table
           this.__focusIndicatorPointerDownListener =
-            this.__focusIndicator.addListener(
-              "pointerdown",
-              function (e) {
-                this.__lastPointerDownCell = {
-                  row: this.__focusedRow,
-                  col: this.__focusedCol
-                };
-
-                e.stopPropagation();
-              },
-              this
-            );
+            this.__focusIndicator.addListener("pointerdown", e => {
+              this.__lastPointerDownCell = {
+                row: this.__focusedRow,
+                col: this.__focusedCol
+              };
+
+              e.stopPropagation();
+            });
 
           this._updateFocusIndicator(true);
           this.__focusIndicator.add(this._cellEditor);

package/source/class/qx/ui/toolbar/FileSelectorButton.js

@@ -0,0 +1,57 @@
+/* ************************************************************************
+
+   qooxdoo
+
+   https://qooxdoo.org
+
+   Copyright:
+     2022 OETIKER+PARTNER AG
+
+   License:
+     MIT: https://opensource.org/licenses/MIT
+     See the LICENSE file in the project's top-level directory for details.
+
+   Authors:
+     * Tobias Oetiker (oetiker)
+
+************************************************************************ */
+
+/**
+ * A toolbar-aware version of the {@link qx.ui.form.FileSelectorButton}.
+ */
+
+qx.Class.define("qx.ui.toolbar.FileSelectorButton", {
+  extend: qx.ui.form.FileSelectorButton,
+  construct: function (label, icon, command) {
+    this.base(arguments, label, icon, command);
+    // Toolbar buttons should not support the keyboard events
+    this.removeListener("keydown", this._onKeyDown);
+    this.removeListener("keyup", this._onKeyUp);
+  },
+  properties: {
+    appearance: {
+      refine: true,
+      init: "toolbar-button"
+    },
+    show: {
+      refine: true,
+      init: "inherit"
+    },
+    focusable: {
+      refine: true,
+      init: false
+    }
+  },
+
+  members: {
+    // overridden
+    _applyVisibility: function (value, old) {
+      this.base(arguments, value, old);
+      // trigger a appearance recalculation of the parent
+      let parent = this.getLayoutParent();
+      if (parent && parent instanceof qx.ui.toolbar.PartContainer) {
+        qx.ui.core.queue.Appearance.add(parent);
+      }
+    }
+  }
+});

package/source/class/qx/ui/toolbar/Part.js

@@ -105,13 +105,9 @@ qx.Class.define("qx.ui.toolbar.Part", {
           control = new qx.ui.toolbar.PartContainer();
           control.addListener("syncAppearance", this.__onSyncAppearance, this);
           this._add(control);
-          control.addListener(
-            "changeChildren",
-            function () {
-              this.__onSyncAppearance();
-            },
-            this
-          );
+          control.addListener("changeChildren", () => {
+            this.__onSyncAppearance();
+          });
 
           break;
       }

package/source/class/qx/ui/tree/VirtualTree.js

@@ -526,15 +526,11 @@ qx.Class.define("qx.ui.tree.VirtualTree", {
       this._layer = this._provider.createLayer();
       this._layer.addListener("updated", this._onUpdated, this);
       this.getPane().addLayer(this._layer);
-      this.getPane().addListenerOnce(
-        "resize",
-        function (e) {
-          // apply width to pane on first rendering pass
-          // to avoid visible flickering
-          this.getPane().getColumnConfig().setItemSize(0, e.getData().width);
-        },
-        this
-      );
+      this.getPane().addListenerOnce("resize", e => {
+        // apply width to pane on first rendering pass
+        // to avoid visible flickering
+        this.getPane().getColumnConfig().setItemSize(0, e.getData().width);
+      });
     },
 
     // Interface implementation

package/source/class/qx/ui/treevirtual/MNode.js

@@ -171,7 +171,7 @@ qx.Mixin.define("qx.ui.treevirtual.MNode", {
       var model = this.getTableModel();
       model.getData().forEach(node => {
         if (node) {
-          model.setState(node.nodeId, {bOpened: true}, true);
+          model.setState(node.nodeId, { bOpened: true }, true);
         }
       });
       model.setData();
@@ -184,7 +184,7 @@ qx.Mixin.define("qx.ui.treevirtual.MNode", {
       var model = this.getTableModel();
       model.getData().forEach(node => {
         if (node) {
-          model.setState(node.nodeId, {bOpened: false}, true);
+          model.setState(node.nodeId, { bOpened: false }, true);
         }
       });
       model.setData();
@@ -225,7 +225,9 @@ qx.Mixin.define("qx.ui.treevirtual.MNode", {
         this.getTableModel().setState(node.nodeId, { bOpened: opened }, true);
       }
       if (cascade) {
-        node.children.forEach(child => this.nodeSetOpened(child, opened, cascade, true));
+        node.children.forEach(child =>
+          this.nodeSetOpened(child, opened, cascade, true)
+        );
       }
       if (!cascade || !isRecursed) {
         this.getTableModel().setData();

package/source/class/qx/ui/treevirtual/TreeVirtual.js

@@ -170,13 +170,9 @@ qx.Class.define("qx.ui.treevirtual.TreeVirtual", {
     super(custom.dataModel, custom);
 
     // Arrange to redisplay edited data following editing
-    this.addListener(
-      "dataEdited",
-      function (e) {
-        this.getDataModel().setData();
-      },
-      this
-    );
+    this.addListener("dataEdited", e => {
+      this.getDataModel().setData();
+    });
 
     // By default, present the column visibility button only if there are
     // multiple columns.