@qooxdoo/framework 7.1.0 → 7.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@qooxdoo/framework",
-  "version": "7.1.0",
+  "version": "7.2.1",
   "description": "The JS Framework for Coders",
   "author": "The qooxdoo project",
   "keywords": [
@@ -51,7 +51,7 @@
     "bin/deploy"
   ],
   "dependencies": {
-    "@babel/core": "^7.12.10",
+    "@babel/core": "^7.17.10",
     "@babel/eslint-parser": "^7.16.3",
     "@babel/generator": "^7.12.11",
     "@babel/parser": "^7.12.11",
@@ -60,12 +60,14 @@
     "@babel/plugin-syntax-jsx": "^7.16.7",
     "@babel/plugin-transform-block-scoping": "^7.12.12",
     "@babel/plugin-transform-react-jsx": "^7.12.12",
-    "@babel/preset-env": "^7.12.11",
+    "@babel/preset-env": "^7.17.10",
     "@babel/preset-react": "^7.12.10",
     "@babel/preset-typescript": "^7.12.7",
     "@babel/traverse": "^7.12.12",
     "@babel/types": "^7.12.12",
     "@foliojs-fork/fontkit": "^1.9.1",
+    "@metalsmith/layouts": "^2.5.1",
+    "@metalsmith/markdown": "^1.5.0",
     "@octokit/rest": "^18.0.15",
     "@qooxdoo/eslint-config-jsdoc-disable": "^1.0.3",
     "@qooxdoo/eslint-config-qx": "^2.0.1",
@@ -73,6 +75,7 @@
     "ajv": "^8.8.1",
     "app-module-path": "^2.2.0",
     "async": "^2.6.3",
+    "babelify": "^10.0.0",
     "better-ajv-errors": "^1.1.1",
     "browserify": "^17.0.0",
     "chokidar": "^3.5.1",
@@ -95,9 +98,7 @@
     "inquirer": "^7.3.3",
     "json-stable-stringify": "^1.0.1",
     "jstransformer-dot": "^0.1.2",
-    "metalsmith": "^2.3.0",
-    "metalsmith-layouts": "^2.3.1",
-    "metalsmith-markdown": "^1.3.0",
+    "metalsmith": "^2.4.3",
     "node-fetch": "^2.6.7",
     "object-hash": "^2.1.1",
     "prettier": "^2.5.1",
@@ -108,9 +109,9 @@
     "semver": "^7.3.4",
     "set-value": "^4.1.0",
     "showdown": "^1.9.1",
-    "source-map": "^0.5.7",
+    "source-map-js": "^1.0.2",
     "tap-colorize": "^1.2.0",
-    "terser": "^5.10.0",
+    "terser": "^5.14.1",
     "tmp": "0.2.1",
     "unset-value": "^1.0.0",
     "upath": "^1.2.0",

package/source/class/qx/Interface.js

@@ -255,21 +255,19 @@ qx.Bootstrap.define("qx.Interface", {
           } else {
             // Other members are not checked more detailed because of
             // JavaScript's loose type handling
-            if (typeof object[key] === undefined) {
-              if (typeof object[key] !== "function") {
-                if (shouldThrow) {
-                  throw new Error(
-                    'Implementation of member "' +
-                      key +
-                      '" is missing in class "' +
-                      clazz.classname +
-                      '" required by interface "' +
-                      iface.name +
-                      '"'
-                  );
-                } else {
-                  return false;
-                }
+            if (typeof object[key] === "undefined") {
+              if (shouldThrow) {
+                throw new Error(
+                  'Implementation of member "' +
+                    key +
+                    '" is missing in class "' +
+                    clazz.classname +
+                    '" required by interface "' +
+                    iface.name +
+                    '"'
+                );
+              } else {
+                return false;
               }
             }
           }

package/source/class/qx/dev/unit/MTestLoader.js

@@ -91,39 +91,31 @@ qx.Mixin.define("qx.dev.unit.MTestLoader", {
     runStandAlone() {
       var testResult = new qx.dev.unit.TestResult();
 
-      testResult.addListener(
-        "failure",
-        function (e) {
-          var ex = e.getData()[0].exception;
-          var test = e.getData()[0].test;
-          this.error(
-            "Test '" +
-              test.getFullName() +
-              "' failed: " +
-              ex.message +
-              " - " +
-              ex.getComment()
-          );
-
-          if (ex.getStackTrace) {
-            this.error("Stack trace: " + ex.getStackTrace().join("\n"));
-          }
-        },
-        this
-      );
-
-      testResult.addListener(
-        "error",
-        function (e) {
-          var ex = e.getData()[0].exception;
-          var test = e.getData()[0].test;
-          this.error(
-            "The test '" + test.getFullName() + "' had an error: " + ex,
-            ex
-          );
-        },
-        this
-      );
+      testResult.addListener("failure", e => {
+        var ex = e.getData()[0].exception;
+        var test = e.getData()[0].test;
+        this.error(
+          "Test '" +
+            test.getFullName() +
+            "' failed: " +
+            ex.message +
+            " - " +
+            ex.getComment()
+        );
+
+        if (ex.getStackTrace) {
+          this.error("Stack trace: " + ex.getStackTrace().join("\n"));
+        }
+      });
+
+      testResult.addListener("error", e => {
+        var ex = e.getData()[0].exception;
+        var test = e.getData()[0].test;
+        this.error(
+          "The test '" + test.getFullName() + "' had an error: " + ex,
+          ex
+        );
+      });
 
       this.getSuite().run(testResult);
     },

package/source/class/qx/dev/unit/TestResult.js

@@ -125,20 +125,16 @@ qx.Class.define("qx.dev.unit.TestResult", {
 
       var testClass = test.getTestClass();
       if (!testClass.hasListener("assertionFailed")) {
-        testClass.addListener(
-          "assertionFailed",
-          function (ev) {
-            var error = [
-              {
-                exception: ev.getData(),
-                test: test
-              }
-            ];
+        testClass.addListener("assertionFailed", ev => {
+          var error = [
+            {
+              exception: ev.getData(),
+              test: test
+            }
+          ];
 
-            this.fireDataEvent("failure", error);
-          },
-          this
-        );
+          this.fireDataEvent("failure", error);
+        });
       }
 
       if (resume && !this._timeout[test.getFullName()]) {

package/source/class/qx/event/handler/Focus.js

@@ -88,7 +88,7 @@ qx.Class.define("qx.event.handler.Focus", {
       nullable: true
     },
 
-    /** The focussed DOM element */
+    /** The focused DOM element */
     focus: {
       apply: "_applyFocus",
       nullable: true

package/source/class/qx/html/Element.js

@@ -1044,7 +1044,7 @@ qx.Class.define("qx.html.Element", {
      * @Override
      */
     _applyVisible(value, oldValue) {
-      this.base(arguments, value, oldValue);
+      super._applyVisible(value, oldValue);
       if (value) {
         if (this._domNode) {
           qx.html.Element._visibility[this.toHashCode()] = this;

package/source/class/qx/html/Node.js

@@ -1349,7 +1349,6 @@ qx.Class.define("qx.html.Node", {
       // Nothing - to be overridden
     },
 
-
     /*
     ---------------------------------------------------------------------------
       PROPERTY SUPPORT

package/source/class/qx/io/request/AbstractRequest.js

@@ -451,87 +451,63 @@ qx.Class.define("qx.io.request.AbstractRequest", {
         var promise = new qx.Promise(function (resolve, reject) {
           var listeners = [];
 
-          var changeResponseListener = req.addListener(
-            "success",
-            function (e) {
-              listeners.forEach(req.removeListenerById.bind(req));
-              resolve(req);
-            },
-            this
-          );
+          var changeResponseListener = req.addListener("success", e => {
+            listeners.forEach(req.removeListenerById.bind(req));
+            resolve(req);
+          });
 
           listeners.push(changeResponseListener);
 
-          var statusErrorListener = req.addListener(
-            "statusError",
-            function (e) {
-              listeners.forEach(req.removeListenerById.bind(req));
-              var failMessage = qx.lang.String.format("%1: %2.", [
-                req.getStatus(),
-                req.getStatusText()
-              ]);
-
-              var err = new qx.type.BaseError("statusError", failMessage);
-              reject(err);
-            },
-            this
-          );
+          var statusErrorListener = req.addListener("statusError", e => {
+            listeners.forEach(req.removeListenerById.bind(req));
+            var failMessage = qx.lang.String.format("%1: %2.", [
+              req.getStatus(),
+              req.getStatusText()
+            ]);
+
+            var err = new qx.type.BaseError("statusError", failMessage);
+            reject(err);
+          });
 
           listeners.push(statusErrorListener);
 
-          var timeoutListener = req.addListener(
-            "timeout",
-            function (e) {
-              listeners.forEach(req.removeListenerById.bind(req));
-              var failMessage = qx.lang.String.format(
-                "Request failed with timeout after %1 ms.",
-                [req.getTimeout()]
-              );
-
-              var err = new qx.type.BaseError("timeout", failMessage);
-              reject(err);
-            },
-            this
-          );
+          var timeoutListener = req.addListener("timeout", e => {
+            listeners.forEach(req.removeListenerById.bind(req));
+            var failMessage = qx.lang.String.format(
+              "Request failed with timeout after %1 ms.",
+              [req.getTimeout()]
+            );
+
+            var err = new qx.type.BaseError("timeout", failMessage);
+            reject(err);
+          });
 
           listeners.push(timeoutListener);
 
-          var parseErrorListener = req.addListener(
-            "parseError",
-            function (e) {
-              listeners.forEach(req.removeListenerById.bind(req));
-              var failMessage = "Error parsing the response.";
-              var err = new qx.type.BaseError("parseError", failMessage);
-              reject(err);
-            },
-            this
-          );
+          var parseErrorListener = req.addListener("parseError", e => {
+            listeners.forEach(req.removeListenerById.bind(req));
+            var failMessage = "Error parsing the response.";
+            var err = new qx.type.BaseError("parseError", failMessage);
+            reject(err);
+          });
 
           listeners.push(parseErrorListener);
 
-          var abortListener = req.addListener(
-            "abort",
-            function (e) {
-              listeners.forEach(req.removeListenerById.bind(req));
-              var failMessage = "Request aborted.";
-              var err = new qx.type.BaseError("abort", failMessage);
-              reject(err);
-            },
-            this
-          );
+          var abortListener = req.addListener("abort", e => {
+            listeners.forEach(req.removeListenerById.bind(req));
+            var failMessage = "Request aborted.";
+            var err = new qx.type.BaseError("abort", failMessage);
+            reject(err);
+          });
 
           listeners.push(abortListener);
 
-          var errorListener = req.addListener(
-            "error",
-            function (e) {
-              listeners.forEach(req.removeListenerById.bind(req));
-              var failMessage = "Request failed.";
-              var err = new qx.type.BaseError("error", failMessage);
-              reject(err);
-            },
-            this
-          );
+          var errorListener = req.addListener("error", e => {
+            listeners.forEach(req.removeListenerById.bind(req));
+            var failMessage = "Request failed.";
+            var err = new qx.type.BaseError("error", failMessage);
+            reject(err);
+          });
 
           listeners.push(errorListener);
 

package/source/class/qx/test/Interface.js

@@ -28,7 +28,9 @@ qx.Class.define("qx.test.Interface", {
         members: {
           startEngine() {
             return true;
-          }
+          },
+
+          engineStarted : null
         },
 
         properties: { color: {} }
@@ -49,7 +51,9 @@ qx.Class.define("qx.test.Interface", {
         members: {
           startEngine() {
             return "start";
-          }
+          },
+
+          engineStarted : true
         },
 
         statics: {
@@ -78,7 +82,9 @@ qx.Class.define("qx.test.Interface", {
         members: {
           startEngine() {
             return "start";
-          }
+          },
+
+          engineStarted : true
         },
 
         statics: {
@@ -117,6 +123,54 @@ qx.Class.define("qx.test.Interface", {
       qx.Class.undefine("qx.test.i.Bmw2");
     },
 
+    testMissingMemberFunction() {
+      qx.Class.define("qx.test.i.Bmw2", {
+        extend: Object,
+        construct() {},
+        members : {
+          engineStarted : false
+        },
+        statics: {
+          honk() {
+            return "honk";
+          }
+        },
+
+        properties: { color: {} }
+      });
+
+      this.assertFalse(
+        qx.Interface.classImplements(qx.test.i.Bmw2, qx.test.i.ICar)
+      );
+
+      qx.Class.undefine("qx.test.i.Bmw2");
+    },
+
+    testMissingMemberVariable() {
+      qx.Class.define("qx.test.i.Bmw2", {
+        extend: Object,
+        construct() {},
+        members : {
+          startEngine() {
+            return "start";
+          }
+        },
+        statics: {
+          honk() {
+            return "honk";
+          }
+        },
+
+        properties: { color: {} }
+      });
+
+      this.assertFalse(
+        qx.Interface.classImplements(qx.test.i.Bmw2, qx.test.i.ICar)
+      );
+
+      qx.Class.undefine("qx.test.i.Bmw2");
+    },
+
     testMissingStatics() {
       // (ie it does implement all necessary)
       qx.Class.define("qx.test.i.Bmw3", {
@@ -125,7 +179,9 @@ qx.Class.define("qx.test.Interface", {
         members: {
           startEngine() {
             return "start";
-          }
+          },
+
+          engineStarted : null
         },
 
         properties: { color: {} }
@@ -145,7 +201,9 @@ qx.Class.define("qx.test.Interface", {
         members: {
           startEngine() {
             return "start";
-          }
+          },
+
+          engineStarted : false
         },
 
         statics: {
@@ -189,6 +247,10 @@ qx.Class.define("qx.test.Interface", {
               construct() {},
               implement: [qx.test.i.ICar],
 
+              members: {
+                engineStarted : false
+              },
+
               statics: {
                 honk() {
                   return "honk";
@@ -213,7 +275,9 @@ qx.Class.define("qx.test.Interface", {
               members: {
                 startEngine() {
                   return "start";
-                }
+                },
+
+                engineStarted : false
               },
 
               statics: {

package/source/class/qx/test/Mixin.js

@@ -405,7 +405,6 @@ qx.Class.define("qx.test.Mixin", {
     },
 
     testPatchDouble() {
-
       qx.Class.define("qx.Patch_1", {
         extend: qx.core.Object,
 
@@ -426,14 +425,14 @@ qx.Class.define("qx.test.Mixin", {
         }
       });
 
-
       qx.Mixin.define("qx.MPatch", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " Mixin";
-          },
+          }
         }
       });
+
       qx.Class.patch(qx.Patch_1, qx.MPatch);
       qx.Class.patch(qx.Patch_2, qx.MPatch);
 
@@ -444,7 +443,6 @@ qx.Class.define("qx.test.Mixin", {
       var o = new qx.Patch_2();
       this.assertEquals("Juhu 2 Mixin", o.sayJuhu());
       o.dispose();
-
     },
 
     testPatchOverwrittenDerived() {
@@ -470,9 +468,10 @@ qx.Class.define("qx.test.Mixin", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " Mixin";
-          },
+          }
         }
       });
+
       qx.Class.patch(qx.PatchDerived, qx.MPatch);
 
       var o = new qx.PatchDerived();
@@ -481,12 +480,11 @@ qx.Class.define("qx.test.Mixin", {
     },
 
     testPatchOverwrittenDerivedInBaseClass() {
-
       qx.Mixin.define("qx.MPatch", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " Mixin";
-          },
+          }
         }
       });
 
@@ -517,7 +515,6 @@ qx.Class.define("qx.test.Mixin", {
       var o = new qx.PatchDerived();
       this.assertEquals("Juhu Mixin Derived", o.sayJuhu());
       o.dispose();
-
     },
 
     testPatchMultiOverwrittenDerived() {
@@ -529,6 +526,7 @@ qx.Class.define("qx.test.Mixin", {
           }
         }
       });
+
       qx.Class.define("qx.B", {
         extend: qx.A,
         members: {
@@ -537,6 +535,7 @@ qx.Class.define("qx.test.Mixin", {
           }
         }
       });
+
       qx.Class.define("qx.C", {
         extend: qx.B,
         members: {
@@ -545,27 +544,31 @@ qx.Class.define("qx.test.Mixin", {
           }
         }
       });
+
       qx.Mixin.define("qx.MA", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " MA";
-          },
+          }
         }
       });
+
       qx.Mixin.define("qx.MB", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " MB";
-          },
+          }
         }
       });
+
       qx.Mixin.define("qx.MC", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " MC";
-          },
+          }
         }
       });
+
       qx.Class.patch(qx.A, qx.MA);
       qx.Class.patch(qx.B, qx.MB);
       qx.Class.patch(qx.C, qx.MC);
@@ -573,7 +576,6 @@ qx.Class.define("qx.test.Mixin", {
       var o = new qx.C();
       this.assertEquals("A MA B MB C MC", o.sayJuhu());
       o.dispose();
-
     },
 
     testDoubleMixin() {
@@ -585,28 +587,29 @@ qx.Class.define("qx.test.Mixin", {
           }
         }
       });
+
       qx.Mixin.define("qx.MDA", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " MA";
-          },
+          }
         }
       });
+
       qx.Mixin.define("qx.MDB", {
         members: {
           sayJuhu() {
             return super.sayJuhu() + " MB";
-          },
+          }
         }
       });
+
       qx.Class.patch(qx.D, qx.MDA);
       qx.Class.patch(qx.D, qx.MDB);
 
       var o = new qx.D();
       this.assertEquals("Double MA MB", o.sayJuhu());
       o.dispose();
-
     }
-
-   }
+  }
 });