@qooxdoo/framework 7.0.0 → 7.1.0

package/source/class/qx/ui/table/model/Abstract.js

@@ -66,11 +66,22 @@ qx.Class.define("qx.ui.table.model.Abstract", {
     this.__columnIndexMap = {};
   },
 
+  statics: {
+    /**
+     * Member to control if a table should throw an error when you try to change the
+     * data model data whilst there is an incomplete edit. It could possibly break
+     * current implementations so only introduce the change from QX v8.
+     * Ref: https://github.com/qooxdoo/qooxdoo/pull/10377#discussion_r818697343
+     */
+    THROW_ON_MODEL_CHANGE_DURING_EDIT: parseInt(qx.core.Environment.get("qx.version"), 10) >= 8
+  },
+
   members: {
     __columnIdArr: null,
     __columnNameArr: null,
     __columnIndexMap: null,
     __internalChange: null,
+    __table: null,
 
     /**
      * Initialize the table model <--> table interaction. The table model is
@@ -84,7 +95,17 @@ qx.Class.define("qx.ui.table.model.Abstract", {
      *   The table to which this model is attached
      */
     init(table) {
-      // default implementation has nothing to do
+      // store a reference back to the table
+      this.__table = table;
+    },
+
+    /**
+     *
+     *
+     * @returns table {qx.ui.table.Table}
+     */
+    getTable() {
+      return this.__table;
     },
 
     /**
@@ -292,6 +313,15 @@ qx.Class.define("qx.ui.table.model.Abstract", {
       }
 
       this.setColumnNamesByIndex(columnNameArr);
+    },
+
+    _checkEditing() {
+      if (!qx.ui.table.model.Abstract.THROW_ON_MODEL_CHANGE_DURING_EDIT) {
+        return;
+      }
+      if (this.getTable() && this.getTable().isEditing()) {
+        throw new Error("A cell is currently being edited. Commit or cancel the edit before setting the table data");
+      }
     }
   },
 

package/source/class/qx/ui/table/model/Remote.js

@@ -548,6 +548,7 @@ qx.Class.define("qx.ui.table.model.Remote", {
      * @param rowIndex {Integer} the index of the row to remove.
      */
     removeRow(rowIndex) {
+      this._checkEditing();
       if (this.getClearCacheOnRemove()) {
         this.clearCache();
 

package/source/class/qx/ui/table/model/Simple.js

@@ -531,6 +531,7 @@ qx.Class.define("qx.ui.table.model.Simple", {
      * @param clearSorting {Boolean ? true} Whether to clear the sort state.
      */
     setData(rowArr, clearSorting) {
+      this._checkEditing();
       this._rowArr = rowArr;
 
       // Inform the listeners
@@ -650,6 +651,7 @@ qx.Class.define("qx.ui.table.model.Simple", {
      * @param clearSorting {Boolean ? true} Whether to clear the sort state.
      */
     setRows(rowArr, startIndex, clearSorting) {
+      this._checkEditing();
       if (startIndex == null) {
         startIndex = 0;
       }
@@ -708,6 +710,7 @@ qx.Class.define("qx.ui.table.model.Simple", {
      * @param clearSorting {Boolean ? true} Whether to clear the sort state.
      */
     removeRows(startIndex, howMany, clearSorting) {
+      this._checkEditing();
       // In the case of `removeRows`, specifically, we must create the
       // listeners' event data before actually removing the rows from
       // the row data, so that the `lastRow` calculation is correct.

package/source/class/qx/ui/treevirtual/MNode.js

@@ -165,7 +165,33 @@ qx.Mixin.define("qx.ui.treevirtual.MNode", {
     },
 
     /**
-     * Set the opened state for a node.  (Note that this method has no effect
+     * Opens all nodes in the tree with minimal redraw
+     */
+    nodeOpenAll() {
+      var model = this.getTableModel();
+      model.getData().forEach(node => {
+        if (node) {
+          model.setState(node.nodeId, {bOpened: true}, true);
+        }
+      });
+      model.setData();
+    },
+
+    /**
+     * Closes all nodes in the tree with minimal redraw
+     */
+    nodeCloseAll() {
+      var model = this.getTableModel();
+      model.getData().forEach(node => {
+        if (node) {
+          model.setState(node.nodeId, {bOpened: false}, true);
+        }
+      });
+      model.setData();
+    },
+
+    /**
+     * Internal call to set the opened state for a node. (Note that this method has no effect
      * if the requested state is the same as the current state.)
      *
      * @param nodeReference {Object | Integer}
@@ -173,11 +199,16 @@ qx.Mixin.define("qx.ui.treevirtual.MNode", {
      *   represented either by the node object, or the node id (as would have
      *   been returned by addBranch(), addLeaf(), etc.)
      *
-     * @param b {Boolean}
+     * @param opened {Boolean}
      *   The new opened state for the specified node.
      *
+     * @param cascade {Boolean}
+     *   Whether to descend the tree changing opened state of all children
+     *
+     * @param isRecursed {Boolean?}
+     *   For internal use when cascading to determine outer level and call setData
      */
-    nodeSetOpened(nodeReference, b) {
+    _nodeSetOpenedInternal(nodeReference, opened, cascade, isRecursed) {
       var node;
 
       if (typeof nodeReference == "object") {
@@ -190,10 +221,34 @@ qx.Mixin.define("qx.ui.treevirtual.MNode", {
 
       // Only set new state if not already in the requested state, since
       // setting new state involves dispatching events.
-      if (b != node.bOpened) {
-        this.nodeToggleOpened(node);
+      if (opened != node.bOpened) {
+        this.getTableModel().setState(node.nodeId, { bOpened: opened }, true);
+      }
+      if (cascade) {
+        node.children.forEach(child => this.nodeSetOpened(child, opened, cascade, true));
+      }
+      if (!cascade || !isRecursed) {
+        this.getTableModel().setData();
       }
     },
+    /**
+     * Set the opened state for a node.  (Note that this method has no effect
+     * if the requested state is the same as the current state.)
+     *
+     * @param nodeReference {Object | Integer}
+     *   The node for which the opened state is being set.  The node can be
+     *   represented either by the node object, or the node id (as would have
+     *   been returned by addBranch(), addLeaf(), etc.)
+     *
+     * @param opened {Boolean}
+     *   The new opened state for the specified node.
+     *
+     * @param cascade {Boolean}
+     *   Whether to descend the tree changing opened state of all children
+     */
+    nodeSetOpened(nodeReference, opened, cascade) {
+      this._nodeSetOpenedInternal(nodeReference, opened, cascade, false);
+    },
 
     /**
      * Get the opened state for a node.

package/source/class/qx/ui/treevirtual/SimpleTreeDataModel.js

@@ -795,7 +795,7 @@ qx.Class.define("qx.ui.treevirtual.SimpleTreeDataModel", {
      * Sets the whole data en bulk, or notifies the data model that node
      * modifications are complete.
      *
-     * @param nodeArr {Array | null}
+     * @param nodeArr {Array?null}
      *   Pass either an Array of node objects, or null.
      *
      *   If non-null, nodeArr is an array of node objects containing the
@@ -813,6 +813,7 @@ qx.Class.define("qx.ui.treevirtual.SimpleTreeDataModel", {
      * @throws {Error} If the parameter has the wrong type.
      */
     setData(nodeArr) {
+      this._checkEditing();
       if (nodeArr instanceof Array) {
         // Save the user-supplied data.
         this._nodeArr = nodeArr;
@@ -853,6 +854,7 @@ qx.Class.define("qx.ui.treevirtual.SimpleTreeDataModel", {
      *
      */
     clearData() {
+      this._checkEditing();
       this._clearSelections();
       this.setData([qx.ui.treevirtual.MTreePrimitive._getEmptyTree()]);
     },
@@ -907,9 +909,13 @@ qx.Class.define("qx.ui.treevirtual.SimpleTreeDataModel", {
      *   {@link SimpleTreeDataModel}.  Each property value will be assigned
      *   to the corresponding property of the node specified by nodeId.
      *
+     * @param suppressRedraw {Boolean}
+     *    If true then prevents redraw; it becomes the caller's responsibility to
+     *    call setData() subsequently, to cause a redraw.
+     *
      * @throws {Error} If the node object or id is not valid.
      */
-    setState(nodeReference, attributes) {
+    setState(nodeReference, attributes, suppressRedraw) {
       var node;
       var nodeId;
 
@@ -1003,7 +1009,9 @@ qx.Class.define("qx.ui.treevirtual.SimpleTreeDataModel", {
 
             // Re-render the row data since formerly visible rows may now be
             // invisible, or vice versa.
-            this.setData();
+            if (!suppressRedraw) {
+              this.setData();
+            }
             break;
 
           default: