@qooxdoo/framework 6.0.0 → 6.0.4

package/source/class/qx/core/Property.js

@@ -1811,14 +1811,15 @@ qx.Bootstrap.define("qx.core.Property",
     __emitCallCallback : function(code, config, name, variant, refresh)
     {
       // Execute user configured setter
-      code.push('var promise;');
+      code.push("var self=this;",
+        'var promise;');
       if (config.apply) {
         code.push('promise = this.', config.apply, '(computed, old, "', name, '", "', variant, '");');
       }
 
       if (config.async) {
         code.push(
-        		"function fire() {",
+            "function fire() {",
               "var promiseData = qx.Promise.resolve(computed);",
               "var promise = promiseData;"
         		);
@@ -1827,21 +1828,21 @@ qx.Bootstrap.define("qx.core.Property",
         if (config.event) {
           code.push(
               "var reg=qx.event.Registration;",
-              "if(reg.hasListener(this, '", config.event, "')) {",
-                "promise = reg.fireEventAsync(this, '", config.event, "', qx.event.type.Data, [computed, old]", ");",
+              "if(reg.hasListener(self, '", config.event, "')) {",
+                "promise = reg.fireEventAsync(self, '", config.event, "', qx.event.type.Data, [computed, old]", ");",
                 "promise = promise.then(function() { return computed; });",
               "}",
-              "if(reg.hasListener(this, '", config.event, "Async'))",
+              "if(reg.hasListener(self, '", config.event, "Async'))",
                 "promise = promise.then(function() {",
-                    "return reg.fireEventAsync(this, '", config.event, "Async', qx.event.type.Data, [promiseData, old]", ");",
-                  "}, this);"
+                    "return reg.fireEventAsync(self, '", config.event, "Async', qx.event.type.Data, [promiseData, old]", ");",
+                  "});"
               );
         }
 
         // Emit code to update the inherited values of child objects
         if (refresh) {
           code.push(
-            'var a=this._getChildren();',
+            'var a=self._getChildren();',
             'if(a)',
               'for(var i=0,l=a.length;i<l;i++){',
                 'if(a[i].', this.$$method.refresh[name], ')',
@@ -1862,13 +1863,13 @@ qx.Bootstrap.define("qx.core.Property",
           code.push(
               "var reg=qx.event.Registration;",
 
-              "if(reg.hasListener(this, '", config.event, "'))",
-                "qx.event.Utils.track(tracker, reg.fireEvent(this, '", config.event, "', qx.event.type.Data, [computed, old]", "));");
+              "if(reg.hasListener(self, '", config.event, "'))",
+                "qx.event.Utils.track(tracker, reg.fireEvent(self, '", config.event, "', qx.event.type.Data, [computed, old]", "));");
           if (qx.core.Environment.get("qx.promise")) {
             code.push(
-                "if(reg.hasListener(this, '", config.event, "Async'))",
+                "if(reg.hasListener(self, '", config.event, "Async'))",
                   "qx.event.Utils.then(tracker, function() {\n" +
-                  "  return reg.fireEventAsync(this, '", config.event, "Async', qx.event.type.Data, [qx.Promise.resolve(computed), old]", ");\n" +
+                  "  return reg.fireEventAsync(self, '", config.event, "Async', qx.event.type.Data, [qx.Promise.resolve(computed), old]", ");\n" +
                   "});"
                 );
           }
@@ -1876,7 +1877,7 @@ qx.Bootstrap.define("qx.core.Property",
         // Emit code to update the inherited values of child objects
         if (refresh) {
           code.push(
-            'var a=this._getChildren();',
+            'var a=self._getChildren();',
             'if(a)',
               'for(var i=0,l=a.length;i<l;i++){',
                 'if(a[i].', this.$$method.refresh[name], ')',
@@ -1894,11 +1895,11 @@ qx.Bootstrap.define("qx.core.Property",
       if (qx.core.Environment.get("qx.promise")) {
         code.push(
             "if(promise instanceof qx.Promise || promise instanceof Promise) " +
-              "return promise.then(fire, this); "
+              "return promise.then(fire); "
           );
       }
       code.push(
-        "return fire.call(this);"
+        "return fire();"
       );
     }
   }

package/source/class/qx/data/Array.js

@@ -22,7 +22,7 @@
  * for it. All the native methods are included in the implementation and it
  * also fires events if the content or the length of the array changes in
  * any way. Also the <code>.length</code> property is available on the array.
- * 
+ *
  * This class does not need to be disposed, unless you set the autoDisposeItems
  * property to true and want the items to be disposed.
  */
@@ -372,16 +372,18 @@ qx.Class.define("qx.data.Array",
       var added = arguments.length > 2;
       if (removed || added) {
         var addedItems = qx.lang.Array.fromArguments(arguments, 2);
+        var type;
+        var end;
 
         if (returnArray.length == 0) {
-          var type = "add";
-          var end = startIndex + addedItems.length;
+          type = "add";
+          end = startIndex + addedItems.length;
         } else if (addedItems.length == 0) {
-          var type = "remove";
-          var end = this.length - 1;
+          type = "remove";
+          end = this.length - 1;
         } else {
-          var type = "add/remove";
-          var end = startIndex + Math.max(addedItems.length, returnArray.length) - 1;
+          type = "add/remove";
+          end = startIndex + Math.max(addedItems.length, returnArray.length) - 1;
         }
 
         this.fireDataEvent("change",
@@ -426,13 +428,13 @@ qx.Class.define("qx.data.Array",
       }
       return (new qx.data.Array(returnArray));
     },
-    
-    
+
+
     /**
      * Efficiently replaces the array with the contents of src; this will suppress the
      * change event if the array contents are the same, and will make sure that only
      * one change event is fired
-     * 
+     *
      * @param src {qx.data.Array|Array} the new value to set the array to
      */
     replace: function(src) {
@@ -967,9 +969,7 @@ qx.Class.define("qx.data.Array",
      */
     forEach : function(callback, context)
     {
-      for (var i = 0; i < this.__array.length; i++) {
-        callback.call(context, this.__array[i], i, this);
-      }
+      this.__array.forEach((element, index) => callback.call(context, element, index, this));
     },
 
 
@@ -1013,6 +1013,22 @@ qx.Class.define("qx.data.Array",
     },
 
 
+    /**
+     * Finds the first matching element in the array which passes the test implemented by the
+     * provided function.
+     * @param callback {Function} The test function, which will be executed for every
+     *   item in the array. The function will have three arguments.
+     *   <li><code>item</code>: the current item in the array</li>
+     *   <li><code>index</code>: the index of the current item</li>
+     *   <li><code>array</code>: The native array instance, NOT the data array instance.</li>
+     * @param self {var?undefined} The context of the callback.
+     * @return {Boolean} <code>true</code>, if any element passed the test function.
+     */
+    find : function(callback, self) {
+      return this.__array.find(callback, self);
+    },
+
+
     /**
      * Tests whether any element in the array passes the test implemented by the
      * provided function.
@@ -1106,7 +1122,7 @@ qx.Class.define("qx.data.Array",
     __updateEventPropagation : function(from, to) {
       for (var i=from; i < to; i++) {
         this._registerEventChaining(this.__array[i], this.__array[i], i);
-      };
+      }
     }
   },
 

package/source/class/qx/data/SingleValueBinding.js

@@ -1281,6 +1281,10 @@ qx.Class.define("qx.data.SingleValueBinding",
           this.removeBindingFromObject(object, bindings[i][0]);
         }
       }
+
+      var hash = object.toHashCode();
+      delete this.__bindings[hash];
+      delete this.__bindingsByTarget[hash];
     },
 
 
@@ -1333,16 +1337,22 @@ qx.Class.define("qx.data.SingleValueBinding",
      */
     getAllBindingsForObject : function(object) {
       var hash = object.toHashCode();
-      // create an empty array if no binding exists
-      if (this.__bindings[hash] === undefined) {
-        this.__bindings[hash] = [];
-      }
 
       // get all bindings of object as source
       var sourceBindings = this.__bindings[hash];
 
       // get all bindings of object as target
-      var targetBindings = this.__bindingsByTarget[hash] ? this.__bindingsByTarget[hash] : [];
+      var targetBindings = this.__bindingsByTarget[hash];
+
+      if (!sourceBindings && !targetBindings) {
+        return [];
+      }
+      if (!sourceBindings) {
+        return qx.lang.Array.clone(targetBindings);
+      }
+      if (!targetBindings) {
+        return qx.lang.Array.clone(sourceBindings);
+      }
 
       return qx.lang.Array.unique(sourceBindings.concat(targetBindings));
     },