@qlik/eslint-config 1.1.3 → 1.1.5

package/README.md

@@ -227,9 +227,50 @@ export default [
 
 ### More examples with export
 
-One GOTCHA about the flat configs. If there's no `files` property in one of the configs in the config array it is applied
-to every file. So in the case of turning off a rule that belongs to specific config e.g. jest or vitest. The following
-approach does NOT work.
+One GOTCHA about the flat configs. If there's no `files` property in one of the configs in the config array it is applied to every file. So in the case of turning off a rule that belongs to specific config e.g. `@typescript/eslint`. The following
+approach can be problematic.
+
+```js
+// @ts-check
+import qlik from "@qlik/eslint-config";
+
+export default qlik.compose(
+  ...qlik.configs.recommended, // <-- typescript-eslint is applied to .ts files only
+  {
+    rules: {
+      // I want to change this rule, but it is applied to all files so if I have a .js file somewhere getting linted I will get an ERROR about missing plugin.
+      "@typescript-eslint/method-signature-style": "off",
+    },
+  },
+);
+```
+
+This will have to be fine-tuned. However, it is recommended to not disable rules.
+
+```js
+// @ts-check
+import qlik from "@qlik/eslint-config";
+
+export default qlik.compose(
+  ...qlik.configs.recommended, // <-- typescript-eslint is applied to .ts files only
+  {
+    files: ["**/*.ts"]
+    rules: {
+      // typescript specific rules here
+      "@typescript-eslint/method-signature-style": "off",
+    },
+  },
+  {
+    rules: {
+      // these are fine, since they are applied to all files
+      "no-var": "off",
+      "import-x/no-unresolved": "off"
+    },
+  },
+);
+```
+
+Another GOTCHA can happen with the vitest and jest configs
 
 ```js
 // @ts-check

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@qlik/eslint-config",
-  "version": "1.1.3",
+  "version": "1.1.5",
   "description": "Qlik's ESLint configs",
   "repository": "git@github.com:qlik-oss/dev-tools-js.git",
   "license": "ISC",
@@ -16,35 +16,35 @@
   ],
   "prettier": "@qlik/prettier-config",
   "dependencies": {
-    "@eslint-react/eslint-plugin": "1.17.1",
-    "@eslint/js": "^9.15.0",
-    "@typescript-eslint/utils": "^8.16.0",
-    "@vitest/eslint-plugin": "^1.1.11",
+    "@eslint-react/eslint-plugin": "1.19.0",
+    "@eslint/js": "^9.17.0",
+    "@typescript-eslint/utils": "^8.18.0",
+    "@vitest/eslint-plugin": "^1.1.16",
     "confusing-browser-globals": "^1.0.11",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.3",
-    "eslint-plugin-import-x": "^4.4.3",
+    "eslint-import-resolver-typescript": "^3.7.0",
+    "eslint-plugin-import-x": "^4.5.0",
     "eslint-plugin-jest": "^28.9.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-playwright": "2.1.0",
     "eslint-plugin-react": "^7.37.2",
-    "eslint-plugin-react-hooks": "^5.0.0",
-    "eslint-plugin-svelte": "2.46.0",
-    "eslint-plugin-testing-library": "^7.0.0",
-    "globals": "^15.12.0",
+    "eslint-plugin-react-hooks": "^5.1.0",
+    "eslint-plugin-svelte": "2.46.1",
+    "eslint-plugin-testing-library": "^7.1.1",
+    "globals": "^15.13.0",
     "svelte-eslint-parser": "0.43.0",
-    "typescript-eslint": "^8.16.0"
+    "typescript-eslint": "^8.18.0"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "^1.0.3",
     "@types/eslint-config-prettier": "^6.11.3",
     "@types/eslint-plugin-jsx-a11y": "^6.10.0",
     "@types/eslint__js": "^8.42.3",
-    "eslint": "^9.15.0",
-    "prettier": "^3.4.1",
-    "vitest": "^2.1.6",
-    "@qlik/prettier-config": "0.4.19",
-    "@qlik/tsconfig": "0.2.8"
+    "eslint": "^9.17.0",
+    "prettier": "^3.4.2",
+    "vitest": "^2.1.8",
+    "@qlik/tsconfig": "0.3.0",
+    "@qlik/prettier-config": "0.4.19"
   },
   "peerDependencies": {
     "eslint": ">=9.0.0",

package/src/configs/react.js

@@ -92,6 +92,9 @@ const reactTS = mergeConfigs(
     rules: {
       // turn on/off or modify js/ts rules necessary for react
       "react/jsx-filename-extension": [2, { extensions: [".js", ".jsx", ".ts", ".tsx"] }],
+      // avoid double linting of class-methods-use-this in typescript
+      "class-methods-use-this": "off",
+      "@typescript-eslint/class-methods-use-this": reactBaseConfig.rules?.["class-methods-use-this"] || "off",
     },
   },
   prettier,