@qlik/eslint-config 0.1.1 → 0.2.1

package/{mods/airbnb-base.js → configs/airbnb-base-mod.js}

@@ -33,29 +33,8 @@ module.exports = {
 
     // modifies airbnb ts default rules
     "lines-between-class-members": "off",
-    "@typescript-eslint/lines-between-class-members": "off",
-
-    // discouraged https://palantir.github.io/tslint/rules/no-use-before-declare/
     "no-use-before-define": "off",
-    "@typescript-eslint/no-use-before-define": "off",
-
     "dot-notation": "off",
-    "@typescript-eslint/dot-notation": "off",
-
-    "@typescript-eslint/prefer-ts-expect-error": "error",
-    "@typescript-eslint/no-misused-promises": [
-      "error",
-      {
-        checksConditionals: false,
-      },
-    ],
-
-    // no-unsafe-* does not work good
-    "@typescript-eslint/no-unsafe-call": "off",
-    "@typescript-eslint/no-unsafe-member-access": "off",
-    "@typescript-eslint/no-unsafe-return": "off",
-    "@typescript-eslint/no-unsafe-argument": "off",
-    "@typescript-eslint/no-unsafe-assignment": "off",
 
     // import plugin
     "import/prefer-default-export": "off",

package/{mods/airbnb.js → configs/airbnb-mod.js}

@@ -1,5 +1,5 @@
 module.exports = {
-  extends: ["./airbnb-base.js"],
+  extends: ["./airbnb-base-mod.js"],
   rules: {
     // modifies airbnb rules for react
     "react/jsx-props-no-spreading": "off",

package/configs/airbnb-ts-base-mod.js

@@ -0,0 +1,32 @@
+module.exports = {
+  extends: ["./airbnb-base-mod"],
+  rules: {
+    // modifies airbnb default rules
+    "no-undef": "off", // typescript handles these checks
+    // modifies airbnb ts default rules
+    "lines-between-class-members": "off",
+    "@typescript-eslint/lines-between-class-members": "off",
+
+    // discouraged https://palantir.github.io/tslint/rules/no-use-before-declare/
+    "no-use-before-define": "off",
+    "@typescript-eslint/no-use-before-define": "off",
+
+    "dot-notation": "off",
+    "@typescript-eslint/dot-notation": "off",
+
+    "@typescript-eslint/prefer-ts-expect-error": "error",
+    "@typescript-eslint/no-misused-promises": [
+      "error",
+      {
+        checksConditionals: false,
+      },
+    ],
+
+    // no-unsafe-* does not work good
+    "@typescript-eslint/no-unsafe-call": "off",
+    "@typescript-eslint/no-unsafe-member-access": "off",
+    "@typescript-eslint/no-unsafe-return": "off",
+    "@typescript-eslint/no-unsafe-argument": "off",
+    "@typescript-eslint/no-unsafe-assignment": "off",
+  },
+};

package/configs/airbnb-ts-mod.js

@@ -0,0 +1,17 @@
+module.exports = {
+  extends: ["./airbnb-ts-base-mod.js"],
+  rules: {
+    // modifies airbnb rules for react
+    "react/jsx-props-no-spreading": "off",
+    "react/jsx-uses-react": "off",
+    "react/react-in-jsx-scope": "off",
+    "react/forbid-prop-types": "off",
+    "react/function-component-definition": [
+      2,
+      {
+        namedComponents: "arrow-function",
+        unnamedComponents: "arrow-function",
+      },
+    ],
+  },
+};

package/configs/env.js

@@ -0,0 +1,11 @@
+module.exports = {
+  env: {
+    browser: true,
+    node: true,
+    es2022: true,
+  },
+  parserOptions: {
+    sourceType: "module",
+    ecmaVersion: "2022",
+  },
+};

package/index.js

@@ -1,22 +1,10 @@
 module.exports = {
   extends: [
     "eslint:recommended",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:@typescript-eslint/recommended-requiring-type-checking",
     "airbnb-base",
-    "airbnb-typescript/base",
-    "./mods/airbnb-base",
+    "./configs/airbnb-base-mod",
     "prettier",
+    "./overrides/ts",
+    "./configs/env",
   ],
-  env: {
-    browser: true,
-    es2020: true,
-    node: true,
-  },
-  plugins: ["@typescript-eslint"],
-  parser: "@typescript-eslint/parser",
-  parserOptions: {
-    sourceType: "module",
-    ecmaVersion: 2020,
-  },
 };

package/overrides/react.js

@@ -0,0 +1,22 @@
+module.exports = {
+  overrides: [
+    {
+      files: ["*.js", "*.jsx"],
+      extends: ["airbnb", "../configs/airbnb-mod", "prettier", "../configs/env"],
+    },
+    {
+      files: ["*.ts", "*.tsx"],
+      extends: [
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking",
+        "airbnb",
+        "airbnb-typescript",
+        "../configs/airbnb-ts-mod",
+        "prettier",
+        "../configs/env",
+      ],
+      plugins: ["@typescript-eslint"],
+      parser: "@typescript-eslint/parser",
+    },
+  ],
+};

package/overrides/svelte.js

@@ -0,0 +1,30 @@
+module.exports = {
+  overrides: [
+    {
+      files: ["*.svelte"],
+      extends: [
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking",
+        "airbnb-base",
+        "airbnb-typescript/base",
+        "../configs/airbnb-ts-base-mod",
+        "plugin:svelte/recommended",
+        "plugin:svelte/prettier",
+        "prettier",
+        "../configs/env",
+      ],
+      parser: "svelte-eslint-parser",
+
+      parserOptions: {
+        parser: "@typescript-eslint/parser",
+        extraFileExtensions: [".svelte"],
+      },
+      rules: {
+        "no-undef-init": "off",
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": "off",
+        "import/no-mutable-exports": "off",
+      },
+    },
+  ],
+};

package/overrides/ts.js

@@ -0,0 +1,18 @@
+module.exports = {
+  overrides: [
+    {
+      files: ["*.ts"],
+      extends: [
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking",
+        "airbnb-base",
+        "airbnb-typescript/base",
+        "../configs/airbnb-ts-base-mod",
+        "prettier",
+        "../configs/env",
+      ],
+      plugins: ["@typescript-eslint"],
+      parser: "@typescript-eslint/parser",
+    },
+  ],
+};

package/package.json

@@ -1,12 +1,13 @@
 {
   "name": "@qlik/eslint-config",
-  "version": "0.1.1",
+  "version": "0.2.1",
   "description": "Qlik's ESLint config for typescript",
   "repository": "git@github.com:qlik-oss/dev-tools-js.git",
   "license": "ISC",
   "main": "index.js",
   "files": [
-    "mods",
+    "configs",
+    "overrides",
     "index.js",
     "node.js",
     "esm.js",
@@ -25,8 +26,8 @@
     "extends": "eslint:recommended"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "5.59.7",
-    "@typescript-eslint/parser": "5.59.7",
+    "@typescript-eslint/eslint-plugin": "5.59.8",
+    "@typescript-eslint/parser": "5.59.8",
     "eslint-config-airbnb": "19.0.4",
     "eslint-config-airbnb-base": "15.0.0",
     "eslint-config-airbnb-typescript": "17.0.0",
@@ -36,21 +37,21 @@
     "eslint-plugin-playwright": "0.12.0",
     "eslint-plugin-react": "7.32.2",
     "eslint-plugin-react-hooks": "4.6.0",
-    "eslint-plugin-svelte": "2.29.0",
-    "eslint-plugin-vitest": "0.2.3",
-    "svelte-eslint-parser": "0.29.0"
+    "eslint-plugin-svelte": "2.30.0",
+    "eslint-plugin-vitest": "0.2.5",
+    "svelte-eslint-parser": "0.30.0"
   },
   "devDependencies": {
-    "eslint": "8.41.0",
+    "eslint": "8.42.0",
     "prettier": "2.8.8",
-    "@qlik/prettier-config": "0.1.2"
+    "@qlik/prettier-config": "0.1.3"
   },
   "peerDependencies": {
     "eslint": "*"
   },
   "optionalDependencies": {
     "svelte": "^3.59.1",
-    "typescript": "^5.0.4"
+    "typescript": "^5.1.3"
   },
   "engines": {
     "node": ">=16",

package/react-svelte.js

@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ["./react", "./mods/svelte"],
+  extends: ["./index", "./overrides/react", "./overrides/svelte"],
 };

package/react.js

@@ -1,22 +1,3 @@
 module.exports = {
-  extends: [
-    "eslint:recommended",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:@typescript-eslint/recommended-requiring-type-checking",
-    "airbnb",
-    "airbnb-typescript",
-    "./mods/airbnb",
-    "prettier",
-  ],
-  env: {
-    browser: true,
-    es2020: true,
-    node: true,
-  },
-  plugins: ["@typescript-eslint"],
-  parser: "@typescript-eslint/parser",
-  parserOptions: {
-    sourceType: "module",
-    ecmaVersion: 2020,
-  },
+  extends: ["./index", "./overrides/react"],
 };

package/svelte.js

@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ["./index", "./mods/svelte"],
+  extends: ["./index", "./overrides/svelte"],
 };

package/mods/svelte.js

@@ -1,21 +0,0 @@
-module.exports = {
-  extends: ["plugin:svelte/recommended", "plugin:svelte/prettier"],
-  parserOptions: {
-    extraFileExtensions: [".svelte"],
-  },
-  overrides: [
-    {
-      files: ["*.svelte"],
-      parser: "svelte-eslint-parser",
-      parserOptions: {
-        parser: "@typescript-eslint/parser",
-      },
-      rules: {
-        "no-undef-init": "off",
-        "no-unused-vars": "off",
-        "@typescript-eslint/no-unused-vars": "off",
-        "import/no-mutable-exports": "off",
-      },
-    },
-  ],
-};