@qijenchen/design-system 0.1.0-beta.8 → 0.1.0-beta.80

package/ds-canonical/hooks/tests/test_check_full_story_visual_interaction_sweep.sh

@@ -0,0 +1,190 @@
+#!/bin/bash
+# Tests for check_full_story_visual_interaction_sweep.sh(P0 BLOCKER,codex M31 2026-05-27)
+#
+# Hook 規則(PreToolUse,Write|Edit|MultiEdit):
+#   - File gate:tool_input.file_path 必 match `(sweep|audit-report)\.json$`,否則 silent。
+#   - Content:tool_input.new_string // tool_input.content。空 → silent。
+#   - Escape:content 含 `_sampling_allowed` → silent。
+#   - Story count:`.storyResults // .results | length`,fallback `.storySummary.total // .summary.total // .total`。
+#   - Manifest:$CLAUDE_PROJECT_DIR/packages/design-system/ds-story-manifest.json .totalStories。
+#       manifest 不存在 / total=0 → silent。STORY_COUNT=0 → silent。
+#   - BLOCKER:STORY_COUNT < MANIFEST_TOTAL → exit 2 + stderr「FULL-STORY-SWEEP BLOCKER」。
+#   - STORY_COUNT >= MANIFEST_TOTAL → silent(全跑通過)。
+#
+# Non-Write/Edit tool / 非 sweep|audit-report 檔名 → silent。
+#
+# Determinism:TMP_DIR + CLAUDE_PROJECT_DIR override(manifest fixture totalStories=916),
+# 不碰 repo 真 manifest / 不寫 repo logs。
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_full_story_visual_interaction_sweep.sh"
+
+if [ ! -x "$HOOK" ]; then
+  echo "FATAL: hook not executable: $HOOK"
+  exit 1
+fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+TMP_DIR=$(mktemp -d)
+trap 'rm -rf "$TMP_DIR"' EXIT
+
+# Override CLAUDE_PROJECT_DIR so manifest lookup + _log-fire land in TMP_DIR
+# (不污染 repo packages/ 與 .claude/logs/)
+export CLAUDE_PROJECT_DIR="$TMP_DIR"
+mkdir -p "$TMP_DIR/.claude/logs"
+mkdir -p "$TMP_DIR/packages/design-system"
+
+MANIFEST="$TMP_DIR/packages/design-system/ds-story-manifest.json"
+MANIFEST_TOTAL=916
+# Deterministic manifest fixture(mirrors real SSOT totalStories at write time)
+jq -n --argjson t "$MANIFEST_TOTAL" '{totalStories:$t}' > "$MANIFEST"
+
+# run_hook: feed Write/Edit JSON payload via stdin.
+#   $1 = file_path
+#   $2 = content (goes into tool_input.content)
+#   $3 = tool_name (default Write)
+#   $4 = use_new_string ("1" → put $2 into tool_input.new_string instead of content)
+run_hook() {
+  local file_path="$1"; local content="$2"
+  local tool="${3:-Write}"; local use_new_string="${4:-0}"
+  local payload
+  if [ "$use_new_string" = "1" ]; then
+    payload=$(jq -n --arg fp "$file_path" --arg c "$content" --arg tn "$tool" \
+      '{hook_event_name:"PreToolUse", tool_name:$tn, tool_input:{file_path:$fp, new_string:$c}}')
+  else
+    payload=$(jq -n --arg fp "$file_path" --arg c "$content" --arg tn "$tool" \
+      '{hook_event_name:"PreToolUse", tool_name:$tn, tool_input:{file_path:$fp, content:$c}}')
+  fi
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_pass_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent, exit=$EXIT, stderr=$([ -n "$STDERR_TEXT" ] && echo non-empty || echo empty))"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_block() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "2" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected BLOCK exit=2 + '$needle', got exit=$EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+# Build a sampled audit-report content (storyResults array of N entries)
+sampled_results() {
+  local n="$1"
+  jq -n --argjson n "$n" '{storyResults:[range(0;$n)|{id:("s"+(.|tostring)), pass:true}]}'
+}
+
+echo "=== check_full_story_visual_interaction_sweep tests ==="
+
+# ── POSITIVE cases(SHOULD BLOCK)──────────────────────────────────
+
+# 1. POSITIVE: audit-report.json with 900 < 916 stories → BLOCK
+run_hook "/tmp/codex-2026-sweep/audit-report.json" "$(sampled_results 900)"
+expect_block "1. [POS] audit-report.json sampled 900<916 → BLOCK" "FULL-STORY-SWEEP BLOCKER"
+
+# 2. POSITIVE: filename ending *-sweep.json (the OTHER regex branch) → BLOCK
+#    Guards the file-gate regex breadth: both `sweep` and `audit-report` must fire.
+run_hook "/tmp/claude-visual-sweep.json" "$(sampled_results 1)"
+expect_block "2. [POS] *-sweep.json sampled 1<916 → BLOCK (file-gate breadth)" "FULL-STORY-SWEEP BLOCKER"
+
+# 3. POSITIVE (near-complete, M34 over-narrow guard): 915 < 916 by one story → BLOCK
+#    Guards against a hook that only fires on grossly-undersampled reports.
+run_hook "/tmp/codex-sweep/audit-report.json" "$(sampled_results 915)"
+expect_block "3. [POS] off-by-one 915<916 → BLOCK (no slack)" "FULL-STORY-SWEEP BLOCKER"
+
+# 4. POSITIVE via fallback field: summary.total=500 (no storyResults) → BLOCK
+run_hook "/tmp/x-sweep.json" '{"summary":{"total":500}}'
+expect_block "4. [POS] fallback summary.total=500<916 → BLOCK" "FULL-STORY-SWEEP BLOCKER"
+
+# 5. POSITIVE via Edit tool + new_string field → BLOCK
+run_hook ".claude/snapshots/visual-audit-report.json" "$(sampled_results 100)" "Edit" "1"
+expect_block "5. [POS] Edit new_string sampled 100<916 → BLOCK" "FULL-STORY-SWEEP BLOCKER"
+
+# ── NEGATIVE cases(should NOT block)──────────────────────────────
+
+# 6. NEGATIVE: full sweep storyResults == 916 → silent
+run_hook "/tmp/codex-2026-sweep/audit-report.json" "$(sampled_results 916)"
+expect_pass_silent "6. [NEG] full 916==916 → silent (complete sweep passes)"
+
+# 7. NEGATIVE: over-count 920 >= 916 → silent (hook uses < not !=)
+run_hook "/tmp/codex-2026-sweep/audit-report.json" "$(sampled_results 920)"
+expect_pass_silent "7. [NEG] 920>=916 → silent"
+
+# 8. NEGATIVE escape: sampled but `_sampling_allowed` rationale present → silent
+run_hook "/tmp/codex-sweep/audit-report.json" \
+  '{"_sampling_allowed":"smoke test only","storyResults":[{"id":"s0"}]}'
+expect_pass_silent "8. [NEG] _sampling_allowed escape → silent"
+
+# 9. NEGATIVE near-miss filename (M34 over-broad guard):
+#    "sweeper-config.json" / "audit-reporter.json" do NOT end in (sweep|audit-report).json
+run_hook "/tmp/sweeper-config.json" "$(sampled_results 1)"
+expect_pass_silent "9. [NEG] sweeper-config.json (not *sweep.json) → silent (regex not over-broad)"
+
+# 10. NEGATIVE near-miss filename: audit-reporter.json (suffix, not audit-report.json)
+run_hook "/tmp/audit-reporter.json" "$(sampled_results 1)"
+expect_pass_silent "10. [NEG] audit-reporter.json → silent (regex anchored, not over-broad)"
+
+# 11. NEGATIVE: unrelated .json file (regular config) → silent
+run_hook "/tmp/some-component-data.json" "$(sampled_results 1)"
+expect_pass_silent "11. [NEG] unrelated *.json → silent (file gate)"
+
+# 12. NEGATIVE: non-Write/Edit tool (Read) on a sweep file → silent
+run_hook "/tmp/codex-sweep/audit-report.json" "$(sampled_results 1)" "Read"
+expect_pass_silent "12. [NEG] tool=Read → silent (event gate)"
+
+# 13. NEGATIVE: STORY_COUNT=0 (no parseable count) → silent
+#     (hook explicitly exits 0 when count is 0 to avoid false positive on non-sweep payloads)
+run_hook "/tmp/codex-sweep/audit-report.json" '{"meta":{"note":"warmup"}}'
+expect_pass_silent "13. [NEG] count=0 unparseable → silent"
+
+# 14. NEGATIVE: empty content → silent
+run_hook "/tmp/codex-sweep/audit-report.json" ""
+expect_pass_silent "14. [NEG] empty content → silent"
+
+# 15. NEGATIVE: manifest missing → silent (graceful degrade)
+#     Temporarily point at a project dir without a manifest.
+NOMANIFEST_DIR=$(mktemp -d)
+mkdir -p "$NOMANIFEST_DIR/.claude/logs"
+payload=$(jq -n --arg fp "/tmp/codex-sweep/audit-report.json" --arg c "$(sampled_results 10)" \
+  '{hook_event_name:"PreToolUse", tool_name:"Write", tool_input:{file_path:$fp, content:$c}}')
+STDOUT=$(mktemp); STDERR=$(mktemp)
+set +e
+printf '%s' "$payload" | CLAUDE_PROJECT_DIR="$NOMANIFEST_DIR" bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+EXIT=$?
+set -e
+STDERR_TEXT=$(cat "$STDERR")
+rm -f "$STDOUT" "$STDERR"
+expect_pass_silent "15. [NEG] manifest missing → silent (graceful degrade)"
+rm -rf "$NOMANIFEST_DIR"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  printf "Failed:%b\n" "$FAILED_TESTS"
+  exit 1
+fi
+exit 0

package/ds-canonical/hooks/tests/test_check_hardcoded_strings.sh

@@ -0,0 +1,14 @@
+#!/bin/bash
+set -u
+HOOK="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/../lib/_hardcoded_strings.sh"
+[ -x "$HOOK" ] || { echo "FATAL"; exit 1; }
+PASS=0; FAIL=0
+run_hook() {
+  local payload=$(jq -n --arg fp "$1" --arg ct "$2" '{tool_name:"Write", tool_input:{file_path:$fp, content:$ct}}')
+  STDOUT=$(echo "$payload" | bash "$HOOK" 2>&1); EXIT=$?
+}
+echo "Test 1: non-DS file → silent skip"
+run_hook "/tmp/test.tsx" "<div>長字串確認被略過</div>"
+[ "$EXIT" = "0" ] && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL ($STDOUT)"; FAIL=$((FAIL+1)); }
+echo "Results: $PASS PASS, $FAIL FAIL"
+[ "$FAIL" -eq 0 ] || exit 1

package/ds-canonical/hooks/tests/test_check_header_with_tabs_border.sh

@@ -0,0 +1,110 @@
+#!/bin/bash
+# Tests for check_header_with_tabs_border.sh(header-canonical W1 BLOCKER)
+#
+# Hook 規則:PreToolUse Edit/Write/MultiEdit + file 為 `packages/design-system/src/**/*.tsx`(非 stories)→
+#   讀 disk content + tool_input.new_string/content 合 FULL_CONTENT;
+#   含 `<XxxHeader>` + `<Tabs|TabsList|TabsTrigger>` JSX 但 `withTabs` 出現 0 次 → exit 2 BLOCKER。
+#   header > withTabs(但 ≥ 1)→ soft warn exit 0。
+# Allow:FULL_CONTENT 含 `@header-withtabs-allow:` → 整檔豁免。
+# Skip:stories.tsx / anatomy.stories.tsx / principles.stories.tsx。
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../lib/_header_with_tabs_border.sh"
+
+if [ ! -x "$HOOK" ]; then
+  echo "FATAL: hook not executable: $HOOK"
+  exit 1
+fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+run_hook() {
+  local file_path="$1"; local content="$2"
+  local payload
+  payload=$(jq -n --arg fp "$file_path" --arg c "$content" \
+    '{tool_name: "Write", tool_input: {file_path: $fp, content: $c}}')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_pass_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent, exit=$EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_blocker() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "2" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit 2 + '$needle', got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_warn_silent_exit0() {
+  # exit 0 but stderr contains needle (soft warn)
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "0" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit 0 + warn '$needle', got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== check_header_with_tabs_border tests ==="
+
+# 1. Out-of-scope path (random tsx) → skip
+run_hook "/repo/src/foo.tsx" '<ChromeHeader/><Tabs/>'
+expect_pass_silent "1. out-of-scope path → skip"
+
+# 2. Story file → skip
+run_hook "/repo/packages/design-system/src/components/Foo/foo.stories.tsx" '<ChromeHeader/><Tabs/>'
+expect_pass_silent "2. .stories.tsx → skip"
+
+# 3. In-scope but no header → skip
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '<button/>'
+expect_pass_silent "3. no header JSX → skip"
+
+# 4. In-scope header but no Tabs → skip
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '<ChromeHeader/>'
+expect_pass_silent "4. header but no Tabs → skip"
+
+# 5. In-scope header + Tabs + withTabs prop → silent
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '<ChromeHeader withTabs><TabsList ></TabsList></ChromeHeader>'
+expect_pass_silent "5. header + Tabs + withTabs → silent"
+
+# 6. In-scope header + Tabs WITHOUT withTabs → BLOCKER exit 2
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '<ChromeHeader><TabsList ></TabsList></ChromeHeader>'
+expect_blocker "6. header + Tabs missing withTabs → BLOCKER" "HEADER + TABS WITHTABS BLOCKER"
+
+# 7. With allow escape → silent
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '// @header-withtabs-allow: special case
+<ChromeHeader><TabsList ></TabsList></ChromeHeader>'
+expect_pass_silent "7. @header-withtabs-allow → silent"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  echo "Failed:$FAILED_TESTS"
+  exit 1
+fi

package/ds-canonical/hooks/tests/test_check_item_list_gap.sh

@@ -0,0 +1,44 @@
+#!/bin/bash
+# Tests for check_item_list_gap.sh(M16)
+
+set -u
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_item_list_gap.sh"
+[ ! -f "$HOOK" ] && { echo "FATAL"; exit 1; }
+PASS=0; FAIL=0
+
+run() {
+  local fp="$1"; local content="$2"
+  local payload=$(jq -n --arg fp "$fp" --arg c "$content" \
+    '{hook_event_name:"PreToolUse",tool_name:"Write",tool_input:{file_path:$fp,content:$c}}')
+  STDERR=$(mktemp)
+  printf '%s' "$payload" | bash "$HOOK" 2>"$STDERR" >/dev/null
+  STDERR_TEXT=$(cat "$STDERR"); rm -f "$STDERR"
+}
+
+# Test 1:2+ FileItem 無 gap → warn
+echo "Test 1: 2+ FileItem no gap → warn"
+CONTENT='<div><FileItem /><FileItem /><FileItem /></div>'
+run "/path/foo.tsx" "$CONTENT"
+if echo "$STDERR_TEXT" | grep -q "M16 Item-list gap"; then echo "  PASS"; PASS=$((PASS+1)); else echo "  FAIL: no warn"; FAIL=$((FAIL+1)); fi
+
+# Test 2:有 gap-2 parent → silent
+echo "Test 2: with gap-2 parent → silent"
+CONTENT='<div className="flex gap-2"><FileItem /><FileItem /></div>'
+run "/path/foo.tsx" "$CONTENT"
+if [ -z "$STDERR_TEXT" ]; then echo "  PASS"; PASS=$((PASS+1)); else echo "  FAIL"; FAIL=$((FAIL+1)); fi
+
+# Test 3:single FileItem → silent
+echo "Test 3: single FileItem → silent"
+run "/path/foo.tsx" '<FileItem />'
+if [ -z "$STDERR_TEXT" ]; then echo "  PASS"; PASS=$((PASS+1)); else echo "  FAIL"; FAIL=$((FAIL+1)); fi
+
+# Test 4:stories.tsx skip
+echo "Test 4: stories.tsx skip"
+run "/path/foo.stories.tsx" '<FileItem /><FileItem />'
+if [ -z "$STDERR_TEXT" ]; then echo "  PASS"; PASS=$((PASS+1)); else echo "  FAIL"; FAIL=$((FAIL+1)); fi
+
+echo ""
+echo "════ Results: $PASS PASS, $FAIL FAIL ════"
+[ "$FAIL" -gt 0 ] && exit 1
+exit 0

package/ds-canonical/hooks/tests/test_check_layout_space_canonical.sh

@@ -0,0 +1,73 @@
+#!/bin/bash
+# Tests for check_layout_space_canonical.sh
+set -u
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../lib/_layout_space_canonical.sh"
+[ -x "$HOOK" ] || { echo "FATAL: hook not executable"; exit 1; }
+PASS=0; FAIL=0
+
+setup() { TMP=$(mktemp -d); mkdir -p "$TMP/.claude/hooks"; echo 'log_hook_fire(){ :; }' > "$TMP/.claude/hooks/_log-fire.sh"; }
+teardown() { rm -rf "$TMP"; }
+
+run() {
+  local fp="$1"
+  STDOUT=$(echo "{\"tool_input\":{\"file_path\":\"$fp\"}}" | bash "$HOOK" 2>&1)
+  EXIT=$?
+}
+
+# Test 1: out-of-scope file → silent
+echo "Test 1: out-of-scope path → silent"
+setup
+echo "<div></div>" > "$TMP/random.tsx"
+run "$TMP/random.tsx"
+[ "$EXIT" = "0" ] && [ -z "$STDOUT" ] && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 2: stories.tsx with block + tight margin → flag
+echo "Test 2: tight margin near DataTable → flagged"
+setup
+mkdir -p "$TMP/packages/design-system/src/components"
+cat > "$TMP/test.stories.tsx" <<EOF
+import { DataTable } from '@/design-system/components/DataTable/data-table'
+export const X = { render: () => (
+  <div>
+    <DataTable />
+    <div className="mt-[var(--layout-space-tight)]">Footer</div>
+  </div>
+)}
+EOF
+run "$TMP/test.stories.tsx"
+echo "$STDOUT" | grep -q "tight margin near block" && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 3: gap-tight on flex-col → flag
+echo "Test 3: flex-col gap-tight → flagged"
+setup
+cat > "$TMP/test.stories.tsx" <<EOF
+export const Y = { render: () => (
+  <div className="flex flex-col gap-[var(--layout-space-tight)]">
+    <Input /><Button /><Select />
+  </div>
+)}
+EOF
+run "$TMP/test.stories.tsx"
+echo "$STDOUT" | grep -q "flex-col gap-tight" && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 4: clean stories.tsx → silent
+echo "Test 4: compliant stories.tsx → silent"
+setup
+cat > "$TMP/clean.stories.tsx" <<EOF
+export const Z = { render: () => (
+  <div className="flex flex-col gap-[var(--layout-space-loose)]">
+    <Input /><Button />
+  </div>
+)}
+EOF
+run "$TMP/clean.stories.tsx"
+[ "$EXIT" = "0" ] && [ -z "$STDOUT" ] && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+echo ""
+echo "── Summary: $PASS / $((PASS+FAIL)) passed ──"
+[ "$FAIL" -eq 0 ] && echo "✅ All passed" || exit 1

package/ds-canonical/hooks/tests/test_check_layout_space_magic_numbers.sh

@@ -0,0 +1,206 @@
+#!/bin/bash
+# Tests for check_layout_space_magic_numbers.sh(P0 BLOCKER,2026-05-27 codified)
+#
+# Hook 契約(PostToolUse,Edit|Write|MultiEdit):
+#   - 讀 tool_name / tool_input.file_path(or notebook_path)/ tool_input.new_string(or content)
+#   - Scope:只查 .tsx / .ts;skip packages/design-system/src/ + node_modules/
+#   - BLOCKER(exit 2):content 任一行命中 Tailwind spacing magic-number regex
+#       \b(p|px|py|pt|pb|pl|pr|gap|space-x|space-y|m|mx|my|mt|mb|ml|mr)-(0\.5|[1-9][0-9]?(\.[0-9])?)\b
+#     且該行 **無** escape marker `@layout-space-magic-ok:`
+#   - Escape:同行 OR 前一行加 `// @layout-space-magic-ok: <rationale>` → 該行被濾掉
+#     (前一行支援 2026-06-03 補實作 — JSX className 行無法放同行 //,必靠前一行 {/* */})
+#   - 非 Edit/Write/MultiEdit tool / 非 .tsx,.ts / DS src / 空 content → silent exit 0
+#
+# M34 broad-vs-narrow symmetry:
+#   - over-narrow guard:p-4 / px-6 / gap-3 / gap-0.5 / m-2 等真 violation 必 fire
+#   - over-broad guard:p-0(padding zero,regex 不收 `0`)/ token var() 用法 /
+#     非 spacing class(text-sm / w-4 / size-3)/ JSX prop(size={24})必 silent
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_layout_space_magic_numbers.sh"
+
+if [ ! -x "$HOOK" ]; then
+  echo "FATAL: hook not executable: $HOOK"
+  exit 1
+fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+TMP_DIR=$(mktemp -d)
+trap 'rm -rf "$TMP_DIR"' EXIT
+
+# Override CLAUDE_PROJECT_DIR so _log-fire.sh per-hook log lands in TMP_DIR
+# (避免污染 repo .claude/logs/)
+export CLAUDE_PROJECT_DIR="$TMP_DIR"
+mkdir -p "$TMP_DIR/.claude/logs"
+
+# run_hook <tool> <file_path> <content_field> <content>
+#   content_field ∈ {new_string, content} — 測 hook 兩條讀法都 work
+run_hook() {
+  local tool="$1"; local file_path="$2"; local field="$3"; local content="$4"
+  local payload
+  payload=$(jq -n \
+    --arg t "$tool" --arg fp "$file_path" --arg c "$content" --arg f "$field" \
+    '{hook_event_name:"PostToolUse", tool_name:$t,
+      tool_input: ({file_path:$fp} + {($f):$c})}')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_block() {
+  local name="$1"; local needle="${2:-LAYOUT-SPACE-MAGIC-NUMBER BLOCKER}"
+  if [ "$EXIT" = "2" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected BLOCK exit=2 + '$needle', got exit=$EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent exit=0, got exit=$EXIT, stderr=$([ -n "$STDERR_TEXT" ] && echo non-empty || echo empty))"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== check_layout_space_magic_numbers tests ==="
+
+APP_TSX="/Users/x/my-project/apps/template/src/screens/Dashboard.tsx"
+APP_TS="/Users/x/my-project/apps/template/src/lib/layout.ts"
+DS_TSX="/Users/x/my-project/packages/design-system/src/components/Button/button.tsx"
+
+# ─────────────────────────────────────────────────────────────
+# POSITIVE cases — SHOULD trigger BLOCKER (over-narrow guard)
+# ─────────────────────────────────────────────────────────────
+
+# P1. Classic consumer padding magic number → BLOCK
+run_hook "Write" "$APP_TSX" "content" \
+  'export const Card = () => <div className="p-4 rounded-md">內容</div>;'
+expect_block "P1. p-4 consumer padding → BLOCK"
+
+# P2. Multiple spacing classes (px / py / gap) → BLOCK
+run_hook "Edit" "$APP_TSX" "new_string" \
+  '  return <section className="px-6 py-2 gap-3 flex">{children}</section>;'
+expect_block "P2. px-6 py-2 gap-3 (new_string field) → BLOCK"
+
+# P3. space-y magic → BLOCK
+run_hook "Write" "$APP_TSX" "content" \
+  'const List = () => <ul className="space-y-4">{items}</ul>;'
+expect_block "P3. space-y-4 → BLOCK"
+
+# P4. Fractional 0.5 magic (edge of regex) → BLOCK
+run_hook "Write" "$APP_TSX" "content" \
+  'const Row = () => <div className="gap-0.5">x</div>;'
+expect_block "P4. gap-0.5 fractional → BLOCK"
+
+# P5. margin family (mt / mb / mx) → BLOCK
+run_hook "Write" "$APP_TSX" "content" \
+  'const Hero = () => <div className="mt-8 mb-12 mx-4">hero</div>;'
+expect_block "P5. mt-8 mb-12 mx-4 margin → BLOCK"
+
+# P6. Two-digit value (p-10) → BLOCK
+run_hook "Write" "$APP_TSX" "content" \
+  'const Wide = () => <div className="p-10">wide</div>;'
+expect_block "P6. p-10 two-digit → BLOCK"
+
+# P7. Magic number in .ts (not just .tsx) → BLOCK
+run_hook "Edit" "$APP_TS" "new_string" \
+  'export const cardCls = "px-4 py-3 gap-2";'
+expect_block "P7. magic in .ts file → BLOCK"
+
+# P8. Mixed: one escaped line + one un-escaped magic line → still BLOCK
+#     (un-escaped line is the real violation)
+run_hook "Write" "$APP_TSX" "content" \
+'const A = () => (
+  <div>
+    <span className="gap-1" /> {/* @layout-space-magic-ok: 4px icon stack non-layout */}
+    <span className="p-6" />
+  </div>
+);'
+expect_block "P8. mixed escaped + un-escaped magic → BLOCK"
+
+# ─────────────────────────────────────────────────────────────
+# NEGATIVE cases — should NOT trigger (over-broad guard)
+# ─────────────────────────────────────────────────────────────
+
+# N1. layoutSpace token var() usage → silent (the canonical correct form)
+run_hook "Write" "$APP_TSX" "content" \
+  'const Card = () => <div className="p-[var(--layout-space-loose)] gap-[var(--layout-space-tight)]">ok</div>;'
+expect_silent "N1. p-[var(--layout-space-loose)] token → silent"
+
+# N2. NEAR-MISS: p-0 / m-0 (padding/margin zero — regex 不收 `0`) → silent
+run_hook "Write" "$APP_TSX" "content" \
+  'const Main = () => <main className="p-0 m-0">landmark padding=0 intentional</main>;'
+expect_silent "N2. near-miss p-0 m-0 → silent (regex excludes 0)"
+
+# N3. NEAR-MISS: non-spacing utilities that contain digits (w-4 / h-8 / text-sm / size-3 / z-10) → silent
+run_hook "Write" "$APP_TSX" "content" \
+  'const Icon = () => <svg className="w-4 h-8 text-sm z-10 size-3 rounded-2" />;'
+expect_silent "N3. near-miss w-4/h-8/text-sm/size-3 non-spacing → silent"
+
+# N4. Escape marker on the magic line → silent
+run_hook "Write" "$APP_TSX" "content" \
+  'const Stack = () => <div className="gap-1">x</div>; // @layout-space-magic-ok: 4px icon stack, non-consumer-layout'
+expect_silent "N4. magic line with @layout-space-magic-ok escape → silent"
+
+# N4b. 2026-06-03 回歸防護:escape marker 在「前一行」→ silent。JSX className 行無法放同行 //,
+#      原 code 只查同行(doc 卻宣稱支援前一行)→ JSX escape 實質失效;修後前一行 marker 必被認。
+run_hook "Write" "$APP_TSX" "content" \
+  'const C = () => (
+  {/* @layout-space-magic-ok: dev artifact wrapper, non-consumer-layout */}
+  <div className="p-4">x</div>
+);'
+expect_silent "N4b. magic line with escape on PRECEDING line → silent(回歸防護)"
+
+# N5. DS source file is excluded from scope → silent (even WITH magic number)
+run_hook "Write" "$DS_TSX" "content" \
+  'const Btn = () => <button className="px-4 py-2 gap-2">click</button>;'
+expect_silent "N5. magic in packages/design-system/src → silent (out of scope)"
+
+# N6. Non-.tsx/.ts file (e.g. .css) → silent
+run_hook "Write" "/Users/x/my-project/apps/template/src/globals.css" "content" \
+  '.card { padding: 16px; } /* p-4 in a comment */'
+expect_silent "N6. .css file → silent (scope is tsx/ts only)"
+
+# N7. Wrong tool (Read) → silent
+run_hook "Read" "$APP_TSX" "content" \
+  'const Card = () => <div className="p-4">x</div>;'
+expect_silent "N7. tool=Read → silent (only Edit/Write/MultiEdit)"
+
+# N8. Empty content → silent
+run_hook "Write" "$APP_TSX" "content" ""
+expect_silent "N8. empty content → silent"
+
+# N9. Clean consumer code with NO spacing classes at all → silent
+run_hook "Write" "$APP_TSX" "content" \
+  'export const Greeting = ({ name }: { name: string }) => <h1 className="text-lg font-semibold text-fg">Hello {name}</h1>;'
+expect_silent "N9. clean code, no spacing class → silent"
+
+# N10. node_modules path excluded → silent
+run_hook "Write" "/Users/x/my-project/node_modules/@qijenchen/design-system/dist/x.tsx" "content" \
+  'const X = () => <div className="p-4">x</div>;'
+expect_silent "N10. node_modules path → silent (out of scope)"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  printf "Failed:%b\n" "$FAILED_TESTS"
+  exit 1
+fi
+exit 0