@pyric/cli 0.1.0-alpha.14 → 0.1.0-alpha.15

package/src/cli/service-command-records/database-rules-generate.ts

@@ -0,0 +1,3 @@
+import { runDatabaseRulesGenerate } from '../database-rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runDatabaseRulesGenerate satisfies ServiceCommandHandler;

package/src/cli/service-command-records/database-rules-lint.ts

@@ -0,0 +1,3 @@
+import { runDatabaseRulesLint } from '../database-rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runDatabaseRulesLint satisfies ServiceCommandHandler;

package/src/cli/service-command-records/database-rules-simulate.ts

@@ -0,0 +1,3 @@
+import { runDatabaseRulesSimulate } from '../database-rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runDatabaseRulesSimulate satisfies ServiceCommandHandler;

package/src/cli/service-command-records/database-rules-validate.ts

@@ -0,0 +1,3 @@
+import { runDatabaseRulesValidate } from '../database-rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runDatabaseRulesValidate satisfies ServiceCommandHandler;

package/src/cli/service-command-records/firestore-indexes-generate.ts

@@ -0,0 +1,3 @@
+import { runFirestoreIndexesGenerate } from '../firestore-indexes.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runFirestoreIndexesGenerate satisfies ServiceCommandHandler;

package/src/cli/service-command-records/firestore-rules-lint.ts

@@ -0,0 +1,3 @@
+import { runRulesLint } from '../rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runRulesLint satisfies ServiceCommandHandler;

package/src/cli/service-command-records/firestore-rules-resolve.ts

@@ -0,0 +1,3 @@
+import { runRulesResolve } from '../rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runRulesResolve satisfies ServiceCommandHandler;

package/src/cli/service-command-records/firestore-rules-simulate.ts

@@ -0,0 +1,3 @@
+import { runRulesSimulate } from '../rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runRulesSimulate satisfies ServiceCommandHandler;

package/src/cli/service-command-records/firestore-rules-validate.ts

@@ -0,0 +1,3 @@
+import { runRulesValidate } from '../rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runRulesValidate satisfies ServiceCommandHandler;

package/src/cli/service-command-records/storage-rules-lint.ts

@@ -0,0 +1,3 @@
+import { runStorageRulesLint } from '../storage-rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runStorageRulesLint satisfies ServiceCommandHandler;

package/src/cli/service-command-records/storage-rules-simulate.ts

@@ -0,0 +1,3 @@
+import { runStorageRulesSimulate } from '../storage-rules.js';
+import type { ServiceCommandHandler } from '../service-commands.js';
+export default runStorageRulesSimulate satisfies ServiceCommandHandler;

package/src/cli/service-commands.generated.ts

@@ -0,0 +1,27 @@
+// Generated by scripts/generate-service-command-registry.ts. Do not edit.
+import type { ServiceCommand } from './service-commands.js';
+import databaseRulesGenerate from './service-command-records/database-rules-generate.js';
+import databaseRulesLint from './service-command-records/database-rules-lint.js';
+import databaseRulesSimulate from './service-command-records/database-rules-simulate.js';
+import databaseRulesValidate from './service-command-records/database-rules-validate.js';
+import firestoreIndexesGenerate from './service-command-records/firestore-indexes-generate.js';
+import firestoreRulesLint from './service-command-records/firestore-rules-lint.js';
+import firestoreRulesResolve from './service-command-records/firestore-rules-resolve.js';
+import firestoreRulesSimulate from './service-command-records/firestore-rules-simulate.js';
+import firestoreRulesValidate from './service-command-records/firestore-rules-validate.js';
+import storageRulesLint from './service-command-records/storage-rules-lint.js';
+import storageRulesSimulate from './service-command-records/storage-rules-simulate.js';
+
+export const SERVICE_COMMANDS = [
+  { path: ["database","rules","generate"], run: databaseRulesGenerate },
+  { path: ["database","rules","lint"], run: databaseRulesLint },
+  { path: ["database","rules","simulate"], run: databaseRulesSimulate },
+  { path: ["database","rules","validate"], run: databaseRulesValidate },
+  { path: ["firestore","indexes","generate"], run: firestoreIndexesGenerate },
+  { path: ["firestore","rules","lint"], run: firestoreRulesLint },
+  { path: ["firestore","rules","resolve"], run: firestoreRulesResolve },
+  { path: ["firestore","rules","simulate"], run: firestoreRulesSimulate },
+  { path: ["firestore","rules","validate"], run: firestoreRulesValidate },
+  { path: ["storage","rules","lint"], run: storageRulesLint },
+  { path: ["storage","rules","simulate"], run: storageRulesSimulate },
+] as const satisfies readonly ServiceCommand[];

package/src/cli/service-commands.test.ts

@@ -0,0 +1,43 @@
+import { describe, expect, it } from 'bun:test';
+
+import { parseArgs } from './parse-args.js';
+import {
+  createServiceCommandRegistry,
+  dispatchServiceCommand,
+} from './service-commands.js';
+
+describe('service command dispatcher', () => {
+  it('leaves non-service commands for the top-level dispatcher', async () => {
+    expect(await dispatchServiceCommand(parseArgs(['dev']))).toBeNull();
+  });
+
+  it('rejects an unknown command beneath a known service with the complete invocation', async () => {
+    let stderr = '';
+    const originalWrite = process.stderr.write;
+    process.stderr.write = ((chunk: string | Uint8Array) => {
+      stderr += typeof chunk === 'string' ? chunk : Buffer.from(chunk).toString();
+      return true;
+    }) as typeof process.stderr.write;
+
+    try {
+      expect(
+        await dispatchServiceCommand(parseArgs(['firestore', 'rules', 'unknown', 'operand'])),
+      ).toBe(1);
+    } finally {
+      process.stderr.write = originalWrite;
+    }
+
+    expect(stderr).toBe("pyric: unknown command 'firestore rules unknown operand'.\n");
+  });
+
+  it('rejects duplicate route paths when constructing a registry', () => {
+    const run = async (): Promise<number> => 0;
+
+    expect(() =>
+      createServiceCommandRegistry([
+        { path: ['firestore', 'rules', 'lint'], run },
+        { path: ['firestore', 'rules', 'lint'], run },
+      ]),
+    ).toThrow("duplicate service command 'firestore rules lint'");
+  });
+});

package/src/cli/service-commands.ts

@@ -1,27 +1,38 @@
 import type { ParsedArgs } from './parse-args.js';
-import {
-  runDatabaseRulesGenerate,
-  runDatabaseRulesLint,
-  runDatabaseRulesSimulate,
-  runDatabaseRulesValidate,
-} from './database-rules.js';
-import { runFirestoreIndexesGenerate } from './firestore-indexes.js';
-import {
-  runRulesLint,
-  runRulesResolve,
-  runRulesSimulate,
-  runRulesValidate,
-} from './rules.js';
-import { runStorageRulesLint, runStorageRulesSimulate } from './storage-rules.js';
+import { SERVICE_COMMANDS } from './service-commands.generated.js';
 
-const SERVICES = new Set(['firestore', 'storage', 'database']);
+export type ServiceCommandPath = readonly [service: string, artifact: string, operation: string];
 
-function invocation(parsed: ParsedArgs): string {
-  return [parsed.subcommand, ...parsed.positional].filter(Boolean).join(' ');
+export interface ServiceCommand {
+  path: ServiceCommandPath;
+  run: ServiceCommandHandler;
+}
+
+export type ServiceCommandHandler = (parsed: ParsedArgs) => Promise<number>;
+
+function routeKey(path: readonly string[]): string {
+  return JSON.stringify(path);
 }
 
-function argumentsAfterPath(parsed: ParsedArgs, pathLength: number): ParsedArgs {
-  return { ...parsed, positional: parsed.positional.slice(pathLength - 1) };
+export function createServiceCommandRegistry(
+  commands: readonly ServiceCommand[],
+): ReadonlyMap<string, ServiceCommand> {
+  const registry = new Map<string, ServiceCommand>();
+  for (const command of commands) {
+    const key = routeKey(command.path);
+    if (registry.has(key)) {
+      throw new Error(`duplicate service command '${command.path.join(' ')}'`);
+    }
+    registry.set(key, command);
+  }
+  return registry;
+}
+
+const SERVICE_COMMAND_REGISTRY = createServiceCommandRegistry(SERVICE_COMMANDS);
+const SERVICES: ReadonlySet<string> = new Set(SERVICE_COMMANDS.map(({ path }) => path[0]));
+
+function invocation(parsed: ParsedArgs): string {
+  return [parsed.subcommand, ...parsed.positional].filter(Boolean).join(' ');
 }
 
 /**
@@ -34,38 +45,12 @@ export async function dispatchServiceCommand(parsed: ParsedArgs): Promise<number
   if (!service || !SERVICES.has(service)) return null;
 
   const [artifact, operation] = parsed.positional;
-  if (service === 'firestore' && artifact === 'rules' && operation === 'lint') {
-    return await runRulesLint(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'firestore' && artifact === 'rules' && operation === 'validate') {
-    return await runRulesValidate(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'firestore' && artifact === 'rules' && operation === 'simulate') {
-    return await runRulesSimulate(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'firestore' && artifact === 'rules' && operation === 'resolve') {
-    return await runRulesResolve(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'firestore' && artifact === 'indexes' && operation === 'generate') {
-    return await runFirestoreIndexesGenerate(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'storage' && artifact === 'rules' && operation === 'lint') {
-    return await runStorageRulesLint(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'storage' && artifact === 'rules' && operation === 'simulate') {
-    return await runStorageRulesSimulate(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'database' && artifact === 'rules' && operation === 'lint') {
-    return await runDatabaseRulesLint(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'database' && artifact === 'rules' && operation === 'validate') {
-    return await runDatabaseRulesValidate(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'database' && artifact === 'rules' && operation === 'simulate') {
-    return await runDatabaseRulesSimulate(argumentsAfterPath(parsed, 3));
-  }
-  if (service === 'database' && artifact === 'rules' && operation === 'generate') {
-    return await runDatabaseRulesGenerate(argumentsAfterPath(parsed, 3));
+  const command = SERVICE_COMMAND_REGISTRY.get(routeKey([service, artifact, operation]));
+  if (command) {
+    return await command.run({
+      ...parsed,
+      positional: parsed.positional.slice(command.path.length - 1),
+    });
   }
 
   process.stderr.write(`pyric: unknown command '${invocation(parsed)}'.\n`);