@pyreon/vite-plugin 0.24.4 → 0.24.5

package/lib/analysis/index.js.html

@@ -5386,7 +5386,7 @@ var drawChart = (function (exports) {
   </script>
   <script>
     /*<!--*/
-    const data = {"version":2,"tree":{"name":"root","children":[{"name":"index.js","children":[{"name":"src/index.ts","uid":"e04d9c6c-1"}]},{"name":"rocketstyle-collapse-C4eMAnwR.js","children":[{"name":"src/rocketstyle-collapse.ts","uid":"e04d9c6c-3"}]}],"isRoot":true},"nodeParts":{"e04d9c6c-1":{"renderedLength":45559,"gzipLength":14773,"brotliLength":0,"metaUid":"e04d9c6c-0"},"e04d9c6c-3":{"renderedLength":3424,"gzipLength":1530,"brotliLength":0,"metaUid":"e04d9c6c-2"}},"nodeMetas":{"e04d9c6c-0":{"id":"/src/index.ts","moduleParts":{"index.js":"e04d9c6c-1"},"imported":[{"uid":"e04d9c6c-4"},{"uid":"e04d9c6c-5"},{"uid":"e04d9c6c-6"},{"uid":"e04d9c6c-2","dynamic":true},{"uid":"e04d9c6c-7","dynamic":true}],"importedBy":[],"isEntry":true},"e04d9c6c-2":{"id":"/src/rocketstyle-collapse.ts","moduleParts":{"rocketstyle-collapse-C4eMAnwR.js":"e04d9c6c-3"},"imported":[{"uid":"e04d9c6c-8","dynamic":true}],"importedBy":[{"uid":"e04d9c6c-0"}]},"e04d9c6c-4":{"id":"node:fs","moduleParts":{},"imported":[],"importedBy":[{"uid":"e04d9c6c-0"}]},"e04d9c6c-5":{"id":"node:path","moduleParts":{},"imported":[],"importedBy":[{"uid":"e04d9c6c-0"}]},"e04d9c6c-6":{"id":"@pyreon/compiler","moduleParts":{},"imported":[],"importedBy":[{"uid":"e04d9c6c-0"}]},"e04d9c6c-7":{"id":"node:fs/promises","moduleParts":{},"imported":[],"importedBy":[{"uid":"e04d9c6c-0"}]},"e04d9c6c-8":{"id":"vite","moduleParts":{},"imported":[],"importedBy":[{"uid":"e04d9c6c-2"}]}},"env":{"rollup":"4.23.0"},"options":{"gzip":true,"brotli":false,"sourcemap":false}};
+    const data = {"version":2,"tree":{"name":"root","children":[{"name":"index.js","children":[{"name":"src/index.ts","uid":"4f3120a0-1"}]},{"name":"rocketstyle-collapse-C4eMAnwR.js","children":[{"name":"src/rocketstyle-collapse.ts","uid":"4f3120a0-3"}]}],"isRoot":true},"nodeParts":{"4f3120a0-1":{"renderedLength":45599,"gzipLength":14790,"brotliLength":0,"metaUid":"4f3120a0-0"},"4f3120a0-3":{"renderedLength":3424,"gzipLength":1530,"brotliLength":0,"metaUid":"4f3120a0-2"}},"nodeMetas":{"4f3120a0-0":{"id":"/src/index.ts","moduleParts":{"index.js":"4f3120a0-1"},"imported":[{"uid":"4f3120a0-4"},{"uid":"4f3120a0-5"},{"uid":"4f3120a0-6"},{"uid":"4f3120a0-2","dynamic":true},{"uid":"4f3120a0-7","dynamic":true}],"importedBy":[],"isEntry":true},"4f3120a0-2":{"id":"/src/rocketstyle-collapse.ts","moduleParts":{"rocketstyle-collapse-C4eMAnwR.js":"4f3120a0-3"},"imported":[{"uid":"4f3120a0-8","dynamic":true}],"importedBy":[{"uid":"4f3120a0-0"}]},"4f3120a0-4":{"id":"node:fs","moduleParts":{},"imported":[],"importedBy":[{"uid":"4f3120a0-0"}]},"4f3120a0-5":{"id":"node:path","moduleParts":{},"imported":[],"importedBy":[{"uid":"4f3120a0-0"}]},"4f3120a0-6":{"id":"@pyreon/compiler","moduleParts":{},"imported":[],"importedBy":[{"uid":"4f3120a0-0"}]},"4f3120a0-7":{"id":"node:fs/promises","moduleParts":{},"imported":[],"importedBy":[{"uid":"4f3120a0-0"}]},"4f3120a0-8":{"id":"vite","moduleParts":{},"imported":[],"importedBy":[{"uid":"4f3120a0-2"}]}},"env":{"rollup":"4.23.0"},"options":{"gzip":true,"brotli":false,"sourcemap":false}};
 
     const run = () => {
       const width = window.innerWidth;

package/lib/index.js

@@ -236,6 +236,7 @@ function pyreonPlugin(options) {
 			const pyreonExclude = scanPyreonDeps(projectRoot);
 			return {
 				resolve: { conditions: ["bun"] },
+				ssr: { noExternal: [/@pyreon\//] },
 				optimizeDeps: { exclude: Array.from(new Set([...compatExclude, ...pyreonExclude])) },
 				oxc: { jsx: {
 					runtime: "automatic",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pyreon/vite-plugin",
-  "version": "0.24.4",
+  "version": "0.24.5",
   "description": "Vite plugin for Pyreon — .pyreon SFC support, HMR, compiler integration",
   "homepage": "https://github.com/pyreon/pyreon/tree/main/packages/vite-plugin#readme",
   "bugs": {
@@ -43,7 +43,7 @@
     "prepublishOnly": "bun run build"
   },
   "dependencies": {
-    "@pyreon/compiler": "^0.24.4"
+    "@pyreon/compiler": "^0.24.5"
   },
   "devDependencies": {
     "vite": "^8.0.0"

package/src/index.ts

@@ -504,6 +504,28 @@ export default function pyreonPlugin(options?: PyreonPluginOptions): Plugin {
         // Use "bun" condition for workspace resolution — source .ts/.tsx files
         // for HMR, fast refresh, and type-safe imports.
         resolve: { conditions: ['bun'] },
+        // Force every `@pyreon/*` package through Vite's transform pipeline
+        // for SSR. Without this, Vite externalizes some `@pyreon/*` packages
+        // (loads via Node's `import()`) while transforming others — producing
+        // TWO module instances of `@pyreon/core` (one at `lib/index.js`, one
+        // at `src/index.ts` via the `bun` condition). The two instances have
+        // SEPARATE `_current` lifecycle state, so `runWithHooks` sets
+        // `_current` on instance A while `provide()` reads `_current` from
+        // instance B → null → `provide() outside setup` warning storm.
+        //
+        // Real-app symptom (bokisch.com dev-404 SSR, 0.24.4): 17 spurious
+        // `[Pyreon] onUnmount() called outside component setup` warnings
+        // per unmatched URL hit, even though every `provide()` IS structurally
+        // inside a `runWithHooks` setup window. Fix is purely a Vite
+        // module-graph reconciliation; no runtime behavior change.
+        //
+        // The regex `/@pyreon\//` matches every framework package + every
+        // user-side `@pyreon/*` import. Internal `@pyreon/*` resolution
+        // chains (zero → runtime-server → core; user `_layout.tsx` →
+        // ui-core → core) all converge on the same module instance.
+        ssr: {
+          noExternal: [/@pyreon\//],
+        },
         optimizeDeps: {
           exclude: optimizeDepsExclude,
         },

package/src/tests/ssr-no-external.test.ts

@@ -0,0 +1,82 @@
+/**
+ * Regression lock: `@pyreon/vite-plugin` must set
+ * `ssr.noExternal: [/@pyreon\//]` so every framework package goes through
+ * Vite's transform pipeline. Without this, Vite externalizes some
+ * `@pyreon/*` packages (loads via Node's `import()`) while transforming
+ * others — producing TWO module instances of `@pyreon/core` (one at
+ * `lib/index.js` via `import` condition, one at `src/index.ts` via the
+ * `bun` condition). The two instances have SEPARATE `_current` lifecycle
+ * state → `provide()` outside setup warning storm.
+ *
+ * Real-app symptom (bokisch.com dev-404 SSR, 0.24.4): 17 spurious
+ * `[Pyreon] onUnmount() called outside component setup` warnings per
+ * unmatched URL hit, even though every `provide()` IS structurally
+ * inside a `runWithHooks` setup window.
+ *
+ * Reproduction trace (the differential):
+ *   at onUnmount        (.../core/lib/index.js:68)       ← LIB
+ *   at provide          (.../core/lib/index.js:427)      ← LIB
+ *   at HeadProvider     (.../head/lib/provider.js:44)    ← LIB
+ *   at runWithHooks     (.../core/src/component.ts:34)   ← SRC ❗
+ *   at renderComponent  (.../runtime-server/lib/index.js:308)
+ *
+ * `head/lib` and `runtime-server/lib` resolve `@pyreon/core` via
+ * different Vite paths — `head` lands at `lib/`, `runtime-server` lands
+ * at `src/`. Two `_current` variables, two `setCurrentHooks` slots, the
+ * one that gets set is NOT the one `provide()` reads from.
+ *
+ * Bisect-verified: removing `ssr.noExternal` from `vite-plugin`'s
+ * `config()` return → bokisch reproduces 17 warnings on `/xyzzy-404`.
+ * Restored → 1 (the residual is a separate `useWindowResize` bug class).
+ */
+import pyreon from '@pyreon/vite-plugin'
+import { describe, expect, it } from 'vitest'
+
+describe('@pyreon/vite-plugin — ssr.noExternal regression lock', () => {
+  it('config() return includes ssr.noExternal matching @pyreon/* via regex', () => {
+    const plugin = pyreon()
+    const cfg = (plugin as { config: (u: unknown, e: unknown) => unknown }).config(
+      { root: process.cwd() },
+      { command: 'serve' as const, mode: 'development', isPreview: false, isSsrBuild: false },
+    ) as { ssr?: { noExternal?: unknown } }
+
+    expect(cfg.ssr).toBeDefined()
+    expect(cfg.ssr?.noExternal).toBeDefined()
+    expect(Array.isArray(cfg.ssr?.noExternal)).toBe(true)
+
+    const arr = cfg.ssr?.noExternal as readonly (string | RegExp)[]
+    expect(arr.length).toBeGreaterThan(0)
+
+    // The regex must match every @pyreon/* package name. Without this,
+    // Vite externalizes some packages and the module-instance duplication
+    // bug returns.
+    const matches = (name: string) =>
+      arr.some((entry) => (entry instanceof RegExp ? entry.test(name) : entry === name))
+
+    expect(matches('@pyreon/core'), '@pyreon/core must be noExternal').toBe(true)
+    expect(matches('@pyreon/runtime-server'), '@pyreon/runtime-server must be noExternal').toBe(true)
+    expect(matches('@pyreon/router'), '@pyreon/router must be noExternal').toBe(true)
+    expect(matches('@pyreon/head'), '@pyreon/head must be noExternal').toBe(true)
+    expect(matches('@pyreon/ui-core'), '@pyreon/ui-core must be noExternal').toBe(true)
+    expect(matches('@pyreon/styler'), '@pyreon/styler must be noExternal').toBe(true)
+    expect(matches('@pyreon/elements'), '@pyreon/elements must be noExternal').toBe(true)
+    expect(matches('@pyreon/rocketstyle'), '@pyreon/rocketstyle must be noExternal').toBe(true)
+    // Hypothetical third-party @pyreon package — the regex should match too.
+    expect(matches('@pyreon/anything-new'), 'regex must match future packages').toBe(true)
+  })
+
+  it('regex does NOT match non-@pyreon packages', () => {
+    const plugin = pyreon()
+    const cfg = (plugin as { config: (u: unknown, e: unknown) => unknown }).config(
+      { root: process.cwd() },
+      { command: 'serve' as const, mode: 'development', isPreview: false, isSsrBuild: false },
+    ) as { ssr?: { noExternal?: readonly (string | RegExp)[] } }
+    const arr = cfg.ssr?.noExternal ?? []
+    const matches = (name: string) =>
+      arr.some((entry) => (entry instanceof RegExp ? entry.test(name) : entry === name))
+
+    expect(matches('react'), 'react must not be noExternal').toBe(false)
+    expect(matches('vite'), 'vite must not be noExternal').toBe(false)
+    expect(matches('pyreon'), 'unscoped pyreon must not be noExternal').toBe(false)
+  })
+})