@pyreon/rocketstyle 0.24.2 → 0.24.3

package/lib/index.d.ts

@@ -3,7 +3,7 @@ import { config, context, render } from "@pyreon/ui-core";
 
 //#region src/context/context.d.ts
 type Theme$1 = {
-  rootSize: number;
+  rootSize?: number;
   breakpoints?: Record<string, number>;
 } & Record<string, unknown>;
 type TProvider = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pyreon/rocketstyle",
-  "version": "0.24.2",
+  "version": "0.24.3",
   "description": "Multi-dimensional style composition for Pyreon components",
   "license": "MIT",
   "repository": {
@@ -43,8 +43,8 @@
   },
   "devDependencies": {
     "@pyreon/test-utils": "^0.13.11",
-    "@pyreon/typescript": "^0.24.2",
-    "@pyreon/ui-core": "^0.24.2",
+    "@pyreon/typescript": "^0.24.3",
+    "@pyreon/ui-core": "^0.24.3",
     "@vitest/browser-playwright": "^4.1.4",
     "@vitus-labs/tools-rolldown": "^2.4.0"
   },
@@ -52,9 +52,9 @@
     "node": ">= 22"
   },
   "dependencies": {
-    "@pyreon/core": "^0.24.2",
-    "@pyreon/reactivity": "^0.24.2",
-    "@pyreon/styler": "^0.24.2",
-    "@pyreon/ui-core": "^0.24.2"
+    "@pyreon/core": "^0.24.3",
+    "@pyreon/reactivity": "^0.24.3",
+    "@pyreon/styler": "^0.24.3",
+    "@pyreon/ui-core": "^0.24.3"
   }
 }

package/src/__tests__/minimal-theme.test.ts

@@ -0,0 +1,62 @@
+// Locks in the "one-size app" contract for the rocketstyle Provider's
+// Theme type. Pre-fix, `rootSize: number` was REQUIRED in the type at
+// `rocketstyle/src/context/context.ts` — passing a minimal theme without
+// rootSize was a TypeScript error even though it works fine at runtime
+// (enrichTheme defaults rootSize to 16, value() defaults rootSize to 16,
+// makeItResponsive short-circuits when breakpoints are empty).
+//
+// User report: "[breakpoints/rootSize] are used too directly". Even in
+// places where runtime tolerates undefined, an over-constrained TYPE
+// forces downstream consumers to either lie (`as any`) or pass dummy
+// values they don't actually need.
+//
+// This spec is a TYPE-LEVEL assertion via `// @ts-expect-error` flips.
+// The flip-positive case (minimal theme) is the regression contract; if
+// someone re-adds the required `rootSize: number` constraint, this file
+// FAILS to compile because the @ts-expect-error directives become dead.
+import type { TProvider } from '../context/context'
+
+describe('rocketstyle Provider — minimal theme typing', () => {
+  it('TYPE: theme with only colors (no rootSize, no breakpoints) is accepted', () => {
+    // Should NOT be a type error — this is the "one-size app" shape.
+    const props: TProvider = {
+      theme: { colors: { primary: '#228be6' } },
+      children: null,
+    }
+    expect(props.theme).toEqual({ colors: { primary: '#228be6' } })
+  })
+
+  it('TYPE: theme with breakpoints but no rootSize is accepted', () => {
+    const props: TProvider = {
+      theme: { breakpoints: { xs: 0, sm: 576 }, colors: { primary: '#228be6' } },
+      children: null,
+    }
+    expect(props.theme?.breakpoints).toEqual({ xs: 0, sm: 576 })
+  })
+
+  it('TYPE: theme with rootSize but no breakpoints is accepted', () => {
+    const props: TProvider = {
+      theme: { rootSize: 16, colors: { primary: '#228be6' } },
+      children: null,
+    }
+    expect(props.theme?.rootSize).toBe(16)
+  })
+
+  it('TYPE: full theme (rootSize + breakpoints) still accepted (backward compat)', () => {
+    const props: TProvider = {
+      theme: {
+        rootSize: 16,
+        breakpoints: { xs: 0, sm: 576, md: 768 },
+        colors: { primary: '#228be6' },
+      },
+      children: null,
+    }
+    expect(props.theme?.rootSize).toBe(16)
+    expect(props.theme?.breakpoints).toEqual({ xs: 0, sm: 576, md: 768 })
+  })
+
+  it('TYPE: omitting theme entirely is still accepted (was already optional)', () => {
+    const props: TProvider = { children: null }
+    expect(props.theme).toBeUndefined()
+  })
+})

package/src/context/context.ts

@@ -3,8 +3,20 @@ import { nativeCompat, useContext } from '@pyreon/core'
 import { Provider as CoreProvider, context } from '@pyreon/ui-core'
 import { MODE_DEFAULT, THEME_MODES_INVERSED } from '../constants'
 
+// Both `rootSize` and `breakpoints` are OPTIONAL — the rest of the chain
+// handles their absence: `enrichTheme` defaults rootSize to 16,
+// `makeItResponsive` short-circuits to plain CSS when breakpoints are
+// empty, and `value()` defaults rootSize to 16 internally. Marking
+// either as required here over-constrained user themes downstream
+// (e.g. a minimal `{ colors: { primary: '#228be6' } }` theme passed
+// to the public Provider was a TS error even though it works at runtime).
+//
+// Shape matches `@pyreon/unistyle` `PyreonTheme` and the downstream
+// `@pyreon/ui-core` Provider's `Partial<...>`-wrapped theme — `?:` with
+// no explicit `| undefined` so the downstream Partial composition holds
+// under `exactOptionalPropertyTypes: true`.
 type Theme = {
-  rootSize: number
+  rootSize?: number
   breakpoints?: Record<string, number>
 } & Record<string, unknown>