@pyreon/lint 0.12.9 → 0.12.11

package/lib/index.js

@@ -670,6 +670,136 @@ const noErrorWithoutPrefix = {
 	}
 };
 
+//#endregion
+//#region src/rules/architecture/no-process-dev-gate.ts
+/**
+* `pyreon/no-process-dev-gate` — flag the broken `typeof process` dev-mode gate
+* pattern that is dead code in real Vite browser bundles.
+*
+* The pattern this rule catches:
+*
+* ```ts
+* const __DEV__ = typeof process !== 'undefined' && process.env.NODE_ENV !== 'production'
+* ```
+*
+* This works in vitest (Node, `process` is defined) but is **silently dead
+* code in real Vite browser bundles** because Vite does not polyfill
+* `process` for the client. Every dev warning gated on this constant never
+* fires for real users in dev mode.
+*
+* The fix is to use `import.meta.env.DEV`, which Vite/Rolldown literal-replace
+* at build time:
+*
+* ```ts
+* // No const needed — read directly at the use site so the bundler can fold:
+* if (!import.meta.env?.DEV) return
+* ```
+*
+* Vitest sets `import.meta.env.DEV === true` automatically (because it is
+* Vite-based), so existing tests continue to pass.
+*
+* Reference implementation: `packages/fundamentals/flow/src/layout.ts:warnIgnoredOptions`.
+*
+* **Auto-fix**: replaces the assignment with `import.meta.env?.DEV === true`.
+* Does NOT delete the const declaration — that has to happen by hand because
+* the variable name and downstream usages may need updating in callers.
+*
+* **Server-package exception**: server-only files run in Node where `process`
+* is always defined, so the pattern is correct there. The rule skips files
+* matching `packages/zero/`, `packages/core/server/`, `packages/core/runtime-server/`,
+* `packages/tools/vite-plugin/`, and any file containing `/server/` in its
+* path. Add new server packages to `SERVER_PACKAGE_PATTERNS` below.
+*/
+/**
+* File-path patterns for server-only packages. Substring match against the
+* file path passed to the rule. Patterns intentionally do NOT start with `/`
+* so they match both absolute paths (`/Users/.../packages/zero/...`) and
+* relative paths (`packages/zero/...`) — different lint runners pass paths
+* differently.
+*/
+const SERVER_PACKAGE_PATTERNS = [
+	"packages/zero/",
+	"packages/core/server/",
+	"packages/core/runtime-server/",
+	"packages/tools/vite-plugin/",
+	"packages/tools/cli/",
+	"packages/tools/lint/",
+	"packages/tools/mcp/",
+	"packages/tools/storybook/",
+	"packages/tools/typescript/",
+	"scripts/"
+];
+function isServerOnlyFile(filePath) {
+	return SERVER_PACKAGE_PATTERNS.some((pat) => filePath.includes(pat));
+}
+const noProcessDevGate = {
+	meta: {
+		id: "pyreon/no-process-dev-gate",
+		category: "architecture",
+		description: "Forbid `typeof process !== \"undefined\" && process.env.NODE_ENV !== \"production\"` as a dev-mode gate. Use `import.meta.env.DEV` instead — `typeof process` is dead code in real Vite browser bundles because Vite does not polyfill `process` for the client.",
+		severity: "error",
+		fixable: true
+	},
+	create(context) {
+		const filePath = context.getFilePath();
+		if (filePath.includes("/tests/") || filePath.includes("/test/") || filePath.includes("/__tests__/") || filePath.includes(".test.") || filePath.includes(".spec.")) return {};
+		if (isServerOnlyFile(filePath)) return {};
+		/**
+		* Match the broken pattern at the AST level. We're looking for any
+		* `LogicalExpression` whose two sides are:
+		*
+		*   1. `typeof process !== 'undefined'` (a UnaryExpression on the LHS
+		*      of a BinaryExpression with operator `!==`)
+		*   2. `process.env.NODE_ENV !== 'production'` (a MemberExpression on
+		*      the LHS of a BinaryExpression with operator `!==`)
+		*
+		* The order can be either way (process check first or NODE_ENV check
+		* first), and the operator can be `&&` or `||` (we only flag `&&`
+		* because `||` doesn't make sense as a dev gate).
+		*/
+		function isTypeofProcessCheck(node) {
+			if (node?.type !== "BinaryExpression") return false;
+			if (node.operator !== "!==" && node.operator !== "!=") return false;
+			const left = node.left;
+			const right = node.right;
+			if (left?.type !== "UnaryExpression" || left.operator !== "typeof") return false;
+			if (left.argument?.type !== "Identifier" || left.argument.name !== "process") return false;
+			if ((right?.type === "Literal" || right?.type === "StringLiteral") && right.value === "undefined") return true;
+			return false;
+		}
+		function isNodeEnvCheck(node) {
+			if (node?.type !== "BinaryExpression") return false;
+			if (node.operator !== "!==" && node.operator !== "!=") return false;
+			const left = node.left;
+			const right = node.right;
+			if (left?.type !== "MemberExpression") return false;
+			if (left.object?.type !== "MemberExpression") return false;
+			if (left.object.object?.type !== "Identifier" || left.object.object.name !== "process") return false;
+			if (left.object.property?.type !== "Identifier" || left.object.property.name !== "env") return false;
+			if (left.property?.type !== "Identifier" || left.property.name !== "NODE_ENV") return false;
+			if ((right?.type === "Literal" || right?.type === "StringLiteral") && right.value === "production") return true;
+			return false;
+		}
+		function isBrokenDevGate(node) {
+			if (node?.type !== "LogicalExpression") return false;
+			if (node.operator !== "&&") return false;
+			return isTypeofProcessCheck(node.left) && isNodeEnvCheck(node.right) || isNodeEnvCheck(node.left) && isTypeofProcessCheck(node.right);
+		}
+		return { LogicalExpression(node) {
+			if (!isBrokenDevGate(node)) return;
+			const span = getSpan(node);
+			context.report({
+				message: "`typeof process !== \"undefined\" && process.env.NODE_ENV !== \"production\"` is dead code in real Vite browser bundles — Vite does not polyfill `process`, so this guard is `false` and any wrapped dev warnings never fire for real users. Use `import.meta.env.DEV` instead, which Vite literal-replaces at build time and tree-shakes correctly in prod. Reference implementation: `packages/fundamentals/flow/src/layout.ts:warnIgnoredOptions`.",
+				span,
+				fix: {
+					span,
+					replacement: "import.meta.env?.DEV === true"
+				}
+			});
+		} };
+	}
+};
+
 //#endregion
 //#region src/rules/form/no-submit-without-validation.ts
 const noSubmitWithoutValidation = {
@@ -2541,6 +2671,7 @@ const allRules = [
 	noCrossLayerImport,
 	devGuardWarnings,
 	noErrorWithoutPrefix,
+	noProcessDevGate,
 	noStoreOutsideProvider,
 	noMutateStoreState,
 	noDuplicateStoreId,
@@ -2595,7 +2726,8 @@ function buildLib() {
 		"pyreon/no-circular-import": "error",
 		"pyreon/no-cross-layer-import": "error",
 		"pyreon/dev-guard-warnings": "error",
-		"pyreon/no-error-without-prefix": "error"
+		"pyreon/no-error-without-prefix": "error",
+		"pyreon/no-process-dev-gate": "error"
 	} };
 }
 const presetBuilders = {