@pyreon/lint 0.11.9 → 0.12.0

package/lib/index.js

@@ -1130,39 +1130,72 @@ function containsJSXReturn(node) {
 	}
 	return false;
 }
+/**
+* Extract destructured property names from an ObjectPattern.
+* Returns names for the fix suggestion.
+*/
+function getDestructuredNames(pattern) {
+	if (pattern.type !== "ObjectPattern") return [];
+	const names = [];
+	for (const prop of pattern.properties ?? []) if (prop.type === "ObjectProperty" && prop.key?.type === "Identifier") names.push(prop.key.name);
+	return names;
+}
 const noPropsDestructure = {
 	meta: {
 		id: "pyreon/no-props-destructure",
 		category: "jsx",
-		description: "Disallow destructuring props in component functions — it breaks signal reactivity.",
+		description: "Disallow destructuring props in component functions — breaks reactive prop tracking. Use props.x or splitProps().",
 		severity: "error",
 		fixable: false
 	},
 	create(context) {
+		let functionDepth = 0;
 		return {
 			ArrowFunctionExpression(node) {
-				checkFunction(node, context);
+				functionDepth++;
+				checkFunction(node, context, functionDepth);
+			},
+			"ArrowFunctionExpression:exit"() {
+				functionDepth--;
 			},
 			FunctionDeclaration(node) {
-				checkFunction(node, context);
+				functionDepth++;
+				checkFunction(node, context, functionDepth);
+			},
+			"FunctionDeclaration:exit"() {
+				functionDepth--;
 			},
 			FunctionExpression(node) {
-				checkFunction(node, context);
+				functionDepth++;
+				checkFunction(node, context, functionDepth);
+			},
+			"FunctionExpression:exit"() {
+				functionDepth--;
 			}
 		};
 	}
 };
-function checkFunction(node, context) {
+function checkFunction(node, context, depth) {
 	const params = node.params;
 	if (!params || params.length === 0) return;
 	const firstParam = params[0];
 	if (!isDestructuring(firstParam)) return;
+	if (depth > 1) return;
 	const body = node.body;
 	if (!body) return;
-	if (containsJSXReturn(body)) context.report({
-		message: "Destructured props in a component function — this breaks signal reactivity. Use `props.x` or `splitProps()` instead.",
-		span: getSpan(firstParam)
-	});
+	if (containsJSXReturn(body)) {
+		const names = getDestructuredNames(firstParam);
+		const hasRest = (firstParam.properties ?? []).some((p) => p.type === "RestElement");
+		let suggestion = "Use `props.x` pattern for reactive prop access.";
+		if (names.length > 0) {
+			suggestion = `Use \`props\` parameter and access as ${names.map((n) => `props.${n}`).join(", ")}.`;
+			if (hasRest) suggestion += ` For rest props, use \`splitProps(props, [${names.map((n) => `'${n}'`).join(", ")}])\`.`;
+		}
+		context.report({
+			message: `Destructured props in component function — breaks reactive prop tracking. ${suggestion}`,
+			span: getSpan(firstParam)
+		});
+	}
 }
 
 //#endregion