@pyreon/lint 0.11.4 → 0.11.6

package/src/rules/architecture/no-cross-layer-import.ts

@@ -1,60 +1,60 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan } from "../../utils/ast"
-import { isPyreonImport } from "../../utils/imports"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan } from '../../utils/ast'
+import { isPyreonImport } from '../../utils/imports'
 
-type PackageCategory = "core" | "fundamentals" | "tools" | "ui-system"
+type PackageCategory = 'core' | 'fundamentals' | 'tools' | 'ui-system'
 
 const CORE_PACKAGES = new Set([
-  "@pyreon/reactivity",
-  "@pyreon/core",
-  "@pyreon/compiler",
-  "@pyreon/runtime-dom",
-  "@pyreon/runtime-server",
-  "@pyreon/router",
-  "@pyreon/head",
-  "@pyreon/server",
+  '@pyreon/reactivity',
+  '@pyreon/core',
+  '@pyreon/compiler',
+  '@pyreon/runtime-dom',
+  '@pyreon/runtime-server',
+  '@pyreon/router',
+  '@pyreon/head',
+  '@pyreon/server',
 ])
 
 const UI_PACKAGES = new Set([
-  "@pyreon/ui-core",
-  "@pyreon/styler",
-  "@pyreon/unistyle",
-  "@pyreon/elements",
-  "@pyreon/attrs",
-  "@pyreon/rocketstyle",
-  "@pyreon/coolgrid",
-  "@pyreon/kinetic",
-  "@pyreon/kinetic-presets",
-  "@pyreon/connector-document",
-  "@pyreon/document-primitives",
+  '@pyreon/ui-core',
+  '@pyreon/styler',
+  '@pyreon/unistyle',
+  '@pyreon/elements',
+  '@pyreon/attrs',
+  '@pyreon/rocketstyle',
+  '@pyreon/coolgrid',
+  '@pyreon/kinetic',
+  '@pyreon/kinetic-presets',
+  '@pyreon/connector-document',
+  '@pyreon/document-primitives',
 ])
 
 function getImportCategory(source: string): PackageCategory | null {
-  if (CORE_PACKAGES.has(source)) return "core"
-  if (UI_PACKAGES.has(source)) return "ui-system"
+  if (CORE_PACKAGES.has(source)) return 'core'
+  if (UI_PACKAGES.has(source)) return 'ui-system'
   return null
 }
 
 function getFileCategory(filePath: string): PackageCategory | null {
-  if (filePath.includes("/packages/core/")) return "core"
-  if (filePath.includes("/packages/ui-system/")) return "ui-system"
-  if (filePath.includes("/packages/fundamentals/")) return "fundamentals"
-  if (filePath.includes("/packages/tools/")) return "tools"
+  if (filePath.includes('/packages/core/')) return 'core'
+  if (filePath.includes('/packages/ui-system/')) return 'ui-system'
+  if (filePath.includes('/packages/fundamentals/')) return 'fundamentals'
+  if (filePath.includes('/packages/tools/')) return 'tools'
   return null
 }
 
 export const noCrossLayerImport: Rule = {
   meta: {
-    id: "pyreon/no-cross-layer-import",
-    category: "architecture",
-    description: "Prevent core packages from importing ui-system packages.",
-    severity: "error",
+    id: 'pyreon/no-cross-layer-import',
+    category: 'architecture',
+    description: 'Prevent core packages from importing ui-system packages.',
+    severity: 'error',
     fixable: false,
   },
   create(context) {
     const filePath = context.getFilePath()
     const fileCategory = getFileCategory(filePath)
-    if (fileCategory !== "core") return {}
+    if (fileCategory !== 'core') return {}
 
     const callbacks: VisitorCallbacks = {
       ImportDeclaration(node: any) {
@@ -62,7 +62,7 @@ export const noCrossLayerImport: Rule = {
         if (!source || !isPyreonImport(source)) return
 
         const importCategory = getImportCategory(source)
-        if (importCategory === "ui-system") {
+        if (importCategory === 'ui-system') {
           context.report({
             message: `Core package importing ui-system package \`${source}\` — core packages must not depend on ui-system.`,
             span: getSpan(node),

package/src/rules/architecture/no-deep-import.ts

@@ -1,16 +1,16 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan } from "../../utils/ast"
-import { isPyreonImport } from "../../utils/imports"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan } from '../../utils/ast'
+import { isPyreonImport } from '../../utils/imports'
 
 const DEEP_IMPORT_PATTERN = /@pyreon\/[^/]+\/(src|dist|lib)\//
 
 export const noDeepImport: Rule = {
   meta: {
-    id: "pyreon/no-deep-import",
-    category: "architecture",
+    id: 'pyreon/no-deep-import',
+    category: 'architecture',
     description:
-      "Disallow importing from @pyreon/*/src/, /dist/, or /lib/ — use public exports instead.",
-    severity: "warn",
+      'Disallow importing from @pyreon/*/src/, /dist/, or /lib/ — use public exports instead.',
+    severity: 'warn',
     fixable: false,
   },
   create(context) {

package/src/rules/architecture/no-error-without-prefix.ts

@@ -1,22 +1,22 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan } from "../../utils/ast"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan } from '../../utils/ast'
 
 export const noErrorWithoutPrefix: Rule = {
   meta: {
-    id: "pyreon/no-error-without-prefix",
-    category: "architecture",
-    description: "Require error messages to be prefixed with [Pyreon].",
-    severity: "warn",
+    id: 'pyreon/no-error-without-prefix',
+    category: 'architecture',
+    description: 'Require error messages to be prefixed with [Pyreon].',
+    severity: 'warn',
     fixable: true,
   },
   create(context) {
     const filePath = context.getFilePath()
     // Skip test files
     if (
-      filePath.includes("/tests/") ||
-      filePath.includes("/test/") ||
-      filePath.includes(".test.") ||
-      filePath.includes(".spec.")
+      filePath.includes('/tests/') ||
+      filePath.includes('/test/') ||
+      filePath.includes('.test.') ||
+      filePath.includes('.spec.')
     ) {
       return {}
     }
@@ -24,9 +24,9 @@ export const noErrorWithoutPrefix: Rule = {
     const callbacks: VisitorCallbacks = {
       ThrowStatement(node: any) {
         const arg = node.argument
-        if (!arg || arg.type !== "NewExpression") return
+        if (!arg || arg.type !== 'NewExpression') return
         const callee = arg.callee
-        if (!callee || callee.type !== "Identifier" || callee.name !== "Error") return
+        if (!callee || callee.type !== 'Identifier' || callee.name !== 'Error') return
 
         const args = arg.arguments
         if (!args || args.length === 0) return
@@ -34,34 +34,34 @@ export const noErrorWithoutPrefix: Rule = {
         const firstArg = args[0]
         if (!firstArg) return
 
-        if (firstArg.type === "Literal" || firstArg.type === "StringLiteral") {
+        if (firstArg.type === 'Literal' || firstArg.type === 'StringLiteral') {
           const value = firstArg.value as string
-          if (typeof value === "string" && !value.startsWith("[Pyreon]")) {
+          if (typeof value === 'string' && !value.startsWith('[Pyreon]')) {
             const argSpan = getSpan(firstArg)
             // Fix: add [Pyreon] prefix
             const quote = context.getSourceText()[argSpan.start]
             const fixedValue = `${quote}[Pyreon] ${value}${quote}`
             context.report({
               message:
-                "Error message missing `[Pyreon]` prefix — all framework errors should be prefixed for identification.",
+                'Error message missing `[Pyreon]` prefix — all framework errors should be prefixed for identification.',
               span: getSpan(node),
               fix: { span: argSpan, replacement: fixedValue },
             })
           }
         }
 
-        if (firstArg.type === "TemplateLiteral") {
+        if (firstArg.type === 'TemplateLiteral') {
           const quasis = firstArg.quasis
           if (quasis && quasis.length > 0) {
             const first = quasis[0]
-            const raw = first.value?.raw ?? first.value?.cooked ?? ""
-            if (!raw.startsWith("[Pyreon]")) {
+            const raw = first.value?.raw ?? first.value?.cooked ?? ''
+            if (!raw.startsWith('[Pyreon]')) {
               const argSpan = getSpan(firstArg)
               const source = context.getSourceText().slice(argSpan.start, argSpan.end)
-              const fixed = source.replace(/^`/, "`[Pyreon] ")
+              const fixed = source.replace(/^`/, '`[Pyreon] ')
               context.report({
                 message:
-                  "Error message missing `[Pyreon]` prefix — all framework errors should be prefixed for identification.",
+                  'Error message missing `[Pyreon]` prefix — all framework errors should be prefixed for identification.',
                 span: getSpan(node),
                 fix: { span: argSpan, replacement: fixed },
               })

package/src/rules/form/no-submit-without-validation.ts

@@ -1,40 +1,40 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan, isCallTo } from "../../utils/ast"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan, isCallTo } from '../../utils/ast'
 
 export const noSubmitWithoutValidation: Rule = {
   meta: {
-    id: "pyreon/no-submit-without-validation",
-    category: "form",
-    description: "Warn when useForm() has onSubmit but no validators or schema.",
-    severity: "warn",
+    id: 'pyreon/no-submit-without-validation',
+    category: 'form',
+    description: 'Warn when useForm() has onSubmit but no validators or schema.',
+    severity: 'warn',
     fixable: false,
   },
   create(context) {
     const callbacks: VisitorCallbacks = {
       CallExpression(node: any) {
-        if (!isCallTo(node, "useForm")) return
+        if (!isCallTo(node, 'useForm')) return
         const args = node.arguments
         if (!args || args.length === 0) return
 
         const options = args[0]
-        if (!options || options.type !== "ObjectExpression") return
+        if (!options || options.type !== 'ObjectExpression') return
 
         let hasOnSubmit = false
         let hasValidation = false
 
         for (const prop of options.properties ?? []) {
-          if (prop.type !== "Property") continue
+          if (prop.type !== 'Property') continue
           const key = prop.key
           if (!key) continue
-          const name = key.type === "Identifier" ? key.name : null
-          if (name === "onSubmit") hasOnSubmit = true
-          if (name === "validators" || name === "schema") hasValidation = true
+          const name = key.type === 'Identifier' ? key.name : null
+          if (name === 'onSubmit') hasOnSubmit = true
+          if (name === 'validators' || name === 'schema') hasValidation = true
         }
 
         if (hasOnSubmit && !hasValidation) {
           context.report({
             message:
-              "`useForm()` has `onSubmit` without `validators` or `schema` — consider adding validation for data integrity.",
+              '`useForm()` has `onSubmit` without `validators` or `schema` — consider adding validation for data integrity.',
             span: getSpan(node),
           })
         }

package/src/rules/form/no-unregistered-field.ts

@@ -1,12 +1,12 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan, isCallTo } from "../../utils/ast"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan, isCallTo } from '../../utils/ast'
 
 export const noUnregisteredField: Rule = {
   meta: {
-    id: "pyreon/no-unregistered-field",
-    category: "form",
-    description: "Warn when useField() is called without a corresponding register() call.",
-    severity: "warn",
+    id: 'pyreon/no-unregistered-field',
+    category: 'form',
+    description: 'Warn when useField() is called without a corresponding register() call.',
+    severity: 'warn',
     fixable: false,
   },
   create(context) {
@@ -16,20 +16,20 @@ export const noUnregisteredField: Rule = {
     const callbacks: VisitorCallbacks = {
       VariableDeclarator(node: any) {
         const init = node.init
-        if (!init || !isCallTo(init, "useField")) return
+        if (!init || !isCallTo(init, 'useField')) return
         const id = node.id
-        if (!id || id.type !== "Identifier") return
+        if (!id || id.type !== 'Identifier') return
         fieldDecls.set(id.name, { span: getSpan(node) })
       },
       CallExpression(node: any) {
         const callee = node.callee
-        if (!callee || callee.type !== "MemberExpression") return
-        if (callee.property?.type !== "Identifier" || callee.property.name !== "register") return
-        if (callee.object?.type === "Identifier") {
+        if (!callee || callee.type !== 'MemberExpression') return
+        if (callee.property?.type !== 'Identifier' || callee.property.name !== 'register') return
+        if (callee.object?.type === 'Identifier') {
           registeredNames.add(callee.object.name)
         }
       },
-      "Program:exit"() {
+      'Program:exit'() {
         for (const [name, { span }] of fieldDecls) {
           if (!registeredNames.has(name)) {
             context.report({

package/src/rules/form/prefer-field-array.ts

@@ -1,13 +1,13 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan, isCallTo } from "../../utils/ast"
-import { extractImportInfo } from "../../utils/imports"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan, isCallTo } from '../../utils/ast'
+import { extractImportInfo } from '../../utils/imports'
 
 export const preferFieldArray: Rule = {
   meta: {
-    id: "pyreon/prefer-field-array",
-    category: "form",
-    description: "Suggest useFieldArray() instead of signal([]) in files that import @pyreon/form.",
-    severity: "info",
+    id: 'pyreon/prefer-field-array',
+    category: 'form',
+    description: 'Suggest useFieldArray() instead of signal([]) in files that import @pyreon/form.',
+    severity: 'info',
     fixable: false,
   },
   create(context) {
@@ -16,21 +16,21 @@ export const preferFieldArray: Rule = {
     const callbacks: VisitorCallbacks = {
       ImportDeclaration(node: any) {
         const info = extractImportInfo(node)
-        if (info && info.source === "@pyreon/form") {
+        if (info && info.source === '@pyreon/form') {
           importsForm = true
         }
       },
       CallExpression(node: any) {
         if (!importsForm) return
-        if (!isCallTo(node, "signal")) return
+        if (!isCallTo(node, 'signal')) return
 
         const args = node.arguments
         if (!args || args.length === 0) return
         const firstArg = args[0]
-        if (firstArg?.type === "ArrayExpression") {
+        if (firstArg?.type === 'ArrayExpression') {
           context.report({
             message:
-              "`signal([])` in a form file — consider using `useFieldArray()` for dynamic array fields with stable keys.",
+              '`signal([])` in a form file — consider using `useFieldArray()` for dynamic array fields with stable keys.',
             span: getSpan(node),
           })
         }

package/src/rules/hooks/no-raw-addeventlistener.ts

@@ -1,24 +1,24 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan } from "../../utils/ast"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan } from '../../utils/ast'
 
 export const noRawAddEventListener: Rule = {
   meta: {
-    id: "pyreon/no-raw-addeventlistener",
-    category: "hooks",
-    description: "Suggest useEventListener() instead of raw .addEventListener() calls.",
-    severity: "info",
+    id: 'pyreon/no-raw-addeventlistener',
+    category: 'hooks',
+    description: 'Suggest useEventListener() instead of raw .addEventListener() calls.',
+    severity: 'info',
     fixable: false,
   },
   create(context) {
     const callbacks: VisitorCallbacks = {
       CallExpression(node: any) {
         const callee = node.callee
-        if (!callee || callee.type !== "MemberExpression") return
-        if (callee.property?.type !== "Identifier" || callee.property.name !== "addEventListener")
+        if (!callee || callee.type !== 'MemberExpression') return
+        if (callee.property?.type !== 'Identifier' || callee.property.name !== 'addEventListener')
           return
         context.report({
           message:
-            "Raw `.addEventListener()` — consider using `useEventListener()` from `@pyreon/hooks` for auto-cleanup on unmount.",
+            'Raw `.addEventListener()` — consider using `useEventListener()` from `@pyreon/hooks` for auto-cleanup on unmount.',
           span: getSpan(node),
         })
       },

package/src/rules/hooks/no-raw-localstorage.ts

@@ -1,26 +1,26 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan } from "../../utils/ast"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan } from '../../utils/ast'
 
-const STORAGE_OBJECTS = new Set(["localStorage", "sessionStorage"])
-const STORAGE_METHODS = new Set(["getItem", "setItem", "removeItem"])
+const STORAGE_OBJECTS = new Set(['localStorage', 'sessionStorage'])
+const STORAGE_METHODS = new Set(['getItem', 'setItem', 'removeItem'])
 
 export const noRawLocalStorage: Rule = {
   meta: {
-    id: "pyreon/no-raw-localstorage",
-    category: "hooks",
-    description: "Suggest useStorage() instead of raw localStorage/sessionStorage access.",
-    severity: "info",
+    id: 'pyreon/no-raw-localstorage',
+    category: 'hooks',
+    description: 'Suggest useStorage() instead of raw localStorage/sessionStorage access.',
+    severity: 'info',
     fixable: false,
   },
   create(context) {
     const callbacks: VisitorCallbacks = {
       CallExpression(node: any) {
         const callee = node.callee
-        if (!callee || callee.type !== "MemberExpression") return
+        if (!callee || callee.type !== 'MemberExpression') return
         if (
-          callee.object?.type === "Identifier" &&
+          callee.object?.type === 'Identifier' &&
           STORAGE_OBJECTS.has(callee.object.name) &&
-          callee.property?.type === "Identifier" &&
+          callee.property?.type === 'Identifier' &&
           STORAGE_METHODS.has(callee.property.name)
         ) {
           context.report({

package/src/rules/hooks/no-raw-setinterval.ts

@@ -1,28 +1,28 @@
-import type { Rule, VisitorCallbacks } from "../../types"
-import { getSpan, isCallTo } from "../../utils/ast"
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan, isCallTo } from '../../utils/ast'
 
-const TIMER_FNS = new Set(["setInterval", "setTimeout"])
+const TIMER_FNS = new Set(['setInterval', 'setTimeout'])
 
 export const noRawSetInterval: Rule = {
   meta: {
-    id: "pyreon/no-raw-setinterval",
-    category: "hooks",
-    description: "Suggest wrapping setInterval/setTimeout in onMount for automatic cleanup.",
-    severity: "info",
+    id: 'pyreon/no-raw-setinterval',
+    category: 'hooks',
+    description: 'Suggest wrapping setInterval/setTimeout in onMount for automatic cleanup.',
+    severity: 'info',
     fixable: false,
   },
   create(context) {
     let mountDepth = 0
     const callbacks: VisitorCallbacks = {
       CallExpression(node: any) {
-        if (isCallTo(node, "onMount")) {
+        if (isCallTo(node, 'onMount')) {
           mountDepth++
         }
 
         if (mountDepth > 0) return
 
         const callee = node.callee
-        if (!callee || callee.type !== "Identifier") return
+        if (!callee || callee.type !== 'Identifier') return
         if (TIMER_FNS.has(callee.name)) {
           context.report({
             message: `\`${callee.name}()\` outside \`onMount\` — wrap in \`onMount(() => { ... return () => clear... })\` for automatic cleanup.`,
@@ -30,8 +30,8 @@ export const noRawSetInterval: Rule = {
           })
         }
       },
-      "CallExpression:exit"(node: any) {
-        if (isCallTo(node, "onMount")) {
+      'CallExpression:exit'(node: any) {
+        if (isCallTo(node, 'onMount')) {
           mountDepth--
         }
       },