@pyreon/lint 0.11.10 → 0.12.1

package/lib/types/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index2.d.ts","names":[],"sources":["../../../src/types.ts","../../../src/utils/source.ts","../../../src/cache.ts","../../../src/config/ignore.ts","../../../src/config/loader.ts","../../../src/config/presets.ts","../../../src/lint.ts","../../../src/reporter.ts","../../../src/lsp/index.ts","../../../src/rules/index.ts","../../../src/runner.ts","../../../src/utils/imports.ts","../../../src/watcher.ts"],"mappings":";KAEY,QAAA;AAAA,UAEK,cAAA;EACf,IAAA;EACA,MAAA;AAAA;AAAA,UAGe,IAAA;EACf,KAAA;EACA,GAAA;AAAA;AAAA,UAGe,GAAA;EACf,IAAA,EAAM,IAAA;EACN,WAAA;AAAA;AAAA,UAGe,UAAA;EACf,MAAA;EACA,QAAA,EAAU,QAAA;EACV,OAAA;EACA,IAAA,EAAM,IAAA;EACN,GAAA,EAAK,cAAA;EACL,GAAA,GAAM,GAAA;AAAA;AAAA,KAKI,YAAA;AAAA,UAcK,QAAA;EACf,EAAA;EACA,QAAA,EAAU,YAAA;EACV,WAAA;EACA,QAAA,EAAU,QAAA;EACV,OAAA;AAAA;AAAA,UAKe,WAAA;EACf,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,aAAA;EACA,WAAA;AAAA;AAAA,KAGU,eAAA,IAAmB,IAAA,OAAW,MAAA;AAAA,UAEzB,gBAAA;EAAA,CACd,QAAA,WAAmB,eAAA;AAAA;AAAA,UAKL,IAAA;EACf,IAAA,EAAM,QAAA;EACN,MAAA,CAAO,OAAA,EAAS,WAAA,GAAc,gBAAA;AAAA;AAAA,UAKf,UAAA;EACf,KAAA,EAAO,MAAA,SAAe,QAAA;EACtB,OAAA;EACA,OAAA;AAAA;AAAA,UAGe,cAAA;EACf,MAAA,GAAS,UAAA;EACT,KAAA,GAAQ,MAAA,SAAe,QAAA;EACvB,OAAA;EACA,OAAA;AAAA;AAAA,KAGU,UAAA;AAAA,UAIK,cAAA;EACf,QAAA;EACA,WAAA,EAAa,UAAA;EACb,WAAA;AAAA;AAAA,UAGe,UAAA;EACf,KAAA,EAAO,cAAA;EACP,WAAA;EACA,aAAA;EACA,UAAA;AAAA;AAAA,UAKe,WAAA;EACf,KAAA;EACA,MAAA,GAAS,UAAA;EACT,GAAA;EACA,KAAA;EACA,aAAA,GAAgB,MAAA,SAAe,QAAA;EAC/B,MAAA;EACA,MAAA;AAAA;AAAA,UAKe,UAAA;EACf,MAAA;EACA,UAAA,EAAY,KAAA;IAAQ,QAAA;IAAkB,KAAA;EAAA;EACtC,SAAA;EACA,WAAA;AAAA;;;AAzHF;;;AAAA,cCGa,SAAA;EAAA,QACH,UAAA;cAEI,UAAA;EDJiB;ECc7B,MAAA,CAAO,MAAA,WAAiB,cAAA;AAAA;;;ADhB1B;;;;;AAEA;;;;;AAKA;;;;;AAKA;;;AAZA,cEkBa,QAAA;EAAA,QACH,KAAA;EAER,GAAA,CAAI,UAAA;IAAuB,OAAA;IAAc,SAAA,EAAW,SAAA;EAAA;EAKpD,GAAA,CAAI,UAAA,UAAoB,KAAA;IAAS,OAAA;IAAc,SAAA,EAAW,SAAA;EAAA;EAK1D,KAAA,CAAA;EAAA,IAII,IAAA,CAAA;AAAA;;;;AFnCN;;;;;AAEA;;;;;AAKA;;iBGOgB,kBAAA,CACd,GAAA,UACA,WAAA,yBACE,QAAA;;;AHjBJ;;;;;AAEA;;;;;AAKA;;;;;AAKA;;AAZA,iBIqBgB,UAAA,CAAW,GAAA,WAAc,cAAA;;;;iBAmCzB,kBAAA,CAAmB,QAAA,WAAmB,cAAA;;;iBCDtC,SAAA,CAAU,IAAA,EAAM,UAAA,GAAa,UAAA;;;ALvD7C;;;;;AAEA;;;;;AAKA;AAPA,iBM0KgB,IAAA,CAAK,OAAA,EAAS,WAAA,GAAc,UAAA;;;;AN9J5C;;;;;;;;;iBM2MgB,SAAA,CAAA,GAAa,QAAA;;;ANvN7B;;;AAAA,iBOyBgB,UAAA,CAAW,MAAA,EAAQ,UAAA;;APvBnC;;iBO6DgB,UAAA,CAAW,MAAA,EAAQ,UAAA;;;APxDnC;iBO+DgB,aAAA,CAAc,MAAA,EAAQ,UAAA;;;;APtEtC;;;;;AAEA;;;;;AAKA;;;;;AAKA;;;;;;iBQ6KgB,cAAA,CAAA;;;cCrHH,QAAA,EAAU,IAAA;;;;;;;ATlEvB;;;;;iBUwFgB,QAAA,CACd,QAAA,UACA,UAAA,UACA,KAAA,EAAO,IAAA,IACP,MAAA,EAAQ,UAAA,EACR,KAAA,GAAQ,QAAA,eACP,cAAA;;;;;iBAkDa,UAAA,CAAW,UAAA,UAAoB,WAAA,EAAa,UAAA;;;iBClF5C,cAAA,CAAe,MAAA;AAAA,iBAIf,eAAA,CAAgB,MAAA;AAAA,iBAIhB,iBAAA,CAAkB,IAAA,QAAY,UAAA;AAAA,iBA2B9B,WAAA,CAAY,OAAA,EAAS,UAAA,IAAc,IAAA,UAAc,WAAA;AAAA,iBAQjD,YAAA,CACd,OAAA,EAAS,UAAA,IACT,IAAA,UACA,WAAA;;;AX9GF;;;;;AAEA;;;;;AAKA;;;AAPA,iBY4BgB,YAAA,CAAa,OAAA,EAAS,WAAA;EAAgB,MAAA;AAAA"}
+{"version":3,"file":"index2.d.ts","names":[],"sources":["../../../src/types.ts","../../../src/utils/source.ts","../../../src/cache.ts","../../../src/config/ignore.ts","../../../src/config/loader.ts","../../../src/config/presets.ts","../../../src/lint.ts","../../../src/reporter.ts","../../../src/lsp/index.ts","../../../src/rules/index.ts","../../../src/runner.ts","../../../src/utils/imports.ts","../../../src/watcher.ts"],"mappings":";KAEY,QAAA;AAAA,UAEK,cAAA;EACf,IAAA;EACA,MAAA;AAAA;AAAA,UAGe,IAAA;EACf,KAAA;EACA,GAAA;AAAA;AAAA,UAGe,GAAA;EACf,IAAA,EAAM,IAAA;EACN,WAAA;AAAA;AAAA,UAGe,UAAA;EACf,MAAA;EACA,QAAA,EAAU,QAAA;EACV,OAAA;EACA,IAAA,EAAM,IAAA;EACN,GAAA,EAAK,cAAA;EACL,GAAA,GAAM,GAAA;AAAA;AAAA,KAKI,YAAA;AAAA,UAcK,QAAA;EACf,EAAA;EACA,QAAA,EAAU,YAAA;EACV,WAAA;EACA,QAAA,EAAU,QAAA;EACV,OAAA;AAAA;AAAA,UAKe,WAAA;EACf,MAAA,CAAO,UAAA,EAAY,IAAA,CAAK,UAAA;EACxB,aAAA;EACA,WAAA;AAAA;AAAA,KAGU,eAAA,IAAmB,IAAA,OAAW,MAAA;AAAA,UAEzB,gBAAA;EAAA,CACd,QAAA,WAAmB,eAAA;AAAA;AAAA,UAKL,IAAA;EACf,IAAA,EAAM,QAAA;EACN,MAAA,CAAO,OAAA,EAAS,WAAA,GAAc,gBAAA;AAAA;AAAA,UAKf,UAAA;EACf,KAAA,EAAO,MAAA,SAAe,QAAA;EACtB,OAAA;EACA,OAAA;AAAA;AAAA,UAGe,cAAA;EACf,MAAA,GAAS,UAAA;EACT,KAAA,GAAQ,MAAA,SAAe,QAAA;EACvB,OAAA;EACA,OAAA;AAAA;AAAA,KAGU,UAAA;AAAA,UAIK,cAAA;EACf,QAAA;EACA,WAAA,EAAa,UAAA;EACb,WAAA;AAAA;AAAA,UAGe,UAAA;EACf,KAAA,EAAO,cAAA;EACP,WAAA;EACA,aAAA;EACA,UAAA;AAAA;AAAA,UAKe,WAAA;EACf,KAAA;EACA,MAAA,GAAS,UAAA;EACT,GAAA;EACA,KAAA;EACA,aAAA,GAAgB,MAAA,SAAe,QAAA;EAC/B,MAAA;EACA,MAAA;AAAA;AAAA,UAKe,UAAA;EACf,MAAA;EACA,UAAA,EAAY,KAAA;IAAQ,QAAA;IAAkB,KAAA;EAAA;EACtC,SAAA;EACA,WAAA;AAAA;;;AAzHF;;;AAAA,cCGa,SAAA;EAAA,QACH,UAAA;cAEI,UAAA;EDJiB;ECc7B,MAAA,CAAO,MAAA,WAAiB,cAAA;AAAA;;;ADhB1B;;;;;AAEA;;;;;AAKA;;;;;AAKA;;;AAZA,cEkBa,QAAA;EAAA,QACH,KAAA;EAER,GAAA,CAAI,UAAA;IAAuB,OAAA;IAAc,SAAA,EAAW,SAAA;EAAA;EAKpD,GAAA,CAAI,UAAA,UAAoB,KAAA;IAAS,OAAA;IAAc,SAAA,EAAW,SAAA;EAAA;EAK1D,KAAA,CAAA;EAAA,IAII,IAAA,CAAA;AAAA;;;;AFnCN;;;;;AAEA;;;;;AAKA;;iBGOgB,kBAAA,CACd,GAAA,UACA,WAAA,yBACE,QAAA;;;AHjBJ;;;;;AAEA;;;;;AAKA;;;;;AAKA;;AAZA,iBIqBgB,UAAA,CAAW,GAAA,WAAc,cAAA;;;;iBAmCzB,kBAAA,CAAmB,QAAA,WAAmB,cAAA;;;iBCDtC,SAAA,CAAU,IAAA,EAAM,UAAA,GAAa,UAAA;;;ALvD7C;;;;;AAEA;;;;;AAKA;AAPA,iBM0KgB,IAAA,CAAK,OAAA,EAAS,WAAA,GAAc,UAAA;;;;AN9J5C;;;;;;;;;iBM2MgB,SAAA,CAAA,GAAa,QAAA;;;ANvN7B;;;AAAA,iBOyBgB,UAAA,CAAW,MAAA,EAAQ,UAAA;;APvBnC;;iBO6DgB,UAAA,CAAW,MAAA,EAAQ,UAAA;;;APxDnC;iBO+DgB,aAAA,CAAc,MAAA,EAAQ,UAAA;;;;APtEtC;;;;;AAEA;;;;;AAKA;;;;;AAKA;;;;;;iBQ6KgB,cAAA,CAAA;;;cCpHH,QAAA,EAAU,IAAA;;;;;;;ATnEvB;;;;;iBUwFgB,QAAA,CACd,QAAA,UACA,UAAA,UACA,KAAA,EAAO,IAAA,IACP,MAAA,EAAQ,UAAA,EACR,KAAA,GAAQ,QAAA,eACP,cAAA;;;;;iBA+Da,UAAA,CAAW,UAAA,UAAoB,WAAA,EAAa,UAAA;;;iBC/F5C,cAAA,CAAe,MAAA;AAAA,iBAIf,eAAA,CAAgB,MAAA;AAAA,iBAIhB,iBAAA,CAAkB,IAAA,QAAY,UAAA;AAAA,iBA2B9B,WAAA,CAAY,OAAA,EAAS,UAAA,IAAc,IAAA,UAAc,WAAA;AAAA,iBAQjD,YAAA,CACd,OAAA,EAAS,UAAA,IACT,IAAA,UACA,WAAA;;;AX9GF;;;;;AAEA;;;;;AAKA;;;AAPA,iBY4BgB,YAAA,CAAa,OAAA,EAAS,WAAA;EAAgB,MAAA;AAAA"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pyreon/lint",
-  "version": "0.11.10",
+  "version": "0.12.1",
   "description": "Pyreon-specific linter — 56 rules for signals, JSX, SSR, performance, router, and architecture",
   "homepage": "https://github.com/pyreon/pyreon/tree/main/packages/lint#readme",
   "bugs": {

package/src/rules/index.ts

@@ -46,6 +46,7 @@ import { noEffectAssignment } from './reactivity/no-effect-assignment'
 import { noNestedEffect } from './reactivity/no-nested-effect'
 import { noPeekInTracked } from './reactivity/no-peek-in-tracked'
 import { noSignalInLoop } from './reactivity/no-signal-in-loop'
+import { noSignalInProps } from './reactivity/no-signal-in-props'
 import { noSignalLeak } from './reactivity/no-signal-leak'
 import { noUnbatchedUpdates } from './reactivity/no-unbatched-updates'
 import { preferComputed } from './reactivity/prefer-computed'
@@ -69,10 +70,11 @@ import { noThemeOutsideProvider } from './styling/no-theme-outside-provider'
 import { preferCx } from './styling/prefer-cx'
 
 export const allRules: Rule[] = [
-  // Reactivity (9)
+  // Reactivity (10)
   noBareSignalInJsx,
   noContextDestructure,
   noSignalInLoop,
+  noSignalInProps,
   noNestedEffect,
   noPeekInTracked,
   noUnbatchedUpdates,
@@ -187,6 +189,7 @@ export {
   noRawLocalStorage,
   noRawSetInterval,
   noSignalInLoop,
+  noSignalInProps,
   noSignalLeak,
   // Store
   noStoreOutsideProvider,

package/src/rules/jsx/no-props-destructure.ts

@@ -3,11 +3,9 @@ import { getSpan, isDestructuring } from '../../utils/ast'
 
 function containsJSXReturn(node: any): boolean {
   if (!node) return false
-  // Arrow with expression body returning JSX
   if (node.type === 'JSXElement' || node.type === 'JSXFragment') return true
   if (node.type === 'ParenthesizedExpression') return containsJSXReturn(node.expression)
 
-  // Block body — look for return statements with JSX
   if (node.type === 'BlockStatement') {
     for (const stmt of node.body ?? []) {
       if (stmt.type === 'ReturnStatement' && containsJSXReturn(stmt.argument)) {
@@ -18,46 +16,89 @@ function containsJSXReturn(node: any): boolean {
   return false
 }
 
+/**
+ * Extract destructured property names from an ObjectPattern.
+ * Returns names for the fix suggestion.
+ */
+function getDestructuredNames(pattern: any): string[] {
+  if (pattern.type !== 'ObjectPattern') return []
+  const names: string[] = []
+  for (const prop of pattern.properties ?? []) {
+    if (prop.type === 'ObjectProperty' && prop.key?.type === 'Identifier') {
+      names.push(prop.key.name)
+    }
+  }
+  return names
+}
+
 export const noPropsDestructure: Rule = {
   meta: {
     id: 'pyreon/no-props-destructure',
     category: 'jsx',
     description:
-      'Disallow destructuring props in component functions — it breaks signal reactivity.',
+      'Disallow destructuring props in component functions — breaks reactive prop tracking. Use props.x or splitProps().',
     severity: 'error',
     fixable: false,
   },
   create(context) {
+    let functionDepth = 0
+
     const callbacks: VisitorCallbacks = {
       ArrowFunctionExpression(node: any) {
-        checkFunction(node, context)
+        functionDepth++
+        checkFunction(node, context, functionDepth)
+      },
+      'ArrowFunctionExpression:exit'() {
+        functionDepth--
       },
       FunctionDeclaration(node: any) {
-        checkFunction(node, context)
+        functionDepth++
+        checkFunction(node, context, functionDepth)
+      },
+      'FunctionDeclaration:exit'() {
+        functionDepth--
       },
       FunctionExpression(node: any) {
-        checkFunction(node, context)
+        functionDepth++
+        checkFunction(node, context, functionDepth)
+      },
+      'FunctionExpression:exit'() {
+        functionDepth--
       },
     }
     return callbacks
   },
 }
 
-function checkFunction(node: any, context: any) {
+function checkFunction(node: any, context: any, depth: number) {
   const params = node.params
   if (!params || params.length === 0) return
 
   const firstParam = params[0]
   if (!isDestructuring(firstParam)) return
 
-  // Check if this function returns JSX
+  // Skip HOC inner functions (depth > 1)
+  if (depth > 1) return
+
   const body = node.body
   if (!body) return
 
   if (containsJSXReturn(body)) {
+    const names = getDestructuredNames(firstParam)
+    const hasRest = (firstParam.properties ?? []).some((p: any) => p.type === 'RestElement')
+
+    let suggestion = 'Use `props.x` pattern for reactive prop access.'
+    if (names.length > 0) {
+      const propsAccess = names.map((n) => `props.${n}`).join(', ')
+      suggestion = `Use \`props\` parameter and access as ${propsAccess}.`
+      if (hasRest) {
+        suggestion += ` For rest props, use \`splitProps(props, [${names.map((n) => `'${n}'`).join(', ')}])\`.`
+      }
+    }
+
     context.report({
       message:
-        'Destructured props in a component function — this breaks signal reactivity. Use `props.x` or `splitProps()` instead.',
+        `Destructured props in component function — breaks reactive prop tracking. ${suggestion}`,
       span: getSpan(firstParam),
     })
   }

package/src/rules/reactivity/no-signal-in-props.ts

@@ -0,0 +1,53 @@
+import type { Rule, VisitorCallbacks } from '../../types'
+import { getSpan } from '../../utils/ast'
+
+function isComponentTag(name: string): boolean {
+  return name.length > 0 && name[0] === name[0]?.toUpperCase() && name[0] !== name[0]?.toLowerCase()
+}
+
+/**
+ * Warn when a known signal/computed is called in a component prop position.
+ * Component props are evaluated once at mount — signal reads are NOT reactive
+ * unless the compiler wraps them with _rp(). The compiler handles this
+ * automatically, but this rule catches manual h() calls and educates developers.
+ */
+export const noSignalInProps: Rule = {
+  meta: {
+    id: 'pyreon/no-signal-in-props',
+    category: 'reactivity',
+    description:
+      'Signal call in component prop — value captured once unless compiler wraps it. Use props.x pattern for reactivity.',
+    severity: 'warn',
+    fixable: false,
+  },
+  create(context) {
+    const callbacks: VisitorCallbacks = {
+      JSXExpressionContainer(node: any) {
+        const expr = node.expression
+        if (!expr || expr.type !== 'CallExpression') return
+        const callee = expr.callee
+        if (!callee || callee.type !== 'Identifier') return
+
+        const source = context.getSourceText()
+        const start = node.start as number
+
+        let i = start - 1
+        while (i >= 0 && source[i] !== '<' && source[i] !== '>') i--
+        if (i < 0 || source[i] !== '<') return
+
+        const tagStart = i + 1
+        let tagEnd = tagStart
+        while (tagEnd < source.length && /[\w.]/.test(source[tagEnd] ?? '')) tagEnd++
+        const tagName = source.slice(tagStart, tagEnd)
+
+        if (!tagName || !isComponentTag(tagName)) return
+
+        context.report({
+          message: `Signal call in <${tagName}> prop — use props.x pattern inside the component for reactive access.`,
+          span: getSpan(expr),
+        })
+      },
+    }
+    return callbacks
+  },
+}

package/src/runner.ts

@@ -138,8 +138,21 @@ export function lintFile(
   const visitor = new Visitor(mergeCallbacks(allCallbacks))
   visitor.visit(program)
 
-  diagnostics.sort((a, b) => a.span.start - b.span.start)
-  return { filePath, diagnostics }
+  // Filter suppressed diagnostics:
+  // // pyreon-lint-ignore             — suppress all on next line
+  // // pyreon-lint-ignore rule-name   — suppress specific rule on next line
+  const lines = sourceText.split('\n')
+  const filtered = diagnostics.filter((d) => {
+    const prevLineIdx = d.loc.line - 2
+    if (prevLineIdx < 0) return true
+    const prevLine = lines[prevLineIdx]?.trim()
+    if (!prevLine?.startsWith('// pyreon-lint-ignore')) return true
+    const rest = prevLine.slice('// pyreon-lint-ignore'.length).trim()
+    return rest.length > 0 && rest !== d.ruleId
+  })
+
+  filtered.sort((a, b) => a.span.start - b.span.start)
+  return { filePath, diagnostics: filtered }
 }
 
 /**

package/src/tests/runner.test.ts

@@ -37,7 +37,7 @@ function lintWith(ruleId: string, source: string, filePath?: string) {
 
 describe('Rule metadata', () => {
   it('should have 56 rules', () => {
-    expect(allRules.length).toBe(56)
+    expect(allRules.length).toBe(57)
   })
 
   it('should have unique rule IDs', () => {
@@ -77,7 +77,7 @@ describe('Rule metadata', () => {
     for (const rule of allRules) {
       counts[rule.meta.category] = (counts[rule.meta.category] ?? 0) + 1
     }
-    expect(counts.reactivity).toBe(9)
+    expect(counts.reactivity).toBe(10)
     expect(counts.jsx).toBe(11)
     expect(counts.lifecycle).toBe(4)
     expect(counts.performance).toBe(4)
@@ -1013,7 +1013,7 @@ describe('Ignore filter', () => {
 describe('Presets', () => {
   it('recommended should include all rules', () => {
     const config = getPreset('recommended')
-    expect(Object.keys(config.rules).length).toBe(56)
+    expect(Object.keys(config.rules).length).toBe(57)
   })
 
   it('strict should promote all warns to errors', () => {