@pyreon/core 0.21.0 → 0.23.0

package/lib/jsx-dev-runtime.js

@@ -1,98 +1,4 @@
-//#region src/h.ts
-/**
-* Marker for fragment nodes — renders children without a wrapper element.
-*
-* MUST use `Symbol.for(...)` (global registry, keyed by string), NOT
-* `Symbol(...)` (fresh per evaluation). `h.ts` is inlined into BOTH the
-* main `lib/index.js` and the `lib/jsx-runtime.js` published bundles —
-* each bundle's evaluation of a bare `Symbol(...)` would produce a
-* DISTINCT Symbol identity. JSX `<>` compiles to `jsx(Fragment, ...)` and
-* resolves to jsx-runtime's identity; `runtime-server` checks
-* `vnode.type === Fragment` against the main-entry identity. Mismatch
-* fell through to `renderElement` and crashed SSG with
-* `TypeError: Cannot convert a Symbol value to a string`.
-* `Symbol.for()` keys by string in a global registry shared across all
-* bundle evaluations — same identity everywhere.
-*/
-const Fragment = Symbol.for("Pyreon.Fragment");
-/**
-* Hyperscript function — the compiled output of JSX.
-* `<div class="x">hello</div>` → `h("div", { class: "x" }, "hello")`
-*
-* Generic on P so TypeScript validates props match the component's signature
-* at the call site, then stores the result in the loosely-typed VNode.
-*/
-/** Shared empty props sentinel — identity-checked in mountElement to skip applyProps. */
-const EMPTY_PROPS = {};
-function h(type, props, ...children) {
-	return {
-		type,
-		props: props ?? EMPTY_PROPS,
-		children: normalizeChildren(children),
-		key: props?.key ?? null
-	};
-}
-function normalizeChildren(children) {
-	for (let i = 0; i < children.length; i++) if (Array.isArray(children[i])) return flattenChildren(children);
-	return children;
-}
-function flattenChildren(children) {
-	const result = [];
-	for (const child of children) if (Array.isArray(child)) result.push(...flattenChildren(child));
-	else result.push(child);
-	return result;
-}
+import { n as Fragment } from "./_chunks/h-CYSD6aBx.js";
+import { jsx, jsxs } from "./jsx-runtime.js";
 
-//#endregion
-//#region src/jsx-runtime.ts
-/**
-* JSX automatic runtime.
-*
-* When tsconfig has `"jsxImportSource": "@pyreon/core"`, the TS/bundler compiler
-* rewrites JSX to imports from this file automatically:
-*   <div class="x" />  →  jsx("div", { class: "x" })
-*
-* The triple-slash reference above makes this file self-declare its DOM-lib
-* dependency. Without it, any consumer whose tsconfig has `lib: ["ESNext"]`
-* (no DOM) — e.g. backend-only packages like @pyreon/cli — fails to typecheck
-* once `@pyreon/core` becomes resolvable from their dependency graph (e.g. via
-* a transitive devDep), because tsc auto-resolves jsxImportSource and pulls
-* jsx-runtime.ts into the consumer's compilation unit.
-*/
-function jsx(type, props, key) {
-	const descriptors = Object.getOwnPropertyDescriptors(props);
-	let hasGetter = false;
-	for (const k in descriptors) if (descriptors[k].get) {
-		hasGetter = true;
-		break;
-	}
-	const children = props.children;
-	if (!hasGetter) {
-		const { children: _ignored, ...rest } = props;
-		const propsWithKey = key != null ? {
-			...rest,
-			key
-		} : rest;
-		if (typeof type === "function") return h(type, children !== void 0 ? {
-			...propsWithKey,
-			children
-		} : propsWithKey);
-		return h(type, propsWithKey, ...children === void 0 ? [] : Array.isArray(children) ? children : [children]);
-	}
-	const propsWithKey = {};
-	for (const k in descriptors) {
-		if (k === "children") continue;
-		Object.defineProperty(propsWithKey, k, descriptors[k]);
-	}
-	if (key != null) propsWithKey.key = key;
-	if (typeof type === "function") {
-		if (children !== void 0) propsWithKey.children = children;
-		return h(type, propsWithKey);
-	}
-	return h(type, propsWithKey, ...children === void 0 ? [] : Array.isArray(children) ? children : [children]);
-}
-const jsxs = jsx;
-
-//#endregion
-export { Fragment, jsx as jsxDEV, jsxs };
-//# sourceMappingURL=jsx-dev-runtime.js.map
+export { Fragment, jsx as jsxDEV, jsxs };

package/lib/jsx-runtime.js

@@ -1,49 +1,5 @@
-//#region src/h.ts
-/**
-* Marker for fragment nodes — renders children without a wrapper element.
-*
-* MUST use `Symbol.for(...)` (global registry, keyed by string), NOT
-* `Symbol(...)` (fresh per evaluation). `h.ts` is inlined into BOTH the
-* main `lib/index.js` and the `lib/jsx-runtime.js` published bundles —
-* each bundle's evaluation of a bare `Symbol(...)` would produce a
-* DISTINCT Symbol identity. JSX `<>` compiles to `jsx(Fragment, ...)` and
-* resolves to jsx-runtime's identity; `runtime-server` checks
-* `vnode.type === Fragment` against the main-entry identity. Mismatch
-* fell through to `renderElement` and crashed SSG with
-* `TypeError: Cannot convert a Symbol value to a string`.
-* `Symbol.for()` keys by string in a global registry shared across all
-* bundle evaluations — same identity everywhere.
-*/
-const Fragment = Symbol.for("Pyreon.Fragment");
-/**
-* Hyperscript function — the compiled output of JSX.
-* `<div class="x">hello</div>` → `h("div", { class: "x" }, "hello")`
-*
-* Generic on P so TypeScript validates props match the component's signature
-* at the call site, then stores the result in the loosely-typed VNode.
-*/
-/** Shared empty props sentinel — identity-checked in mountElement to skip applyProps. */
-const EMPTY_PROPS = {};
-function h(type, props, ...children) {
-	return {
-		type,
-		props: props ?? EMPTY_PROPS,
-		children: normalizeChildren(children),
-		key: props?.key ?? null
-	};
-}
-function normalizeChildren(children) {
-	for (let i = 0; i < children.length; i++) if (Array.isArray(children[i])) return flattenChildren(children);
-	return children;
-}
-function flattenChildren(children) {
-	const result = [];
-	for (const child of children) if (Array.isArray(child)) result.push(...flattenChildren(child));
-	else result.push(child);
-	return result;
-}
+import { n as Fragment, r as h } from "./_chunks/h-CYSD6aBx.js";
 
-//#endregion
 //#region src/jsx-runtime.ts
 /**
 * JSX automatic runtime.

package/lib/types/index.d.ts

@@ -247,7 +247,34 @@ declare function createReactiveContext<T>(defaultValue: T): ReactiveContext<T>;
  */
 declare function setContextStackProvider(fn: () => Map<symbol, unknown>[]): void;
 declare function pushContext(values: Map<symbol, unknown>): void;
+/**
+ * Pop the LAST frame from the context stack.
+ *
+ * NOTE: position-based pop. Safe ONLY when the caller can guarantee that the
+ * top of the stack is the frame they want to remove (the strict LIFO contract).
+ * The `provide()` helper does NOT use this — it uses identity-based removal
+ * via `removeContextFrame` because reactive boundaries can push snapshot
+ * frames between a component's `provide(ctx, value)` and its eventual
+ * unmount, making the top-of-stack unsafe to assume.
+ */
 declare function popContext(): void;
+/**
+ * Remove a SPECIFIC frame from the context stack by reference identity.
+ *
+ * Internal — used by `provide()` and `withContext()` to safely clean up
+ * their pushed frame on unmount even when other frames have been pushed
+ * between push and pop (e.g. a reactive boundary's `restoreContextStack`
+ * pushing snapshot frames during the descendant's lifecycle). The
+ * symmetric position-based `popContext()` would pop the wrong frame in
+ * that case and orphan the descendant's provider frame on the live stack
+ * — the root cause of the 321k-entry context-stack leak under repeated
+ * reactive remounts.
+ *
+ * Uses `lastIndexOf` (LIFO match) — picks the most-recently-pushed frame
+ * with that exact reference, so `provide(ctx, a); provide(ctx, b)` followed
+ * by two unmounts removes them in reverse order.
+ */
+declare function removeContextFrame(frame: Map<symbol, unknown>): void;
 /**
  * Read the nearest provided value for a context.
  * Falls back to `context.defaultValue` if none found.
@@ -1416,5 +1443,5 @@ declare function registerErrorHandler(handler: ErrorHandler): () => void;
  */
 declare function reportError(ctx: ErrorContext): void;
 //#endregion
-export { type AnchorAttributes, type ButtonAttributes, type CSSProperties, CSS_UNITLESS, type ClassValue, type CleanupFn, type ComponentFn, type ComponentInstance, type Context, type ContextSnapshot, Defer, type DeferProps, Dynamic, type DynamicProps, EMPTY_PROPS, ErrorBoundary, type ErrorContext, type ErrorHandler, type ExtractProps, For, type ForProps, ForSymbol, type FormAttributes, Fragment, type HigherOrderComponent, type ImgAttributes, type InputAttributes, type LazyComponent, type LifecycleHooks, Match, type MatchProps, MatchSymbol, NATIVE_COMPAT_MARKER, type NativeItem, Portal, type PortalProps, PortalSymbol, type Props, type PyreonHTMLAttributes, REACTIVE_PROP, type ReactiveContext, type ReactiveTraceEntry, type Ref, type RefCallback, type RefProp, type SelectAttributes, Show, type ShowProps, type StyleValue, Suspense, type SvgAttributes, Switch, type SwitchProps, type TargetedEvent, type TextareaAttributes, type VNode, type VNodeChild, type VNodeChildAccessor, type VNodeChildAtom, _rp, _wrapSpread, captureContextStack, createContext, createReactiveContext, createRef, createUniqueId, cx, defineComponent, dispatchToErrorBoundary, h, isNativeCompat, lazy, makeReactiveProps, mapArray, mapCompatDomProps, mergeProps, nativeCompat, normalizeStyleValue, onErrorCaptured, onMount, onUnmount, onUpdate, popContext, propagateError, provide, pushContext, registerErrorHandler, reportError, restoreContextStack, runWithHooks, setContextStackProvider, shallowEqualProps, splitProps, toKebabCase, useContext, withContext };
+export { type AnchorAttributes, type ButtonAttributes, type CSSProperties, CSS_UNITLESS, type ClassValue, type CleanupFn, type ComponentFn, type ComponentInstance, type Context, type ContextSnapshot, Defer, type DeferProps, Dynamic, type DynamicProps, EMPTY_PROPS, ErrorBoundary, type ErrorContext, type ErrorHandler, type ExtractProps, For, type ForProps, ForSymbol, type FormAttributes, Fragment, type HigherOrderComponent, type ImgAttributes, type InputAttributes, type LazyComponent, type LifecycleHooks, Match, type MatchProps, MatchSymbol, NATIVE_COMPAT_MARKER, type NativeItem, Portal, type PortalProps, PortalSymbol, type Props, type PyreonHTMLAttributes, REACTIVE_PROP, type ReactiveContext, type ReactiveTraceEntry, type Ref, type RefCallback, type RefProp, type SelectAttributes, Show, type ShowProps, type StyleValue, Suspense, type SvgAttributes, Switch, type SwitchProps, type TargetedEvent, type TextareaAttributes, type VNode, type VNodeChild, type VNodeChildAccessor, type VNodeChildAtom, _rp, _wrapSpread, captureContextStack, createContext, createReactiveContext, createRef, createUniqueId, cx, defineComponent, dispatchToErrorBoundary, h, isNativeCompat, lazy, makeReactiveProps, mapArray, mapCompatDomProps, mergeProps, nativeCompat, normalizeStyleValue, onErrorCaptured, onMount, onUnmount, onUpdate, popContext, propagateError, provide, pushContext, registerErrorHandler, removeContextFrame, reportError, restoreContextStack, runWithHooks, setContextStackProvider, shallowEqualProps, splitProps, toKebabCase, useContext, withContext };
 //# sourceMappingURL=index2.d.ts.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pyreon/core",
-  "version": "0.21.0",
+  "version": "0.23.0",
   "description": "Core component model and lifecycle for Pyreon",
   "homepage": "https://github.com/pyreon/pyreon/tree/main/packages/core#readme",
   "bugs": {
@@ -53,7 +53,7 @@
     "prepublishOnly": "bun run build"
   },
   "dependencies": {
-    "@pyreon/reactivity": "^0.21.0"
+    "@pyreon/reactivity": "^0.23.0"
   },
   "devDependencies": {
     "@pyreon/manifest": "0.13.1"

package/src/component.ts

@@ -46,6 +46,22 @@ export function propagateError(err: unknown, hooks: LifecycleHooks): boolean {
 // Module-level stack of active ErrorBoundary handlers (innermost last).
 // ErrorBoundary pushes during its own setup (before children mount) so that
 // any child mountComponent error can dispatch up to the nearest boundary.
+//
+// Mutation contract: removal is IDENTITY-based (`lastIndexOf + splice`), not
+// position-based (`pop`). Sibling boundaries unmount in an order that's
+// driven by the renderer (keyed `<For>` reconciliation, `<Show>` flips,
+// route nav), NOT in strict LIFO push order. A position-based `pop()` would
+// remove the wrong frame whenever the unmount order diverges from the push
+// order — the first boundary's `onUnmount` would pop the last boundary's
+// handler, orphaning the first boundary's handler on the stack and removing
+// the surviving boundary's handler from it. Subsequent errors would then
+// route to the orphan (whose owning boundary's signal is already disposed,
+// so the error vanishes silently) and the surviving boundary's children's
+// errors would fall through to whichever boundary happens to sit at
+// `stack[length-1]`. Same root-cause shape as the `popContext()` bug
+// fixed in #725 for `provide()` — see
+// `.claude/rules/anti-patterns.md` "Position-based pop for stack frames
+// that may be pushed by reactive boundaries".
 
 const _errorBoundaryStack: ((err: unknown) => boolean)[] = []
 
@@ -53,8 +69,23 @@ export function pushErrorBoundary(handler: (err: unknown) => boolean): void {
   _errorBoundaryStack.push(handler)
 }
 
-export function popErrorBoundary(): void {
-  _errorBoundaryStack.pop()
+/**
+ * Remove a SPECIFIC handler from the error-boundary stack by reference
+ * identity. Each `ErrorBoundary` registers `onUnmount(() => popErrorBoundary(handler))`
+ * with its OWN handler — so unmount in any order (LIFO, FIFO, middle-out)
+ * correctly removes the right handler.
+ */
+export function popErrorBoundary(handler?: (err: unknown) => boolean): void {
+  if (handler === undefined) {
+    // Back-compat: legacy callers that don't pass a handler get the old
+    // pop-last behaviour. Internal `ErrorBoundary` setup always passes
+    // its handler now; any external direct callers (tests, advanced
+    // consumers) keep working with no-arg form.
+    _errorBoundaryStack.pop()
+    return
+  }
+  const idx = _errorBoundaryStack.lastIndexOf(handler)
+  if (idx !== -1) _errorBoundaryStack.splice(idx, 1)
 }
 
 /**

package/src/context.ts

@@ -73,12 +73,44 @@ export function pushContext(values: Map<symbol, unknown>) {
   getStack().push(values)
 }
 
+/**
+ * Pop the LAST frame from the context stack.
+ *
+ * NOTE: position-based pop. Safe ONLY when the caller can guarantee that the
+ * top of the stack is the frame they want to remove (the strict LIFO contract).
+ * The `provide()` helper does NOT use this — it uses identity-based removal
+ * via `removeContextFrame` because reactive boundaries can push snapshot
+ * frames between a component's `provide(ctx, value)` and its eventual
+ * unmount, making the top-of-stack unsafe to assume.
+ */
 export function popContext() {
   const stack = getStack()
   if (stack.length === 0) return
   stack.pop()
 }
 
+/**
+ * Remove a SPECIFIC frame from the context stack by reference identity.
+ *
+ * Internal — used by `provide()` and `withContext()` to safely clean up
+ * their pushed frame on unmount even when other frames have been pushed
+ * between push and pop (e.g. a reactive boundary's `restoreContextStack`
+ * pushing snapshot frames during the descendant's lifecycle). The
+ * symmetric position-based `popContext()` would pop the wrong frame in
+ * that case and orphan the descendant's provider frame on the live stack
+ * — the root cause of the 321k-entry context-stack leak under repeated
+ * reactive remounts.
+ *
+ * Uses `lastIndexOf` (LIFO match) — picks the most-recently-pushed frame
+ * with that exact reference, so `provide(ctx, a); provide(ctx, b)` followed
+ * by two unmounts removes them in reverse order.
+ */
+export function removeContextFrame(frame: Map<symbol, unknown>): void {
+  const stack = getStack()
+  const idx = stack.lastIndexOf(frame)
+  if (idx !== -1) stack.splice(idx, 1)
+}
+
 /**
  * Read the nearest provided value for a context.
  * Falls back to `context.defaultValue` if none found.
@@ -111,8 +143,17 @@ export function useContext<T>(context: Context<T>): T {
  * }
  */
 export function provide<T>(context: Context<T>, value: T): void {
-  pushContext(new Map<symbol, unknown>([[context.id, value]]))
-  onUnmount(() => popContext())
+  const frame = new Map<symbol, unknown>([[context.id, value]])
+  pushContext(frame)
+  // Identity-based removal — the top of the stack is NOT guaranteed to be
+  // this frame at unmount time. Reactive boundaries (`mountReactive`'s
+  // effect snapshot-restore + the inner `restoreContextStack` call) push
+  // additional snapshot frames during a descendant's lifecycle. A
+  // position-based `popContext()` would pop the snapshot frame instead
+  // of this provider's frame and orphan the provider on the live stack.
+  // See `.claude/rules/anti-patterns.md` "Context-stack frame identity"
+  // for the full bug class.
+  onUnmount(() => removeContextFrame(frame))
 }
 
 /**
@@ -125,7 +166,11 @@ export function withContext<T>(context: Context<T>, value: T, fn: () => void) {
   try {
     fn()
   } finally {
-    popContext()
+    // Same identity-based-removal rationale as `provide()` — `fn()` may
+    // synchronously trigger a `mountReactive` re-run whose snapshot-restore
+    // window leaves the top-of-stack pointing at a snapshot push, not our
+    // frame.
+    removeContextFrame(frame)
   }
 }
 
@@ -162,7 +207,6 @@ export function captureContextStack(): ContextSnapshot {
  */
 export function restoreContextStack<T>(snapshot: ContextSnapshot, fn: () => T): T {
   const stack = getStack()
-  const insertIndex = stack.length
 
   // Push captured snapshot frames at the END of the current stack.
   for (const frame of snapshot) {
@@ -172,15 +216,27 @@ export function restoreContextStack<T>(snapshot: ContextSnapshot, fn: () => T):
   try {
     return fn()
   } finally {
-    // Splice out exactly the snapshot frames we pushed (they sit at
-    // [insertIndex, insertIndex + snapshot.length)). Any frames `fn()`
-    // pushed AFTER our snapshot (provider frames) get shifted down by
-    // `snapshot.length` positions but remain on the stack. Their owning
-    // components' `onUnmount(popContext)` handlers will pop them in
-    // LIFO order on subtree teardown — splice preserves that ordering
-    // because it doesn't touch frames at indices >= insertIndex +
-    // snapshot.length until the splice operation itself.
-    stack.splice(insertIndex, snapshot.length)
+    // Remove our pushed snapshot frames by REFERENCE IDENTITY (not by
+    // position). `fn()` may legitimately remove frames at indices BEFORE
+    // our push window — most commonly via `provide()` registering
+    // `onUnmount(removeContextFrame(frame))` and a descendant unmount
+    // firing inside this restore window. A position-based `splice` would
+    // either pull the wrong frames or no-op when the live stack has
+    // shrunk below the original `insertIndex + snapshot.length` —
+    // orphaning the snapshot pushes on the live stack and producing the
+    // 321k-frame leak reported under repeated reactive remounts.
+    //
+    // Iterate in reverse so multi-occurrence frames (the same Map ref
+    // pushed by multiple nested restores) are removed in LIFO push order.
+    // `lastIndexOf` is O(N); N is small in practice (single-digit nesting),
+    // and the alternative `findLastIndex(f => f === frame)` is the same
+    // cost.
+    for (let i = snapshot.length - 1; i >= 0; i--) {
+      const frame = snapshot[i]
+      if (!frame) continue
+      const idx = stack.lastIndexOf(frame)
+      if (idx !== -1) stack.splice(idx, 1)
+    }
   }
 }
 

package/src/error-boundary.ts

@@ -68,7 +68,13 @@ export function ErrorBoundary(props: {
 
   // Push synchronously — before children are mounted — so child errors see this boundary
   pushErrorBoundary(handler)
-  onUnmount(() => popErrorBoundary())
+  // Identity-based pop: pass our own handler reference. Sibling boundaries
+  // can unmount in any order driven by the renderer (keyed `<For>` removal
+  // of a non-last item, `<Show>` flipping on the FIRST of N siblings, route
+  // nav, etc.) — without passing the handler reference, the position-based
+  // `pop()` would remove the WRONG boundary's handler. Same bug class as
+  // #725 (`popContext()` orphaning provider frames under reactive remount).
+  onUnmount(() => popErrorBoundary(handler))
 
   return (): VNodeChildAtom => {
     const err = error()

package/src/index.ts

@@ -11,6 +11,7 @@ export {
   popContext,
   provide,
   pushContext,
+  removeContextFrame,
   restoreContextStack,
   setContextStackProvider,
   useContext,