@pyreon/compiler 0.24.5 → 0.24.6

package/src/tests/ssg-audit.test.ts

@@ -1,402 +0,0 @@
-/**
- * Fixture-based tests for `auditSsg` (M3.4 of the SSG roadmap).
- *
- * Each finding type gets a parallel pair:
- *  - "broken" fixture → finding fires
- *  - "fixed" fixture → no finding fires
- *
- * Bisect-verified by removing the detector body and asserting the
- * broken-shape test fails.
- */
-import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
-import { tmpdir } from 'node:os'
-import { dirname, join } from 'node:path'
-import { auditSsg, formatSsgAudit, type SsgFindingCode } from '../ssg-audit'
-
-interface Fixture {
-  root: string
-  write: (relPath: string, body: string) => void
-  cleanup: () => void
-}
-
-function makeFixture(): Fixture {
-  const root = mkdtempSync(join(tmpdir(), 'pyreon-ssg-audit-fixture-'))
-  mkdirSync(join(root, 'packages'), { recursive: true })
-  return {
-    root,
-    write: (relPath, body) => {
-      const full = join(root, relPath)
-      mkdirSync(dirname(full), { recursive: true })
-      writeFileSync(full, body)
-    },
-    cleanup: () => rmSync(root, { recursive: true, force: true }),
-  }
-}
-
-function findingCodes(result: ReturnType<typeof auditSsg>): SsgFindingCode[] {
-  return result.findings.map((f) => f.code)
-}
-
-// ═══════════════════════════════════════════════════════════════════════════════
-// Discovery
-// ═══════════════════════════════════════════════════════════════════════════════
-
-describe('auditSsg — discovery', () => {
-  it('returns empty results for a directory with no routes/ subdir', () => {
-    const empty = mkdtempSync(join(tmpdir(), 'pyreon-ssg-audit-empty-'))
-    try {
-      const result = auditSsg(empty)
-      expect(result.findings).toEqual([])
-      expect(result.summary.routesScanned).toBe(0)
-    } finally {
-      rmSync(empty, { recursive: true, force: true })
-    }
-  })
-
-  it('counts route files + dynamic routes + revalidate exports in summary', () => {
-    const fixture = makeFixture()
-    try {
-      // Plain page — no [param], no revalidate.
-      fixture.write('examples/myapp/src/routes/_layout.tsx', 'export const layout = () => null')
-      fixture.write('examples/myapp/src/routes/index.tsx', 'export default () => null')
-      fixture.write('examples/myapp/src/routes/about.tsx', 'export default () => null')
-      // Dynamic route with getStaticPaths + revalidate
-      fixture.write(
-        'examples/myapp/src/routes/posts/[id].tsx',
-        `export const getStaticPaths = () => [{ params: { id: '1' } }]
-export const revalidate = 60
-export default () => null`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(result.summary.routesScanned).toBe(4)
-      expect(result.summary.dynamicRoutes).toBe(1)
-      expect(result.summary.revalidateExports).toBe(1)
-    } finally {
-      fixture.cleanup()
-    }
-  })
-})
-
-// ═══════════════════════════════════════════════════════════════════════════════
-// 1) 404-outside-layout-dir
-// ═══════════════════════════════════════════════════════════════════════════════
-
-describe('auditSsg — 404-outside-layout-dir', () => {
-  it('FIRES when _404.tsx has no co-located _layout.tsx', () => {
-    const fixture = makeFixture()
-    try {
-      // Broken shape: _404.tsx alone in the routes dir, no _layout.tsx.
-      fixture.write('examples/myapp/src/routes/_404.tsx', 'export default () => null')
-      fixture.write('examples/myapp/src/routes/index.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).toContain('404-outside-layout-dir')
-      const finding = result.findings.find((f) => f.code === '404-outside-layout-dir')!
-      expect(finding.location.relPath).toContain('_404.tsx')
-      expect(finding.message).toContain('_layout.tsx')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('FIRES for _not-found.tsx (alternate filename)', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write('examples/myapp/src/routes/_not-found.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).toContain('404-outside-layout-dir')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire when _404.tsx is co-located with _layout.tsx', () => {
-    const fixture = makeFixture()
-    try {
-      // Fixed shape: same directory contains both.
-      fixture.write('examples/myapp/src/routes/_layout.tsx', 'export const layout = () => null')
-      fixture.write('examples/myapp/src/routes/_404.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('404-outside-layout-dir')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-})
-
-// ═══════════════════════════════════════════════════════════════════════════════
-// 2) dynamic-route-missing-get-static-paths
-// ═══════════════════════════════════════════════════════════════════════════════
-
-describe('auditSsg — dynamic-route-missing-get-static-paths', () => {
-  it('FIRES for [id].tsx without getStaticPaths', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/[id].tsx',
-        'export default () => null',
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).toContain('dynamic-route-missing-get-static-paths')
-      const finding = result.findings.find(
-        (f) => f.code === 'dynamic-route-missing-get-static-paths',
-      )!
-      expect(finding.location.relPath).toContain('[id].tsx')
-      expect(finding.message).toContain('getStaticPaths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('FIRES for catch-all [...slug].tsx without getStaticPaths', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/blog/[...slug].tsx',
-        'export default () => null',
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire for [id].tsx WITH `export const getStaticPaths`', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/[id].tsx',
-        `export const getStaticPaths = () => [{ params: { id: '1' } }]
-export default () => null`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire for [id].tsx WITH `export async function getStaticPaths`', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/[id].tsx',
-        `export async function getStaticPaths() { return [{ params: { id: '1' } }] }
-export default () => null`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire for static routes (no [param] in filename)', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write('examples/myapp/src/routes/about.tsx', 'export default () => null')
-      fixture.write('examples/myapp/src/routes/index.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire for _layout / _error / _loading / _404 even with brackets in name', () => {
-    // Defensive: special files with bracketed names (unlikely but
-    // possible — `_layout.[locale].tsx`) shouldn't be flagged.
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/_layout.tsx',
-        'export const layout = () => null',
-      )
-      fixture.write('examples/myapp/src/routes/_404.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  // M3.B follow-up — false-positive class surfaced by cpa-pw-blog's
-  // `api/echo/[...path].ts` (real-world API route with bracket
-  // filename). API routes are runtime-only by definition.
-  it('does NOT fire for API routes under routes/api/ (path-based skip)', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/api/echo/[...path].ts',
-        `export function GET({ params }) {
-  return new Response(\`segments: \${params.path}\`)
-}`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire for files without `export default` outside api/ (export-shape skip)', () => {
-    // Method-handler-only file outside api/ — covers users who put API
-    // routes somewhere non-conventional. Page routes structurally
-    // require a default export, so absence is a reliable signal.
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/webhook/[id].ts',
-        `export function POST({ request }) {
-  return new Response('ok')
-}`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('STILL fires on page routes (with default export) missing getStaticPaths', () => {
-    // Sanity — the export-shape skip doesn't accidentally silence the
-    // rule on legitimate page routes.
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/[id].tsx',
-        `export const someHelper = 1
-export default function Post() { return null }`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).toContain('dynamic-route-missing-get-static-paths')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-})
-
-// ═══════════════════════════════════════════════════════════════════════════════
-// 3) non-literal-revalidate-export
-// ═══════════════════════════════════════════════════════════════════════════════
-
-describe('auditSsg — non-literal-revalidate-export', () => {
-  it('FIRES for `export const revalidate = TTL` (identifier reference)', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/index.tsx',
-        `const TTL = 60
-export const revalidate = TTL
-export default () => null`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).toContain('non-literal-revalidate-export')
-      const finding = result.findings.find((f) => f.code === 'non-literal-revalidate-export')!
-      expect(finding.message).toContain('NUMERIC LITERAL')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('FIRES for `export const revalidate = 30 * 60` (arithmetic)', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/index.tsx',
-        `export const revalidate = 30 * 60
-export default () => null`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).toContain('non-literal-revalidate-export')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire for `export const revalidate = 60` (numeric literal)', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/index.tsx',
-        `export const revalidate = 60
-export default () => null`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('non-literal-revalidate-export')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire for `export const revalidate = false` (false keyword)', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write(
-        'examples/myapp/src/routes/posts/index.tsx',
-        `export const revalidate = false
-export default () => null`,
-      )
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('non-literal-revalidate-export')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('does NOT fire when there is no revalidate export at all', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write('examples/myapp/src/routes/about.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      expect(findingCodes(result)).not.toContain('non-literal-revalidate-export')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-})
-
-// ═══════════════════════════════════════════════════════════════════════════════
-// Formatter
-// ═══════════════════════════════════════════════════════════════════════════════
-
-describe('formatSsgAudit', () => {
-  it('renders a clean header when there are no findings', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write('examples/myapp/src/routes/index.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      const output = formatSsgAudit(result)
-      expect(output).toContain('SSG audit')
-      expect(output).toContain('No SSG / ISR issues found')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('renders each finding with relPath:line:col + actionable message', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write('examples/myapp/src/routes/_404.tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      const output = formatSsgAudit(result)
-      expect(output).toContain('[404-outside-layout-dir]')
-      expect(output).toContain('_404.tsx')
-      expect(output).toContain('_layout.tsx')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-
-  it('mentions the --json flag for machine-readable output', () => {
-    const fixture = makeFixture()
-    try {
-      fixture.write('examples/myapp/src/routes/posts/[id].tsx', 'export default () => null')
-      const result = auditSsg(fixture.root)
-      const output = formatSsgAudit(result)
-      expect(output).toContain('--json')
-    } finally {
-      fixture.cleanup()
-    }
-  })
-})

package/src/tests/static-text-baking.test.ts

@@ -1,64 +0,0 @@
-import { transformJSX } from '../jsx'
-
-const t = (code: string) => transformJSX(code, 'input.tsx').code
-const hasBind = (out: string) => /\b_bindText\(|\b_bind\(/.test(out)
-
-// ── Static-text baking contract (perf-correctness regression gate) ──────────
-//
-// The compiler bakes a provably-static `{expr}` child straight into the
-// `_tpl()` HTML and emits NO `_bind`/`_bindText` for it. The Reactivity
-// Lens's `static-text` kind is a faithful RECORD of exactly this codegen
-// branch — it is NOT an independent oracle the emitter could disagree
-// with. So "the analysis proves static but codegen still binds" is
-// structurally impossible; the only thing that can erode this is an
-// `isDynamic` PRECISION regression that starts treating a static shape as
-// dynamic (a silent per-mount allocation + subscription leak with no
-// other guard) OR — the inverse correctness bug — under-wrapping a truly
-// reactive shape.
-//
-// This suite is self-discriminating, which IS its bisect proof: it
-// asserts BOTH regimes against the SAME `isDynamic` decision. An
-// over-broad regression fails the "baked" half; an under-broad
-// (correctness) regression fails the "reactive" half. Both halves are
-// demonstrated reachable by the empirical probe that motivated this gate
-// (every static shape baked; the unknown-call / signal / prop shapes
-// bound) — neither half passes vacuously.
-
-describe('static-text baking — provably-static children are baked, never _bind', () => {
-  const STATIC: [string, string][] = [
-    ['module-const string ref', `const N='hi'; export const C=()=> <div>{N}</div>`],
-    ['string literal', `export const C=()=> <div>{'hi'}</div>`],
-    ['number literal', `export const C=()=> <div>{42}</div>`],
-    ['static ternary on a module const', `const F=false; export const C=()=> <div>{F ? 'a' : 'b'}</div>`],
-    ['template literal interpolating only a const', `const N='x'; export const C=()=> <div>{\`v-\${N}\`}</div>`],
-    ['module-const array .length', `const A=[1,2,3]; export const C=()=> <div>{A.length}</div>`],
-    ['pure built-in call (Math.max)', `export const C=()=> <div>{Math.max(1,2)}</div>`],
-    ['const string concat', `const A='a',B='b'; export const C=()=> <div>{A+B}</div>`],
-  ]
-  for (const [name, src] of STATIC) {
-    test(`bakes (no _bind): ${name}`, () => {
-      const out = t(src)
-      expect(out).toContain('_tpl(')
-      expect(hasBind(out)).toBe(false)
-    })
-  }
-})
-
-describe('static-text baking — genuinely-reactive / unprovable children DO bind (discriminator)', () => {
-  const REACTIVE: [string, string][] = [
-    [
-      'signal read',
-      `import {signal} from '@pyreon/reactivity'; const s=signal(0); export const C=()=> <div>{s()}</div>`,
-    ],
-    ['prop access', `export const C=(props:any)=> <div>{props.x}</div>`],
-    [
-      'unknown local call (conservatively reactive — correct: cannot prove signal-free)',
-      `function f(){return 'z'} export const C=()=> <div>{f()}</div>`,
-    ],
-  ]
-  for (const [name, src] of REACTIVE) {
-    test(`binds: ${name}`, () => {
-      expect(hasBind(t(src))).toBe(true)
-    })
-  }
-})