@pylonsync/functions 0.3.250 → 0.3.251

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pylonsync/functions",
-  "version": "0.3.250",
+  "version": "0.3.251",
   "description": "TypeScript function runtime for pylon — defines server-side queries, mutations, and actions.",
   "type": "module",
   "main": "src/index.ts",

package/src/ssr-runtime.ts

@@ -7,6 +7,20 @@
 // the dispatch arm) so projects without SSR routes pay nothing — no
 // react-dom dependency requirement, no startup cost.
 
+/**
+ * Is the runtime in dev mode? MUST match the Rust host's `is_dev_mode()`
+ * (crates/runtime/src/frontend.rs): `PYLON_DEV_MODE` is on ONLY for the exact
+ * strings "1" or "true" (case-insensitive). A bare `if (process.env.PYLON_DEV_MODE)`
+ * is WRONG — the string "false"/"0" is truthy in JS, so an explicit
+ * `PYLON_DEV_MODE=false` on a PROD machine would wrongly enable dev behavior
+ * (e.g. the live-reload `<script>` was being injected into prod pages, whose
+ * EventSource then 404-retried `/_pylon/dev/live` forever).
+ */
+export function isDevMode(): boolean {
+  const v = process.env.PYLON_DEV_MODE;
+  return v === "1" || v?.toLowerCase() === "true";
+}
+
 /**
  * The message payload the host sends. Matches RenderRouteMessage in
  * crates/functions/src/protocol.rs.
@@ -856,7 +870,7 @@ export function buildHydrationTail(args: {
   } else {
     tail += `<script>console.warn(${JSON.stringify(`[pylon ssr] hydration disabled: ${args.manifestErr}`)})</script>`;
   }
-  if (process.env.PYLON_DEV_MODE) tail += DEV_LIVE_RELOAD_SNIPPET;
+  if (isDevMode()) tail += DEV_LIVE_RELOAD_SNIPPET;
   return tail;
 }
 
@@ -1741,8 +1755,7 @@ export async function handleRenderRoute(
     // In dev, send the full stack as the message so the host can paint a
     // useful error overlay instead of an opaque 500. In prod, send only the
     // message (the host shows a generic page; the stack stays in logs).
-    const devMode =
-      process.env.PYLON_DEV_MODE === "1" || process.env.PYLON_DEV_MODE === "true";
+    const devMode = isDevMode();
     send({
       type: "error",
       call_id: msg.call_id,

package/src/ssr-streaming.test.ts

@@ -22,8 +22,46 @@ import {
   computeRevalidateSecs,
   computeWantsStream,
   diffCommittedResponse,
+  isDevMode,
 } from "./ssr-runtime";
 
+// ---------------------------------------------------------------------------
+// isDevMode — must match the Rust host's is_dev_mode() exactly
+// ---------------------------------------------------------------------------
+
+describe("isDevMode (PYLON_DEV_MODE parity with Rust host)", () => {
+  const orig = process.env.PYLON_DEV_MODE;
+  const set = (v: string | undefined) => {
+    if (v === undefined) delete process.env.PYLON_DEV_MODE;
+    else process.env.PYLON_DEV_MODE = v;
+  };
+
+  test("ONLY '1' / 'true' (case-insensitive) are dev; 'false'/'0'/unset are NOT", () => {
+    try {
+      set("1");
+      expect(isDevMode()).toBe(true);
+      set("true");
+      expect(isDevMode()).toBe(true);
+      set("TRUE");
+      expect(isDevMode()).toBe(true);
+      // The bug this guards: a prod machine explicitly set PYLON_DEV_MODE=false,
+      // and `if (process.env.PYLON_DEV_MODE)` treated the truthy STRING "false"
+      // as dev → injected the live-reload script → EventSource 404-looped on
+      // /_pylon/dev/live in prod.
+      set("false");
+      expect(isDevMode()).toBe(false);
+      set("0");
+      expect(isDevMode()).toBe(false);
+      set("");
+      expect(isDevMode()).toBe(false);
+      set(undefined);
+      expect(isDevMode()).toBe(false);
+    } finally {
+      set(orig);
+    }
+  });
+});
+
 // ---------------------------------------------------------------------------
 // Pure verdict logic
 // ---------------------------------------------------------------------------