@pygmalionjs/pygmalion 0.7.1 → 0.7.3

package/dist-lib/types/editor/visualQa.d.ts

@@ -1,5 +1,5 @@
 import type { InspectApplyPayload } from './inspect';
-import type { EditorTransport } from '../contract/transport.js';
+import type { EditorTransport, TransportCallOptions } from '../contract/transport.js';
 import type { DesignCodegenData } from './designCompiler';
 export interface InspectQaArtifactHash {
     domStructureHash: string;
@@ -61,4 +61,4 @@ export declare function inspectQaFrameIds(payload: InspectApplyPayload, eligible
  * and strictly normalizes its answer. Artifact paths are accepted only under
  * the transport's QA artifact prefix and come back resolved for the document.
  */
-export declare function requestInspectQaCapture(transport: EditorTransport, request: InspectQaCaptureRequest): Promise<InspectQaResult>;
+export declare function requestInspectQaCapture(transport: EditorTransport, request: InspectQaCaptureRequest, options?: TransportCallOptions): Promise<InspectQaResult>;

package/node/dev-mirror.mjs

@@ -272,6 +272,32 @@ async function git(cwd, ...args) {
   return run('git', ['-C', cwd, ...args]);
 }
 
+/**
+ * Spawn options for the dependency install command.
+ *
+ * Package managers on Windows are `.cmd` shims (`npm.cmd`, `pnpm.cmd`,
+ * `yarn.cmd`), and CreateProcess cannot start those: spawning the bare name
+ * fails with ENOENT, and since Node 20.12 naming the `.cmd` file explicitly
+ * fails with EINVAL. Only a shell resolves them, so on Windows the install
+ * goes through one unless the host pointed at an `.exe`. Git is an `.exe`
+ * and never needs this. Install arguments are plain tokens, which is what
+ * the shell path can carry safely.
+ */
+export function dependencyInstallSpawnOptions(command, platform = process.platform) {
+  if (platform !== 'win32') return {};
+  if (path.extname(command).toLowerCase() === '.exe') return {};
+  return { shell: true };
+}
+
+async function runDependencyInstall(dependencies, cwd) {
+  const command = dependencies.installCommand ?? 'npm';
+  await run(
+    command,
+    dependencies.installArgs ?? ['install', '--no-audit', '--no-fund'],
+    { cwd, ...dependencyInstallSpawnOptions(command) },
+  );
+}
+
 async function exists(target) {
   try {
     await fsp.access(target);
@@ -1493,11 +1519,7 @@ export function pygmalionDevMirrorPlugin(options) {
     const stampFile = path.join(nodeModules, '.pygmalion-dev-lock');
     if (!(await exists(lockFile))) {
       if (await exists(nodeModules)) return false;
-      await run(
-        dependencies.installCommand ?? 'npm',
-        dependencies.installArgs ?? ['install', '--no-audit', '--no-fund'],
-        { cwd: mirrorAppRoot },
-      );
+      await runDependencyInstall(dependencies, mirrorAppRoot);
       return true;
     }
     const lockHash = await fileHash(lockFile);
@@ -1521,11 +1543,7 @@ export function pygmalionDevMirrorPlugin(options) {
         if (await exists(nodeModules)) return false;
       }
     }
-    await run(
-      dependencies.installCommand ?? 'npm',
-      dependencies.installArgs ?? ['install', '--no-audit', '--no-fund'],
-      { cwd: mirrorAppRoot },
-    );
+    await runDependencyInstall(dependencies, mirrorAppRoot);
     await fsp.writeFile(stampFile, `${lockHash}\n`);
     return true;
   };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pygmalionjs/pygmalion",
-  "version": "0.7.1",
+  "version": "0.7.3",
   "description": "Code-backed DOM design sandbox and visual QA editor",
   "license": "Apache-2.0",
   "repository": {