@pwddd/skills-scanner 3.0.12 → 3.0.14

package/index.ts

@@ -148,6 +148,8 @@ export default function register(api: OpenClawPluginApi) {
         return;
       }
 
+      api.logger.info("[skills-scanner] Python dependencies ready (requests installed)");
+
       if (preInstallScan === "on" && scanDirs.length > 0) {
         api.logger.info(`[skills-scanner] 📁 Starting file monitoring: ${scanDirs.length} directories`);
         stopWatcher = startWatcher(
@@ -168,14 +170,8 @@ export default function register(api: OpenClawPluginApi) {
         api.logger.info("[skills-scanner] ⏭️  Pre-install scan disabled");
       }
 
-      // Register cron job (only in Gateway mode)
-      const isGatewayMode = !!(api as any).runtime;
-      if (isGatewayMode) {
-        const runtime = (api as any).runtime;
-        await ensureCronJob(api.logger, runtime);
-      }
-
-      api.logger.info("[skills-scanner] ─────────────────────────────────────");
+      // Setup cron job via CLI
+      await ensureCronJob(api.logger);
     },
     stop: () => {
       api.logger.info("[skills-scanner] 🛑 Service stopping...");

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "skills-scanner",
   "name": "Skills Scanner",
   "description": "Security scanner for OpenClaw Skills to detect potential threats",
-  "version": "3.0.12",
+  "version": "3.0.14",
   "author": "pwddd",
   "skills": ["./skills"],
   "configSchema": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pwddd/skills-scanner",
-  "version": "3.0.12",
+  "version": "3.0.14",
   "description": "OpenClaw Skills security scanner plugin - detect malicious code, data exfiltration, and prompt injection",
   "type": "module",
   "main": "./index.ts",

package/src/cron.ts

@@ -57,70 +57,27 @@ function getOpenClawCommand(): string {
 }
 
 /**
- * Create cron job via Gateway API (most reliable)
+ * Create cron job via CLI
  */
-async function ensureCronJobViaAPI(runtime: any, logger: any): Promise<boolean> {
-  if (!runtime?.cron) {
-    logger.debug("[skills-scanner] Cron API not available");
-    return false;
-  }
+async function ensureCronJobViaCLI(logger: any): Promise<void> {
+  const openclawCmd = getOpenClawCommand();
+  logger.info(`[skills-scanner] Using CLI command: ${openclawCmd}`);
   
+  // Test if command is available
   try {
-    const state = loadState() as any;
-    
-    // Check if job already exists
-    const jobs = await runtime.cron.list({ includeDisabled: true });
-    const existing = jobs.find((j: any) => j.name === CRON_JOB_NAME);
-    
-    if (existing) {
-      logger.info(`[skills-scanner] ✅ Job already exists: ${existing.id}`);
-      if (state.cronJobId !== existing.id) {
-        saveState({ ...state, cronJobId: existing.id });
-      }
-      return true;
-    }
-    
-    // Create new job
-    logger.info("[skills-scanner] 📝 Creating cron job via API...");
-    const job = await runtime.cron.add({
-      name: CRON_JOB_NAME,
-      enabled: true,
-      schedule: { 
-        kind: "cron", 
-        expr: CRON_SCHEDULE,
-        tz: CRON_TIMEZONE
-      },
-      payload: {
-        kind: "agentTurn",
-        message: "Please run /skills-scanner scan --report and send results to this channel"
-      },
-      delivery: {
-        mode: "announce",
-        channel: "last"
-      }
+    const testResult = execSync(`${openclawCmd} --version`, {
+      encoding: "utf-8",
+      timeout: 5000,
+      stdio: "pipe"
     });
-    
-    saveState({ ...state, cronJobId: job.id });
-    logger.info(`[skills-scanner] ✅ Job created successfully via API: ${job.id}`);
-    logger.info(
-      `[skills-scanner] 📅 Schedule: Daily at ${CRON_SCHEDULE.split(" ")[1]}:${CRON_SCHEDULE.split(" ")[0]} (${CRON_TIMEZONE})`
-    );
-    logger.info("[skills-scanner] 📬 Reports will be delivered to the last active channel");
-    return true;
-  } catch (err: any) {
-    logger.warn(`[skills-scanner] API creation failed: ${err.message}`);
-    return false;
+    logger.info(`[skills-scanner] Command test successful: ${testResult.trim()}`);
+  } catch (testErr: any) {
+    logger.error(`[skills-scanner] ❌ Command not available: ${testErr.message}`);
+    logger.info(`[skills-scanner] 💡 Please ensure OpenClaw is installed and accessible`);
+    logger.info(`[skills-scanner] 💡 Try running: ${openclawCmd} --version`);
+    return;
   }
-}
-
-/**
- * Create cron job via CLI (fallback)
- */
-async function ensureCronJobViaCLI(logger: any): Promise<void> {
-  const openclawCmd = getOpenClawCommand();
-  logger.info(`[skills-scanner] Using CLI command: ${openclawCmd}`);
   
-  const state = loadState() as any;
   const state = loadState() as any;
 
   try {
@@ -229,6 +186,8 @@ async function ensureCronJobViaCLI(logger: any): Promise<void> {
       "--channel last",
     ].join(" ");
 
+    logger.info(`[skills-scanner] Executing: ${cronCmd}`);
+
     const result = execSync(cronCmd, { encoding: "utf-8", timeout: 10000 });
 
     const jobIdMatch =
@@ -251,7 +210,15 @@ async function ensureCronJobViaCLI(logger: any): Promise<void> {
     }
   } catch (err: any) {
     logger.warn("[skills-scanner] ⚠️  Auto-registration failed");
-    logger.debug(`[skills-scanner] Error details: ${err.message}`);
+    logger.warn(`[skills-scanner] Error: ${err.message || err}`);
+    
+    // Log stderr if available
+    if (err.stderr) {
+      logger.warn(`[skills-scanner] stderr: ${err.stderr}`);
+    }
+    if (err.stdout) {
+      logger.warn(`[skills-scanner] stdout: ${err.stdout}`);
+    }
 
     if (err.message.includes("permission") || err.message.includes("EACCES")) {
       logger.error("[skills-scanner] ❌ Permission denied, please run with admin privileges");
@@ -260,6 +227,7 @@ async function ensureCronJobViaCLI(logger: any): Promise<void> {
       err.message.includes("ENOENT")
     ) {
       logger.error(`[skills-scanner] ❌ ${openclawCmd} command not found, please check installation`);
+      logger.info(`[skills-scanner] 💡 Current PATH: ${process.env.PATH}`);
     } else {
       logger.info("[skills-scanner] 💡 Please manually register cron job:");
       logger.info("[skills-scanner]");
@@ -282,22 +250,11 @@ async function ensureCronJobViaCLI(logger: any): Promise<void> {
 }
 
 /**
- * Ensure cron job exists (tries API first, falls back to CLI)
+ * Ensure cron job exists via CLI
  */
-export async function ensureCronJob(logger: any, runtime?: any): Promise<void> {
+export async function ensureCronJob(logger: any): Promise<void> {
   logger.info("[skills-scanner] ─────────────────────────────────────");
   logger.info("[skills-scanner] 🕐 Checking cron job...");
   
-  // Try API first (most reliable)
-  if (runtime) {
-    const success = await ensureCronJobViaAPI(runtime, logger);
-    if (success) {
-      logger.info("[skills-scanner] ✅ Cron job configured via API");
-      return;
-    }
-    logger.info("[skills-scanner] Falling back to CLI method...");
-  }
-  
-  // Fallback to CLI
   await ensureCronJobViaCLI(logger);
 }