@pwddd/skills-scanner 1.0.0-beta.2 → 1.0.0-beta.21

package/README.md

@@ -4,10 +4,9 @@ OpenClaw Skills 安全扫描插件，用于检测 Skills 中的潜在安全威
 
 ## 功能特性
 
-- 🔍 **自动扫描**: 监听 Skills 目录，自动扫描新安装的 Skill
+- 🔍 **手动扫描**: 支持扫描指定路径的 Skill
 - 🛡️ **安装前拦截**: 使用 before_install hook 在安装前强制拦截不安全的 Skills
 - 🌐 **ClawHub 扫描**: 直接扫描 ClawHub 上的 Skill，无需手动下载
-- 📊 **定时周报**: 每周一自动生成安全扫描报告
 - 🛡️ **多种策略**: 支持 strict/balanced/permissive 三种扫描策略
 - 🤖 **LLM 分析**: 可选的 LLM 语义分析
 - 🔒 **自动隔离**: 检测到不安全的 Skill 自动隔离或删除
@@ -34,11 +33,9 @@ openclaw plugins install @pwddd/skills-scanner
         "enabled": true,
         "config": {
           "apiUrl": "https://110.vemic.com/skills-scanner",
-          "scanDirs": ["~/.openclaw/skills", "~/.openclaw/workspace/skills"],
           "behavioral": false,
           "useLLM": false,
           "policy": "balanced",
-          "preInstallScan": "on",
           "onUnsafe": "warn",
           "enableBeforeInstallHook": true
         }
@@ -51,16 +48,12 @@ openclaw plugins install @pwddd/skills-scanner
 ### 配置说明
 
 - `apiUrl`: 扫描 API 服务地址
-- `scanDirs`: 要监控的 Skills 目录列表
 - `behavioral`: 是否启用行为分析（深度扫描，较慢）
 - `useLLM`: 是否使用 LLM 进行语义分析
 - `policy`: 扫描策略
   - `strict`: 严格模式，发现任何可疑行为都标记为不安全
   - `balanced`: 平衡模式（推荐）
   - `permissive`: 宽松模式，只标记明确的威胁
-- `preInstallScan`: 是否启用文件监控（安装后扫描）
-  - `on`: 启用
-  - `off`: 禁用
 - `onUnsafe`: 发现不安全 Skill 的处理方式
   - `warn`: 仅警告，不处理（推荐）
   - `quarantine`: 移入隔离目录
@@ -88,7 +81,6 @@ openclaw config reload
 
 配置变更会自动:
 - 更新 API URL
-- 重启文件监控器（如果扫描目录变更）
 - 应用新的扫描策略
 
 #### 调试模式
@@ -108,7 +100,6 @@ SKILLS_SCANNER_DEBUG=1 openclaw gateway start
 - 完整的配置信息
 - 详细的扫描过程
 - API 请求和响应
-- 文件监控事件
 
 #### 健康检查端点
 
@@ -130,11 +121,6 @@ curl http://localhost:3000/health/skills-scanner
     "url": "https://110.vemic.com/skills-scanner",
     "status": "available"
   },
-  "watcher": {
-    "enabled": true,
-    "running": true,
-    "directories": 2
-  },
   "metrics": {
     "totalScans": 42,
     "successRate": "95.24%",
@@ -152,7 +138,6 @@ curl http://localhost:3000/health/skills-scanner
 /skills-scanner scan clawhub <URL> [选项]  # 扫描 ClawHub Skill
 /skills-scanner health                # 健康检查
 /skills-scanner config [操作]         # 配置管理
-/skills-scanner cron [操作]           # 定时任务管理
 /skills-scanner help                  # 帮助信息
 ```
 
@@ -161,14 +146,12 @@ curl http://localhost:3000/health/skills-scanner
 - `--detailed`: 显示详细的安全发现
 - `--behavioral`: 启用行为分析
 - `--recursive`: 递归扫描子目录
-- `--report`: 生成日报格式
 
 #### 示例
 
 ```
 /skills-scanner scan ~/.openclaw/skills/my-skill
 /skills-scanner scan ~/.openclaw/skills --recursive
-/skills-scanner scan ~/.openclaw/skills --report
 /skills-scanner scan clawhub https://clawhub.ai/username/project
 /skills-scanner scan clawhub https://clawhub.ai/Asleep123/caldav-calendar --detailed
 /skills-scanner health
@@ -186,9 +169,6 @@ openclaw skills-scanner clawhub <url> [--detailed] [--behavioral]
 # 批量扫描目录
 openclaw skills-scanner batch <directory> [--recursive] [--detailed]
 
-# 生成日报
-openclaw skills-scanner report
-
 # 检查 API 服务健康状态
 openclaw skills-scanner health
 ```
@@ -196,10 +176,8 @@ openclaw skills-scanner health
 ## 工作流程
 
 1. **插件启动**: 自动初始化并连接 API 服务
-2. **文件监控**: 监听配置的 Skills 目录
-3. **自动扫描**: 检测到新 Skill 时自动触发扫描
-4. **结果处理**: 根据配置隔离/删除/警告不安全的 Skill
-5. **定时周报**: 每周一 12:05 自动生成安全报告
+2. **手动扫描**: 使用命令扫描指定的 Skill 或目录
+3. **结果处理**: 根据配置隔离/删除/警告不安全的 Skill
 
 ## 故障排除
 
@@ -209,24 +187,6 @@ openclaw skills-scanner health
 2. 运行健康检查：`/skills-scanner health`
 3. 检查网络连接
 
-### 定时任务未注册
-
-定时任务会在插件启动时自动注册。如果需要手动注册：
-
-```bash
-# 手动注册定时任务
-/skills-scanner cron setup
-
-# 或使用 CLI
-openclaw cron add \
-  --name "skills-weekly-report" \
-  --cron "5 12 * * 1" \
-  --tz "Asia/Shanghai" \
-  --session isolated \
-  --message "请执行 /skills-scanner scan --report 并把结果发送到此渠道" \
-  --announce
-```
-
 ## 开发
 
 ### 目录结构
@@ -241,8 +201,6 @@ extensions/skills-scanner/
 │   ├── api-client.ts        # HTTP API 客户端
 │   ├── config.ts            # 配置管理
 │   ├── scanner.ts           # 扫描逻辑
-│   ├── watcher.ts           # 文件监控
-│   ├── cron.ts              # 定时任务
 │   ├── commands.ts          # 命令处理
 │   └── types.ts             # 类型定义
 └── skills/

package/index.ts

@@ -6,27 +6,20 @@
 
 import { definePluginEntry } from "openclaw/plugin-sdk/plugin-entry";
 import { join } from "node:path";
-import os from "node:os";
-import { existsSync } from "node:fs";
 import type { ScannerConfig } from "./src/types.js";
 import { skillsScannerConfigSchema, generateConfigGuide } from "./src/config.js";
 import {
   loadState,
   saveState,
   expandPath,
-  defaultScanDirs,
   isFirstRun,
   markConfigReviewed,
   getStateDir,
 } from "./src/state.js";
 import { runScan } from "./src/scanner.js";
-import { buildDailyReport } from "./src/report.js";
-import { ensureCronJobViaGateway, checkCronJobStatus } from "./src/cron-manager.js";
-import { startWatcher } from "./src/watcher.js";
+import { ensureCronJob } from "./src/cron-manager.js";
 import { createCommandHandlers } from "./src/commands.js";
 import { SKILLS_SECURITY_GUIDANCE } from "./src/prompt-guidance.js";
-import { PROMPT_INJECTION_GUARD } from "./src/prompt-injection-guard.js";
-import { HIGH_RISK_OPERATION_GUARD } from "./src/high-risk-operation-guard.js";
 import { handleBeforeInstall } from "./src/before-install-hook.js";
 import type { BeforeInstallEvent } from "./src/before-install-hook.js";
 import { validateConfig } from "./src/config-validator.js";
@@ -57,24 +50,16 @@ export default definePluginEntry({
   }
 
   const apiUrl = cfg.apiUrl ?? "https://110.vemic.com/skills-scanner";
-  const scanDirs =
-    (cfg.scanDirs?.map(expandPath) ?? []).filter(existsSync).length > 0
-      ? cfg.scanDirs!.map(expandPath)
-      : defaultScanDirs();
   const behavioral = cfg.behavioral ?? false;
   const useLLM = cfg.useLLM ?? false;
   const policy = cfg.policy ?? "balanced";
-  const preInstallScan = cfg.preInstallScan ?? "on";
   const onUnsafe = cfg.onUnsafe ?? "warn";
   const injectSecurityGuidance = cfg.injectSecurityGuidance ?? true;
-  const enablePromptInjectionGuard = cfg.enablePromptInjectionGuard ?? false;
-  const enableHighRiskOperationGuard = cfg.enableHighRiskOperationGuard ?? false;
   const enableBeforeInstallHook = cfg.enableBeforeInstallHook ?? true;
 
   api.logger.info("[skills-scanner] ═══════════════════════════════════════");
   api.logger.info("[skills-scanner] Plugin loading...");
   api.logger.info(`[skills-scanner] API URL: ${apiUrl}`);
-  api.logger.info(`[skills-scanner] Scan directories: ${scanDirs.join(", ")}`);
   api.logger.info(`[skills-scanner] Before-install hook: ${enableBeforeInstallHook ? "✅ ENABLED" : "❌ DISABLED"}`);
 
   if (isDebugMode()) {
@@ -84,30 +69,11 @@ export default definePluginEntry({
 
   // Inject system prompt guidance (can be disabled via config)
   if (injectSecurityGuidance) {
-    // Build combined guidance
-    const guidanceParts = [SKILLS_SECURITY_GUIDANCE];
-
-    if (enablePromptInjectionGuard) {
-      guidanceParts.push(PROMPT_INJECTION_GUARD);
-    }
-
-    if (enableHighRiskOperationGuard) {
-      guidanceParts.push(HIGH_RISK_OPERATION_GUARD);
-    }
-
-    const combinedGuidance = guidanceParts.join("\n\n");
-
     api.on("before_prompt_build", async () => ({
-      prependSystemContext: combinedGuidance,
+      prependSystemContext: SKILLS_SECURITY_GUIDANCE,
     }));
 
     api.logger.info("[skills-scanner] ✅ Security guidance injected into system prompt");
-    if (enablePromptInjectionGuard) {
-      api.logger.info("[skills-scanner]    - Prompt injection guard enabled");
-    }
-    if (enableHighRiskOperationGuard) {
-      api.logger.info("[skills-scanner]    - High-risk operation guard enabled");
-    }
   } else {
     api.logger.info("[skills-scanner] ⏭️  Security guidance injection disabled");
   }
@@ -129,7 +95,9 @@ export default definePluginEntry({
         api.logger.error("[skills-scanner] ❌ before_install hook error", {
           error: err.message,
           stack: err.stack,
-          skillPath: event.skillPath,
+          sourcePath: event.sourcePath,
+          targetType: event.targetType,
+          targetName: event.targetName,
         });
         // Return safe default on error - allow installation but log the failure
         return { block: false };
@@ -141,80 +109,20 @@ export default definePluginEntry({
     api.logger.warn("[skills-scanner] ⚠️  before_install hook DISABLED - installations will NOT be intercepted!");
   }
 
-  // Register gateway_start hook for automatic cron job registration
-  api.on("gateway_start", async () => {
+  // 在插件启动时设置系统 crontab 清理任务
+  (async () => {
     try {
-      api.logger.info("[skills-scanner] 🚀 Gateway started, checking cron job...");
-      await ensureCronJobViaGateway({
+      await ensureCronJob({
         logger: api.logger,
-        callGateway: async (method: string, params: any) => {
-          return await api.callGateway(method, params);
-        },
-      });
-      api.logger.info("[skills-scanner] ✅ Cron job check completed");
-    } catch (err: any) {
-      api.logger.error("[skills-scanner] ❌ Cron job registration failed", {
-        error: err.message,
-        stack: err.stack,
+        config: api.config,
       });
-      // Don't throw - avoid blocking gateway startup
-    }
-  });
-
-  // Register plugin_uninstall hook for cleanup
-  api.on("plugin_uninstall", async () => {
-    api.logger.info("[skills-scanner] 🗑️  Plugin uninstalling, cleaning up...");
-
-    try {
-      // 1. Stop file watcher
-      if (stopWatcher) {
-        api.logger.debug("[skills-scanner] Stopping file watcher...");
-        stopWatcher();
-        stopWatcher = null;
-        api.logger.debug("[skills-scanner] ✅ File watcher stopped");
-      }
-
-      // 2. Remove cron jobs
-      try {
-        const listResult = await api.callGateway("cron.list", {});
-        const jobs = listResult?.jobs || [];
-        const ourJobs = jobs.filter((j: any) => j.name === "skills-weekly-report");
-
-        for (const job of ourJobs) {
-          const jobId = job.jobId || job.id;
-          await api.callGateway("cron.remove", { jobId });
-          api.logger.info("[skills-scanner] Removed cron job", { jobId });
-        }
-
-        if (ourJobs.length > 0) {
-          api.logger.info(`[skills-scanner] ✅ Removed ${ourJobs.length} cron job(s)`);
-        }
-      } catch (err: any) {
-        api.logger.warn("[skills-scanner] Failed to remove cron jobs", {
-          error: err.message,
-        });
-      }
-
-      // 3. Save final state
-      try {
-        const finalState = loadState(api.runtime);
-        finalState.lastUninstallAt = new Date().toISOString();
-        saveState(finalState, api.runtime);
-        api.logger.debug("[skills-scanner] ✅ Final state saved");
-      } catch (err: any) {
-        api.logger.warn("[skills-scanner] Failed to save final state", {
-          error: err.message,
-        });
-      }
-
-      api.logger.info("[skills-scanner] ✅ Cleanup completed successfully");
+      api.logger.info("[skills-scanner] ✅ System crontab cleanup task ensured");
     } catch (err: any) {
-      api.logger.error("[skills-scanner] ❌ Cleanup failed", {
+      api.logger.warn("[skills-scanner] ⚠️  Failed to setup system crontab", {
         error: err.message,
-        stack: err.stack,
       });
     }
-  });
+  })();
 
   // Register config_changed hook for hot reload
   api.on("config_changed", async (newConfig: any) => {
@@ -233,8 +141,6 @@ export default definePluginEntry({
 
       // Check what changed
       const apiUrlChanged = newCfg.apiUrl !== cfg.apiUrl;
-      const scanDirsChanged = JSON.stringify(newCfg.scanDirs) !== JSON.stringify(cfg.scanDirs);
-      const preInstallScanChanged = newCfg.preInstallScan !== cfg.preInstallScan;
 
       if (apiUrlChanged) {
         api.logger.info("[skills-scanner] API URL updated", {
@@ -245,42 +151,6 @@ export default definePluginEntry({
         Object.assign(cfg, { apiUrl: newCfg.apiUrl });
       }
 
-      if (scanDirsChanged || preInstallScanChanged) {
-        api.logger.info("[skills-scanner] Scan configuration updated, restarting watcher...");
-
-        // Stop old watcher
-        if (stopWatcher) {
-          stopWatcher();
-          stopWatcher = null;
-        }
-
-        // Start new watcher with updated config
-        const newScanDirs =
-          (newCfg.scanDirs?.map(expandPath) ?? []).filter(existsSync).length > 0
-            ? newCfg.scanDirs!.map(expandPath)
-            : defaultScanDirs();
-
-        if (newCfg.preInstallScan === "on" && newScanDirs.length > 0) {
-          stopWatcher = startWatcher(
-            newScanDirs,
-            newCfg.onUnsafe ?? "warn",
-            newCfg.behavioral ?? false,
-            newCfg.apiUrl ?? apiUrl,
-            newCfg.useLLM ?? false,
-            newCfg.policy ?? "balanced",
-            persistWatcherAlert,
-            api.logger,
-            QUARANTINE_DIR
-          );
-          api.logger.info("[skills-scanner] ✅ Watcher restarted with new configuration");
-        } else {
-          api.logger.info("[skills-scanner] ⏭️  Watcher disabled by new configuration");
-        }
-
-        // Update global config
-        Object.assign(cfg, newCfg);
-      }
-
       api.logger.info("[skills-scanner] ✅ Configuration reload completed");
     } catch (err: any) {
       api.logger.error("[skills-scanner] ❌ Configuration reload failed", {
@@ -297,93 +167,15 @@ export default definePluginEntry({
     const configGuide = generateConfigGuide(
       cfg,
       apiUrl,
-      scanDirs,
       behavioral,
       useLLM,
       policy,
-      preInstallScan,
       onUnsafe
     );
     console.log(configGuide);
     markConfigReviewed(api.runtime);
   }
 
-  // Helper for watcher alerts
-  function persistWatcherAlert(msg: string): void {
-    const state = loadState(api.runtime);
-    const alerts: string[] = (state as any).pendingAlerts ?? [];
-    alerts.push(`[${new Date().toLocaleString("en-US")}] ${msg}`);
-    saveState({ ...state, pendingAlerts: alerts } as any, api.runtime);
-    api.logger.warn(`[skills-scanner] ${msg}`);
-  }
-
-  // Service: start watcher
-  let stopWatcher: (() => void) | null = null;
-
-  api.registerService({
-    id: "skills-scanner-setup",
-    start: async () => {
-      api.logger.info("[skills-scanner] 🚀 Service starting...");
-
-      if (preInstallScan === "on" && scanDirs.length > 0) {
-        api.logger.info(`[skills-scanner] 📁 Starting file monitoring: ${scanDirs.length} directories`);
-        stopWatcher = startWatcher(
-          scanDirs,
-          onUnsafe,
-          behavioral,
-          apiUrl,
-          useLLM,
-          policy,
-          persistWatcherAlert,
-          api.logger,
-          QUARANTINE_DIR
-        );
-        api.logger.info("[skills-scanner] ✅ File monitoring started");
-      } else {
-        api.logger.info("[skills-scanner] ⏭️  Pre-install scan disabled");
-      }
-    },
-    stop: async () => {
-      api.logger.info("[skills-scanner] 🛑 Service stopping...");
-
-      try {
-        // 1. Stop file watcher
-        if (stopWatcher) {
-          api.logger.debug("[skills-scanner] Stopping file watcher...");
-          stopWatcher();
-          stopWatcher = null;
-          api.logger.debug("[skills-scanner] ✅ File watcher stopped");
-        }
-
-        // 2. Save final state
-        try {
-          const finalState = loadState(api.runtime);
-          finalState.lastShutdownAt = new Date().toISOString();
-          saveState(finalState, api.runtime);
-          api.logger.debug("[skills-scanner] ✅ Final state saved");
-        } catch (err: any) {
-          api.logger.warn("[skills-scanner] Failed to save final state", {
-            error: err.message,
-          });
-        }
-
-        // 3. Clear pending alerts (optional - keep for next run)
-        // This is intentionally commented out to preserve alerts
-        // const state = loadState(api.runtime);
-        // if ((state as any).pendingAlerts?.length > 0) {
-        //   saveState({ ...state, pendingAlerts: [] } as any, api.runtime);
-        // }
-
-        api.logger.info("[skills-scanner] ✅ Service stopped cleanly");
-      } catch (err: any) {
-        api.logger.error("[skills-scanner] ❌ Error during shutdown", {
-          error: err.message,
-          stack: err.stack,
-        });
-      }
-    },
-  });
-
   // Health check endpoint
   api.registerHttpRoute({
     method: "GET",
@@ -417,11 +209,6 @@ export default definePluginEntry({
             url: apiUrl,
             status: apiStatus,
           },
-          watcher: {
-            enabled: preInstallScan === "on",
-            running: stopWatcher !== null,
-            directories: scanDirs.length,
-          },
           state: {
             lastScanAt: state.lastScanAt || null,
             lastShutdownAt: state.lastShutdownAt || null,
@@ -461,16 +248,12 @@ export default definePluginEntry({
   const handlers = createCommandHandlers(
     cfg,
     apiUrl,
-    scanDirs,
     behavioral,
     useLLM,
     policy,
-    preInstallScan,
     onUnsafe,
     api.logger,
-    async (method: string, params: any) => {
-      return await api.callGateway(method, params);
-    }
+    api.config
   );
 
   // Chat command: /skills-scanner
@@ -492,13 +275,11 @@ export default definePluginEntry({
             "• `/skills-scanner scan clawhub <URL> [选项]` - 扫描 ClawHub Skill",
             "• `/skills-scanner health` - 健康检查",
             "• `/skills-scanner config [操作]` - 配置管理",
-            "• `/skills-scanner cron [操作]` - 定时任务管理",
             "",
             "扫描选项:",
             "• `--detailed` - 显示详细发现",
             "• `--behavioral` - 启用行为分析",
             "• `--recursive` - 递归扫描子目录",
-            "• `--report` - 生成日报格式",
             "",
             "示例:",
             "```",
@@ -523,8 +304,6 @@ export default definePluginEntry({
         return await handlers.handleHealthCommand();
       } else if (subCommand === "config") {
         return await handlers.handleConfigCommand(subArgs);
-      } else if (subCommand === "cron") {
-        return await handlers.handleCronCommand(subArgs);
       } else if (subCommand === "help" || subCommand === "--help" || subCommand === "-h") {
         return { text: handlers.getHelpText() };
       } else {
@@ -560,23 +339,6 @@ export default definePluginEntry({
     }
   });
 
-  api.registerGatewayMethod("skillsScanner.report", async ({ respond }: any) => {
-    if (scanDirs.length === 0) return respond(false, { error: "No scan directories found" });
-    try {
-      const report = await buildDailyReport(
-        scanDirs,
-        behavioral,
-        apiUrl,
-        useLLM,
-        policy,
-        api.logger
-      );
-      respond(true, { report, state: loadState() });
-    } catch (err: any) {
-      respond(false, { error: err.message });
-    }
-  });
-
   // CLI commands
   api.registerCli(
     ({ program }: any) => {
@@ -615,21 +377,6 @@ export default definePluginEntry({
           process.exit(res.exitCode);
         });
 
-      cmd
-        .command("report")
-        .description("生成日报")
-        .action(async () => {
-          const report = await buildDailyReport(
-            scanDirs,
-            behavioral,
-            apiUrl,
-            useLLM,
-            policy,
-            console
-          );
-          console.log(report);
-        });
-
       cmd
         .command("health")
         .description("检查 API 服务健康状态")

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "skills-scanner",
   "name": "Skills Scanner",
   "description": "Security scanner for OpenClaw Skills to detect potential threats",
-  "version": "1.0.0-beta.2",
+  "version": "1.0.0-beta.21",
   "author": "pwddd",
   "skills": ["./skills"],
   "uiHints": {
@@ -27,10 +27,6 @@
       "label": "扫描策略",
       "help": "strict=严格 / balanced=平衡（推荐）/ permissive=宽松"
     },
-    "preInstallScan": {
-      "label": "安装前扫描",
-      "help": "监听新 Skill 并自动扫描"
-    },
     "onUnsafe": {
       "label": "不安全处理",
       "help": "warn=仅警告（推荐）/ quarantine=隔离 / delete=删除"
@@ -85,12 +81,6 @@
         "description": "Scanning policy: strict (more false positives) / balanced (recommended) / permissive (may miss threats)",
         "default": "balanced"
       },
-      "preInstallScan": {
-        "type": "string",
-        "enum": ["on", "off"],
-        "description": "Enable pre-installation scanning (monitors directories for new Skills)",
-        "default": "on"
-      },
       "onUnsafe": {
         "type": "string",
         "enum": ["quarantine", "delete", "warn"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pwddd/skills-scanner",
-  "version": "1.0.0-beta.2",
+  "version": "1.0.0-beta.21",
   "description": "OpenClaw Skills security scanner plugin - detect malicious code, data exfiltration, and prompt injection",
   "type": "module",
   "main": "./index.ts",