@putout/plugin-types 5.0.0 → 6.0.0

package/README.md

@@ -18,6 +18,7 @@ npm i putout @putout/plugin-types -D
 - ✅ [declare](#declare);
 - ✅ [remove-double-negations](#remove-double-negations);
 - ✅ [remove-useless-conversion](#remove-useless-conversion);
+- ✅ [remove-useless-constructor](#remove-useless-constructor);
 - ✅ [remove-useless-typeof](#remove-useless-typeof);
 
 ## Config
@@ -28,6 +29,7 @@ npm i putout @putout/plugin-types -D
         "types/declare": "on",
         "types/convert-typeof-to-istype": "on",
         "types/remove-useless-conversion": "on",
+        "types/remove-useless-constructor": "on",
         "types/remove-double-negations": "on",
         "types/remove-useless-typeof": "on",
         "types/apply-is-array": "on"
@@ -52,6 +54,7 @@ Supported assertions:
 - `isBigInt`;
 - `isArray`;
 - `isEmptyArray`;
+- `isError`;
 
 ### ❌ Example of incorrect code
 
@@ -115,6 +118,30 @@ const b = Boolean([1].includes(1));
 const a = [1].includes(1);
 ```
 
+## remove-useless-constructor
+
+> Wrapper classes have surprising behaviour, such as `new Boolean(false)` evaluating to `true`.
+>
+> (c) [Google TypeScript Style Guide](https://google.github.io/styleguide/tsguide.html#primitive-types-wrapper-classes)
+
+🐊[**Putout**](https://github.com/coderaiser/putout) plugin adds ability to remove useless `constructor`. Use with [`new/remove-useless`](https://github.com/coderaiser/putout/tree/master/packages/plugin-new#readme).
+
+### ❌ Example of incorrect code
+
+```js
+const s = String('hello');
+const b = Boolean(false);
+const n = Number(5);
+```
+
+### ✅ Example of correct code
+
+```js
+const s = 'hello';
+const b = false;
+const n = 5;
+```
+
 ## remove-double-negations
 
 > It is possible to use a couple of **NOT** operators (`!!`) in series to explicitly force the conversion of any value to the corresponding boolean primitive. The conversion is based on the "truthyness" or "falsyness" of the value.

package/lib/convert-typeof-to-is-type/index.js

@@ -16,6 +16,9 @@ const NAMES = {
 const EQUAL = 'typeof __a === "__b"';
 const NOT_EQUAL = 'typeof __a !== "__b"';
 
+const EQUAL_INSTANCE_OF = '__a instanceof __b';
+const NOT_EQUAL_INSTANCE_OF = '!(__a instanceof __b)';
+
 const BODIES = {
     function: `typeof __a === 'function'`,
     string: `typeof __a === 'string'`,
@@ -24,6 +27,7 @@ const BODIES = {
     undefined: `typeof __a === 'undefined'`,
     symbol: `typeof __a === 'symbol'`,
     bigint: `typeof __a === 'bigint'`,
+    error: `__a instanceof Error`,
 };
 
 const NOT_BODIES = {
@@ -34,12 +38,15 @@ const NOT_BODIES = {
     undefined: `typeof __a !== 'undefined'`,
     symbol: `typeof __a !== 'symbol'`,
     bigint: `typeof __a !== 'bigint'`,
+    error: `!(__a instanceof Error)`,
 };
 
-module.exports.report = () => `Use function to check type instead of 'typeof'`;
+module.exports.report = () => `Use function to check type instead of 'typeof' or 'instanceof'`;
 module.exports.match = () => ({
     [EQUAL]: check,
     [NOT_EQUAL]: check,
+    [EQUAL_INSTANCE_OF]: check,
+    [NOT_EQUAL_INSTANCE_OF]: check,
 });
 
 module.exports.replace = () => ({
@@ -50,6 +57,7 @@ module.exports.replace = () => ({
     [BODIES.undefined]: 'isUndefined(__a)',
     [BODIES.symbol]: 'isSymbol(__a)',
     [BODIES.bigint]: 'isBigInt(__a)',
+    [BODIES.error]: 'isError(__a)',
     [NOT_BODIES.function]: '!isFn(__a)',
     [NOT_BODIES.string]: '!isString(__a)',
     [NOT_BODIES.number]: '!isNumber(__a)',
@@ -57,6 +65,7 @@ module.exports.replace = () => ({
     [NOT_BODIES.undefined]: '!isUndefined(__a)',
     [NOT_BODIES.symbol]: '!isSymbol(__a)',
     [NOT_BODIES.bigint]: '!isBigInt(__a)',
+    [NOT_BODIES.error]: '!isError(__a)',
 });
 
 function check({__a, __b}, path) {

package/lib/declare/index.js

@@ -13,4 +13,5 @@ module.exports.declare = () => ({
     isNull: `const isNull = (a) => !a && typeof a === 'object'`,
     isArray: 'const {isArray} = Array',
     isEmptyArray: 'const isEmptyArray = (a) => isArray(a) && !a.length',
+    isError: 'const isError = (a) => a instanceof Error',
 });

package/lib/index.js

@@ -4,6 +4,7 @@ const applyIsArray = require('./apply-is-array');
 const declare = require('./declare');
 const convertTypeofToIsType = require('./convert-typeof-to-is-type');
 const removeUselessConversion = require('./remove-useless-conversion');
+const removeUselessConstructor = require('./remove-useless-constructor');
 const removeDoubleNegations = require('./remove-double-negations');
 const removeUselessTypeof = require('./remove-useless-typeof');
 
@@ -12,6 +13,7 @@ module.exports.rules = {
     declare,
     'convert-typeof-to-is-type': convertTypeofToIsType,
     'remove-useless-conversion': removeUselessConversion,
+    'remove-useless-constructor': removeUselessConstructor,
     'remove-double-negations': removeDoubleNegations,
     'remove-useless-typeof': removeUselessTypeof,
 };

package/lib/remove-useless-constructor/index.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const {types} = require('putout');
+const {
+    isBooleanLiteral,
+    isNumericLiteral,
+} = types;
+
+module.exports.report = () => 'Avoid useless constructor';
+
+module.exports.match = () => ({
+    'Boolean(__a)': ({__a}) => isBooleanLiteral(__a),
+    'Number(__a)': ({__a}) => isNumericLiteral(__a),
+});
+
+module.exports.replace = () => ({
+    'String("__a")': '__a',
+    'Boolean(__a)': '__a',
+    'Number(__a)': '__a',
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-types",
-  "version": "5.0.0",
+  "version": "6.0.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds ability to transform code related to types assertions",
@@ -11,7 +11,7 @@
   "changelog": false,
   "repository": {
     "type": "git",
-    "url": "git://github.com/coderaiser/putout.git"
+    "url": "git+https://github.com/coderaiser/putout.git"
   },
   "scripts": {
     "test": "madrun test",
@@ -43,7 +43,7 @@
     "nodemon": "^3.0.1"
   },
   "peerDependencies": {
-    "putout": ">=36"
+    "putout": ">=37"
   },
   "license": "MIT",
   "engines": {