@putout/plugin-types 1.1.0 → 1.2.0

package/README.md

@@ -17,7 +17,9 @@ npm i putout @putout/plugin-types -D
 {
     "rules": {
         "types/declare": "on",
-        "types/convert-typeof-to-istype": "on"
+        "types/convert-typeof-to-istype": "on",
+        "types/remove-useless-conversion": "on",
+        "types/remove-double-negations": "on"
     }
 }
 ```
@@ -41,7 +43,6 @@ Supported assertions:
 #### ❌ Example of incorrect code
 
 ```js
-const isString = (a) => typeof a === 'string';
 isString('hello');
 ```
 
@@ -88,6 +89,53 @@ if (isBool(a))
     return x;
 ```
 
+
+### remove-useless-conversion
+
+#### ❌ Example of incorrect code
+
+```js
+const a = !![1].includes(1);
+const b = Boolean([1].includes(1));
+```
+
+#### ✅ Example of correct code
+
+```js
+const a = [1].includes(1);
+```
+
+### remove-double-negations
+
+> It is possible to use a couple of **NOT** operators (`!!`) in series to explicitly force the conversion of any value to the corresponding boolean primitive. The conversion is based on the "truthyness" or "falsyness" of the value.
+>
+> The same conversion can be done through the `Boolean` function.
+>
+> (c) [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_NOT)
+
+#### ❌ Example of incorrect code
+
+```js
+if (!!a) {
+    console.log('hi');
+}
+```
+
+#### ✅ Example of correct code
+
+```js
+if (a) {
+    console.log('hi');
+}
+```
+
+## Comparison
+
+Linter | Rule | Fix
+--------|-------|------------|
+🐊 **Putout** | [`types`](https://github.com/coderaiser/putout/tree/master/packages/plugin-types#readme)| ✅
+⏣ **ESLint** | [`no-implicit-coercion`](https://eslint.org/docs/rules/no-implicit-coercion) | ✅
+
 ## License
 
 MIT

package/lib/index.js

@@ -7,5 +7,7 @@ const getRule = (a) => ({
 module.exports.rules = {
     ...getRule('declare'),
     ...getRule('convert-typeof-to-is-type'),
+    ...getRule('remove-useless-conversion'),
+    ...getRule('remove-double-negations'),
 };
 

package/lib/remove-double-negations/index.js

@@ -0,0 +1,16 @@
+'use strict';
+
+module.exports.report = () => `Avoid double negations in conditions`;
+
+module.exports.filter = ({parentPath}) => !parentPath.isJSXExpressionContainer();
+
+module.exports.replace = () => ({
+    'if (!!__a) __b': 'if (__a) __b',
+    '!!__a ? __b : __c': '__a ? __b : __c',
+    '!!__a && __b': '__a && __b',
+    '!!__a.includes(__b)': '__a.includes(__b)',
+    'while(!!__a) __b': 'while(__a) __b',
+    'do __a; while(!!__b)': 'do __a; while(__b)',
+    'for (__a; !!__b; __c) __d': 'for (__a; __b; __c) __d',
+});
+

package/lib/remove-useless-conversion/index.js

@@ -0,0 +1,16 @@
+'use strict';
+
+module.exports.report = () => `Avoid useless type conversion`;
+
+module.exports.replace = () => ({
+    'Boolean(__a.includes(__b))': '__a.includes(__b)',
+    'String(typeof __a)': 'typeof __a',
+    'if (Boolean(__a)) __b': 'if (__a) __b',
+    'while (Boolean(__a)) __b': 'while (__a) __b',
+    'do __b; while (Boolean(__a))': 'do __b; while (__a)',
+    'for (__a; Boolean(__b); __c) __d': 'for (__a; __b; __c) __d',
+    'for (__a; Boolean(__b);) __d': 'for (__a; __b;) __d',
+    'for (; Boolean(__b);__c) __d': 'for (; __b; __c) __d',
+    'for (; Boolean(__b);) __d': 'for (; __b;) __d',
+});
+

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-types",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds ability to transform code related to types assertions",