@putout/plugin-tape 3.5.0 → 3.8.0

package/README.md

@@ -18,6 +18,9 @@ npm i @putout/plugin-tape -D
 ```json
 {
     "rules": {
+        "tape/apply-stub-operator": "on",
+        "tape/apply-with-name": "on",
+        "tape/sync-with-name": "on",
         "tape/switch-expected-with-result": "on",
         "tape/convert-tape-to-supertape": "on",
         "tape/convert-throws-to-try-catch": "on",
@@ -26,13 +29,14 @@ npm i @putout/plugin-tape -D
         "tape/convert-called-with-to-called-with-no-args": "on",
         "tape/convert-called-with-no-args-to-called-with": "on",
         "tape/expand-try-catch-arguments": "on",
-        "tape/apply-stub-operator": "on",
         "tape/convert-emitter-to-promise": "on",
         "tape/convert-ok-to-match": "on",
         "tape/convert-ok-to-called-with": "on",
         "tape/convert-match-regexp-to-string": "on",
         "tape/declare-stub": "on",
-        "tape/declare-t": "on"
+        "tape/declare-t": "on",
+        "tape/remove-default-messages": "on",
+        "tape/remove-useless-not-called-args": "on"
     }
 }
 ```
@@ -314,6 +318,58 @@ test('some message', (t) => {
 });
 ```
 
+## apply-with-name
+
+### ❌ Incorrect code example
+
+```js
+test('should call init before show', (t) => {
+    const init = stub();
+    const show = stub();
+    
+    t.calledInOrder([init, show]);
+    t.end();
+});
+```
+
+### ✅ Correct code example
+
+```js
+test('should call init before show', (t) => {
+    const init = stub().withName('init');
+    const show = stub().withName('show');
+    
+    t.calledInOrder([init, show]);
+    t.end();
+});
+```
+
+## sync-with-name
+
+### ❌ Incorrect code example
+
+```js
+test('should call init before show', (t) => {
+    const init = stub().withName('show');
+    const show = stub().withName('show');
+    
+    t.calledInOrder([init, show]);
+    t.end();
+});
+```
+
+### ✅ Correct code example
+
+```js
+test('should call init before show', (t) => {
+    const init = stub().withName('init');
+    const show = stub().withName('show');
+    
+    t.calledInOrder([init, show]);
+    t.end();
+});
+```
+
 ## declare-stub
 
 ### ❌ Incorrect code example
@@ -445,6 +501,20 @@ t.equal(result, expected, 'should equal');
 t.equal(result, expected);
 ```
 
+## remove-useless-not-called-args
+
+### ❌ Incorrect code example
+
+```js
+t.notCalled(fn, []);
+```
+
+### ✅ Correct code example
+
+```js
+t.notCalled(fn);
+```
+
 ## License
 
 MIT

package/lib/apply-with-name/index.js

@@ -0,0 +1,85 @@
+'use strict';
+
+const {
+    template,
+    operator,
+} = require('putout');
+
+const {replaceWith} = operator;
+
+module.exports.report = () => `'stub().withName()' should be used`;
+
+module.exports.match = () => ({
+    't.calledBefore(__a, __b)': checkStubs,
+    't.calledAfter(__a, __b)': checkStubs,
+    't.calledInOrder(__array)': checkStubsArray,
+});
+
+module.exports.replace = () => ({
+    't.calledBefore(__a, __b)': applyWithName,
+    't.calledAfter(__a, __b)': applyWithName,
+    't.calledInOrder(__array)': applyWithNameToArray,
+});
+
+function checkStubs({__a, __b}, path) {
+    const elements = [__a, __b];
+    const __array = {
+        elements,
+    };
+    return checkStubsArray({__array}, path);
+}
+
+function applyWithName({__a, __b}, path) {
+    applyWithNameToNode(__a, path);
+    applyWithNameToNode(__b, path);
+    return path;
+}
+
+function checkStubsArray({__array}, path) {
+    for (const stub of __array.elements) {
+        if (checkStub(stub, path))
+            return true;
+    }
+    
+    return false;
+}
+
+function applyWithNameToArray({__array}, path) {
+    for (const stub of __array.elements) {
+        applyWithNameToNode(stub, path);
+    }
+    
+    return path;
+}
+
+function checkStub(node, path) {
+    const {bindings} = path.scope;
+    const {name} = node;
+    const binding = bindings[name];
+    
+    if (!binding)
+        return false;
+    
+    const initPath = binding.path.get('init');
+    const calleePath = initPath.get('callee');
+    
+    return !calleePath.isMemberExpression();
+}
+
+function applyWithNameToNode(node, path) {
+    const {bindings} = path.scope;
+    const {name} = node;
+    const binding = bindings[name];
+    
+    if (!binding)
+        return;
+    
+    const initPath = binding.path.get('init');
+    const calleePath = initPath.get('callee');
+    
+    if (calleePath.isMemberExpression())
+        return;
+    
+    replaceWith(initPath, template.ast(`stub().withName('${name}')`));
+}
+

package/lib/index.js

@@ -5,7 +5,8 @@ const getRule = (a) => ({
 });
 
 module.exports.rules = {
-    ...getRule('switch-expected-with-result'),
+    ...getRule('apply-with-name'),
+    ...getRule('sync-with-name'),
     ...getRule('convert-tape-to-supertape'),
     ...getRule('convert-throws-to-try-catch'),
     ...getRule('convert-does-not-throw-to-try-catch'),
@@ -19,9 +20,11 @@ module.exports.rules = {
     ...getRule('convert-equal-to-not-ok'),
     ...getRule('convert-equal-to-ok'),
     ...getRule('expand-try-catch-arguments'),
-    ...getRule('apply-stub-operator'),
     ...getRule('declare-stub'),
     ...getRule('declare-t'),
     ...getRule('remove-default-messages'),
+    ...getRule('remove-useless-not-called-args'),
+    ...getRule('switch-expected-with-result'),
+    ...getRule('apply-stub-operator'),
 };
 

package/lib/remove-useless-not-called-args/index.js

@@ -0,0 +1,8 @@
+'use strict';
+
+module.exports.report = () => 'Remove useless "notCalled" args';
+
+module.exports.replace = () => ({
+    't.notCalled(__a, __array)': 't.notCalled(__a)',
+});
+

package/lib/sync-with-name/index.js

@@ -0,0 +1,14 @@
+'use strict';
+
+module.exports.report = () => `'stub().withName(name)' should synced with variable name`;
+
+module.exports.match = () => ({
+    'const __a = stub().withName(__b)': ({__a, __b}) => __b.value !== __a.name,
+});
+
+module.exports.replace = () => ({
+    'const __a = stub().withName(__b)': ({__a, __b}, path) => {
+        __b.value = __a.name;
+        return path;
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-tape",
-  "version": "3.5.0",
+  "version": "3.8.0",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "putout plugin helps with tests",
   "homepage": "http://github.com/coderaiser/putout",
@@ -39,6 +39,7 @@
     "eslint-plugin-putout": "^10.0.0",
     "lerna": "^4.0.0",
     "madrun": "^8.0.1",
+    "montag": "^1.2.1",
     "nodemon": "^2.0.1"
   },
   "peerDependencies": {