@putout/plugin-tape 21.6.0 → 21.8.0

package/README.md

@@ -50,6 +50,7 @@ npm i @putout/plugin-tape -D
 - ✅ [remove-useless-undefined](#remove-useless-undefined);
 - ✅ [switch-expected-with-result](#switch-expected-with-result);
 - ✅ [sync-with-name](#sync-with-name);
+- ✅ [move-out-result-from-assertion](#move-out-result-from-assertion);
 
 ## Config
 
@@ -90,7 +91,8 @@ npm i @putout/plugin-tape -D
         }],
         "tape/remove-skip": ["on", {
             "allowed": ["test"]
-        }]
+        }],
+        "tape/move-out-result-from-assertion": "on"
     }
 }
 ```
@@ -418,7 +420,7 @@ cleanup();
 
 t.equal(result, expected);
 t.end();
-````
+```
 
 ## apply-destructuring
 
@@ -819,6 +821,39 @@ test('some test', (t) => {
 });
 ```
 
+## move-out-result-from-assertion
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/264bc87f56eae9aa2b2884ff64fe7a06/94836a115a072a18fd717d5454792c1895ab0476).
+
+### ❌ Example of incorrect code
+
+```js
+t.notOk(screen.getByRole('button').disabled);
+
+t.deepEqual(readState({
+    getItem,
+}), {
+    a: 1,
+});
+```
+
+### ✅ Example of correct code
+
+```js
+const {disabled} = screen.getByRole('button');
+t.notOk(disabled);
+
+const result = readState({
+    getItem,
+});
+
+const expected = {
+    a: 1,
+};
+
+t.deepEqual(result, expected);
+```
+
 ## License
 
 MIT

package/lib/apply-assertions-order/index.js

@@ -28,11 +28,15 @@ export const fix = ({prev, prevPrev}) => {
 export const traverse = ({push}) => ({
     't.end()': (path) => {
         const prev = path.parentPath.getPrevSibling();
-        const prevPrev = prev.getPrevSibling();
+        
+        if (!prev.node)
+            return;
         
         if (compare(prev, 't.__a(__args)'))
             return;
         
+        const prevPrev = prev.getPrevSibling();
+        
         push({
             path,
             prev,

package/lib/index.js

@@ -1,3 +1,4 @@
+import * as movOutResultFromAssertion from './move-out-result-from-assertion/index.js';
 import * as applyAssertionsOrder from './apply-assertions-order/index.js';
 import * as removeUselessUndefined from './remove-useless-undefined/index.js';
 import * as extractArgsFromCalledWith from './extract-args-from-called-with/index.js';
@@ -68,4 +69,5 @@ export const rules = {
     'extract-args-from-called-with': extractArgsFromCalledWith,
     'remove-useless-undefined': removeUselessUndefined,
     'apply-assertions-order': applyAssertionsOrder,
+    'move-out-result-from-assertion': movOutResultFromAssertion,
 };

package/lib/move-out-result-from-assertion/index.js

@@ -0,0 +1,78 @@
+import {operator, types} from 'putout';
+
+const {getBinding} = operator;
+
+const {
+    isIdentifier,
+    isMemberExpression,
+    isOptionalMemberExpression,
+    isObjectExpression,
+} = types;
+
+export const report = () => `Move out result from assertion`;
+export const match = () => ({
+    't.__a(__b, __c)': ({__a, __b, __c}, path) => {
+        if (!/equal/i.test(__a.name))
+            return false;
+        
+        if (isMemberExpression(__b) && __b.property.name === 'callCount')
+            return false;
+        
+        if (isMemberExpression(__b))
+            return false;
+        
+        if (isOptionalMemberExpression(__b))
+            return false;
+        
+        const resultBinding = getBinding(path, 'result');
+        const expectedBinding = getBinding(path, 'expected');
+        
+        if (resultBinding && expectedBinding)
+            return false;
+        
+        if (!resultBinding && !isIdentifier(__b))
+            return true;
+        
+        if (expectedBinding)
+            return false;
+        
+        return isObjectExpression(__c);
+    },
+});
+
+export const replace = () => ({
+    't.__(__a.__b(__args).__c)': `{
+        const {__c} = __a.__b(__args);
+        t.__(__c);
+    }`,
+    't.__(__a(__b))': `{
+        const result = __a(__b);
+        t.__(result);
+    }`,
+    't.__a(__b, __c)': ({__b, __c}, path) => {
+        const resultBinding = getBinding(path, 'result');
+        const expectedBinding = getBinding(path, 'expected');
+        
+        if (!resultBinding && !expectedBinding)
+            return `{
+                const result = __b;
+                const expected= __c;
+                
+                t.__a(result, expected);
+            }`;
+        
+        if (!expectedBinding && !isIdentifier(__c))
+            return `{
+                const expected = __c;
+                
+                t.__a(__b, expected);
+            }`;
+        
+        if (!resultBinding && !isIdentifier(__b))
+            return `{
+                const result = __b;
+                
+                t.__a(result, __c);
+            }`;
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-tape",
-  "version": "21.6.0",
+  "version": "21.8.0",
   "type": "module",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin helps with tests",