@putout/plugin-tape 21.3.0 → 21.5.0

package/README.md

@@ -39,12 +39,14 @@ npm i @putout/plugin-tape -D
 - ✅ [convert-tape-to-supertape](#convert-tape-to-supertape);
 - ✅ [convert-throws-to-try-catch](#convert-throws-to-try-catch);
 - ✅ [declare](#declare);
+- ✅ [extract-args-from-called-with](#extract-args-from-called-with);
 - ✅ [jest](#jest);
 - ✅ [remove-default-messages](#remove-default-messages);
 - ✅ [remove-only](#remove-only);
 - ✅ [remove-skip](#remove-skip);
 - ✅ [remove-useless-not-called-args](#remove-useless-not-called-args);
 - ✅ [remove-useless-t-end](#remove-useless-t-end);
+- ✅ [remove-useless-undefined](#remove-useless-undefined);
 - ✅ [switch-expected-with-result](#switch-expected-with-result);
 - ✅ [sync-with-name](#sync-with-name);
 
@@ -77,8 +79,10 @@ npm i @putout/plugin-tape -D
         "tape/convert-match-regexp-to-string": "on",
         "tape/add-args": "on",
         "tape/declare": "on",
+        "tape/extract-args-from-called-with": "on",
         "tape/remove-default-messages": "on",
         "tape/remove-useless-not-called-args": "on",
+        "tape/remove-useless-undefined": "on",
         "tape/remove-only": ["on", {
             "allowed": ["test"]
         }],
@@ -486,6 +490,36 @@ test('should call init before show', (t) => {
 });
 ```
 
+## extract-args-from-called-with
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/1a4b8e28b15ada7c7ad17e544ae03e2a/c6ca31508b8d4f2572d6a0c65dfbfe28c53016b1).
+
+### ❌ Example of incorrect code
+
+```js
+test('abc: def', (t) => {
+    t.calledWith(executeFn, [
+        ['tape', 'test.js'], {
+            exit,
+        },
+    ]);
+});
+```
+
+### ✅ Example of correct code
+
+```js
+test('abc: def', (t) => {
+    const args = [
+        ['tape', 'test.js'], {
+            exit,
+        },
+    ];
+    
+    t.calledWith(executeFn, args);
+});
+```
+
 ## declare
 
 ### ❌ Example of incorrect code
@@ -561,6 +595,22 @@ test('test: remove me', () => {
 });
 ```
 
+## remove-useless-undefined
+
+### ❌ Example of incorrect code
+
+```js
+stub().returns(undefined);
+stub().resolves(undefined);
+```
+
+### ✅ Example of correct code
+
+```js
+stub();
+stub().resolves();
+```
+
 ## convert-ok-to-match
 
 ### ❌ Example of incorrect code

package/lib/extract-args-from-called-with/index.js

@@ -0,0 +1,48 @@
+import {types, operator} from 'putout';
+
+const {
+    isArrayExpression,
+    isObjectExpression,
+    variableDeclarator,
+    variableDeclaration,
+    identifier,
+} = types;
+
+const {insertBefore} = operator;
+
+export const report = () => `Extract 'args' from 't.calledWith()'`;
+
+export const fix = (path) => {
+    const id = identifier('args');
+    const init = path.node.arguments.pop();
+    
+    path.node.arguments.push(id);
+    
+    insertBefore(path.parentPath, variableDeclaration('const', [
+        variableDeclarator(id, init),
+    ]));
+};
+
+export const traverse = ({push}) => ({
+    't.calledWith(__a, __b)': (path) => {
+        if (path.scope.bindings.args)
+            return;
+        
+        const [, args] = path.node.arguments;
+        
+        if (!isArrayExpression(args))
+            return;
+        
+        for (const element of args.elements) {
+            if (isObjectExpression(element)) {
+                push(path);
+                return;
+            }
+            
+            if (isArrayExpression(element)) {
+                push(path);
+                return;
+            }
+        }
+    },
+});

package/lib/index.js

@@ -1,3 +1,5 @@
+import * as removeUselessUndefined from './remove-useless-undefined/index.js';
+import * as extractArgsFromCalledWith from './extract-args-from-called-with/index.js';
 import * as applyStub from './apply-stub/index.js';
 import * as applyDestructuring from './apply-destructuring/index.js';
 import * as applyWithName from './apply-with-name/index.js';
@@ -62,4 +64,6 @@ export const rules = {
     'remove-useless-t-end': removeUselessTEnd,
     'remove-only': removeOnly,
     'remove-skip': removeSkip,
+    'extract-args-from-called-with': extractArgsFromCalledWith,
+    'remove-useless-undefined': removeUselessUndefined,
 };

package/lib/remove-useless-undefined/index.js

@@ -0,0 +1,6 @@
+export const report = () => `Avoid useless 'returns/resolves(undefined)'`;
+
+export const replace = () => ({
+    'stub().returns(undefined)': 'stub()',
+    'stub().resolves(undefined)': 'stub().resolves()',
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-tape",
-  "version": "21.3.0",
+  "version": "21.5.0",
   "type": "module",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin helps with tests",
@@ -33,7 +33,6 @@
     "@putout/plugin-putout": "*",
     "@putout/test": "^15.0.0",
     "eslint": "^10.0.0",
-    "eslint-plugin-n": "^17.0.0",
     "eslint-plugin-putout": "^31.0.0",
     "madrun": "^13.0.0",
     "montag": "^2.0.0",