@putout/plugin-tape 21.17.1 → 21.19.0

package/README.md

@@ -17,6 +17,7 @@ npm i @putout/plugin-tape -D
 
 ## Rules
 
+- ✅ [convert-ok-to-pass](#convert-ok-to-pass)
 - ✅ [add-args](#add-args);
 - ✅ [add-t-end](#add-t-end);
 - ✅ [apply-assertions-order](#apply-assertions-order);
@@ -98,7 +99,8 @@ npm i @putout/plugin-tape -D
         "tape/remove-skip": ["on", {
             "allowed": ["test"]
         }],
-        "tape/extract-result-from-assertion": "on"
+        "tape/extract-result-from-assertion": "on",
+        "tape/convert-ok-to-pass": "on"
     }
 }
 ```
@@ -946,6 +948,22 @@ test('hello: world', (t) => {
 });
 ```
 
+## convert-ok-to-pass
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/33a05ac444d013db10fc5a1986b6ac49/f1bc8eda628a5ce5dc6ad5ee20e796b727e40083).
+
+### ❌ Example of incorrect code
+
+```js
+t.ok(true);
+```
+
+### ✅ Example of correct code
+
+```js
+t.pass();
+```
+
 ## License
 
 MIT

package/lib/apply-assertions-order/index.js

@@ -14,15 +14,15 @@ const printNode = (a) => print(a, {
     }],
 });
 
-export const report = ({prev, prevPrev}) => {
-    return `Use '${printNode(prev)}' before '${printNode(prevPrev)}'`;
+export const report = ({prev, assertion}) => {
+    return `Use '${printNode(prev)}' before '${printNode(assertion)}'`;
 };
 
-export const fix = ({prev, prevPrev}) => {
+export const fix = ({prev, assertion}) => {
     const prevNode = prev.node;
     
     remove(prev);
-    insertBefore(prevPrev, prevNode);
+    insertBefore(assertion, prevNode);
 };
 
 export const traverse = ({push}) => ({
@@ -35,15 +35,27 @@ export const traverse = ({push}) => ({
         if (compare(prev, 't.__a(__args)'))
             return;
         
-        const prevPrev = prev.getPrevSibling();
+        const assertion = findAssertion(prev);
         
-        if (!compare(prevPrev, 't.__a(__args)'))
+        if (!assertion)
             return;
         
         push({
             path,
             prev,
-            prevPrev,
+            assertion,
         });
     },
 });
+
+function findAssertion(path) {
+    const prev = path.getPrevSibling();
+    
+    if (compare(prev, 't.__a(__args)'))
+        return prev;
+    
+    if (!prev.node)
+        return null;
+    
+    return findAssertion(prev);
+}

package/lib/convert-ok-to-pass/index.js

@@ -0,0 +1,5 @@
+export const report = () => `Use 't.pass()' instead of 't.ok()'`;
+
+export const replace = () => ({
+    't.ok(true)': 't.pass()',
+});

package/lib/index.js

@@ -1,3 +1,4 @@
+import * as convertOkToPass from './convert-ok-to-pass/index.js';
 import * as convertEqualLengthToMatchString from './convert-equal-length-to-match-string/index.js';
 import * as removeTFromAsync from './remove-t-from-async/index.js';
 import * as applyStringify from './apply-stringify/index.js';
@@ -76,4 +77,5 @@ export const rules = {
     'apply-stringify': applyStringify,
     'remove-t-from-async': removeTFromAsync,
     'convert-equal-length-to-match-string': convertEqualLengthToMatchString,
+    'convert-ok-to-pass': convertOkToPass,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-tape",
-  "version": "21.17.1",
+  "version": "21.19.0",
   "type": "module",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin helps with tests",