@putout/plugin-putout 23.6.0 → 23.8.0

package/README.md

@@ -37,6 +37,7 @@ npm i @putout/plugin-putout -D
 - ✅ [apply-parens](#apply-parens);
 - ✅ [apply-short-processors](#apply-short-processors);
 - ✅ [check-match](#check-match);
+- ✅ [check-declare](#check-declare);
 - ✅ [check-replace-code](#check-replace-code);
 - ✅ [convert-add-argument-to-add-args](#convert-add-argument-to-add-test-args);
 - ✅ [convert-babel-types](#convert-babel-types);
@@ -105,6 +106,7 @@ npm i @putout/plugin-putout -D
         "putout/apply-for-of-to-track-file": "on",
         "putout/apply-fixture-name-to-message": "on",
         "putout/check-match": "on",
+        "putout/check-declare": "on",
         "putout/check-replace-code": ["on", {
             "once": true
         }],
@@ -162,7 +164,6 @@ path.node = Identifier('x');
 path.node = identifier('x');
 ```
 
-
 ## apply-processors-destructuring
 
 ### ❌ Example of incorrect code
@@ -864,6 +865,23 @@ module.exports.match = () => ({
 });
 ```
 
+## check-declare
+
+Checks that [Declarator](https://github.com/coderaiser/putout/tree/master/packages/engine-runner#declarator) transform is possible.
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/9fccb187bb8933afff0dc0db57b3cea8/25cb812978fadb4efb5f0cb44058a61f70f8b78e):
+
+### ❌ Example of incorrect code
+
+```js
+module.exports.declare = () => ({
+    isNumber: 'const isNumber = () => {}',
+    isString: 'const isNumber = () => {}',
+});
+```
+
+☝️ *There is no `fix` for this rule, it used internally to be more confident about `test coverage`, because of declaration form, transforms cannon be checked by `nyc` and `c8`, and uncovered lines can find unfixable false positives when running on code.
+This is additional tests, if you forget to test some case (from a big list of rules that is supported) it will be checked with this `rule` and make transforms more stable.*
+
 ## check-replace-code
 
 Checks that [Replacer](https://github.com/coderaiser/putout/tree/master/packages/engine-runner#replacer) transform is possible.

package/lib/add-traverse-args/index.js

@@ -7,13 +7,14 @@ const {
     identifier,
 } = types;
 
-const {traverse} = operator;
+const {traverse, getBinding} = operator;
 
 const defaultNames = [
     'push',
     'store',
     'listStore',
     'pathStore',
+    'options',
 ];
 
 module.exports.report = ({name}) => `Add '${name}' argument to 'traverse'`;
@@ -73,22 +74,23 @@ const checkArgs = (names, push) => (path) => {
             if (isArgExists(name, fn))
                 return;
             
+            if (getBinding(path, name))
+                return;
+            
             push({
                 path,
                 fn,
                 name,
             });
         },
-        [`__a(__args)`]: (currentPath) => {
-            const {callee} = currentPath.node;
+        [`__a(__args)`]: (path) => {
+            const {callee} = path.node;
             const {name} = callee;
             
             if (!names.includes(name))
                 return;
             
-            const bindings = currentPath.scope.getAllBindings();
-            
-            if (bindings[name])
+            if (getBinding(path, name))
                 return;
             
             push({

package/lib/check-declare/index.js

@@ -0,0 +1,62 @@
+'use strict';
+
+const tryCatch = require('try-catch');
+const putout = require('putout');
+
+const {types, operator} = putout;
+
+const noop = () => {};
+const {getTemplateValues} = operator;
+
+const DECLARE_ESM = 'export const declare = () => __object';
+const DECLARE_COMMONJS = 'module.exports.declare = () => __object';
+const COMMONJS = 'module.exports = __object';
+
+const {
+    isTemplateLiteral,
+    isStringLiteral,
+} = types;
+
+module.exports.report = ({message}) => message;
+
+module.exports.fix = noop;
+module.exports.traverse = ({push}) => ({
+    [DECLARE_ESM]: createCheck(push, DECLARE_ESM),
+    [DECLARE_COMMONJS]: createCheck(push, DECLARE_COMMONJS),
+    [COMMONJS]: createCheck(push, COMMONJS),
+});
+
+const createCheck = (push, template) => (path) => {
+    const {__object} = getTemplateValues(path, template);
+    
+    const lines = [];
+    
+    for (const {value} of __object.properties) {
+        let current = '';
+        
+        if (isStringLiteral(value)) {
+            current = value.value;
+        } else if (isTemplateLiteral(value)) {
+            if (value.quasis.length > 1)
+                continue;
+            
+            current = value.quasis[0].value.cooked;
+        }
+        
+        if (/^(const|import)/.test(current))
+            lines.push(current);
+    }
+    
+    const source = lines.join(';\n');
+    const [error] = tryCatch(putout.parse, source);
+    
+    if (!error)
+        return;
+    
+    const {message} = error;
+    
+    push({
+        path,
+        message,
+    });
+};

package/lib/index.js

@@ -7,6 +7,7 @@ const applyRemove = require('./apply-remove');
 const applyInsertBefore = require('./apply-insert-before');
 const applyInsertAfter = require('./apply-insert-after');
 const applyDeclare = require('./apply-declare');
+const checkDeclare = require('./check-declare');
 const checkReplaceCode = require('./check-replace-code');
 const checkMatch = require('./check-match');
 const convertPutoutTestToCreateTest = require('./convert-putout-test-to-create-test');
@@ -71,6 +72,7 @@ module.exports.rules = {
     'apply-insert-before': applyInsertBefore,
     'apply-insert-after': applyInsertAfter,
     'apply-declare': applyDeclare,
+    'check-declare': checkDeclare,
     'check-replace-code': checkReplaceCode,
     'check-match': checkMatch,
     'convert-putout-test-to-create-test': convertPutoutTestToCreateTest,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-putout",
-  "version": "23.6.0",
+  "version": "23.8.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin helps with plugins development",