@putout/plugin-putout 23.5.0 → 23.7.0

package/README.md

@@ -29,6 +29,7 @@ npm i @putout/plugin-putout -D
 - ✅ [apply-insert-after](#apply-insert-after);
 - ✅ [apply-insert-before](#apply-insert-before);
 - ✅ [apply-vars](#apply-vars);
+- ✅ [apply-lowercase-to-node-builders](#apply-lowercase-to-node-builders);
 - ✅ [apply-namespace-specifier](#apply-namespace-specifier);
 - ✅ [apply-processors-destructuring](#apply-processors-destructuring);
 - ✅ [apply-remove](#apply-remove);
@@ -36,6 +37,7 @@ npm i @putout/plugin-putout -D
 - ✅ [apply-parens](#apply-parens);
 - ✅ [apply-short-processors](#apply-short-processors);
 - ✅ [check-match](#check-match);
+- ✅ [check-declare](#check-declare);
 - ✅ [check-replace-code](#check-replace-code);
 - ✅ [convert-add-argument-to-add-args](#convert-add-argument-to-add-test-args);
 - ✅ [convert-babel-types](#convert-babel-types);
@@ -99,10 +101,12 @@ npm i @putout/plugin-putout -D
         "putout/apply-insert-after": "on",
         "putout/apply-vars": "on",
         "putout/apply-short-processors": "on",
+        "putout/apply-lowercase-to-node-builders": "on",
         "putout/apply-namespace-specifier": "on",
         "putout/apply-for-of-to-track-file": "on",
         "putout/apply-fixture-name-to-message": "on",
         "putout/check-match": "on",
+        "putout/check-declare": "on",
         "putout/check-replace-code": ["on", {
             "once": true
         }],
@@ -144,6 +148,22 @@ npm i @putout/plugin-putout -D
 }
 ```
 
+## apply-lowercase-to-node-builders
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/fe78f6e48998fb39fa7e53e4046f1fc0/e1e6f2387895ff2ab98b4a9bcd2e8d565f7c3f16).
+
+### ❌ Example of incorrect code
+
+```js
+path.node = Identifier('x');
+```
+
+### ✅ Example of correct code
+
+```js
+path.node = identifier('x');
+```
+
 ## apply-processors-destructuring
 
 ### ❌ Example of incorrect code
@@ -845,6 +865,23 @@ module.exports.match = () => ({
 });
 ```
 
+## check-declare
+
+Checks that [Declarator](https://github.com/coderaiser/putout/tree/master/packages/engine-runner#declarator) transform is possible.
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/9fccb187bb8933afff0dc0db57b3cea8/25cb812978fadb4efb5f0cb44058a61f70f8b78e):
+
+### ❌ Example of incorrect code
+
+```js
+module.exports.declare = () => ({
+    isNumber: 'const isNumber = () => {}',
+    isString: 'const isNumber = () => {}',
+});
+```
+
+☝️ *There is no `fix` for this rule, it used internally to be more confident about `test coverage`, because of declaration form, transforms cannon be checked by `nyc` and `c8`, and uncovered lines can find unfixable false positives when running on code.
+This is additional tests, if you forget to test some case (from a big list of rules that is supported) it will be checked with this `rule` and make transforms more stable.*
+
 ## check-replace-code
 
 Checks that [Replacer](https://github.com/coderaiser/putout/tree/master/packages/engine-runner#replacer) transform is possible.

package/lib/add-await-to-progress/index.js

@@ -2,9 +2,9 @@
 
 const {types, operator} = require('putout');
 const {
-    Identifier,
-    ObjectPattern,
-    ObjectProperty,
+    objectProperty,
+    objectPattern,
+    identifier,
 } = types;
 
 const {remove, compare} = operator;
@@ -40,11 +40,11 @@ function addAwait(vars, path) {
     const [first] = params;
     
     if (first.name === 't') {
-        const id = Identifier('progress');
+        const id = identifier('progress');
         
         path.scope.block.params = [
-            ObjectPattern([
-                ObjectProperty(id, id, false, true),
+            objectPattern([
+                objectProperty(id, id, false, true),
             ]),
         ];
     }

package/lib/add-path-arg-to-visitors/index.js

@@ -1,14 +1,14 @@
 'use strict';
 
 const {types} = require('putout');
-const {Identifier} = types;
+const {identifier} = types;
 
 module.exports.report = () => `Add 'path' argument to 'traverse' visitors`;
 
 const TRAVERSE = '(__args) => __object';
 
 module.exports.fix = (path) => {
-    path.node.params.push(Identifier('path'));
+    path.node.params.push(identifier('path'));
 };
 
 module.exports.traverse = ({push}) => ({

package/lib/add-traverse-args/index.js

@@ -1,14 +1,14 @@
 'use strict';
 
 const {types, operator} = require('putout');
-const {traverse} = operator;
-
 const {
-    ObjectProperty,
-    ObjectPattern,
-    Identifier,
+    objectPattern,
+    objectProperty,
+    identifier,
 } = types;
 
+const {traverse} = operator;
+
 const defaultNames = [
     'push',
     'store',
@@ -21,11 +21,11 @@ module.exports.report = ({name}) => `Add '${name}' argument to 'traverse'`;
 module.exports.fix = ({name, fn}) => {
     const computed = false;
     const shorthand = true;
-    const id = Identifier(name);
-    const property = ObjectProperty(id, id, computed, shorthand);
+    const id = identifier(name);
+    const property = objectProperty(id, id, computed, shorthand);
     
     if (!fn.params.length) {
-        fn.params.push(ObjectPattern([property]));
+        fn.params.push(objectPattern([property]));
         return;
     }
     

package/lib/apply-async-formatter/index.js

@@ -1,16 +1,15 @@
 'use strict';
 
 const {operator, types} = require('putout');
+const {
+    objectProperty,
+    objectPattern,
+    identifier,
+} = types;
 
 const computed = true;
 const shorthand = true;
 
-const {
-    Identifier,
-    ObjectPattern,
-    ObjectProperty,
-} = types;
-
 const {compare} = operator;
 
 module.exports.report = () => 'Use Async API to test Formatter';
@@ -25,13 +24,13 @@ const create = (name) => (vars, path) => {
     const {block} = path.scope;
     const {body} = block.body;
     const n = body.length - 1;
-    const nameId = Identifier(name);
+    const nameId = identifier(name);
     
     block.async = true;
     
     block.params = [
-        ObjectPattern([
-            ObjectProperty(nameId, nameId, !computed, shorthand),
+        objectPattern([
+            objectProperty(nameId, nameId, !computed, shorthand),
         ]),
     ];
     

package/lib/apply-lowercase-to-node-builders/index.js

@@ -0,0 +1,36 @@
+'use strict';
+
+const {types} = require('putout');
+const {isIdentifier} = types;
+
+module.exports.report = () => `Use lowercased node builders`;
+
+module.exports.fix = (path) => {
+    const [first] = path.node.name;
+    const other = path.node.name.slice(1);
+    
+    path.node.name = first.toLowerCase() + other;
+};
+
+module.exports.traverse = ({push}) => ({
+    CallExpression(path) {
+        const calleePath = path.get('callee');
+        
+        if (!isIdentifier(calleePath))
+            return;
+        
+        const {name} = calleePath.node;
+        const [first, second] = name;
+        
+        if (!/[A-Z]/.test(first))
+            return;
+        
+        if (!/[a-z]/.test(second))
+            return;
+        
+        if (!types[name])
+            return;
+        
+        push(calleePath);
+    },
+});

package/lib/apply-short-processors/index.js

@@ -3,7 +3,7 @@
 const {types, operator} = require('putout');
 
 const {compute, rename} = operator;
-const {Identifier} = types;
+const {identifier} = types;
 
 const isString = (a) => typeof a === 'string';
 const chooseType = (a) => a === '__ignore' ? '__array' : '__object';
@@ -22,7 +22,7 @@ module.exports.report = ({value}) => {
 module.exports.fix = ({path, value}) => {
     const name = getShortName(value);
     
-    path.node.key = Identifier(name);
+    path.node.key = identifier(name);
     path.node.computed = true;
     rename(path.get('value'), '__a', chooseType(name));
 };

package/lib/check-declare/index.js

@@ -0,0 +1,62 @@
+'use strict';
+
+const tryCatch = require('try-catch');
+const putout = require('putout');
+
+const {types, operator} = putout;
+
+const noop = () => {};
+const {getTemplateValues} = operator;
+
+const DECLARE_ESM = 'export const declare = () => __object';
+const DECLARE_COMMONJS = 'module.exports.declare = () => __object';
+const COMMONJS = 'module.exports = __object';
+
+const {
+    isTemplateLiteral,
+    isStringLiteral,
+} = types;
+
+module.exports.report = ({message}) => message;
+
+module.exports.fix = noop;
+module.exports.traverse = ({push}) => ({
+    [DECLARE_ESM]: createCheck(push, DECLARE_ESM),
+    [DECLARE_COMMONJS]: createCheck(push, DECLARE_COMMONJS),
+    [COMMONJS]: createCheck(push, COMMONJS),
+});
+
+const createCheck = (push, template) => (path) => {
+    const {__object} = getTemplateValues(path, template);
+    
+    const lines = [];
+    
+    for (const {value} of __object.properties) {
+        let current = '';
+        
+        if (isStringLiteral(value)) {
+            current = value.value;
+        } else if (isTemplateLiteral(value)) {
+            if (value.quasis.length > 1)
+                continue;
+            
+            current = value.quasis[0].value.cooked;
+        }
+        
+        if (/^(const|import)/.test(current))
+            lines.push(current);
+    }
+    
+    const source = lines.join(';\n');
+    const [error] = tryCatch(putout.parse, source);
+    
+    if (!error)
+        return;
+    
+    const {message} = error;
+    
+    push({
+        path,
+        message,
+    });
+};

package/lib/check-replace-code/generate-code/plugin-generate.js

@@ -2,12 +2,12 @@
 
 const {operator, types} = require('putout');
 const {
-    ObjectPattern,
-    BlockStatement,
-    Identifier,
-    ArrayPattern,
-    ArrayExpression,
-    ObjectExpression,
+    objectPattern,
+    objectExpression,
+    blockStatement,
+    identifier,
+    arrayExpression,
+    arrayPattern,
 } = types;
 
 const {replaceWith} = operator;
@@ -48,16 +48,16 @@ module.exports.fix = (path, {options}) => {
     
     if (name === '__array') {
         if (path.parentPath.isCallExpression())
-            return replaceWith(path, ArrayPattern([]));
+            return replaceWith(path, arrayPattern([]));
         
         if (path.parentPath.isFunction())
-            return replaceWith(path, ArrayPattern([]));
+            return replaceWith(path, arrayPattern([]));
         
         if (path.parentPath.isAssignmentExpression())
-            return replaceWith(path, ArrayExpression([]));
+            return replaceWith(path, arrayExpression([]));
         
         if (path.parentPath.isVariableDeclarator())
-            return replaceWith(path, ArrayExpression([]));
+            return replaceWith(path, arrayExpression([]));
     }
     
     if (name === '__object')
@@ -65,14 +65,14 @@ module.exports.fix = (path, {options}) => {
     
     if (name === '__body') {
         if (path.parentPath.isClassProperty()) {
-            const key = Identifier(getVar());
+            const key = identifier(getVar());
             
             replaceWith(path, key);
             
             return;
         }
         
-        replaceWith(path, BlockStatement([]));
+        replaceWith(path, blockStatement([]));
     }
 };
 
@@ -82,14 +82,14 @@ function objectify(path) {
     const isVar = parentPath.isVariableDeclarator();
     
     if (path.parentPath.isExportDeclaration())
-        return replaceWith(path, ObjectExpression([]));
+        return replaceWith(path, objectExpression([]));
     
     if (path.parentPath.isCallExpression())
-        return replaceWith(path, ObjectExpression([]));
+        return replaceWith(path, objectExpression([]));
     
     if (isAssign && parentPath.get('right') === path)
-        return replaceWith(path, ObjectExpression([]));
+        return replaceWith(path, objectExpression([]));
     
     if (isVar && parentPath.get('id') === path)
-        return replaceWith(path, ObjectPattern([]));
+        return replaceWith(path, objectPattern([]));
 }

package/lib/convert-find-to-traverse/index.js

@@ -5,9 +5,9 @@ const {types, operator} = require('putout');
 const {replaceWith} = operator;
 
 const {
-    ReturnStatement,
     isCallExpression,
     isIdentifier,
+    returnStatement,
 } = types;
 
 const {entries} = Object;
@@ -29,7 +29,7 @@ module.exports.fix = fixType({
         path.node.params = [path.node.params[1]];
     },
     isCallExpression: (path) => {
-        replaceWith(path, ReturnStatement(path.node.arguments[1]));
+        replaceWith(path, returnStatement(path.node.arguments[1]));
     },
 });
 

package/lib/convert-get-rule-to-require/index.js

@@ -1,12 +1,19 @@
 'use strict';
 
-const camel = require('just-camel-case');
 const {
     types,
     operator,
     template,
 } = require('putout');
 
+const camel = require('just-camel-case');
+const {
+    stringLiteral,
+    arrayExpression,
+    objectProperty,
+    identifier,
+} = types;
+
 const {
     replaceWith,
     insertBefore,
@@ -14,13 +21,6 @@ const {
     getPathAfterRequires,
 } = operator;
 
-const {
-    ObjectProperty,
-    Identifier,
-    StringLiteral,
-    ArrayExpression,
-} = types;
-
 module.exports.report = () => `Use top-level 'require()' instead of '...getRule()'`;
 
 const REQUIRE = `const __a = require(__b)`;
@@ -36,8 +36,8 @@ module.exports.match = () => ({
 module.exports.replace = () => ({
     'getRule(__a)': ({__a}, path) => {
         const name = camel(__a.value);
-        const id = Identifier(name);
-        const node = ObjectProperty(__a, id);
+        const id = identifier(name);
+        const node = objectProperty(__a, id);
         
         replaceWith(path.parentPath, node);
         
@@ -51,8 +51,8 @@ module.exports.replace = () => ({
     },
     'getRule(__a, __b)': ({__a, __b}, path) => {
         const name = camel(__a.value);
-        const id = Identifier(name);
-        const node = ObjectProperty(__a, ArrayExpression([__b, id]));
+        const id = identifier(name);
+        const node = objectProperty(__a, arrayExpression([__b, id]));
         
         replaceWith(path.parentPath, node);
         
@@ -73,7 +73,7 @@ function addRequire({__a, id, path}) {
     
     const nodeRequire = createRequire({
         __a: id,
-        __b: StringLiteral(`./${__a.value}`),
+        __b: stringLiteral(`./${__a.value}`),
     });
     
     if (compare(first, REQUIRE)) {

package/lib/convert-method-to-property/index.js

@@ -3,7 +3,7 @@
 const {types, operator} = require('putout');
 
 const {replaceWith} = operator;
-const {ObjectProperty} = types;
+const {objectProperty} = types;
 
 module.exports.report = () => 'Object Property should be used instead of Method';
 
@@ -29,5 +29,5 @@ module.exports.fix = (path) => {
     path.node.type = 'ArrowFunctionExpression';
     path.node.id = null;
     
-    replaceWith(path, ObjectProperty(keyPath.node, path.node));
+    replaceWith(path, objectProperty(keyPath.node, path.node));
 };

package/lib/convert-replace-with/index.js

@@ -7,8 +7,8 @@ const {
 } = require('putout');
 
 const fullstore = require('fullstore');
+const {objectProperty, identifier} = types;
 
-const {Identifier, ObjectProperty} = types;
 const {
     replaceWith,
     insertAfter,
@@ -47,10 +47,10 @@ module.exports.fix = ({path, calleePath, property, object, program, isInserted})
         return;
     }
     
-    const id = Identifier('replaceWith');
+    const id = identifier('replaceWith');
     const varPath = getVarPath(bindings);
     
-    varPath.node.id.properties.unshift(ObjectProperty(id, id, false, true));
+    varPath.node.id.properties.unshift(objectProperty(id, id, false, true));
 };
 
 function getVarPath(bindings) {

package/lib/convert-replace-with-multiple/index.js

@@ -6,10 +6,9 @@ const {
     types,
 } = require('putout');
 
+const {objectProperty, identifier} = types;
 const {replaceWith, insertBefore} = operator;
 
-const {Identifier, ObjectProperty} = types;
-
 module.exports.report = () => {
     return `"operate.replaceWithMultiple" should be called instead of "path.replaceWithMultiple"`;
 };
@@ -31,10 +30,10 @@ module.exports.fix = ({path, calleePath, property, object, program}) => {
     if (!bindings.replaceWith && !bindings.insertAfter)
         return insertBefore(first, replaceWithAST);
     
-    const id = Identifier('replaceWithMultiple');
+    const id = identifier('replaceWithMultiple');
     const varPath = getVarPath(bindings);
     
-    varPath.node.id.properties.push(ObjectProperty(id, id, false, true));
+    varPath.node.id.properties.push(objectProperty(id, id, false, true));
 };
 
 function getVarPath(bindings) {

package/lib/convert-to-no-transform-code/index.js

@@ -1,6 +1,7 @@
 'use strict';
 
-const {isIdentifier, Identifier} = require('putout').types;
+const {types} = require('putout');
+const {isIdentifier, identifier} = types;
 
 module.exports.report = () => {
     return `"noTransformCode" should be called instead of using same arguments twice in "transformCode"`;
@@ -34,6 +35,6 @@ module.exports.traverse = ({push}) => ({
 });
 
 module.exports.fix = ({path, calleePath}) => {
-    calleePath.node.property = Identifier('noTransformCode');
+    calleePath.node.property = identifier('noTransformCode');
     path.node.arguments.pop();
 };

package/lib/convert-traverse-to-include/index.js

@@ -6,7 +6,7 @@ const {
     operator,
 } = require('putout');
 
-const {StringLiteral} = types;
+const {stringLiteral} = types;
 const {compare, remove} = operator;
 
 const isPush = (path) => path.get('value').isIdentifier({
@@ -43,7 +43,7 @@ module.exports.replace = () => ({
             const name = getName(propertyPath);
             
             if (isPush(propertyPath) || isBlock(propertyPath)) {
-                node.right.body.elements.push(StringLiteral(name));
+                node.right.body.elements.push(stringLiteral(name));
                 remove(propertyPath);
             }
         }

package/lib/convert-traverse-to-scan/index.js

@@ -11,11 +11,11 @@ const {
 } = operator;
 
 const {
-    Identifier,
     isReturnStatement,
     isObjectMethod,
     isObjectProperty,
     isObjectExpression,
+    identifier,
 } = types;
 
 module.exports.report = () => `Use Scanner instead of Traverser`;
@@ -23,7 +23,7 @@ module.exports.report = () => `Use Scanner instead of Traverser`;
 module.exports.fix = ({path, pathProperty}) => {
     if (path.isObjectMethod()) {
         replaceWith(path.parentPath, path.get('body'));
-        path.parentPath.parentPath.node.params.unshift(Identifier('path'));
+        path.parentPath.parentPath.node.params.unshift(identifier('path'));
         
         path.parentPath.parentPath.parentPath.node.left.property.name = 'scan';
         return;
@@ -31,7 +31,7 @@ module.exports.fix = ({path, pathProperty}) => {
     
     if (path.isObjectProperty()) {
         replaceWith(path.parentPath, path.get('value.body'));
-        path.parentPath.parentPath.node.params.unshift(Identifier('path'));
+        path.parentPath.parentPath.node.params.unshift(identifier('path'));
         
         const assignmentPath = path.parentPath.parentPath.parentPath;
         

package/lib/create-test/index.js

@@ -1,14 +1,13 @@
 'use strict';
 
 const {operator, types} = require('putout');
-
 const {
-    StringLiteral,
-    ArrayExpression,
-    Identifier,
-    ObjectProperty,
-    ObjectExpression,
+    arrayExpression,
+    objectExpression,
+    stringLiteral,
+    identifier,
     isIdentifier,
+    objectProperty,
 } = types;
 
 const {replaceWith, getProperty} = operator;
@@ -30,7 +29,7 @@ module.exports.fix = (path, {options}) => {
         if (getProperty(objectPath, name))
             continue;
         
-        const property = ObjectProperty(Identifier(name), StringLiteral(value));
+        const property = objectProperty(identifier(name), stringLiteral(value));
         objectPath.node.properties.unshift(property);
     }
 };
@@ -51,7 +50,7 @@ module.exports.filter = (path, {options}) => {
 
 const maybeLiteral = (a) => {
     if (isIdentifier(a))
-        return StringLiteral(a.name);
+        return stringLiteral(a.name);
     
     return a;
 };
@@ -59,9 +58,9 @@ const maybeLiteral = (a) => {
 function convert(objectPath) {
     const {key, value} = objectPath.node.properties[0];
     
-    replaceWith(objectPath, ObjectExpression([
-        ObjectProperty(Identifier('plugins'), ArrayExpression([
-            ArrayExpression([
+    replaceWith(objectPath, objectExpression([
+        objectProperty(identifier('plugins'), arrayExpression([
+            arrayExpression([
                 maybeLiteral(key),
                 value,
             ]),