@putout/plugin-putout 12.6.0 → 12.8.0

package/README.md

@@ -23,6 +23,8 @@ npm i @putout/plugin-putout -D
         "putout/apply-declare": "on",
         "putout/add-args": "on",
         "putout/add-push": "on",
+        "putout/check-match": "on",
+        "putout/check-replace-code": "on",
         "putout/convert-putout-test-to-create-test": "on",
         "putout/convert-to-no-transform-code": "on",
         "putout/convert-number-to-numeric": "on",
@@ -43,7 +45,6 @@ npm i @putout/plugin-putout -D
         "putout/convert-report-to-function": "on",
         "putout/create-test": "on",
         "putout/shorten-imports": "on",
-        "putout/check-replace-code": "on",
         "putout/declare": "on",
         "putout/includer": "on",
         "putout/move-require-on-top-level": "on",
@@ -502,8 +503,28 @@ module.exports.replace = () => ({
 });
 ```
 
-There is no `fix` for this rule, it used internally to be more confident about `test coverage`, because of declaration form, transforms cannon be checked by `nyc` and `c8`, and uncovered lines can find unfixable false positives when running on code.
-This is additional tests, if you forget to test some case (from a big list of rules that is supported) it will be checked with this `rule` and make transforms more stable.
+☝️ *There is no `fix` for this rule, it used internally to be more confident about `test coverage`, because of declaration form, transforms cannon be checked by `nyc` and `c8`, and uncovered lines can find unfixable false positives when running on code.
+This is additional tests, if you forget to test some case (from a big list of rules that is supported) it will be checked with this `rule` and make transforms more stable.*
+
+## check-match
+
+Checks that [Replacer](https://github.com/coderaiser/putout/tree/master/packages/engine-runner#replacer) `match()` keys exists in `replace`.
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/c245bee6b129614b2f68c2e89fc3b101/d9f935ccd7f41ff166111cd62277f3244b1d526e).
+
+### ❌ Example of incorrect code
+
+```js
+module.exports.match = () => ({
+    '__a = __b': (vars, path) => {},
+});
+
+module.exports.replace = () => ({
+    '__a = __': '__a',
+});
+```
+
+☝️ *There is no `fix` for this rule, it used internally to be more confident about `test coverage`, because of declaration form, transforms cannon be checked by `nyc` and `c8`, and uncovered lines can find unfixable false positives when running on code.
+This is additional tests, if you forget to test some case (from a big list of rules that is supported) it will be checked with this `rule` and make transforms more stable.*
 
 ## declare
 

package/lib/check-match/index.js

@@ -0,0 +1,58 @@
+'use strict';
+
+const {
+    operator,
+    types,
+} = require('putout');
+
+const {
+    getTemplateValues,
+    traverse,
+} = operator;
+
+const {isStringLiteral} = types;
+
+const PATTERN_MATCH = 'module.exports.match = () => __object';
+const PATTERN_REPLACE = 'module.exports.replace = () => __object';
+
+module.exports.report = () => `☝️ Looks like 'match()' template absent in 'replace()'`;
+
+module.exports.replace = () => ({
+    [PATTERN_MATCH]: PATTERN_MATCH,
+});
+
+module.exports.match = () => ({
+    [PATTERN_MATCH]: ({__object}, path) => {
+        const namesMatch = [];
+        
+        for (const prop of __object.properties) {
+            if (!isStringLiteral(prop.key))
+                continue;
+            
+            namesMatch.push(prop.key.value);
+        }
+        
+        const namesReplace = [];
+        
+        traverse(path.parentPath.parentPath, {
+            [PATTERN_REPLACE]: (path) => {
+                const {__object} = getTemplateValues(path, PATTERN_REPLACE);
+                
+                for (const prop of __object.properties) {
+                    if (!isStringLiteral(prop.key))
+                        continue;
+                    
+                    namesReplace.push(prop.key.value);
+                }
+            },
+        });
+        
+        for (const name of namesMatch) {
+            if (!namesReplace.includes(name)) {
+                return true;
+            }
+        }
+        
+        return false;
+    },
+});

package/lib/check-replace-code/generate-code.js

@@ -54,6 +54,11 @@ module.exports = (rootPath, key) => {
                         return;
                     }
                     
+                    if (/__args/.test(name)) {
+                        path.node.name = getVar(name);
+                        return;
+                    }
+                    
                     if (name === '__array') {
                         if (path.parentPath.isVariableDeclarator())
                             return replaceWith(path, ArrayPattern([]));

package/lib/check-replace-code/index.js

@@ -119,10 +119,7 @@ function parseKey(propertyPath) {
             Error(`Replace key cannot be computed: '${keyPath.toString()}'`),
         ];
     
-    return [
-        null,
-        key,
-    ];
+    return [null, key];
 }
 
 function hasMatch(path) {

package/lib/convert-number-to-numeric/index.js

@@ -23,4 +23,3 @@ module.exports.include = () => [
     'isNumberLiteral(__a)',
     'NumberLiteral(__a)',
 ];
-

package/lib/index.js

@@ -10,6 +10,8 @@ module.exports.rules = {
     ...getRule('apply-create-test'),
     ...getRule('apply-remove'),
     ...getRule('apply-declare'),
+    ...getRule('check-replace-code'),
+    ...getRule('check-match'),
     ...getRule('convert-putout-test-to-create-test'),
     ...getRule('convert-to-no-transform-code'),
     ...getRule('convert-find-to-traverse'),
@@ -33,7 +35,6 @@ module.exports.rules = {
     ...getRule('rename-operate-to-operator'),
     ...getRule('replace-operate-with-operator'),
     ...getRule('shorten-imports'),
-    ...getRule('check-replace-code'),
     ...getRule('declare'),
     ...getRule('add-args'),
     ...getRule('add-push'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-putout",
-  "version": "12.6.0",
+  "version": "12.8.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin helps with plugins development",