@putout/plugin-printer 8.6.8 → 8.7.1

package/README.md

@@ -22,6 +22,7 @@ npm i @putout/plugin-printer -D
 - ✅ [apply-linebreak](#apply-linebreak);
 - ✅ [apply-types](#apply-types);
 - ✅ [check-type-passed-to-type-checker](#check-type-passed-to-type-checker);
+- ✅ [check-if-success-possible-in-type-checker](#check-if-success-possible-in-type-checker);
 - ✅ [declare](#declare);
 - ✅ [remove-args](#remove-args);
 - ✅ [remove-useless-maybe](#remove-useless-maybe);
@@ -43,6 +44,7 @@ npm i @putout/plugin-printer -D
         "printer/apply-create-test-url": "on",
         "printer/apply-types": "on",
         "printer/check-type-passed-to-type-checker": "on",
+        "printer/check-if-success-possible-in-type-checker": "on",
         "printer/declare": "on",
         "printer/remove-args": "on",
         "printer/remove-useless-maybe": "on",
@@ -283,10 +285,59 @@ export const beforeIf = createTypeChecker([
 ]);
 ```
 
+## check-if-success-possible-in-type-checker
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/4164addec1e1b2bb93ad7caf3ed13ad8/b04dc172f4094ea6b6902ec54deee779aba6b944).
+When you have only negative branch defined in type checker it never never succeeds (`+`), and always returns false.
+
+Consider adding success branch, or remove type checker.
+
+☝️ *This rule has no autofix, because most likely tests will fail after auto fix,
+and instead of observing code with a problem, you will first see failed tests,
+and then after some searches determine that there is a wrong auto fix.*
+
+### ❌ Example of incorrect code
+
+```js
+const isSimple = createTypeChecker([
+    '-: -> SpreadElement',
+    '-: -> Identifier',
+    '-: -> !CallExpression',
+]);
+
+const isSimpleAfterObject = createTypeChecker([
+    ['-', isSimple],
+    ['-', callWithNext(isObjectExpression)],
+    ['-', callWithPrev(isObjectExpression)],
+]);
+```
+
+### ✅ Example of correct code
+
+Possible fix:
+
+```js
+const isSimple = createTypeChecker([
+    '-: -> SpreadElement',
+    '-: -> Identifier',
+    '+: -> !CallExpression',
+]);
+
+const isSimpleAfterObject = createTypeChecker([
+    ['-', isSimple],
+    ['-', callWithNext(isObjectExpression)],
+    ['+', callWithPrev(isObjectExpression)],
+]);
+```
+
 ## check-type-passed-to-type-checker
 
 Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/9b35f5f2f23bece832f0f87c929d30e2/b08df8ef8ce6c2a03bceebe6119846c45a78a119).
 
+☝️ *This rule has no autofix, because most likely tests will fail after auto fix,
+and instead of observing code with a problem, you will first see failed tests,
+and then after some searches determine that there is a wrong auto fix.*
+
 ### ❌ Example of incorrect code
 
 ```js
@@ -297,9 +348,11 @@ export const beforeIf = createTypeChecker([
 
 ### ✅ Example of correct code
 
+Here is possible correct code:
+
 ```js
 export const beforeIf = createTypeChecker([
-    ['- : -> 🧨 WrongType'],
+    ['- : -> Identifier'],
 ]);
 ```
 

package/lib/add-missing-tuples-to-type-checker/index.js

@@ -1,4 +1,3 @@
-import process from 'node:process';
 import {operator, types} from 'putout';
 import {createTypeChecker} from '@putout/printer/type-checker';
 
@@ -15,7 +14,7 @@ const {replaceWith} = operator;
 
 const hasResult = (value) => /^[+-]/.test(value);
 const typeOptions = {
-    instrument: Boolean(process.env.PUTOUT_INSTRUMENT),
+    instrumentName: 'PUTOUT_INSTRUMENT',
 };
 
 const isDsl = createTypeChecker([

package/lib/check-if-success-possible-in-type-checker/index.js

@@ -0,0 +1,51 @@
+import {types} from 'putout';
+
+const {
+    isArrayExpression,
+    isStringLiteral,
+    isIdentifier,
+    isCallExpression,
+} = types;
+
+export const report = () => `Success path ('+') is absent in Type Checker, all branches routes to fail ('-')`;
+
+export const fix = () => {};
+
+export const traverse = ({push}) => ({
+    ArrayExpression(path) {
+        const {parentPath} = path;
+        
+        if (!isCallExpression(parentPath))
+            return;
+        
+        const {callee} = parentPath.node;
+        
+        if (!isIdentifier(callee, {name: 'createTypeChecker'}))
+            return;
+        
+        const {elements} = path.node;
+        const results = elements.map(getResult);
+        const successes = results.filter(Boolean);
+        
+        if (!successes.length)
+            push(path);
+    },
+});
+
+const getResult = (a) => {
+    if (isStringLiteral(a)) {
+        const {value} = a;
+        
+        if (value.startsWith('-'))
+            return false;
+    }
+    
+    if (isArrayExpression(a)) {
+        const {value} = a.elements[0];
+        
+        if (value.startsWith('-'))
+            return false;
+    }
+    
+    return true;
+};

package/lib/index.js

@@ -1,3 +1,4 @@
+import * as checkIfSuccessPossibleInTypeChecker from './check-if-success-possible-in-type-checker/index.js';
 import * as removeUselessTuplesFromTypeChecker from './remove-useless-tuples-from-type-checker/index.js';
 import * as addMissingTuplesToTypeChecker from './add-missing-tuples-to-type-checker/index.js';
 import * as checkTypePassedToTypeChecker from './check-type-passed-to-type-checker/index.js';
@@ -32,4 +33,5 @@ export const rules = {
     'check-type-passed-to-type-checker': checkTypePassedToTypeChecker,
     'add-missing-tuples-to-type-checker': addMissingTuplesToTypeChecker,
     'remove-useless-tuples-from-type-checker': removeUselessTuplesFromTypeChecker,
+    'check-if-success-possible-in-type-checker': checkIfSuccessPossibleInTypeChecker,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-printer",
-  "version": "8.6.8",
+  "version": "8.7.1",
   "type": "module",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds support of transformations for @putout/printer",
@@ -45,7 +45,8 @@
     "madrun": "^13.0.0",
     "montag": "^1.2.1",
     "nodemon": "^3.0.1",
-    "superc8": "^12.0.0"
+    "superc8": "^12.0.0",
+    "supertape": "^12.7.0"
   },
   "peerDependencies": {
     "putout": ">=42",