@putout/plugin-nodejs 4.7.0 → 4.8.1

package/README.md

@@ -20,6 +20,7 @@ npm i putout @putout/plugin-nodejs -D
 ```json
 {
     "rules": {
+        "nodejs/convert-buffer-to-buffer-alloc": "on",
         "nodejs/convert-fs-promises": "on",
         "nodejs/convert-promisify-to-fs-promises": "on",
         "nodejs/convert-dirname-to-url": "on",
@@ -33,6 +34,42 @@ npm i putout @putout/plugin-nodejs -D
 
 ## Rules
 
+### convert-buffer-to-buffer-alloc
+
+> The `Buffer()` function and `new Buffer()` constructor are **deprecated** due to API usability issues that can lead to accidental security issues.
+>
+> (c) [DEP0005](https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor)
+
+Check out in 🐊[Putout Editor](https://putout.cloudcmd.io/#/gist/5379bcdfa3d76f7b7121c9671ae48375/2fc2c7f96fc8284788c00914a9b29bfeea8b13d4).
+
+#### ❌ Example of incorrect code
+
+```js
+const n = 100;
+const buf = [];
+
+new Buffer(123);
+new Buffer(n);
+new Buffer('hello');
+
+new Buffer([]);
+new Buffer(buf);
+```
+
+#### ✅ Example of correct code
+
+```js
+const n = 100;
+const buf = [];
+
+Buffer.alloc(123);
+Buffer.alloc(n);
+Buffer.from('hello');
+
+Buffer.from([]);
+Buffer.from(buf);
+```
+
 ### convert-fs-promises
 
 Convert [fs.promises](https://nodejs.org/dist/latest-v15.x/docs/api/fs.html#fs_fs_promises_api) into form that will be simpler to use and convert to and from **ESM**.
@@ -71,7 +108,8 @@ Only for **ESM**.
 #### ❌ Example of incorrect code
 
 ```js
-import {readFile} from 'fs/promises';
+const {join} = require('path');
+const path = require('path');
 
 const file1 = join(__dirname, '../../package.json');
 const file2 = path.join(__dirname, '../../package.json');
@@ -80,8 +118,6 @@ const file2 = path.join(__dirname, '../../package.json');
 #### ✅ Example of correct code
 
 ```js
-import {readFile} from 'fs/promises';
-
 const file1 = new URL('../../package.json', import.meta.url);
 const file2 = new URL('../../package.json', import.meta.url);
 ```
@@ -101,6 +137,7 @@ const file = new URL('../../package.json', import.meta.url);
 
 ```js
 const {readFile} = require('fs/promises');
+const {join} = require('path');
 const file = join(__dirname, '../../package.json');
 ```
 

package/lib/convert-buffer-to-buffer-alloc/index.js

@@ -0,0 +1,33 @@
+'use strict';
+
+const {operator} = require('putout');
+
+const isNumber = (a) => typeof a === 'number';
+
+const {compute} = operator;
+
+module.exports.report = () => `Use 'Buffer.alloc()' or 'Buffer.from()' instead of 'Buffer()' and 'new Buffer()'`;
+
+module.exports.match = () => ({
+    'new Buffer(__a)': (vars, path) => {
+        const __aPath = path.get('arguments.0');
+        const [is] = compute(__aPath);
+        
+        return is;
+    },
+});
+
+module.exports.replace = () => ({
+    'new Buffer(__a)': transform,
+    'Buffer(__a)': transform,
+});
+
+function transform(vars, path) {
+    const [, value] = compute(path.get('arguments.0'));
+    
+    if (isNumber(value))
+        return 'Buffer.alloc(__a)';
+    
+    return 'Buffer.from(__a)';
+}
+

package/lib/declare-after-require/index.js

@@ -55,7 +55,10 @@ module.exports.traverse = ({push, listStore}) => ({
                 if (path.node.__putoutNodeDeclareAfterRequire)
                     continue;
                 
-                if (path.isVariableDeclaration() && path.node.declarations[0].id.name === 'require')
+                if (!path.isVariableDeclaration())
+                    continue;
+                
+                if (path.node.declarations[0].id.name === 'require')
                     continue;
                 
                 if (compareAny(path, REQUIRE_LIST)) {

package/lib/index.js

@@ -5,6 +5,7 @@ const getRule = (a) => ({
 });
 
 module.exports.rules = {
+    ...getRule('convert-buffer-to-buffer-alloc'),
     ...getRule('convert-fs-promises'),
     ...getRule('convert-promisify-to-fs-promises'),
     ...getRule('convert-dirname-to-url'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-nodejs",
-  "version": "4.7.0",
+  "version": "4.8.1",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds ability to transform code to new API of Node.js",
@@ -31,14 +31,14 @@
     "nodejs"
   ],
   "devDependencies": {
-    "@putout/plugin-convert-commonjs-to-esm": "^9.0.0",
+    "@putout/plugin-convert-commonjs-to-esm": "*",
     "@putout/plugin-convert-esm-to-commonjs": "*",
     "@putout/plugin-putout": "*",
     "@putout/test": "^5.0.0",
     "c8": "^7.5.0",
     "eslint": "^8.0.1",
-    "eslint-plugin-node": "^11.0.0",
-    "eslint-plugin-putout": "^15.0.0",
+    "eslint-plugin-n": "^15.2.4",
+    "eslint-plugin-putout": "^16.0.0",
     "lerna": "^5.0.0",
     "madrun": "^9.0.0",
     "montag": "^1.2.1",