@putout/plugin-nodejs 2.0.0 → 3.1.0

package/README.md

@@ -11,19 +11,23 @@
 npm i putout @putout/plugin-nodejs -D
 ```
 
-## Rules
+## Options
 
 ```json
 {
     "rules": {
         "nodejs/convert-fs-promises": "on",
         "nodejs/convert-promisify-to-fs-promises": "on",
-        "nodejs/convert-dirname-to-promises": "on"
+        "nodejs/convert-dirname-to-url": "on",
+        "nodejs/convert-top-level-return": "on",
+        "nodejs/remove-process-exit": "on"
     }
 }
 ```
 
-# convert-fs-promises
+## Rules
+
+### convert-fs-promises
 
 Convert [fs.promises](https://nodejs.org/dist/latest-v15.x/docs/api/fs.html#fs_fs_promises_api) into form that will be simpler to use and convert from in `ESM` to:
 
@@ -31,38 +35,38 @@ Convert [fs.promises](https://nodejs.org/dist/latest-v15.x/docs/api/fs.html#fs_f
 import {readFile} from 'fs/promises';
 ```
 
-## ❌ Incorrect code example
+#### ❌ Incorrect code example
 
 ```js
 const {readFile} = require('fs').promises;
 ```
 
-## ✅ Correct code Example
+#### ✅ Correct code Example
 
 ```js
 const {readFile} = require('fs/promises');
 ```
 
-# convert-promisify-to-fs-promises
+### convert-promisify-to-fs-promises
 
-## ❌ Incorrect code example
+#### ❌ Incorrect code example
 
 ```js
 const fs = require('fs');
 const readFile = promisify(fs.readFile);
 ```
 
-## ✅ Correct code Example
+#### ✅ Correct code Example
 
 ```js
 const {readFile} = require('fs/promises');
 ```
 
-# convert-dirname-to-promises
+### convert-dirname-to-url
 
 Only for `EcmaScript Modules`.
 
-## ❌ Incorrect code example
+#### ❌ Incorrect code example
 
 ```js
 import {readFile} from 'fs/promises';
@@ -71,7 +75,7 @@ const file1 = join(__dirname, '../../package.json');
 const file2 = path.join(__dirname, '../../package.json');
 ```
 
-## ✅ Correct code Example
+#### ✅ Correct code Example
 
 ```js
 import {readFile} from 'fs/promises';
@@ -80,6 +84,28 @@ const file1 = new URL('../../package.json', import.meta.url);
 const file2 = new URL('../../package.json', import.meta.url);
 ```
 
+### remove-process-exit
+
+In most cases `process.exit()` is called from `bin` directory, if not - disable this rule using `match`.
+
+```diff
+-process.exit();
+```
+
+### convert-top-level-return
+
+#### ❌ Incorrect code example
+
+```js
+return;
+```
+
+#### ✅ Correct code Example
+
+```js
+process.exit();
+```
+
 ## License
 
 MIT

package/lib/convert-dirname-to-url/index.js

@@ -8,6 +8,6 @@ module.exports.report = () => `Use 'import.meta.url' instead of '__dirname'`;
 module.exports.filter = isESM;
 
 module.exports.replace = () => ({
-    'join(__dirname, __a)': 'new URL(__a, import.meta.url)',
-    'path.join(__dirname, __a)': 'new URL(__a, import.meta.url)',
+    'join(__dirname, __a)': 'new URL(__a, import.meta.url).pathname',
+    'path.join(__dirname, __a)': 'new URL(__a, import.meta.url).pathname',
 });

package/lib/convert-top-level-return/index.js

@@ -0,0 +1,15 @@
+'use strict';
+
+const {types} = require('putout');
+const {isFunction} = types;
+
+module.exports.report = () => `"process.exit" should be used instead of top-level return`;
+
+module.exports.filter = (path) => !path.findParent(isFunction);
+
+module.exports.replace = () => ({
+    'return __a()': '{__a(); process.exit()}',
+    'return __a': 'process.exit()',
+    'return': 'process.exit()',
+});
+

package/lib/index.js

@@ -7,5 +7,8 @@ const getRule = (a) => ({
 module.exports.rules = {
     ...getRule('convert-fs-promises'),
     ...getRule('convert-promisify-to-fs-promises'),
+    ...getRule('convert-dirname-to-url'),
+    ...getRule('convert-top-level-return'),
+    ...getRule('remove-process-exit'),
 };
 

package/lib/remove-process-exit/index.js

@@ -0,0 +1,9 @@
+'use strict';
+
+module.exports.report = () => '"process.exit" should not be used';
+
+module.exports.replace = () => ({
+    'process.exit()': '',
+    'process["exit"]()': '',
+});
+

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-nodejs",
-  "version": "2.0.0",
+  "version": "3.1.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "putout plugin adds ability to transform code to new API of Node.js",
@@ -35,13 +35,13 @@
     "c8": "^7.5.0",
     "eslint": "^8.0.1",
     "eslint-plugin-node": "^11.0.0",
-    "eslint-plugin-putout": "^12.0.0",
+    "eslint-plugin-putout": "^13.0.0",
     "lerna": "^4.0.0",
     "madrun": "^8.0.1",
     "nodemon": "^2.0.1"
   },
   "peerDependencies": {
-    "putout": ">=23"
+    "putout": ">=24"
   },
   "license": "MIT",
   "engines": {