@putout/plugin-nodejs 11.10.0 → 12.0.0

package/README.md

@@ -17,28 +17,30 @@ npm i putout @putout/plugin-nodejs -D
 
 ## Rules
 
-- ✅ [add-node-prefix][#add-node-prefix];
-- ✅ [convert-buffer-to-buffer-alloc][#convert-buffer-to-buffer-alloc];
-- ✅ [convert-commonjs-to-esm-commons][#convert-commonjs-to-esm-commons];
-- ✅ [convert-commonjs-to-esm-exports][#convert-commonjs-to-esm-exports];
-- ✅ [convert-commonjs-to-esm-require][#convert-commonjs-to-esm-require];
-- ✅ [convert-commonjs-to-esm.js][#convert-commonjs-to-esm.js];
-- ✅ [convert-dirname-to-url][#convert-dirname-to-url];
-- ✅ [convert-esm-to-commonjs][#convert-esm-to-commonjs];
-- ✅ [convert-exports-to-module-exports][#convert-exports-to-module-exports];
-- ✅ [convert-fs-promises][#convert-fs-promises];
-- ✅ [convert-promisify-to-fs-promises][#convert-promisify-to-fs-promises];
-- ✅ [convert-top-level-return][#convert-top-level-return];
-- ✅ [convert-url-to-dirname][#convert-url-to-dirname];
-- ✅ [declare][#declare];
-- ✅ [declare-after-require][#declare-after-require];
-- ✅ [remove-process-exit][#remove-process-exit];
-- ✅ [remove-useless-promisify][#remove-useless-promisify];
-- ✅ [rename-file-cjs-to-js][#rename-file-cjs-to-js];
-- ✅ [rename-file-mjs-to-js][#rename-file-mjs-to-js];
-- ✅ [strict-mode][#strict-mode];
-- ✅ [cjs-file][#cjs-file];
-- ✅ [mjs-file][#mjs-file];
+- ✅ [add-node-prefix](#add-node-prefix);
+- ✅ [add-missing-strict-mode](#add-missing-strict-mode);
+- ✅ [convert-buffer-to-buffer-alloc](#convert-buffer-to-buffer-alloc);
+- ✅ [convert-commonjs-to-esm-commons](#convert-commonjs-to-esm-commons);
+- ✅ [convert-commonjs-to-esm-exports](#convert-commonjs-to-esm-exports);
+- ✅ [convert-commonjs-to-esm-require](#convert-commonjs-to-esm-require);
+- ✅ [convert-commonjs-to-esm.js](#convert-commonjs-to-esm.js);
+- ✅ [convert-dirname-to-url](#convert-dirname-to-url);
+- ✅ [convert-esm-to-commonjs](#convert-esm-to-commonjs);
+- ✅ [convert-exports-to-module-exports](#convert-exports-to-module-exports);
+- ✅ [convert-fs-promises](#convert-fs-promises);
+- ✅ [convert-promisify-to-fs-promises](#convert-promisify-to-fs-promises);
+- ✅ [convert-top-level-return](#convert-top-level-return);
+- ✅ [convert-url-to-dirname](#convert-url-to-dirname);
+- ✅ [declare](#declare);
+- ✅ [declare-after-require](#declare-after-require);
+- ✅ [remove-process-exit](#remove-process-exit);
+- ✅ [remove-useless-promisify](#remove-useless-promisify);
+- ✅ [rename-file-cjs-to-js](#rename-file-cjs-to-js);
+- ✅ [rename-file-mjs-to-js](#rename-file-mjs-to-js);
+- ✅ [remove-useless-strict-mode](#remove-useless-strict-mode);
+- ✅ [remove-illigal-strict-mode](#remove-useless-strict-mode);
+- ✅ [cjs-file](#cjs-file);
+- ✅ [mjs-file](#mjs-file);
 
 ## Config
 
@@ -485,6 +487,53 @@ import a from 'b';
 import a from 'b';
 ```
 
+## remove-illigal-strict-mode
+
+> `SyntaxError: "use strict" not allowed in function with non-simple parameters`
+> The JavaScript exception `"use strict" not allowed in function` occurs when a `use strict` directive is used at the top of a function with default parameters, rest parameters, or destructuring parameters.
+>
+> (c) [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Strict_non_simple_params)
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/a2ff9020bd33d11f3927d4d68c830c50/e6732329a0cca03c09ec0d36b43bfaec17966eff).
+
+### ❌ Example of incorrect code
+
+```ts
+function x1(...a) {
+    'use strict';
+}
+
+function x2(a, b = 3) {
+    'use strict';
+}
+
+function x3({a}) {
+    'use strict';
+}
+
+function x4([a]) {
+    'use strict';
+}
+
+function x5(...a) {
+    'use strict';
+}
+```
+
+### ✅ Example of correct code
+
+```js
+function x1(...a) {}
+
+function x2(a, b = 3) {}
+
+function x3({a}) {}
+
+function x4([a]) {}
+
+function x5(...a) {}
+```
+
 ## remove-useless-promisify
 
 > Takes a function following the common error-first callback style, i.e. taking an (err, value) => ... callback as the last argument, and returns a version that returns promises.

package/lib/convert-commonjs-to-esm-require/index.js

@@ -87,7 +87,11 @@ module.exports.replace = () => ({
             return applyDynamicImport(path);
         }
         
-        // disabled while not supported        // https://babeljs.io/blog/2023/05/26/7.22.0#import-attributes-15536-15620        //        // const isJSON = /\.json$/.test(value);        // const assertion = !isJSON ? '' : 'with { type: "json" }';
+        // disabled while not supported
+        // https://babeljs.io/blog/2023/05/26/7.22.0#import-attributes-15536-15620
+        //
+        // const isJSON = /\.json$/.test(value);
+        // const assertion = !isJSON ? '' : 'with { type: "json" }';
         const assertion = '';
         
         if (isObjectPattern(__a)) {

package/lib/convert-esm-to-commonjs/index.js

@@ -1,15 +1,22 @@
 'use strict';
 
-const {types, template} = require('putout');
+const {types} = require('putout');
 const {isImportDefaultSpecifier} = types;
 
+const BODY = '{__body}';
+const FN = `function __a(__args) ${BODY}`;
+const GEN_FN = `function* __a(__args) ${BODY}`;
+const ASYNC_FN = `async function __a(__args) ${BODY}`;
+const CLASS = `class __a ${BODY}`;
+
 module.exports.report = () => `Use 'CommonJS' instead of 'ESM'`;
 
 module.exports.replace = () => ({
     'export default __a': 'module.exports = __a',
-    'export class __a {__body}': 'module.exports.__a = class __a {__body}',
-    'export function __a(__args) {}': replaceFn,
-    'export async function __a(__args) {}': replaceFn,
+    [`export ${CLASS}`]: `module.exports.__a = ${CLASS}`,
+    [`export ${FN}`]: `module.epxorts.__a = ${FN}`,
+    [`export ${ASYNC_FN}`]: `module.epxorts.__a = ${ASYNC_FN}`,
+    [`export ${GEN_FN}`]: `module.epxorts.__a = ${GEN_FN}`,
     'export const __a = __b': 'module.exports.__a = __b',
     'export {__exports}': ({__exports}) => {
         let result = 'module.exports = {\n';
@@ -56,13 +63,3 @@ module.exports.replace = () => ({
         }`;
     },
 });
-
-function replaceFn({__a}, path) {
-    const {name} = __a;
-    const {declaration} = path.node;
-    const node = template.ast.fresh(`module.exports.${name} = __x`);
-    
-    node.right = declaration;
-    
-    return node;
-}

package/lib/index.js

@@ -53,5 +53,6 @@ module.exports.rules = {
     
     'add-missing-strict-mode': strictMode.rules['add-missing'],
     'remove-useless-strict-mode': strictMode.rules['remove-useless'],
+    'remove-illigal-strict-mode': strictMode.rules['remove-illigal'],
     'remove-useless-promisify': removeUselessPromisify,
 };

package/lib/strict-mode/index.js

@@ -2,8 +2,10 @@
 
 const addMissing = require('./add-missing');
 const removeUseless = require('./remove-useless');
+const removeIlligal = require('./remove-illigal');
 
 module.exports.rules = {
     'add-missing': addMissing,
     'remove-useless': removeUseless,
+    'remove-illigal': removeIlligal,
 };

package/lib/strict-mode/remove-illigal/index.js

@@ -0,0 +1,49 @@
+'use strict';
+
+const {operator, types} = require('putout');
+const {
+    isArrayPattern,
+    isObjectPattern,
+    isAssignmentPattern,
+    isRestElement,
+    isFunction,
+} = types;
+
+const {remove} = operator;
+
+module.exports.report = () => `Avoid illigal 'use strict'`;
+
+module.exports.fix = (path) => {
+    remove(path);
+};
+module.exports.traverse = ({push}) => ({
+    DirectiveLiteral(path) {
+        const fnPath = path.parentPath.parentPath.parentPath;
+        
+        if (!isFunction(fnPath))
+            return;
+        
+        if (isIlligal(fnPath))
+            push(path.parentPath);
+    },
+});
+
+function isIlligal(fnPath) {
+    const params = fnPath.get('params');
+    
+    for (const param of params) {
+        if (isRestElement(param))
+            return true;
+        
+        if (isAssignmentPattern(param))
+            return true;
+        
+        if (isObjectPattern(param))
+            return true;
+        
+        if (isArrayPattern(param))
+            return true;
+    }
+    
+    return false;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-nodejs",
-  "version": "11.10.0",
+  "version": "12.0.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds ability to transform code to new API of Node.js",
@@ -17,7 +17,7 @@
   "changelog": false,
   "repository": {
     "type": "git",
-    "url": "git://github.com/coderaiser/putout.git"
+    "url": "git+https://github.com/coderaiser/putout.git"
   },
   "scripts": {
     "test": "madrun test",
@@ -43,18 +43,18 @@
     "@putout/plugin-declare": "*",
     "@putout/plugin-putout": "*",
     "@putout/plugin-typescript": "*",
-    "@putout/test": "^9.0.0",
-    "c8": "^9.0.0",
+    "@putout/test": "^11.0.0",
+    "c8": "^10.0.0",
     "eslint": "^9.0.0",
     "eslint-plugin-n": "^17.0.0",
-    "eslint-plugin-putout": "^22.0.0",
+    "eslint-plugin-putout": "^23.0.0",
     "lerna": "^6.0.1",
     "madrun": "^10.0.0",
     "montag": "^1.2.1",
     "nodemon": "^3.0.1"
   },
   "peerDependencies": {
-    "putout": ">=35"
+    "putout": ">=36"
   },
   "license": "MIT",
   "engines": {