@putout/plugin-nodejs 10.3.0 → 11.1.0

package/README.md

@@ -36,7 +36,9 @@ npm i putout @putout/plugin-nodejs -D
         "nodejs/declare": "on",
         "nodejs/declare-after-require": "on",
         "nodejs/remove-process-exit": "on",
-        "nodejs/strict-mode": "on"
+        "nodejs/add-missing-strict-mode": "on",
+        "nodejs/remove-useless-strict-mode": "on",
+        "nodejs/remove-useless-promisify": "on"
     }
 }
 ```
@@ -61,6 +63,13 @@ import fs from 'fs';
 import fs from 'node:fs';
 ```
 
+### Comparison
+
+Linter | Rule | Fix
+--------|-------|------------|
+🐊 **Putout** | [`apply-node-prefix`](https://github.com/coderaiser/putout/tree/master/packages/plugin-nodejs/apply-node-prefix#readme) | ✅
+⏣ **ESLint** | [`prefer-node-protocol`](https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-node-protocol.md#readme)  | ✅
+
 ## convert-buffer-to-buffer-alloc
 
 > The `Buffer()` function and `new Buffer()` constructor are **deprecated** due to API usability issues that can lead to accidental security issues.
@@ -398,7 +407,7 @@ Rename `*.mjs` files when `module === "module"`:
 
 Check out in 🐊[Putout Editor](https://putout.cloudcmd.io/#/gist/94fb3298b210e703b01db9a6826942bc/dfe2462451c6b3d4d47da7fd8d39dc8e53bb16eb).
 
-## strict-mode
+## add-missing-strict-mode
 
 > **Strict mode** makes several changes to normal **JavaScript** semantics:
 >
@@ -408,38 +417,60 @@ Check out in 🐊[Putout Editor](https://putout.cloudcmd.io/#/gist/94fb3298b210e
 >
 > (c) [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode)
 
-Add **strict mode** to **CommonJS**, and remove from **ESM**, where it enabled by default.
+Add **strict mode** to **CommonJS**:
 
 ### ❌ Example of incorrect code
 
-ESM:
+```js
+const a = require('b');
+```
+
+### ✅ Example of correct code
 
 ```js
 'strict mode';
 
-import a from 'b';
+const a = require('b');
 ```
 
-CommonJS:
+### ✅ Example of correct code
+
+## remove-useless-strict-mode
+
+Remove `'use strict'` from **ESM**.
+
+### ❌ Example of incorrect code
 
 ```js
-const a = require('b');
+'strict mode';
+
+import a from 'b';
 ```
 
 ### ✅ Example of correct code
 
-ESM:
-
 ```js
 import a from 'b';
 ```
 
-CommonJS:
+## remove-useless-promisify
+
+> Takes a function following the common error-first callback style, i.e. taking an (err, value) => ... callback as the last argument, and returns a version that returns promises.
+>
+> (c) [nodejs.org](https://nodejs.org/dist/latest-v21.x/docs/api/util.html#utilpromisifyoriginal)
+
+Remove useless [`promisify()`](https://nodejs.org/dist/latest-v21.x/docs/api/util.html#utilpromisifyoriginal). Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/31000391865a36dfec2f8db5c2e98601/ce8867f83a84ecbe073637b9ceae58a443817187).
+
+### ❌ Example of incorrect code
 
 ```js
-'strict mode';
+export const readSize = promisify(async (dir, options, callback) => {});
+```
 
-const a = require('b');
+### ✅ Example of correct code
+
+```js
+export const readSize = async (dir, options, callback) => {};
 ```
 
 ## License

package/lib/index.js

@@ -25,6 +25,7 @@ const renameFileCjsToJs = require('./rename-file-cjs-to-js');
 const renameFileMjsToJs = require('./rename-file-mjs-to-js');
 
 const strictMode = require('./strict-mode');
+const removeUselessPromisify = require('./remove-useless-promisify');
 
 module.exports.rules = {
     'convert-buffer-to-buffer-alloc': convertBufferToBufferAlloc,
@@ -50,6 +51,7 @@ module.exports.rules = {
     'rename-file-cjs-to-js': ['off', renameFileCjsToJs],
     'rename-file-mjs-to-js': ['off', renameFileMjsToJs],
     
-    'add-strict-mode': strictMode.rules['add-missing'],
-    'remove-strict-mode': strictMode.rules['remove-useless'],
+    'add-missing-strict-mode': strictMode.rules['add-missing'],
+    'remove-useless-strict-mode': strictMode.rules['remove-useless'],
+    'remove-useless-promisify': removeUselessPromisify,
 };

package/lib/remove-useless-promisify/index.js

@@ -0,0 +1,7 @@
+'use strict';
+
+module.exports.report = () => `Calling 'promisify' on a function that returns a Promise is likely a mistake`;
+
+module.exports.replace = () => ({
+    'promisify(async (__args) => __body)': 'async (__args) => __body',
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-nodejs",
-  "version": "10.3.0",
+  "version": "11.1.0",
   "type": "commonjs",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin adds ability to transform code to new API of Node.js",
@@ -42,10 +42,10 @@
     "@putout/plugin-declare": "*",
     "@putout/plugin-putout": "*",
     "@putout/plugin-typescript": "*",
-    "@putout/test": "^8.0.0",
-    "c8": "^8.0.0",
-    "eslint": "^8.0.1",
-    "eslint-plugin-n": "^16.0.0",
+    "@putout/test": "^9.0.0",
+    "c8": "^9.0.0",
+    "eslint": "^9.0.0-alpha.0",
+    "eslint-plugin-n": "^17.0.0-0",
     "eslint-plugin-putout": "^22.0.0",
     "lerna": "^6.0.1",
     "madrun": "^10.0.0",
@@ -53,7 +53,7 @@
     "nodemon": "^3.0.1"
   },
   "peerDependencies": {
-    "putout": ">=34"
+    "putout": ">=35"
   },
   "license": "MIT",
   "engines": {