@putout/plugin-esm 10.3.0 → 10.5.0

package/README.md

@@ -31,6 +31,7 @@ npm i putout @putout/plugin-esm -D
 - ✅ [remove-quotes-from-import-assertions](#remove-quotes-from-import-assertions);
 - ✅ [remove-empty-import](#remove-empty-import);
 - ✅ [remove-empty-export](#remove-empty-export);
+- ✅ [remove-imports-with-duplicate-source](#remove-imports-with-duplicate-source);
 - ✅ [remove-useless-export-specifiers](#remove-useless-export-specifiers);
 - ✅ [sort-imports-by-specifiers](#sort-imports-by-specifiers);
 
@@ -60,6 +61,7 @@ npm i putout @putout/plugin-esm -D
         "esm/merge-export-declaration": "on",
         "esm/remove-quotes-from-import-assertions": "on",
         "esm/remove-empty-export": "on",
+        "esm/remove-imports-with-duplicate-source": "on",
         "esm/remove-empty-import": ["on", {
             "ignore": []
         }],
@@ -225,8 +227,6 @@ export {
 
 Check out in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/e5c3ea469437ade0f4467323dcec9a36/7c298c7078b004ae3aba2a29e38579bf8f48a098).
 
-#### ❌ Example of incorrect code
-
 ```diff
 export const hello = () => 'world';
 export const {
@@ -234,6 +234,23 @@ export const {
 }
 ```
 
+### remove-imports-with-duplicate-source
+
+Check out in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/f48250f577be00b53f923318a1d0a584/1a42dc1be8610fc35975ee397bce9fe4722b82dc).
+
+```diff
+import * as convertCommonjsToEsm from '@putout/plugin-nodejs/convert-commonjs-to-esm';
+-import * as convert from '@putout/plugin-nodejs/convert-commonjs-to-esm';
+
+test('putout: plugin-destructuring: merge-properties: transform: exports', (t) => {
+    t.transform('exports', {
+-       'node/convert-commonjs-to-esm': convert,
++       'node/convert-commonjs-to-esm': convertCommonjsToEsm,
+    });
+    t.end();
+});
+```
+
 ### declare-imports-first
 
 Check out in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/b1c18e5d726afe4ebb69d6b7a7dda82b/8189590815a1b8adb35bb8a846e28228e3c7fadf). For **CommonJS** use [nodejs/declare-after-require](https://github.com/coderaiser/putout/tree/master/packages/plugin-nodejs#declare-after-require).

package/lib/apply-export-from/index.js

@@ -58,10 +58,12 @@ function isExported(binding) {
 }
 
 function removeSpecifier(path) {
-    if (path.parentPath.node.specifiers.length === 1)
+    if (path.parentPath.node.specifiers.length === 1) {
         remove(path.parentPath);
-    else
-        remove(path);
+        return;
+    }
+    
+    remove(path);
 }
 
 function createExport(path, parentReference) {

package/lib/index.js

@@ -1,3 +1,4 @@
+import * as removeImportsWithDuplicateSource from './remove-imports-with-duplicate-source/index.js';
 import * as convertConstToImport from './convert-const-to-import/index.js';
 import * as applyImportAttributes from './apply-import-attributes/index.js';
 import * as applyDefaultImport from './apply-default-import/index.js';
@@ -43,4 +44,5 @@ export const rules = {
     'apply-default-import': applyDefaultImport,
     'apply-import-attributes': applyImportAttributes,
     'convert-const-to-import': convertConstToImport,
+    'remove-imports-with-duplicate-source': removeImportsWithDuplicateSource,
 };

package/lib/remove-imports-with-duplicate-source/index.js

@@ -0,0 +1,91 @@
+import {operator, types} from 'putout';
+
+const {
+    isImportDeclaration,
+    variableDeclaration,
+    variableDeclarator,
+    objectPattern,
+    objectProperty,
+    isImportNamespaceSpecifier,
+} = types;
+
+const {
+    replaceWith,
+    rename,
+    remove,
+} = operator;
+
+export const report = ({path}) => {
+    const {value} = path.node.source;
+    return `Avoid 'imports' with duplicate 'source': '${value}'`;
+};
+
+export const fix = ({path, original}) => {
+    const {specifiers} = path.node;
+    const originalSpecifiers = original.node.specifiers;
+    
+    if (!originalSpecifiers.length) {
+        remove(original);
+        return;
+    }
+    
+    const [firstOriginal] = originalSpecifiers;
+    const [first] = specifiers;
+    
+    if (isImportNamespaceSpecifier(first) && firstOriginal.type === first.type) {
+        const {name} = first.local;
+        const originalName = firstOriginal.local.name;
+        
+        rename(path, name, originalName);
+        remove(path);
+        
+        return;
+    }
+    
+    if (isImportNamespaceSpecifier(first)) {
+        convertImportToVariable(first.local, original);
+        return;
+    }
+    
+    if (isImportNamespaceSpecifier(firstOriginal)) {
+        convertImportToVariable(firstOriginal.local, path);
+        return;
+    }
+};
+
+function convertImportToVariable(init, original) {
+    const properties = [];
+    
+    for (const {local, imported} of original.node.specifiers) {
+        properties.push(objectProperty(local, imported));
+    }
+    
+    const id = objectPattern(properties);
+    const declaration = variableDeclarator(id, init);
+    const variable = variableDeclaration('const', [declaration]);
+    
+    replaceWith(original, variable);
+}
+
+export const traverse = ({push}) => ({
+    Program(path) {
+        const imports = path.get('body').filter(isImportDeclaration);
+        const sources = new Map();
+        
+        for (const element of imports) {
+            const {value} = element.node.source;
+            
+            if (!sources.has(value)) {
+                sources.set(value, element);
+                continue;
+            }
+            
+            const original = sources.get(value);
+            
+            push({
+                path: element,
+                original,
+            });
+        }
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@putout/plugin-esm",
-  "version": "10.3.0",
+  "version": "10.5.0",
   "type": "module",
   "author": "coderaiser <mnemonic.enemy@gmail.com> (https://github.com/coderaiser)",
   "description": "🐊Putout plugin improves ability to transform ESM code",
@@ -58,7 +58,6 @@
     "@putout/plugin-tape": "*",
     "@putout/plugin-typescript": "*",
     "@putout/test": "^15.0.0",
-    "c8": "^10.0.0",
     "eslint": "^10.0.0",
     "eslint-plugin-n": "^17.0.0",
     "eslint-plugin-putout": "^31.0.0",
@@ -66,6 +65,7 @@
     "montag": "^1.2.1",
     "nodemon": "^3.0.1",
     "redlint": "^6.0.0",
+    "superc8": "^12.0.0",
     "supertape": "^12.0.0"
   },
   "peerDependencies": {